Removing non-const RtpSenderInterface::GetParameters().
This removes the temporary non-const method that was kept in the code to
enable backwards compatibility while we fix downstream project dependencies.
Bug: webrtc:10251
Change-Id: Ie221af1d3b0f19112449d61e0f357a833f7a8b18
Reviewed-on: https://webrtc-review.googlesource.com/c/123561
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26824}diff --git a/api/rtp_sender_interface.cc b/api/rtp_sender_interface.cc
index 2b27b74..d23fd18 100644
--- a/api/rtp_sender_interface.cc
+++ b/api/rtp_sender_interface.cc
@@ -30,16 +30,4 @@
return nullptr;
}
-// TODO(amithi): Fix downstream dependencies and make GetParameters pure
-// virtual.
-RtpParameters RtpSenderInterface::GetParameters() {
- const RtpSenderInterface* interface = this;
- return interface->GetParameters();
-}
-
-RtpParameters RtpSenderInterface::GetParameters() const {
- RtpSenderInterface* interface = const_cast<RtpSenderInterface*>(this);
- return interface->GetParameters();
-}
-
} // namespace webrtc
diff --git a/api/rtp_sender_interface.h b/api/rtp_sender_interface.h
index f8a9757..e0a29a3 100644
--- a/api/rtp_sender_interface.h
+++ b/api/rtp_sender_interface.h
@@ -67,9 +67,7 @@
// TODO(orphis): Make it pure virtual once Chrome has updated
virtual std::vector<RtpEncodingParameters> init_send_encodings() const;
- // TODO(amithi): Fix downstream dependecies and remove the non-const method.
- virtual RtpParameters GetParameters();
- virtual RtpParameters GetParameters() const;
+ virtual RtpParameters GetParameters() const = 0;
// Note that only a subset of the parameters can currently be changed. See
// rtpparameters.h
// The encodings are in increasing quality order for simulcast.
