commit efbfc40029b6986137f9179476955c263da7052a
author Tommi <tommi@webrtc.org> Fri Feb 23 13:49:05 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Feb 23 14:20:23 2024
tree 5dd9bda8a5cf493e6c40cdc93ef6204b66e9b264
parent 4f63ea423f6fee0386ef2e0fc17b192e736b69cb

Demote RTC_CHECK for sctp_mid() to RTC_LOG(LS_ERROR) if unavailable

Bug: chromium:326275823
Change-Id: Icfb8850867d1e39f23661422693da4f2829ecc57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340460
Reviewed-by: Evan Shrubsole <eshr@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41793}

pc/sdp_offer_answer.cc

diff --git a/pc/sdp_offer_answer.cc b/pc/sdp_offer_answer.cc
index d75606a..95d5497 100644
--- a/pc/sdp_offer_answer.cc
+++ b/pc/sdp_offer_answer.cc
@@ -4297,11 +4297,13 @@
             GetMediaDescriptionOptionsForRejectedData(mid));
       } else {
         const auto data_mid = pc_->sctp_mid();
-        RTC_CHECK(data_mid);
-        if (mid == data_mid.value()) {
+        if (data_mid.has_value() && mid == data_mid.value()) {
           session_options->media_description_options.push_back(
               GetMediaDescriptionOptionsForActiveData(mid));
         } else {
+          if (!data_mid.has_value()) {
+            RTC_LOG(LS_ERROR) << "Datachannel transport not available: " << mid;
+          }
           session_options->media_description_options.push_back(
               GetMediaDescriptionOptionsForRejectedData(mid));
         }