commit f5770a0198bfb116f92d4a65c4da5e9a09213b99
author Per Kjellander <perkj@webrtc.org> Wed Jan 12 12:43:31 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jan 12 13:25:25 2022
tree e4102e0f4e3b16521daea82ca03b86f9a50c5e96
parent 961f38245824e90dc3e380a619a29c5bb84ced4f

Replace RTC_DCHECK_NOT_REACHED in framegenerator implementations of
ChangeResolution

Instead a warning is logged.

This effect tests only, and allows us to write screen share tests that may try to trigger the capturers to change resolution.

Bug: none
Change-Id: I4740fc4ed0bcf75e1c9df332fa610c24ed14973a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245981
Auto-Submit: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35668}

test/frame_generator.h

diff --git a/test/frame_generator.h b/test/frame_generator.h
index a5521bf..3e2a4cb 100644
--- a/test/frame_generator.h
+++ b/test/frame_generator.h
@@ -20,6 +20,7 @@
 #include "api/video/video_frame.h"
 #include "api/video/video_frame_buffer.h"
 #include "api/video/video_source_interface.h"
+#include "rtc_base/logging.h"
 #include "rtc_base/random.h"
 #include "rtc_base/synchronization/mutex.h"
 #include "system_wrappers/include/clock.h"
@@ -75,7 +76,8 @@
 
   VideoFrameData NextFrame() override;
   void ChangeResolution(size_t width, size_t height) override {
-    RTC_DCHECK_NOTREACHED();
+    RTC_LOG(LS_WARNING)
+        << "ScrollingImageFrameGenerator::ChangeResolution not implemented";
   }
 
  private:
@@ -104,7 +106,7 @@
 
   VideoFrameData NextFrame() override;
   void ChangeResolution(size_t width, size_t height) override {
-    RTC_DCHECK_NOTREACHED();
+    RTC_LOG(LS_WARNING) << "SlideGenerator::ChangeResolution not implemented";
   }
 
  private:
@@ -134,7 +136,8 @@
 
   VideoFrameData NextFrame() override;
   void ChangeResolution(size_t width, size_t height) override {
-    RTC_DCHECK_NOTREACHED();
+    RTC_LOG(LS_WARNING)
+        << "ScrollingImageFrameGenerator::ChangeResolution not implemented";
   }
 
  private: