commit f68d15cba3e0d19a2ce12bbbe2b4b38f667a871a
author henrika <henrika@webrtc.org> Wed Nov 22 15:54:33 2017
committer Commit Bot <commit-bot@chromium.org> Wed Nov 22 18:01:27 2017
tree 3a9dc9b100a1450f64ff40f46580fe177a81cd48
parent f7ff3e8b3ab0f1fb697e586817062c6946f61fbc

Removes check of RECORD_AUDIO in native audio layer on Android.

This type of check should instead be performed by the application/client.
If the app does not have mic permissions, construction of the AudioRecord
object will fail and the user will receive an error callback anyhow.

Bug: b/69434512
Change-Id: If1d7eff488f7c693697e048a567c17ed0c51f040
Reviewed-on: https://webrtc-review.googlesource.com/25261
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20839}

modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java

diff --git a/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java b/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
index 71c7df1..f9bdc5d 100644
--- a/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
+++ b/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
@@ -171,11 +171,6 @@
 
   private int initRecording(int sampleRate, int channels) {
     Logging.d(TAG, "initRecording(sampleRate=" + sampleRate + ", channels=" + channels + ")");
-    if (!WebRtcAudioUtils.hasPermission(
-            ContextUtils.getApplicationContext(), android.Manifest.permission.RECORD_AUDIO)) {
-      reportWebRtcAudioRecordInitError("RECORD_AUDIO permission is missing");
-      return -1;
-    }
     if (audioRecord != null) {
       reportWebRtcAudioRecordInitError("InitRecording called twice without StopRecording.");
       return -1;

modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java

diff --git a/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java b/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java
index e55d738..3d66923 100644
--- a/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java
+++ b/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java
@@ -207,10 +207,4 @@
             + "Model: " + Build.MODEL + ", "
             + "Product: " + Build.PRODUCT);
   }
-
-  // Checks if the process has as specified permission or not.
-  public static boolean hasPermission(Context context, String permission) {
-    return context.checkPermission(permission, Process.myPid(), Process.myUid())
-        == PackageManager.PERMISSION_GRANTED;
-  }
 }