commit fafae11bfc4c7d1f8f02e708b0187fb48f7b8810
author Bjorn Terelius <terelius@webrtc.org> Wed Dec 05 20:06:17 2018
committer Commit Bot <commit-bot@chromium.org> Thu Dec 06 09:59:45 2018
tree 36b7d10368ff409f83895137ed3bd2e0a31aff58
parent 518add35a8f363184add76b25fc4383535761af7

Allow parsing RTC event logs without a transaction ID.

Bug: webrtc:9972
Change-Id: I01d60671d249adbd55f25c8f49f205b18787cbf4
Reviewed-on: https://webrtc-review.googlesource.com/c/113304
Reviewed-by: Zach Stein <zstein@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25914}

logging/rtc_event_log/rtc_event_log_parser_new.cc

diff --git a/logging/rtc_event_log/rtc_event_log_parser_new.cc b/logging/rtc_event_log/rtc_event_log_parser_new.cc
index 7ae7fef..7926f3b 100644
--- a/logging/rtc_event_log/rtc_event_log_parser_new.cc
+++ b/logging/rtc_event_log/rtc_event_log_parser_new.cc
@@ -2428,8 +2428,10 @@
   ice_event.type = GetRuntimeIceCandidatePairEventType(proto.event_type());
   RTC_CHECK(proto.has_candidate_pair_id());
   ice_event.candidate_pair_id = proto.candidate_pair_id();
-  RTC_CHECK(proto.has_transaction_id());
-  ice_event.transaction_id = proto.transaction_id();
+  // TODO(zstein): Make the transaction_id field required once all old versions
+  // of the log (which don't have the field) are obsolete.
+  if (proto.has_transaction_id())
+    ice_event.transaction_id = proto.transaction_id();
 
   ice_candidate_pair_events_.push_back(ice_event);