commit e486aedc1660ae3912fb0317cda7deba7db06fc3
author Philipp Hancke <phancke@meta.com> Fri Oct 11 15:28:13 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Oct 16 06:28:07 2024
tree cc8540385c3206c7f52453b503d38679aaa25aa9
parent 2dc95ba29953731ca078c62a401873c6f3d53da8

Fix misaligned read in physical_socket_server

which causes errors under ASAN/UBSAN

BUG=None

Change-Id: I36bf4ff706339b6e3a8fd3764551e98fce111ad7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/365249
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#43243}

rtc_base/physical_socket_server.cc

diff --git a/rtc_base/physical_socket_server.cc b/rtc_base/physical_socket_server.cc
index 71da31e..af133b8 100644
--- a/rtc_base/physical_socket_server.cc
+++ b/rtc_base/physical_socket_server.cc
@@ -10,6 +10,7 @@
 #include "rtc_base/physical_socket_server.h"
 
 #include <cstdint>
+#include <cstring>
 #include <utility>
 
 #if defined(_MSC_VER) && _MSC_VER < 1300
@@ -549,10 +550,11 @@
         if (cmsg->cmsg_level != SOL_SOCKET)
           continue;
         if (timestamp && cmsg->cmsg_type == SCM_TIMESTAMP) {
-          timeval* ts = reinterpret_cast<timeval*>(CMSG_DATA(cmsg));
+          timeval ts;
+          std::memcpy(static_cast<void*>(&ts), CMSG_DATA(cmsg), sizeof(ts));
           *timestamp =
-              rtc::kNumMicrosecsPerSec * static_cast<int64_t>(ts->tv_sec) +
-              static_cast<int64_t>(ts->tv_usec);
+              rtc::kNumMicrosecsPerSec * static_cast<int64_t>(ts.tv_sec) +
+              static_cast<int64_t>(ts.tv_usec);
         }
       }
     }