philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include <cstring> |
philipel | 02447bc | 2016-05-13 13:01:03 | [diff] [blame] | 12 | #include <map> |
| 13 | #include <set> |
philipel | a105987 | 2016-05-09 09:41:48 | [diff] [blame] | 14 | #include <utility> |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 15 | |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 16 | #include "common_video/h264/h264_common.h" |
| 17 | #include "modules/video_coding/frame_object.h" |
| 18 | #include "modules/video_coding/packet_buffer.h" |
| 19 | #include "rtc_base/random.h" |
| 20 | #include "system_wrappers/include/clock.h" |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 21 | #include "test/field_trial.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 22 | #include "test/gtest.h" |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 23 | |
| 24 | namespace webrtc { |
| 25 | namespace video_coding { |
| 26 | |
| 27 | class TestPacketBuffer : public ::testing::Test, |
Elad Alon | b4643ad | 2019-02-22 10:19:50 | [diff] [blame] | 28 | public OnAssembledFrameCallback { |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 29 | protected: |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 30 | TestPacketBuffer() : TestPacketBuffer("") {} |
| 31 | explicit TestPacketBuffer(std::string field_trials) |
| 32 | : scoped_field_trials_(field_trials), |
| 33 | rand_(0x7732213), |
philipel | b4d3108 | 2016-07-11 15:46:29 | [diff] [blame] | 34 | clock_(new SimulatedClock(0)), |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 35 | packet_buffer_( |
| 36 | PacketBuffer::Create(clock_.get(), kStartSize, kMaxSize, this)) {} |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 37 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 38 | uint16_t Rand() { return rand_.Rand<uint16_t>(); } |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 39 | |
Elad Alon | b4643ad | 2019-02-22 10:19:50 | [diff] [blame] | 40 | void OnAssembledFrame(std::unique_ptr<RtpFrameObject> frame) override { |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 41 | uint16_t first_seq_num = frame->first_seq_num(); |
| 42 | if (frames_from_callback_.find(first_seq_num) != |
| 43 | frames_from_callback_.end()) { |
| 44 | ADD_FAILURE() << "Already received frame with first sequence number " |
| 45 | << first_seq_num << "."; |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 46 | return; |
| 47 | } |
philipel | 2c9f9f2 | 2017-06-13 09:47:28 | [diff] [blame] | 48 | |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 49 | frames_from_callback_.insert( |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 50 | std::make_pair(frame->first_seq_num(), std::move(frame))); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 51 | } |
| 52 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 53 | enum IsKeyFrame { kKeyFrame, kDeltaFrame }; |
| 54 | enum IsFirst { kFirst, kNotFirst }; |
| 55 | enum IsLast { kLast, kNotLast }; |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 56 | |
Ilya Nikolaevskiy | d397a0d | 2018-02-21 14:57:09 | [diff] [blame] | 57 | bool Insert(uint16_t seq_num, // packet sequence number |
| 58 | IsKeyFrame keyframe, // is keyframe |
| 59 | IsFirst first, // is first packet of frame |
| 60 | IsLast last, // is last packet of frame |
| 61 | int data_size = 0, // size of data |
| 62 | uint8_t* data = nullptr, // data pointer |
| 63 | uint32_t timestamp = 123u) { // rtp timestamp |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 64 | VCMPacket packet; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 65 | packet.video_header.codec = kVideoCodecGeneric; |
Ilya Nikolaevskiy | d397a0d | 2018-02-21 14:57:09 | [diff] [blame] | 66 | packet.timestamp = timestamp; |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 67 | packet.seqNum = seq_num; |
Niels Möller | abbc50e | 2019-04-24 07:41:16 | [diff] [blame] | 68 | packet.video_header.frame_type = keyframe == kKeyFrame |
| 69 | ? VideoFrameType::kVideoFrameKey |
| 70 | : VideoFrameType::kVideoFrameDelta; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 71 | packet.video_header.is_first_packet_in_frame = first == kFirst; |
| 72 | packet.video_header.is_last_packet_in_frame = last == kLast; |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 73 | packet.sizeBytes = data_size; |
| 74 | packet.dataPtr = data; |
| 75 | |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 76 | return packet_buffer_->InsertPacket(&packet); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 77 | } |
| 78 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 79 | void CheckFrame(uint16_t first_seq_num) { |
| 80 | auto frame_it = frames_from_callback_.find(first_seq_num); |
| 81 | ASSERT_FALSE(frame_it == frames_from_callback_.end()) |
| 82 | << "Could not find frame with first sequence number " << first_seq_num |
| 83 | << "."; |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 84 | } |
| 85 | |
Johannes Kron | 957c62e | 2018-10-01 12:53:01 | [diff] [blame] | 86 | void DeleteFrame(uint16_t first_seq_num) { |
| 87 | auto frame_it = frames_from_callback_.find(first_seq_num); |
| 88 | ASSERT_FALSE(frame_it == frames_from_callback_.end()) |
| 89 | << "Could not find frame with first sequence number " << first_seq_num |
| 90 | << "."; |
| 91 | frames_from_callback_.erase(frame_it); |
| 92 | } |
| 93 | |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 94 | static constexpr int kStartSize = 16; |
| 95 | static constexpr int kMaxSize = 64; |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 96 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 97 | const test::ScopedFieldTrials scoped_field_trials_; |
| 98 | |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 99 | Random rand_; |
philipel | 3184f8e | 2017-05-18 15:08:53 | [diff] [blame] | 100 | std::unique_ptr<SimulatedClock> clock_; |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 101 | rtc::scoped_refptr<PacketBuffer> packet_buffer_; |
| 102 | std::map<uint16_t, std::unique_ptr<RtpFrameObject>> frames_from_callback_; |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 103 | }; |
| 104 | |
| 105 | TEST_F(TestPacketBuffer, InsertOnePacket) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 106 | const uint16_t seq_num = Rand(); |
| 107 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kLast)); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 108 | } |
| 109 | |
| 110 | TEST_F(TestPacketBuffer, InsertMultiplePackets) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 111 | const uint16_t seq_num = Rand(); |
| 112 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kLast)); |
| 113 | EXPECT_TRUE(Insert(seq_num + 1, kKeyFrame, kFirst, kLast)); |
| 114 | EXPECT_TRUE(Insert(seq_num + 2, kKeyFrame, kFirst, kLast)); |
| 115 | EXPECT_TRUE(Insert(seq_num + 3, kKeyFrame, kFirst, kLast)); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 116 | } |
| 117 | |
| 118 | TEST_F(TestPacketBuffer, InsertDuplicatePacket) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 119 | const uint16_t seq_num = Rand(); |
Johannes Kron | a370556 | 2019-08-26 14:37:11 | [diff] [blame] | 120 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 121 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 122 | EXPECT_TRUE(Insert(seq_num + 1, kKeyFrame, kNotFirst, kLast)); |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 123 | } |
| 124 | |
Artem Titarenko | 97e35ce | 2018-10-30 10:17:54 | [diff] [blame] | 125 | TEST_F(TestPacketBuffer, SeqNumWrapOneFrame) { |
philipel | 2c2f34c | 2017-01-03 13:55:34 | [diff] [blame] | 126 | EXPECT_TRUE(Insert(0xFFFF, kKeyFrame, kFirst, kNotLast)); |
| 127 | EXPECT_TRUE(Insert(0x0, kKeyFrame, kNotFirst, kLast)); |
| 128 | |
| 129 | CheckFrame(0xFFFF); |
| 130 | } |
| 131 | |
| 132 | TEST_F(TestPacketBuffer, SeqNumWrapTwoFrames) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 133 | EXPECT_TRUE(Insert(0xFFFF, kKeyFrame, kFirst, kLast)); |
| 134 | EXPECT_TRUE(Insert(0x0, kKeyFrame, kFirst, kLast)); |
| 135 | |
| 136 | CheckFrame(0xFFFF); |
philipel | 2c2f34c | 2017-01-03 13:55:34 | [diff] [blame] | 137 | CheckFrame(0x0); |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 138 | } |
| 139 | |
| 140 | TEST_F(TestPacketBuffer, InsertOldPackets) { |
| 141 | const uint16_t seq_num = Rand(); |
| 142 | |
| 143 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 144 | EXPECT_TRUE(Insert(seq_num + 2, kDeltaFrame, kFirst, kLast)); |
| 145 | EXPECT_TRUE(Insert(seq_num + 1, kKeyFrame, kNotFirst, kLast)); |
| 146 | ASSERT_EQ(2UL, frames_from_callback_.size()); |
| 147 | |
| 148 | frames_from_callback_.erase(seq_num + 2); |
| 149 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 150 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 151 | |
| 152 | frames_from_callback_.erase(frames_from_callback_.find(seq_num)); |
| 153 | ASSERT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 154 | EXPECT_TRUE(Insert(seq_num + 2, kDeltaFrame, kFirst, kLast)); |
| 155 | |
| 156 | packet_buffer_->ClearTo(seq_num + 2); |
Johannes Kron | bd3f305 | 2019-08-01 13:45:54 | [diff] [blame] | 157 | EXPECT_TRUE(Insert(seq_num + 2, kDeltaFrame, kFirst, kLast)); |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 158 | EXPECT_TRUE(Insert(seq_num + 3, kDeltaFrame, kFirst, kLast)); |
| 159 | ASSERT_EQ(2UL, frames_from_callback_.size()); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 160 | } |
| 161 | |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 162 | TEST_F(TestPacketBuffer, NackCount) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 163 | const uint16_t seq_num = Rand(); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 164 | |
| 165 | VCMPacket packet; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 166 | packet.video_header.codec = kVideoCodecGeneric; |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 167 | packet.seqNum = seq_num; |
Niels Möller | abbc50e | 2019-04-24 07:41:16 | [diff] [blame] | 168 | packet.video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 169 | packet.video_header.is_first_packet_in_frame = true; |
| 170 | packet.video_header.is_last_packet_in_frame = false; |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 171 | packet.timesNacked = 0; |
| 172 | |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 173 | packet_buffer_->InsertPacket(&packet); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 174 | |
| 175 | packet.seqNum++; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 176 | packet.video_header.is_first_packet_in_frame = false; |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 177 | packet.timesNacked = 1; |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 178 | packet_buffer_->InsertPacket(&packet); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 179 | |
| 180 | packet.seqNum++; |
| 181 | packet.timesNacked = 3; |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 182 | packet_buffer_->InsertPacket(&packet); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 183 | |
| 184 | packet.seqNum++; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 185 | packet.video_header.is_last_packet_in_frame = true; |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 186 | packet.timesNacked = 1; |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 187 | packet_buffer_->InsertPacket(&packet); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 188 | |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 189 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 190 | RtpFrameObject* frame = frames_from_callback_.begin()->second.get(); |
| 191 | EXPECT_EQ(3, frame->times_nacked()); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 192 | } |
| 193 | |
| 194 | TEST_F(TestPacketBuffer, FrameSize) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 195 | const uint16_t seq_num = Rand(); |
philipel | 41b8ca0 | 2016-11-07 14:42:24 | [diff] [blame] | 196 | uint8_t* data1 = new uint8_t[5](); |
| 197 | uint8_t* data2 = new uint8_t[5](); |
| 198 | uint8_t* data3 = new uint8_t[5](); |
| 199 | uint8_t* data4 = new uint8_t[5](); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 200 | |
philipel | 41b8ca0 | 2016-11-07 14:42:24 | [diff] [blame] | 201 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast, 5, data1)); |
| 202 | EXPECT_TRUE(Insert(seq_num + 1, kKeyFrame, kNotFirst, kNotLast, 5, data2)); |
| 203 | EXPECT_TRUE(Insert(seq_num + 2, kKeyFrame, kNotFirst, kNotLast, 5, data3)); |
| 204 | EXPECT_TRUE(Insert(seq_num + 3, kKeyFrame, kNotFirst, kLast, 5, data4)); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 205 | |
| 206 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
nisse | 37abf53 | 2016-10-28 07:37:29 | [diff] [blame] | 207 | EXPECT_EQ(20UL, frames_from_callback_.begin()->second->size()); |
philipel | 5ceaaae | 2016-05-24 08:20:47 | [diff] [blame] | 208 | } |
| 209 | |
Ilya Nikolaevskiy | d397a0d | 2018-02-21 14:57:09 | [diff] [blame] | 210 | TEST_F(TestPacketBuffer, CountsUniqueFrames) { |
| 211 | const uint16_t seq_num = Rand(); |
| 212 | |
| 213 | ASSERT_EQ(0, packet_buffer_->GetUniqueFramesSeen()); |
| 214 | |
| 215 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast, 0, nullptr, 100)); |
| 216 | ASSERT_EQ(1, packet_buffer_->GetUniqueFramesSeen()); |
| 217 | // Still the same frame. |
| 218 | EXPECT_TRUE( |
| 219 | Insert(seq_num + 1, kKeyFrame, kNotFirst, kLast, 0, nullptr, 100)); |
| 220 | ASSERT_EQ(1, packet_buffer_->GetUniqueFramesSeen()); |
| 221 | |
| 222 | // Second frame. |
| 223 | EXPECT_TRUE( |
| 224 | Insert(seq_num + 2, kKeyFrame, kFirst, kNotLast, 0, nullptr, 200)); |
| 225 | ASSERT_EQ(2, packet_buffer_->GetUniqueFramesSeen()); |
| 226 | EXPECT_TRUE( |
| 227 | Insert(seq_num + 3, kKeyFrame, kNotFirst, kLast, 0, nullptr, 200)); |
| 228 | ASSERT_EQ(2, packet_buffer_->GetUniqueFramesSeen()); |
| 229 | |
| 230 | // Old packet. |
| 231 | EXPECT_TRUE( |
| 232 | Insert(seq_num + 1, kKeyFrame, kNotFirst, kLast, 0, nullptr, 100)); |
| 233 | ASSERT_EQ(2, packet_buffer_->GetUniqueFramesSeen()); |
| 234 | |
| 235 | // Missing middle packet. |
| 236 | EXPECT_TRUE( |
| 237 | Insert(seq_num + 4, kKeyFrame, kFirst, kNotLast, 0, nullptr, 300)); |
| 238 | EXPECT_TRUE( |
| 239 | Insert(seq_num + 6, kKeyFrame, kNotFirst, kLast, 0, nullptr, 300)); |
| 240 | ASSERT_EQ(3, packet_buffer_->GetUniqueFramesSeen()); |
| 241 | } |
| 242 | |
| 243 | TEST_F(TestPacketBuffer, HasHistoryOfUniqueFrames) { |
| 244 | const int kNumFrames = 1500; |
| 245 | const int kRequiredHistoryLength = 1000; |
| 246 | const uint16_t seq_num = Rand(); |
| 247 | const uint32_t timestamp = 0xFFFFFFF0; // Large enough to cause wrap-around. |
| 248 | |
| 249 | for (int i = 0; i < kNumFrames; ++i) { |
Johannes Kron | bd3f305 | 2019-08-01 13:45:54 | [diff] [blame] | 250 | Insert(seq_num + i, kKeyFrame, kFirst, kNotLast, 0, nullptr, |
| 251 | timestamp + 10 * i); |
Ilya Nikolaevskiy | d397a0d | 2018-02-21 14:57:09 | [diff] [blame] | 252 | } |
| 253 | ASSERT_EQ(kNumFrames, packet_buffer_->GetUniqueFramesSeen()); |
| 254 | |
| 255 | // Old packets within history should not affect number of seen unique frames. |
| 256 | for (int i = kNumFrames - kRequiredHistoryLength; i < kNumFrames; ++i) { |
Johannes Kron | bd3f305 | 2019-08-01 13:45:54 | [diff] [blame] | 257 | Insert(seq_num + i, kKeyFrame, kFirst, kNotLast, 0, nullptr, |
| 258 | timestamp + 10 * i); |
Ilya Nikolaevskiy | d397a0d | 2018-02-21 14:57:09 | [diff] [blame] | 259 | } |
| 260 | ASSERT_EQ(kNumFrames, packet_buffer_->GetUniqueFramesSeen()); |
| 261 | |
| 262 | // Very old packets should be treated as unique. |
Johannes Kron | bd3f305 | 2019-08-01 13:45:54 | [diff] [blame] | 263 | Insert(seq_num, kKeyFrame, kFirst, kNotLast, 0, nullptr, timestamp); |
Ilya Nikolaevskiy | d397a0d | 2018-02-21 14:57:09 | [diff] [blame] | 264 | ASSERT_EQ(kNumFrames + 1, packet_buffer_->GetUniqueFramesSeen()); |
| 265 | } |
| 266 | |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 267 | TEST_F(TestPacketBuffer, ExpandBuffer) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 268 | const uint16_t seq_num = Rand(); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 269 | |
Johannes Kron | a370556 | 2019-08-26 14:37:11 | [diff] [blame] | 270 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 271 | for (int i = 1; i < kStartSize; ++i) |
| 272 | EXPECT_TRUE(Insert(seq_num + i, kKeyFrame, kNotFirst, kNotLast)); |
| 273 | |
| 274 | // Already inserted kStartSize number of packets, inserting the last packet |
| 275 | // should increase the buffer size and also result in an assembled frame. |
| 276 | EXPECT_TRUE(Insert(seq_num + kStartSize, kKeyFrame, kNotFirst, kLast)); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 277 | } |
| 278 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 279 | TEST_F(TestPacketBuffer, SingleFrameExpandsBuffer) { |
| 280 | const uint16_t seq_num = Rand(); |
| 281 | |
| 282 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 283 | for (int i = 1; i < kStartSize; ++i) |
| 284 | EXPECT_TRUE(Insert(seq_num + i, kKeyFrame, kNotFirst, kNotLast)); |
| 285 | EXPECT_TRUE(Insert(seq_num + kStartSize, kKeyFrame, kNotFirst, kLast)); |
| 286 | |
| 287 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 288 | CheckFrame(seq_num); |
| 289 | } |
| 290 | |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 291 | TEST_F(TestPacketBuffer, ExpandBufferOverflow) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 292 | const uint16_t seq_num = Rand(); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 293 | |
Johannes Kron | a370556 | 2019-08-26 14:37:11 | [diff] [blame] | 294 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 295 | for (int i = 1; i < kMaxSize; ++i) |
| 296 | EXPECT_TRUE(Insert(seq_num + i, kKeyFrame, kNotFirst, kNotLast)); |
| 297 | |
| 298 | // Already inserted kMaxSize number of packets, inserting the last packet |
| 299 | // should overflow the buffer and result in false being returned. |
| 300 | EXPECT_FALSE(Insert(seq_num + kMaxSize, kKeyFrame, kNotFirst, kLast)); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 301 | } |
| 302 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 303 | TEST_F(TestPacketBuffer, OnePacketOneFrame) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 304 | const uint16_t seq_num = Rand(); |
| 305 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kLast)); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 306 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 307 | CheckFrame(seq_num); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 308 | } |
| 309 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 310 | TEST_F(TestPacketBuffer, TwoPacketsTwoFrames) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 311 | const uint16_t seq_num = Rand(); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 312 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 313 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kLast)); |
| 314 | EXPECT_TRUE(Insert(seq_num + 1, kKeyFrame, kFirst, kLast)); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 315 | |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 316 | EXPECT_EQ(2UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 317 | CheckFrame(seq_num); |
| 318 | CheckFrame(seq_num + 1); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 319 | } |
| 320 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 321 | TEST_F(TestPacketBuffer, TwoPacketsOneFrames) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 322 | const uint16_t seq_num = Rand(); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 323 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 324 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 325 | EXPECT_TRUE(Insert(seq_num + 1, kKeyFrame, kNotFirst, kLast)); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 326 | |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 327 | EXPECT_EQ(1UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 328 | CheckFrame(seq_num); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 329 | } |
| 330 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 331 | TEST_F(TestPacketBuffer, ThreePacketReorderingOneFrame) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 332 | const uint16_t seq_num = Rand(); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 333 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 334 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 335 | EXPECT_TRUE(Insert(seq_num + 2, kKeyFrame, kNotFirst, kLast)); |
| 336 | EXPECT_TRUE(Insert(seq_num + 1, kKeyFrame, kNotFirst, kNotLast)); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 337 | |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 338 | EXPECT_EQ(1UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 339 | CheckFrame(seq_num); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 340 | } |
| 341 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 342 | TEST_F(TestPacketBuffer, Frames) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 343 | const uint16_t seq_num = Rand(); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 344 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 345 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kLast)); |
| 346 | EXPECT_TRUE(Insert(seq_num + 1, kDeltaFrame, kFirst, kLast)); |
| 347 | EXPECT_TRUE(Insert(seq_num + 2, kDeltaFrame, kFirst, kLast)); |
| 348 | EXPECT_TRUE(Insert(seq_num + 3, kDeltaFrame, kFirst, kLast)); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 349 | |
| 350 | ASSERT_EQ(4UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 351 | CheckFrame(seq_num); |
| 352 | CheckFrame(seq_num + 1); |
| 353 | CheckFrame(seq_num + 2); |
| 354 | CheckFrame(seq_num + 3); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 355 | } |
| 356 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 357 | TEST_F(TestPacketBuffer, ClearSinglePacket) { |
| 358 | const uint16_t seq_num = Rand(); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 359 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 360 | for (int i = 0; i < kMaxSize; ++i) |
| 361 | EXPECT_TRUE(Insert(seq_num + i, kDeltaFrame, kFirst, kLast)); |
| 362 | |
| 363 | packet_buffer_->ClearTo(seq_num); |
| 364 | EXPECT_TRUE(Insert(seq_num + kMaxSize, kDeltaFrame, kFirst, kLast)); |
| 365 | } |
| 366 | |
philipel | c5fb468 | 2017-08-02 11:28:57 | [diff] [blame] | 367 | TEST_F(TestPacketBuffer, ClearFullBuffer) { |
| 368 | for (int i = 0; i < kMaxSize; ++i) |
| 369 | EXPECT_TRUE(Insert(i, kDeltaFrame, kFirst, kLast)); |
| 370 | |
| 371 | packet_buffer_->ClearTo(kMaxSize - 1); |
| 372 | |
| 373 | for (int i = kMaxSize; i < 2 * kMaxSize; ++i) |
| 374 | EXPECT_TRUE(Insert(i, kDeltaFrame, kFirst, kLast)); |
| 375 | } |
| 376 | |
| 377 | TEST_F(TestPacketBuffer, DontClearNewerPacket) { |
| 378 | EXPECT_TRUE(Insert(0, kKeyFrame, kFirst, kLast)); |
| 379 | packet_buffer_->ClearTo(0); |
| 380 | EXPECT_TRUE(Insert(2 * kStartSize, kKeyFrame, kFirst, kLast)); |
| 381 | EXPECT_TRUE(Insert(3 * kStartSize + 1, kKeyFrame, kFirst, kNotLast)); |
| 382 | packet_buffer_->ClearTo(2 * kStartSize); |
| 383 | EXPECT_TRUE(Insert(3 * kStartSize + 2, kKeyFrame, kNotFirst, kLast)); |
| 384 | |
| 385 | ASSERT_EQ(3UL, frames_from_callback_.size()); |
| 386 | CheckFrame(0); |
| 387 | CheckFrame(2 * kStartSize); |
| 388 | CheckFrame(3 * kStartSize + 1); |
| 389 | } |
| 390 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 391 | TEST_F(TestPacketBuffer, OneIncompleteFrame) { |
| 392 | const uint16_t seq_num = Rand(); |
| 393 | |
| 394 | EXPECT_TRUE(Insert(seq_num, kDeltaFrame, kFirst, kNotLast)); |
| 395 | EXPECT_TRUE(Insert(seq_num + 1, kDeltaFrame, kNotFirst, kLast)); |
| 396 | EXPECT_TRUE(Insert(seq_num - 1, kDeltaFrame, kNotFirst, kLast)); |
| 397 | |
| 398 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 399 | CheckFrame(seq_num); |
| 400 | } |
| 401 | |
| 402 | TEST_F(TestPacketBuffer, TwoIncompleteFramesFullBuffer) { |
| 403 | const uint16_t seq_num = Rand(); |
| 404 | |
| 405 | for (int i = 1; i < kMaxSize - 1; ++i) |
| 406 | EXPECT_TRUE(Insert(seq_num + i, kDeltaFrame, kNotFirst, kNotLast)); |
| 407 | EXPECT_TRUE(Insert(seq_num, kDeltaFrame, kFirst, kNotLast)); |
| 408 | EXPECT_TRUE(Insert(seq_num - 1, kDeltaFrame, kNotFirst, kLast)); |
| 409 | |
| 410 | ASSERT_EQ(0UL, frames_from_callback_.size()); |
| 411 | } |
| 412 | |
| 413 | TEST_F(TestPacketBuffer, FramesReordered) { |
| 414 | const uint16_t seq_num = Rand(); |
| 415 | |
| 416 | EXPECT_TRUE(Insert(seq_num + 1, kDeltaFrame, kFirst, kLast)); |
| 417 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kLast)); |
| 418 | EXPECT_TRUE(Insert(seq_num + 3, kDeltaFrame, kFirst, kLast)); |
| 419 | EXPECT_TRUE(Insert(seq_num + 2, kDeltaFrame, kFirst, kLast)); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 420 | |
| 421 | ASSERT_EQ(4UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 422 | CheckFrame(seq_num); |
| 423 | CheckFrame(seq_num + 1); |
| 424 | CheckFrame(seq_num + 2); |
| 425 | CheckFrame(seq_num + 3); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 426 | } |
| 427 | |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 428 | TEST_F(TestPacketBuffer, GetBitstream) { |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 429 | // "many bitstream, such data" with null termination. |
philipel | 41b8ca0 | 2016-11-07 14:42:24 | [diff] [blame] | 430 | uint8_t many_data[] = {0x6d, 0x61, 0x6e, 0x79, 0x20}; |
| 431 | uint8_t bitstream_data[] = {0x62, 0x69, 0x74, 0x73, 0x74, 0x72, |
| 432 | 0x65, 0x61, 0x6d, 0x2c, 0x20}; |
| 433 | uint8_t such_data[] = {0x73, 0x75, 0x63, 0x68, 0x20}; |
| 434 | uint8_t data_data[] = {0x64, 0x61, 0x74, 0x61, 0x0}; |
| 435 | |
| 436 | uint8_t* many = new uint8_t[sizeof(many_data)]; |
| 437 | uint8_t* bitstream = new uint8_t[sizeof(bitstream_data)]; |
| 438 | uint8_t* such = new uint8_t[sizeof(such_data)]; |
| 439 | uint8_t* data = new uint8_t[sizeof(data_data)]; |
| 440 | |
| 441 | memcpy(many, many_data, sizeof(many_data)); |
| 442 | memcpy(bitstream, bitstream_data, sizeof(bitstream_data)); |
| 443 | memcpy(such, such_data, sizeof(such_data)); |
| 444 | memcpy(data, data_data, sizeof(data_data)); |
| 445 | |
Niels Möller | 648a7ce | 2018-11-28 14:14:54 | [diff] [blame] | 446 | const size_t result_length = sizeof(many_data) + sizeof(bitstream_data) + |
| 447 | sizeof(such_data) + sizeof(data_data); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 448 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 449 | const uint16_t seq_num = Rand(); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 450 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 451 | EXPECT_TRUE( |
philipel | 41b8ca0 | 2016-11-07 14:42:24 | [diff] [blame] | 452 | Insert(seq_num, kKeyFrame, kFirst, kNotLast, sizeof(many_data), many)); |
| 453 | EXPECT_TRUE(Insert(seq_num + 1, kDeltaFrame, kNotFirst, kNotLast, |
| 454 | sizeof(bitstream_data), bitstream)); |
| 455 | EXPECT_TRUE(Insert(seq_num + 2, kDeltaFrame, kNotFirst, kNotLast, |
| 456 | sizeof(such_data), such)); |
| 457 | EXPECT_TRUE(Insert(seq_num + 3, kDeltaFrame, kNotFirst, kLast, |
| 458 | sizeof(data_data), data)); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 459 | |
| 460 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 461 | CheckFrame(seq_num); |
Niels Möller | 648a7ce | 2018-11-28 14:14:54 | [diff] [blame] | 462 | EXPECT_EQ(frames_from_callback_[seq_num]->size(), result_length); |
Niels Möller | 9c843906 | 2019-01-11 09:21:35 | [diff] [blame] | 463 | EXPECT_EQ(memcmp(frames_from_callback_[seq_num]->data(), |
Niels Möller | 648a7ce | 2018-11-28 14:14:54 | [diff] [blame] | 464 | "many bitstream, such data", result_length), |
| 465 | 0); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 466 | } |
| 467 | |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 468 | TEST_F(TestPacketBuffer, GetBitstreamOneFrameOnePacket) { |
| 469 | uint8_t bitstream_data[] = "All the bitstream data for this frame!"; |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 470 | uint8_t* data = new uint8_t[sizeof(bitstream_data)]; |
| 471 | memcpy(data, bitstream_data, sizeof(bitstream_data)); |
| 472 | |
| 473 | EXPECT_TRUE( |
| 474 | Insert(0, kKeyFrame, kFirst, kLast, sizeof(bitstream_data), data)); |
| 475 | |
| 476 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 477 | CheckFrame(0); |
| 478 | EXPECT_EQ(frames_from_callback_[0]->size(), sizeof(bitstream_data)); |
Johannes Kron | a370556 | 2019-08-26 14:37:11 | [diff] [blame] | 479 | EXPECT_EQ(memcmp(frames_from_callback_[0]->data(), bitstream_data, |
| 480 | sizeof(bitstream_data)), |
| 481 | 0); |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 482 | } |
| 483 | |
| 484 | TEST_F(TestPacketBuffer, GetBitstreamOneFrameFullBuffer) { |
| 485 | uint8_t* data_arr[kStartSize]; |
| 486 | uint8_t expected[kStartSize]; |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 487 | |
| 488 | for (uint8_t i = 0; i < kStartSize; ++i) { |
| 489 | data_arr[i] = new uint8_t[1]; |
| 490 | data_arr[i][0] = i; |
| 491 | expected[i] = i; |
| 492 | } |
| 493 | |
| 494 | EXPECT_TRUE(Insert(0, kKeyFrame, kFirst, kNotLast, 1, data_arr[0])); |
| 495 | for (uint8_t i = 1; i < kStartSize - 1; ++i) |
| 496 | EXPECT_TRUE(Insert(i, kKeyFrame, kNotFirst, kNotLast, 1, data_arr[i])); |
| 497 | EXPECT_TRUE(Insert(kStartSize - 1, kKeyFrame, kNotFirst, kLast, 1, |
| 498 | data_arr[kStartSize - 1])); |
| 499 | |
| 500 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 501 | CheckFrame(0); |
| 502 | EXPECT_EQ(frames_from_callback_[0]->size(), static_cast<size_t>(kStartSize)); |
Niels Möller | 9c843906 | 2019-01-11 09:21:35 | [diff] [blame] | 503 | EXPECT_EQ(memcmp(frames_from_callback_[0]->data(), expected, kStartSize), 0); |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 504 | } |
| 505 | |
Johannes Kron | 957c62e | 2018-10-01 12:53:01 | [diff] [blame] | 506 | TEST_F(TestPacketBuffer, InsertPacketAfterOldFrameObjectIsRemoved) { |
| 507 | uint16_t kFirstSeqNum = 0; |
| 508 | uint32_t kTimestampDelta = 100; |
| 509 | uint32_t timestamp = 10000; |
| 510 | uint16_t seq_num = kFirstSeqNum; |
| 511 | |
| 512 | // Loop until seq_num wraps around. |
Philip Eliasson | 1f850a6 | 2019-03-19 12:15:00 | [diff] [blame] | 513 | SeqNumUnwrapper<uint16_t> unwrapper; |
Johannes Kron | 957c62e | 2018-10-01 12:53:01 | [diff] [blame] | 514 | while (unwrapper.Unwrap(seq_num) < std::numeric_limits<uint16_t>::max()) { |
| 515 | Insert(seq_num++, kKeyFrame, kFirst, kNotLast, 0, nullptr, timestamp); |
| 516 | for (int i = 0; i < 5; ++i) { |
| 517 | Insert(seq_num++, kKeyFrame, kNotFirst, kNotLast, 0, nullptr, timestamp); |
| 518 | } |
| 519 | Insert(seq_num++, kKeyFrame, kNotFirst, kLast, 0, nullptr, timestamp); |
| 520 | timestamp += kTimestampDelta; |
| 521 | } |
| 522 | |
| 523 | size_t number_of_frames = frames_from_callback_.size(); |
| 524 | // Delete old frame object while receiving frame with overlapping sequence |
| 525 | // numbers. |
| 526 | Insert(seq_num++, kKeyFrame, kFirst, kNotLast, 0, nullptr, timestamp); |
| 527 | for (int i = 0; i < 5; ++i) { |
| 528 | Insert(seq_num++, kKeyFrame, kNotFirst, kNotLast, 0, nullptr, timestamp); |
| 529 | } |
| 530 | // Delete FrameObject connected to packets that have already been cleared. |
| 531 | DeleteFrame(kFirstSeqNum); |
| 532 | Insert(seq_num++, kKeyFrame, kNotFirst, kLast, 0, nullptr, timestamp); |
| 533 | |
| 534 | // Regardless of the initial size, the number of frames should be constant |
| 535 | // after removing and then adding a new frame object. |
| 536 | EXPECT_EQ(number_of_frames, frames_from_callback_.size()); |
| 537 | } |
| 538 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 539 | // If |sps_pps_idr_is_keyframe| is true, we require keyframes to contain |
| 540 | // SPS/PPS/IDR and the keyframes we create as part of the test do contain |
| 541 | // SPS/PPS/IDR. If |sps_pps_idr_is_keyframe| is false, we only require and |
| 542 | // create keyframes containing only IDR. |
| 543 | class TestPacketBufferH264 : public TestPacketBuffer { |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 544 | protected: |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 545 | explicit TestPacketBufferH264(bool sps_pps_idr_is_keyframe) |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 546 | : TestPacketBuffer(sps_pps_idr_is_keyframe |
| 547 | ? "WebRTC-SpsPpsIdrIsH264Keyframe/Enabled/" |
| 548 | : ""), |
| 549 | sps_pps_idr_is_keyframe_(sps_pps_idr_is_keyframe) {} |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 550 | |
| 551 | bool InsertH264(uint16_t seq_num, // packet sequence number |
| 552 | IsKeyFrame keyframe, // is keyframe |
| 553 | IsFirst first, // is first packet of frame |
| 554 | IsLast last, // is last packet of frame |
| 555 | uint32_t timestamp, // rtp timestamp |
| 556 | int data_size = 0, // size of data |
| 557 | uint8_t* data = nullptr) { // data pointer |
| 558 | VCMPacket packet; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 559 | packet.video_header.codec = kVideoCodecH264; |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 560 | auto& h264_header = |
| 561 | packet.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 562 | packet.seqNum = seq_num; |
| 563 | packet.timestamp = timestamp; |
| 564 | if (keyframe == kKeyFrame) { |
| 565 | if (sps_pps_idr_is_keyframe_) { |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 566 | h264_header.nalus[0].type = H264::NaluType::kSps; |
| 567 | h264_header.nalus[1].type = H264::NaluType::kPps; |
| 568 | h264_header.nalus[2].type = H264::NaluType::kIdr; |
| 569 | h264_header.nalus_length = 3; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 570 | } else { |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 571 | h264_header.nalus[0].type = H264::NaluType::kIdr; |
| 572 | h264_header.nalus_length = 1; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 573 | } |
| 574 | } |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 575 | packet.video_header.is_first_packet_in_frame = first == kFirst; |
| 576 | packet.video_header.is_last_packet_in_frame = last == kLast; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 577 | packet.sizeBytes = data_size; |
| 578 | packet.dataPtr = data; |
| 579 | |
| 580 | return packet_buffer_->InsertPacket(&packet); |
| 581 | } |
| 582 | |
| 583 | const bool sps_pps_idr_is_keyframe_; |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 584 | }; |
| 585 | |
| 586 | // This fixture is used to test the general behaviour of the packet buffer |
| 587 | // in both configurations. |
| 588 | class TestPacketBufferH264Parameterized |
| 589 | : public ::testing::WithParamInterface<bool>, |
| 590 | public TestPacketBufferH264 { |
| 591 | protected: |
| 592 | TestPacketBufferH264Parameterized() : TestPacketBufferH264(GetParam()) {} |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 593 | }; |
| 594 | |
Mirko Bonadei | c84f661 | 2019-01-31 11:20:57 | [diff] [blame] | 595 | INSTANTIATE_TEST_SUITE_P(SpsPpsIdrIsKeyframe, |
| 596 | TestPacketBufferH264Parameterized, |
| 597 | ::testing::Values(false, true)); |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 598 | |
philipel | bc5a408 | 2017-12-06 09:41:08 | [diff] [blame] | 599 | TEST_P(TestPacketBufferH264Parameterized, DontRemoveMissingPacketOnClearTo) { |
| 600 | EXPECT_TRUE(InsertH264(0, kKeyFrame, kFirst, kLast, 0)); |
| 601 | EXPECT_TRUE(InsertH264(2, kDeltaFrame, kFirst, kNotLast, 2)); |
| 602 | packet_buffer_->ClearTo(0); |
| 603 | EXPECT_TRUE(InsertH264(3, kDeltaFrame, kNotFirst, kLast, 2)); |
| 604 | |
| 605 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 606 | CheckFrame(0); |
| 607 | } |
| 608 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 609 | TEST_P(TestPacketBufferH264Parameterized, GetBitstreamOneFrameFullBuffer) { |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 610 | uint8_t* data_arr[kStartSize]; |
| 611 | uint8_t expected[kStartSize]; |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 612 | |
| 613 | for (uint8_t i = 0; i < kStartSize; ++i) { |
| 614 | data_arr[i] = new uint8_t[1]; |
| 615 | data_arr[i][0] = i; |
| 616 | expected[i] = i; |
| 617 | } |
| 618 | |
| 619 | EXPECT_TRUE(InsertH264(0, kKeyFrame, kFirst, kNotLast, 1, 1, data_arr[0])); |
| 620 | for (uint8_t i = 1; i < kStartSize - 1; ++i) { |
| 621 | EXPECT_TRUE( |
| 622 | InsertH264(i, kKeyFrame, kNotFirst, kNotLast, 1, 1, data_arr[i])); |
| 623 | } |
| 624 | EXPECT_TRUE(InsertH264(kStartSize - 1, kKeyFrame, kNotFirst, kLast, 1, 1, |
| 625 | data_arr[kStartSize - 1])); |
| 626 | |
| 627 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 628 | CheckFrame(0); |
| 629 | EXPECT_EQ(frames_from_callback_[0]->size(), static_cast<size_t>(kStartSize)); |
Niels Möller | 9c843906 | 2019-01-11 09:21:35 | [diff] [blame] | 630 | EXPECT_EQ(memcmp(frames_from_callback_[0]->data(), expected, kStartSize), 0); |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 631 | } |
| 632 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 633 | TEST_P(TestPacketBufferH264Parameterized, GetBitstreamBufferPadding) { |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 634 | uint16_t seq_num = Rand(); |
philipel | 41b8ca0 | 2016-11-07 14:42:24 | [diff] [blame] | 635 | uint8_t data_data[] = "some plain old data"; |
| 636 | uint8_t* data = new uint8_t[sizeof(data_data)]; |
| 637 | memcpy(data, data_data, sizeof(data_data)); |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 638 | |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 639 | VCMPacket packet; |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 640 | auto& h264_header = |
| 641 | packet.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
| 642 | h264_header.nalus_length = 1; |
| 643 | h264_header.nalus[0].type = H264::NaluType::kIdr; |
| 644 | h264_header.packetization_type = kH264SingleNalu; |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 645 | packet.seqNum = seq_num; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 646 | packet.video_header.codec = kVideoCodecH264; |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 647 | packet.insertStartCode = true; |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 648 | packet.dataPtr = data; |
philipel | 41b8ca0 | 2016-11-07 14:42:24 | [diff] [blame] | 649 | packet.sizeBytes = sizeof(data_data); |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 650 | packet.video_header.is_first_packet_in_frame = true; |
| 651 | packet.video_header.is_last_packet_in_frame = true; |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 652 | packet_buffer_->InsertPacket(&packet); |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 653 | |
| 654 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
Niels Möller | 77536a2 | 2019-01-15 07:50:01 | [diff] [blame] | 655 | EXPECT_EQ(frames_from_callback_[seq_num]->EncodedImage().size(), |
philipel | 41b8ca0 | 2016-11-07 14:42:24 | [diff] [blame] | 656 | sizeof(data_data)); |
Niels Möller | 48a7946 | 2018-12-07 15:21:18 | [diff] [blame] | 657 | EXPECT_EQ(frames_from_callback_[seq_num]->EncodedImage().capacity(), |
Niels Möller | 009ab3c | 2019-03-08 10:26:58 | [diff] [blame] | 658 | sizeof(data_data)); |
Johannes Kron | a370556 | 2019-08-26 14:37:11 | [diff] [blame] | 659 | EXPECT_EQ(memcmp(frames_from_callback_[seq_num]->data(), data_data, |
| 660 | sizeof(data_data)), |
| 661 | 0); |
philipel | 3692845 | 2016-11-07 09:42:36 | [diff] [blame] | 662 | } |
| 663 | |
Johannes Kron | a370556 | 2019-08-26 14:37:11 | [diff] [blame] | 664 | TEST_F(TestPacketBuffer, FreeSlotsOnFrameCreation) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 665 | const uint16_t seq_num = Rand(); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 666 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 667 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 668 | EXPECT_TRUE(Insert(seq_num + 1, kDeltaFrame, kNotFirst, kNotLast)); |
| 669 | EXPECT_TRUE(Insert(seq_num + 2, kDeltaFrame, kNotFirst, kLast)); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 670 | EXPECT_EQ(1UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 671 | CheckFrame(seq_num); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 672 | |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 673 | // Insert frame that fills the whole buffer. |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 674 | EXPECT_TRUE(Insert(seq_num + 3, kKeyFrame, kFirst, kNotLast)); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 675 | for (int i = 0; i < kMaxSize - 2; ++i) |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 676 | EXPECT_TRUE(Insert(seq_num + i + 4, kDeltaFrame, kNotFirst, kNotLast)); |
| 677 | EXPECT_TRUE(Insert(seq_num + kMaxSize + 2, kKeyFrame, kNotFirst, kLast)); |
Johannes Kron | a370556 | 2019-08-26 14:37:11 | [diff] [blame] | 678 | EXPECT_EQ(2UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 679 | CheckFrame(seq_num + 3); |
Johannes Kron | a370556 | 2019-08-26 14:37:11 | [diff] [blame] | 680 | |
| 681 | frames_from_callback_.clear(); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 682 | } |
| 683 | |
philipel | 02447bc | 2016-05-13 13:01:03 | [diff] [blame] | 684 | TEST_F(TestPacketBuffer, Clear) { |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 685 | const uint16_t seq_num = Rand(); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 686 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 687 | EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kNotLast)); |
| 688 | EXPECT_TRUE(Insert(seq_num + 1, kDeltaFrame, kNotFirst, kNotLast)); |
| 689 | EXPECT_TRUE(Insert(seq_num + 2, kDeltaFrame, kNotFirst, kLast)); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 690 | EXPECT_EQ(1UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 691 | CheckFrame(seq_num); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 692 | |
philipel | 02447bc | 2016-05-13 13:01:03 | [diff] [blame] | 693 | packet_buffer_->Clear(); |
philipel | f413933 | 2016-04-20 08:26:34 | [diff] [blame] | 694 | |
philipel | aee3e0e | 2016-11-01 10:45:34 | [diff] [blame] | 695 | EXPECT_TRUE(Insert(seq_num + kStartSize, kKeyFrame, kFirst, kNotLast)); |
| 696 | EXPECT_TRUE( |
| 697 | Insert(seq_num + kStartSize + 1, kDeltaFrame, kNotFirst, kNotLast)); |
| 698 | EXPECT_TRUE(Insert(seq_num + kStartSize + 2, kDeltaFrame, kNotFirst, kLast)); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 699 | EXPECT_EQ(2UL, frames_from_callback_.size()); |
philipel | 17deeb4 | 2016-08-11 13:09:26 | [diff] [blame] | 700 | CheckFrame(seq_num + kStartSize); |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 701 | } |
| 702 | |
philipel | 20dce34 | 2016-11-28 15:14:57 | [diff] [blame] | 703 | TEST_F(TestPacketBuffer, FramesAfterClear) { |
| 704 | Insert(9025, kDeltaFrame, kFirst, kLast); |
| 705 | Insert(9024, kKeyFrame, kFirst, kLast); |
| 706 | packet_buffer_->ClearTo(9025); |
| 707 | Insert(9057, kDeltaFrame, kFirst, kLast); |
| 708 | Insert(9026, kDeltaFrame, kFirst, kLast); |
| 709 | |
| 710 | CheckFrame(9024); |
| 711 | CheckFrame(9025); |
| 712 | CheckFrame(9026); |
| 713 | CheckFrame(9057); |
| 714 | } |
| 715 | |
philipel | 8b6995b | 2019-01-09 11:39:18 | [diff] [blame] | 716 | TEST_F(TestPacketBuffer, SameFrameDifferentTimestamps) { |
| 717 | Insert(0, kKeyFrame, kFirst, kNotLast, 0, nullptr, 1000); |
| 718 | Insert(1, kKeyFrame, kNotFirst, kLast, 0, nullptr, 1001); |
| 719 | |
| 720 | ASSERT_EQ(0UL, frames_from_callback_.size()); |
| 721 | } |
| 722 | |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 723 | TEST_F(TestPacketBuffer, DontLeakPayloadData) { |
| 724 | // NOTE! Any eventual leak is suppose to be detected by valgrind |
| 725 | // or any other similar tool. |
| 726 | uint8_t* data1 = new uint8_t[5]; |
| 727 | uint8_t* data2 = new uint8_t[5]; |
| 728 | uint8_t* data3 = new uint8_t[5]; |
| 729 | uint8_t* data4 = new uint8_t[5]; |
| 730 | |
| 731 | // Expected to free data1 upon PacketBuffer destruction. |
| 732 | EXPECT_TRUE(Insert(2, kKeyFrame, kFirst, kNotLast, 5, data1)); |
| 733 | |
| 734 | // Expect to free data2 upon insertion. |
| 735 | EXPECT_TRUE(Insert(2, kKeyFrame, kFirst, kNotLast, 5, data2)); |
| 736 | |
| 737 | // Expect to free data3 upon insertion (old packet). |
| 738 | packet_buffer_->ClearTo(1); |
Johannes Kron | bd3f305 | 2019-08-01 13:45:54 | [diff] [blame] | 739 | EXPECT_TRUE(Insert(1, kKeyFrame, kFirst, kNotLast, 5, data3)); |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 740 | |
| 741 | // Expect to free data4 upon insertion (packet buffer is full). |
Johannes Kron | bd3f305 | 2019-08-01 13:45:54 | [diff] [blame] | 742 | EXPECT_FALSE(Insert(2 + kMaxSize, kKeyFrame, kFirst, kNotLast, 5, data4)); |
philipel | 759e0b7 | 2016-11-30 09:32:05 | [diff] [blame] | 743 | } |
| 744 | |
philipel | ea142f8 | 2017-01-11 10:01:56 | [diff] [blame] | 745 | TEST_F(TestPacketBuffer, ContinuousSeqNumDoubleMarkerBit) { |
| 746 | Insert(2, kKeyFrame, kNotFirst, kNotLast); |
| 747 | Insert(1, kKeyFrame, kFirst, kLast); |
| 748 | frames_from_callback_.clear(); |
| 749 | Insert(3, kKeyFrame, kNotFirst, kLast); |
| 750 | |
| 751 | EXPECT_EQ(0UL, frames_from_callback_.size()); |
| 752 | } |
| 753 | |
philipel | 3184f8e | 2017-05-18 15:08:53 | [diff] [blame] | 754 | TEST_F(TestPacketBuffer, PacketTimestamps) { |
Danil Chapovalov | 0040b66 | 2018-06-18 08:48:16 | [diff] [blame] | 755 | absl::optional<int64_t> packet_ms; |
| 756 | absl::optional<int64_t> packet_keyframe_ms; |
philipel | 3184f8e | 2017-05-18 15:08:53 | [diff] [blame] | 757 | |
| 758 | packet_ms = packet_buffer_->LastReceivedPacketMs(); |
| 759 | packet_keyframe_ms = packet_buffer_->LastReceivedKeyframePacketMs(); |
| 760 | EXPECT_FALSE(packet_ms); |
| 761 | EXPECT_FALSE(packet_keyframe_ms); |
| 762 | |
| 763 | int64_t keyframe_ms = clock_->TimeInMilliseconds(); |
| 764 | EXPECT_TRUE(Insert(100, kKeyFrame, kFirst, kLast)); |
| 765 | packet_ms = packet_buffer_->LastReceivedPacketMs(); |
| 766 | packet_keyframe_ms = packet_buffer_->LastReceivedKeyframePacketMs(); |
| 767 | EXPECT_TRUE(packet_ms); |
| 768 | EXPECT_TRUE(packet_keyframe_ms); |
| 769 | EXPECT_EQ(keyframe_ms, *packet_ms); |
| 770 | EXPECT_EQ(keyframe_ms, *packet_keyframe_ms); |
| 771 | |
| 772 | clock_->AdvanceTimeMilliseconds(100); |
| 773 | int64_t delta_ms = clock_->TimeInMilliseconds(); |
| 774 | EXPECT_TRUE(Insert(101, kDeltaFrame, kFirst, kLast)); |
| 775 | packet_ms = packet_buffer_->LastReceivedPacketMs(); |
| 776 | packet_keyframe_ms = packet_buffer_->LastReceivedKeyframePacketMs(); |
| 777 | EXPECT_TRUE(packet_ms); |
| 778 | EXPECT_TRUE(packet_keyframe_ms); |
| 779 | EXPECT_EQ(delta_ms, *packet_ms); |
| 780 | EXPECT_EQ(keyframe_ms, *packet_keyframe_ms); |
| 781 | |
| 782 | packet_buffer_->Clear(); |
| 783 | packet_ms = packet_buffer_->LastReceivedPacketMs(); |
| 784 | packet_keyframe_ms = packet_buffer_->LastReceivedKeyframePacketMs(); |
| 785 | EXPECT_FALSE(packet_ms); |
| 786 | EXPECT_FALSE(packet_keyframe_ms); |
| 787 | } |
| 788 | |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 789 | TEST_F(TestPacketBuffer, IncomingCodecChange) { |
| 790 | VCMPacket packet; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 791 | packet.video_header.is_first_packet_in_frame = true; |
| 792 | packet.video_header.is_last_packet_in_frame = true; |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 793 | packet.sizeBytes = 0; |
| 794 | packet.dataPtr = nullptr; |
| 795 | |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 796 | packet.video_header.codec = kVideoCodecVP8; |
| 797 | packet.video_header.video_type_header.emplace<RTPVideoHeaderVP8>(); |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 798 | packet.timestamp = 1; |
| 799 | packet.seqNum = 1; |
Niels Möller | abbc50e | 2019-04-24 07:41:16 | [diff] [blame] | 800 | packet.video_header.frame_type = VideoFrameType::kVideoFrameKey; |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 801 | EXPECT_TRUE(packet_buffer_->InsertPacket(&packet)); |
| 802 | |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 803 | packet.video_header.codec = kVideoCodecH264; |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 804 | auto& h264_header = |
| 805 | packet.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
| 806 | h264_header.nalus_length = 1; |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 807 | packet.timestamp = 3; |
| 808 | packet.seqNum = 3; |
| 809 | EXPECT_TRUE(packet_buffer_->InsertPacket(&packet)); |
| 810 | |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 811 | packet.video_header.codec = kVideoCodecVP8; |
| 812 | packet.video_header.video_type_header.emplace<RTPVideoHeaderVP8>(); |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 813 | packet.timestamp = 2; |
| 814 | packet.seqNum = 2; |
Niels Möller | abbc50e | 2019-04-24 07:41:16 | [diff] [blame] | 815 | packet.video_header.frame_type = VideoFrameType::kVideoFrameDelta; |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 816 | |
| 817 | EXPECT_TRUE(packet_buffer_->InsertPacket(&packet)); |
| 818 | |
| 819 | EXPECT_EQ(3UL, frames_from_callback_.size()); |
| 820 | } |
| 821 | |
| 822 | TEST_F(TestPacketBuffer, TooManyNalusInPacket) { |
| 823 | VCMPacket packet; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 824 | packet.video_header.codec = kVideoCodecH264; |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 825 | packet.timestamp = 1; |
| 826 | packet.seqNum = 1; |
Niels Möller | abbc50e | 2019-04-24 07:41:16 | [diff] [blame] | 827 | packet.video_header.frame_type = VideoFrameType::kVideoFrameKey; |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 828 | packet.video_header.is_first_packet_in_frame = true; |
| 829 | packet.video_header.is_last_packet_in_frame = true; |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 830 | auto& h264_header = |
| 831 | packet.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
| 832 | h264_header.nalus_length = kMaxNalusPerPacket; |
philipel | 09133af | 2018-05-17 12:11:09 | [diff] [blame] | 833 | packet.sizeBytes = 0; |
| 834 | packet.dataPtr = nullptr; |
| 835 | EXPECT_TRUE(packet_buffer_->InsertPacket(&packet)); |
| 836 | |
| 837 | EXPECT_EQ(0UL, frames_from_callback_.size()); |
| 838 | } |
| 839 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 840 | TEST_P(TestPacketBufferH264Parameterized, OneFrameFillBuffer) { |
philipel | 2c9f9f2 | 2017-06-13 09:47:28 | [diff] [blame] | 841 | InsertH264(0, kKeyFrame, kFirst, kNotLast, 1000); |
| 842 | for (int i = 1; i < kStartSize - 1; ++i) |
| 843 | InsertH264(i, kKeyFrame, kNotFirst, kNotLast, 1000); |
| 844 | InsertH264(kStartSize - 1, kKeyFrame, kNotFirst, kLast, 1000); |
| 845 | |
| 846 | EXPECT_EQ(1UL, frames_from_callback_.size()); |
| 847 | CheckFrame(0); |
| 848 | } |
| 849 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 850 | TEST_P(TestPacketBufferH264Parameterized, CreateFramesAfterFilledBuffer) { |
philipel | 227f8b9 | 2017-08-04 13:39:31 | [diff] [blame] | 851 | InsertH264(kStartSize - 2, kKeyFrame, kFirst, kLast, 0); |
| 852 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 853 | frames_from_callback_.clear(); |
| 854 | |
| 855 | InsertH264(kStartSize, kDeltaFrame, kFirst, kNotLast, 2000); |
| 856 | for (int i = 1; i < kStartSize; ++i) |
| 857 | InsertH264(kStartSize + i, kDeltaFrame, kNotFirst, kNotLast, 2000); |
| 858 | InsertH264(kStartSize + kStartSize, kDeltaFrame, kNotFirst, kLast, 2000); |
| 859 | ASSERT_EQ(0UL, frames_from_callback_.size()); |
| 860 | |
| 861 | InsertH264(kStartSize - 1, kKeyFrame, kFirst, kLast, 1000); |
| 862 | ASSERT_EQ(2UL, frames_from_callback_.size()); |
| 863 | CheckFrame(kStartSize - 1); |
| 864 | CheckFrame(kStartSize); |
| 865 | } |
| 866 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 867 | TEST_P(TestPacketBufferH264Parameterized, OneFrameMaxSeqNum) { |
philipel | 2c9f9f2 | 2017-06-13 09:47:28 | [diff] [blame] | 868 | InsertH264(65534, kKeyFrame, kFirst, kNotLast, 1000); |
| 869 | InsertH264(65535, kKeyFrame, kNotFirst, kLast, 1000); |
| 870 | |
| 871 | EXPECT_EQ(1UL, frames_from_callback_.size()); |
| 872 | CheckFrame(65534); |
| 873 | } |
| 874 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 875 | TEST_P(TestPacketBufferH264Parameterized, ClearMissingPacketsOnKeyframe) { |
philipel | 2c9f9f2 | 2017-06-13 09:47:28 | [diff] [blame] | 876 | InsertH264(0, kKeyFrame, kFirst, kLast, 1000); |
| 877 | InsertH264(2, kKeyFrame, kFirst, kLast, 3000); |
| 878 | InsertH264(3, kDeltaFrame, kFirst, kNotLast, 4000); |
| 879 | InsertH264(4, kDeltaFrame, kNotFirst, kLast, 4000); |
| 880 | |
| 881 | ASSERT_EQ(3UL, frames_from_callback_.size()); |
| 882 | |
| 883 | InsertH264(kStartSize + 1, kKeyFrame, kFirst, kLast, 18000); |
| 884 | |
| 885 | ASSERT_EQ(4UL, frames_from_callback_.size()); |
| 886 | CheckFrame(0); |
| 887 | CheckFrame(2); |
| 888 | CheckFrame(3); |
| 889 | CheckFrame(kStartSize + 1); |
| 890 | } |
| 891 | |
Rasmus Brandt | 88f080a | 2017-11-02 13:28:06 | [diff] [blame] | 892 | TEST_P(TestPacketBufferH264Parameterized, FindFramesOnPadding) { |
philipel | 2c9f9f2 | 2017-06-13 09:47:28 | [diff] [blame] | 893 | InsertH264(0, kKeyFrame, kFirst, kLast, 1000); |
| 894 | InsertH264(2, kDeltaFrame, kFirst, kLast, 1000); |
| 895 | |
| 896 | ASSERT_EQ(1UL, frames_from_callback_.size()); |
| 897 | packet_buffer_->PaddingReceived(1); |
| 898 | ASSERT_EQ(2UL, frames_from_callback_.size()); |
| 899 | CheckFrame(0); |
| 900 | CheckFrame(2); |
| 901 | } |
| 902 | |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 903 | class TestPacketBufferH264XIsKeyframe : public TestPacketBufferH264 { |
| 904 | protected: |
| 905 | const uint16_t kSeqNum = 5; |
| 906 | |
| 907 | explicit TestPacketBufferH264XIsKeyframe(bool sps_pps_idr_is_keyframe) |
| 908 | : TestPacketBufferH264(sps_pps_idr_is_keyframe) { |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 909 | packet_.video_header.codec = kVideoCodecH264; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 910 | packet_.seqNum = kSeqNum; |
| 911 | |
Niels Möller | d5e02f0 | 2019-02-20 12:12:21 | [diff] [blame] | 912 | packet_.video_header.is_first_packet_in_frame = true; |
| 913 | packet_.video_header.is_last_packet_in_frame = true; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 914 | } |
| 915 | |
| 916 | VCMPacket packet_; |
| 917 | }; |
| 918 | |
| 919 | class TestPacketBufferH264IdrIsKeyframe |
| 920 | : public TestPacketBufferH264XIsKeyframe { |
| 921 | protected: |
| 922 | TestPacketBufferH264IdrIsKeyframe() |
| 923 | : TestPacketBufferH264XIsKeyframe(false) {} |
| 924 | }; |
| 925 | |
| 926 | TEST_F(TestPacketBufferH264IdrIsKeyframe, IdrIsKeyframe) { |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 927 | auto& h264_header = |
| 928 | packet_.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
| 929 | h264_header.nalus[0].type = H264::NaluType::kIdr; |
| 930 | h264_header.nalus_length = 1; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 931 | packet_buffer_->InsertPacket(&packet_); |
| 932 | |
| 933 | ASSERT_EQ(1u, frames_from_callback_.size()); |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 934 | EXPECT_EQ(VideoFrameType::kVideoFrameKey, |
| 935 | frames_from_callback_[kSeqNum]->frame_type()); |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 936 | } |
| 937 | |
| 938 | TEST_F(TestPacketBufferH264IdrIsKeyframe, SpsPpsIdrIsKeyframe) { |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 939 | auto& h264_header = |
| 940 | packet_.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
| 941 | h264_header.nalus[0].type = H264::NaluType::kSps; |
| 942 | h264_header.nalus[1].type = H264::NaluType::kPps; |
| 943 | h264_header.nalus[2].type = H264::NaluType::kIdr; |
| 944 | h264_header.nalus_length = 3; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 945 | |
| 946 | packet_buffer_->InsertPacket(&packet_); |
| 947 | |
| 948 | ASSERT_EQ(1u, frames_from_callback_.size()); |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 949 | EXPECT_EQ(VideoFrameType::kVideoFrameKey, |
| 950 | frames_from_callback_[kSeqNum]->frame_type()); |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 951 | } |
| 952 | |
| 953 | class TestPacketBufferH264SpsPpsIdrIsKeyframe |
| 954 | : public TestPacketBufferH264XIsKeyframe { |
| 955 | protected: |
| 956 | TestPacketBufferH264SpsPpsIdrIsKeyframe() |
| 957 | : TestPacketBufferH264XIsKeyframe(true) {} |
| 958 | }; |
| 959 | |
| 960 | TEST_F(TestPacketBufferH264SpsPpsIdrIsKeyframe, IdrIsNotKeyframe) { |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 961 | auto& h264_header = |
| 962 | packet_.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
| 963 | h264_header.nalus[0].type = H264::NaluType::kIdr; |
| 964 | h264_header.nalus_length = 1; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 965 | |
| 966 | packet_buffer_->InsertPacket(&packet_); |
| 967 | |
| 968 | ASSERT_EQ(1u, frames_from_callback_.size()); |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 969 | EXPECT_EQ(VideoFrameType::kVideoFrameDelta, |
| 970 | frames_from_callback_[5]->frame_type()); |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 971 | } |
| 972 | |
| 973 | TEST_F(TestPacketBufferH264SpsPpsIdrIsKeyframe, SpsPpsIsNotKeyframe) { |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 974 | auto& h264_header = |
| 975 | packet_.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
| 976 | h264_header.nalus[0].type = H264::NaluType::kSps; |
| 977 | h264_header.nalus[1].type = H264::NaluType::kPps; |
| 978 | h264_header.nalus_length = 2; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 979 | |
| 980 | packet_buffer_->InsertPacket(&packet_); |
| 981 | |
| 982 | ASSERT_EQ(1u, frames_from_callback_.size()); |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 983 | EXPECT_EQ(VideoFrameType::kVideoFrameDelta, |
| 984 | frames_from_callback_[kSeqNum]->frame_type()); |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 985 | } |
| 986 | |
| 987 | TEST_F(TestPacketBufferH264SpsPpsIdrIsKeyframe, SpsPpsIdrIsKeyframe) { |
philipel | 7d745e5 | 2018-08-02 12:03:53 | [diff] [blame] | 988 | auto& h264_header = |
| 989 | packet_.video_header.video_type_header.emplace<RTPVideoHeaderH264>(); |
| 990 | h264_header.nalus[0].type = H264::NaluType::kSps; |
| 991 | h264_header.nalus[1].type = H264::NaluType::kPps; |
| 992 | h264_header.nalus[2].type = H264::NaluType::kIdr; |
| 993 | h264_header.nalus_length = 3; |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 994 | |
| 995 | packet_buffer_->InsertPacket(&packet_); |
| 996 | |
| 997 | ASSERT_EQ(1u, frames_from_callback_.size()); |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 998 | EXPECT_EQ(VideoFrameType::kVideoFrameKey, |
| 999 | frames_from_callback_[kSeqNum]->frame_type()); |
Rasmus Brandt | edf4ff7 | 2017-10-24 08:07:48 | [diff] [blame] | 1000 | } |
| 1001 | |
philipel | c707ab7 | 2016-04-01 09:01:54 | [diff] [blame] | 1002 | } // namespace video_coding |
| 1003 | } // namespace webrtc |