aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 11 | #include "modules/audio_mixer/frame_combiner.h" |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 12 | |
Yves Gerey | 3e70781 | 2018-11-28 15:47:49 | [diff] [blame] | 13 | #include <cstdint> |
| 14 | #include <initializer_list> |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 15 | #include <numeric> |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 16 | #include <string> |
Yves Gerey | 3e70781 | 2018-11-28 15:47:49 | [diff] [blame] | 17 | #include <type_traits> |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 18 | |
Yves Gerey | 3e70781 | 2018-11-28 15:47:49 | [diff] [blame] | 19 | #include "api/array_view.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 20 | #include "audio/utility/audio_frame_operations.h" |
| 21 | #include "modules/audio_mixer/gain_change_calculator.h" |
| 22 | #include "modules/audio_mixer/sine_wave_generator.h" |
| 23 | #include "rtc_base/checks.h" |
Jonas Olsson | 366a50c | 2018-09-06 11:41:30 | [diff] [blame] | 24 | #include "rtc_base/strings/string_builder.h" |
Alex Loiko | b4977de | 2019-01-28 15:38:38 | [diff] [blame] | 25 | #include "test/gmock.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 26 | #include "test/gtest.h" |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 27 | |
| 28 | namespace webrtc { |
| 29 | |
| 30 | namespace { |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 31 | using LimiterType = FrameCombiner::LimiterType; |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 32 | struct FrameCombinerConfig { |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 33 | bool use_limiter; |
| 34 | int sample_rate_hz; |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 35 | int number_of_channels; |
| 36 | float wave_frequency; |
| 37 | }; |
| 38 | |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 39 | std::string ProduceDebugText(int sample_rate_hz, |
| 40 | int number_of_channels, |
| 41 | int number_of_sources) { |
Jonas Olsson | 366a50c | 2018-09-06 11:41:30 | [diff] [blame] | 42 | rtc::StringBuilder ss; |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 43 | ss << "Sample rate: " << sample_rate_hz << " ,"; |
| 44 | ss << "number of channels: " << number_of_channels << " ,"; |
| 45 | ss << "number of sources: " << number_of_sources; |
Jonas Olsson | 84df1c7 | 2018-09-14 14:59:32 | [diff] [blame] | 46 | return ss.Release(); |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 47 | } |
| 48 | |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 49 | std::string ProduceDebugText(const FrameCombinerConfig& config) { |
Jonas Olsson | 366a50c | 2018-09-06 11:41:30 | [diff] [blame] | 50 | rtc::StringBuilder ss; |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 51 | ss << "Sample rate: " << config.sample_rate_hz << " ,"; |
| 52 | ss << "number of channels: " << config.number_of_channels << " ,"; |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 53 | ss << "limiter active: " << (config.use_limiter ? "on" : "off") << " ,"; |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 54 | ss << "wave frequency: " << config.wave_frequency << " ,"; |
Jonas Olsson | 84df1c7 | 2018-09-14 14:59:32 | [diff] [blame] | 55 | return ss.Release(); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 56 | } |
| 57 | |
| 58 | AudioFrame frame1; |
| 59 | AudioFrame frame2; |
| 60 | AudioFrame audio_frame_for_mixing; |
| 61 | |
| 62 | void SetUpFrames(int sample_rate_hz, int number_of_channels) { |
| 63 | for (auto* frame : {&frame1, &frame2}) { |
solenberg | c7b4a45 | 2017-09-28 14:37:11 | [diff] [blame] | 64 | frame->UpdateFrame(0, nullptr, rtc::CheckedDivExact(sample_rate_hz, 100), |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 65 | sample_rate_hz, AudioFrame::kNormalSpeech, |
| 66 | AudioFrame::kVadActive, number_of_channels); |
| 67 | } |
| 68 | } |
| 69 | } // namespace |
| 70 | |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 71 | // The limiter requires sample rate divisible by 2000. |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 72 | TEST(FrameCombiner, BasicApiCallsLimiter) { |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 73 | FrameCombiner combiner(true); |
| 74 | for (const int rate : {8000, 18000, 34000, 48000}) { |
Alex Loiko | b4977de | 2019-01-28 15:38:38 | [diff] [blame] | 75 | for (const int number_of_channels : {1, 2, 4, 8}) { |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 76 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 77 | SetUpFrames(rate, number_of_channels); |
| 78 | |
| 79 | for (const int number_of_frames : {0, 1, 2}) { |
| 80 | SCOPED_TRACE( |
| 81 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 82 | const std::vector<AudioFrame*> frames_to_combine( |
| 83 | all_frames.begin(), all_frames.begin() + number_of_frames); |
| 84 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 85 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 86 | } |
| 87 | } |
| 88 | } |
| 89 | } |
| 90 | |
Alex Loiko | b4977de | 2019-01-28 15:38:38 | [diff] [blame] | 91 | // There are DCHECKs in place to check for invalid parameters. |
| 92 | TEST(FrameCombiner, DebugBuildCrashesWithManyChannels) { |
| 93 | FrameCombiner combiner(true); |
| 94 | for (const int rate : {8000, 18000, 34000, 48000}) { |
| 95 | for (const int number_of_channels : {10, 20, 21}) { |
| 96 | if (static_cast<size_t>(rate / 100 * number_of_channels) > |
| 97 | AudioFrame::kMaxDataSizeSamples) { |
| 98 | continue; |
| 99 | } |
| 100 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 101 | SetUpFrames(rate, number_of_channels); |
| 102 | |
| 103 | const int number_of_frames = 2; |
| 104 | SCOPED_TRACE( |
| 105 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 106 | const std::vector<AudioFrame*> frames_to_combine( |
| 107 | all_frames.begin(), all_frames.begin() + number_of_frames); |
| 108 | #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
| 109 | EXPECT_DEATH( |
| 110 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
| 111 | frames_to_combine.size(), &audio_frame_for_mixing), |
| 112 | ""); |
| 113 | #elif !RTC_DCHECK_IS_ON |
| 114 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
| 115 | frames_to_combine.size(), &audio_frame_for_mixing); |
| 116 | #endif |
| 117 | } |
| 118 | } |
| 119 | } |
| 120 | |
| 121 | TEST(FrameCombiner, DebugBuildCrashesWithHighRate) { |
| 122 | FrameCombiner combiner(true); |
| 123 | for (const int rate : {50000, 96000, 128000, 196000}) { |
| 124 | for (const int number_of_channels : {1, 2, 3}) { |
| 125 | if (static_cast<size_t>(rate / 100 * number_of_channels) > |
| 126 | AudioFrame::kMaxDataSizeSamples) { |
| 127 | continue; |
| 128 | } |
| 129 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 130 | SetUpFrames(rate, number_of_channels); |
| 131 | |
| 132 | const int number_of_frames = 2; |
| 133 | SCOPED_TRACE( |
| 134 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 135 | const std::vector<AudioFrame*> frames_to_combine( |
| 136 | all_frames.begin(), all_frames.begin() + number_of_frames); |
| 137 | #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
| 138 | EXPECT_DEATH( |
| 139 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
| 140 | frames_to_combine.size(), &audio_frame_for_mixing), |
| 141 | ""); |
| 142 | #elif !RTC_DCHECK_IS_ON |
| 143 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
| 144 | frames_to_combine.size(), &audio_frame_for_mixing); |
| 145 | #endif |
| 146 | } |
| 147 | } |
| 148 | } |
| 149 | |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 150 | // With no limiter, the rate has to be divisible by 100 since we use |
| 151 | // 10 ms frames. |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 152 | TEST(FrameCombiner, BasicApiCallsNoLimiter) { |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 153 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 154 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
Alex Loiko | b4977de | 2019-01-28 15:38:38 | [diff] [blame] | 155 | for (const int number_of_channels : {1, 2, 4, 8}) { |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 156 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 157 | SetUpFrames(rate, number_of_channels); |
| 158 | |
| 159 | for (const int number_of_frames : {0, 1, 2}) { |
| 160 | SCOPED_TRACE( |
| 161 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 162 | const std::vector<AudioFrame*> frames_to_combine( |
| 163 | all_frames.begin(), all_frames.begin() + number_of_frames); |
| 164 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 165 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 166 | } |
| 167 | } |
| 168 | } |
| 169 | } |
| 170 | |
| 171 | TEST(FrameCombiner, CombiningZeroFramesShouldProduceSilence) { |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 172 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 173 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
| 174 | for (const int number_of_channels : {1, 2}) { |
| 175 | SCOPED_TRACE(ProduceDebugText(rate, number_of_channels, 0)); |
| 176 | |
| 177 | const std::vector<AudioFrame*> frames_to_combine; |
| 178 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 179 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 180 | |
yujo | 36b1a5f | 2017-06-12 19:45:32 | [diff] [blame] | 181 | const int16_t* audio_frame_for_mixing_data = |
| 182 | audio_frame_for_mixing.data(); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 183 | const std::vector<int16_t> mixed_data( |
yujo | 36b1a5f | 2017-06-12 19:45:32 | [diff] [blame] | 184 | audio_frame_for_mixing_data, |
| 185 | audio_frame_for_mixing_data + number_of_channels * rate / 100); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 186 | |
| 187 | const std::vector<int16_t> expected(number_of_channels * rate / 100, 0); |
| 188 | EXPECT_EQ(mixed_data, expected); |
| 189 | } |
| 190 | } |
| 191 | } |
| 192 | |
| 193 | TEST(FrameCombiner, CombiningOneFrameShouldNotChangeFrame) { |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 194 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 195 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
Alex Loiko | b4977de | 2019-01-28 15:38:38 | [diff] [blame] | 196 | for (const int number_of_channels : {1, 2, 4, 8, 10}) { |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 197 | SCOPED_TRACE(ProduceDebugText(rate, number_of_channels, 1)); |
| 198 | |
| 199 | SetUpFrames(rate, number_of_channels); |
yujo | 36b1a5f | 2017-06-12 19:45:32 | [diff] [blame] | 200 | int16_t* frame1_data = frame1.mutable_data(); |
| 201 | std::iota(frame1_data, frame1_data + number_of_channels * rate / 100, 0); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 202 | const std::vector<AudioFrame*> frames_to_combine = {&frame1}; |
| 203 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 204 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 205 | |
yujo | 36b1a5f | 2017-06-12 19:45:32 | [diff] [blame] | 206 | const int16_t* audio_frame_for_mixing_data = |
| 207 | audio_frame_for_mixing.data(); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 208 | const std::vector<int16_t> mixed_data( |
yujo | 36b1a5f | 2017-06-12 19:45:32 | [diff] [blame] | 209 | audio_frame_for_mixing_data, |
| 210 | audio_frame_for_mixing_data + number_of_channels * rate / 100); |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 211 | |
| 212 | std::vector<int16_t> expected(number_of_channels * rate / 100); |
| 213 | std::iota(expected.begin(), expected.end(), 0); |
| 214 | EXPECT_EQ(mixed_data, expected); |
| 215 | } |
| 216 | } |
| 217 | } |
| 218 | |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 219 | // Send a sine wave through the FrameCombiner, and check that the |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 220 | // difference between input and output varies smoothly. Also check |
| 221 | // that it is inside reasonable bounds. This is to catch issues like |
| 222 | // chromium:695993 and chromium:816875. |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 223 | TEST(FrameCombiner, GainCurveIsSmoothForAlternatingNumberOfStreams) { |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 224 | // Rates are divisible by 2000 when limiter is active. |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 225 | std::vector<FrameCombinerConfig> configs = { |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 226 | {false, 30100, 2, 50.f}, {false, 16500, 1, 3200.f}, |
| 227 | {true, 8000, 1, 3200.f}, {true, 16000, 1, 50.f}, |
Alex Loiko | b4977de | 2019-01-28 15:38:38 | [diff] [blame] | 228 | {true, 18000, 8, 3200.f}, {true, 10000, 2, 50.f}, |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 229 | }; |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 230 | |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 231 | for (const auto& config : configs) { |
| 232 | SCOPED_TRACE(ProduceDebugText(config)); |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 233 | |
Alex Loiko | 8396e34 | 2018-06-21 10:04:05 | [diff] [blame] | 234 | FrameCombiner combiner(config.use_limiter); |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 235 | |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 236 | constexpr int16_t wave_amplitude = 30000; |
| 237 | SineWaveGenerator wave_generator(config.wave_frequency, wave_amplitude); |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 238 | |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 239 | GainChangeCalculator change_calculator; |
| 240 | float cumulative_change = 0.f; |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 241 | |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 242 | constexpr size_t iterations = 100; |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 243 | |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 244 | for (size_t i = 0; i < iterations; ++i) { |
| 245 | SetUpFrames(config.sample_rate_hz, config.number_of_channels); |
| 246 | wave_generator.GenerateNextFrame(&frame1); |
| 247 | AudioFrameOperations::Mute(&frame2); |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 248 | |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 249 | std::vector<AudioFrame*> frames_to_combine = {&frame1}; |
| 250 | if (i % 2 == 0) { |
| 251 | frames_to_combine.push_back(&frame2); |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 252 | } |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 253 | const size_t number_of_samples = |
| 254 | frame1.samples_per_channel_ * config.number_of_channels; |
| 255 | |
| 256 | // Ensures limiter is on if 'use_limiter'. |
| 257 | constexpr size_t number_of_streams = 2; |
| 258 | combiner.Combine(frames_to_combine, config.number_of_channels, |
| 259 | config.sample_rate_hz, number_of_streams, |
| 260 | &audio_frame_for_mixing); |
| 261 | cumulative_change += change_calculator.CalculateGainChange( |
| 262 | rtc::ArrayView<const int16_t>(frame1.data(), number_of_samples), |
| 263 | rtc::ArrayView<const int16_t>(audio_frame_for_mixing.data(), |
| 264 | number_of_samples)); |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 265 | } |
Alex Loiko | 507e8d1 | 2018-02-27 12:51:47 | [diff] [blame] | 266 | |
| 267 | // Check that the gain doesn't vary too much. |
| 268 | EXPECT_LT(cumulative_change, 10); |
| 269 | |
| 270 | // Check that the latest gain is within reasonable bounds. It |
| 271 | // should be slightly less that 1. |
| 272 | EXPECT_LT(0.9f, change_calculator.LatestGain()); |
| 273 | EXPECT_LT(change_calculator.LatestGain(), 1.01f); |
aleloi | 2c9306e | 2017-03-29 11:25:16 | [diff] [blame] | 274 | } |
| 275 | } |
aleloi | 24899e5 | 2017-02-21 13:06:29 | [diff] [blame] | 276 | } // namespace webrtc |