Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2019 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include "modules/pacing/pacing_controller.h" |
| 12 | |
| 13 | #include <algorithm> |
| 14 | #include <list> |
| 15 | #include <memory> |
| 16 | #include <string> |
| 17 | #include <utility> |
| 18 | #include <vector> |
| 19 | |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 20 | #include "api/transport/network_types.h" |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 21 | #include "api/units/data_rate.h" |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 22 | #include "api/units/time_delta.h" |
Per K | ffdecdc | 2023-02-22 12:53:27 | [diff] [blame] | 23 | #include "api/units/timestamp.h" |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 24 | #include "modules/pacing/packet_router.h" |
| 25 | #include "system_wrappers/include/clock.h" |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 26 | #include "test/explicit_key_value_config.h" |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 27 | #include "test/gmock.h" |
| 28 | #include "test/gtest.h" |
| 29 | |
| 30 | using ::testing::_; |
Erik Språng | e03862b | 2022-11-29 08:44:51 | [diff] [blame] | 31 | using ::testing::AnyNumber; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 32 | using ::testing::Field; |
| 33 | using ::testing::Pointee; |
| 34 | using ::testing::Property; |
| 35 | using ::testing::Return; |
Erik Språng | 1a08096 | 2022-03-17 14:16:59 | [diff] [blame] | 36 | using ::testing::WithoutArgs; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 37 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 38 | using ::webrtc::test::ExplicitKeyValueConfig; |
| 39 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 40 | namespace webrtc { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 41 | namespace { |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 42 | constexpr DataRate kFirstClusterRate = DataRate::KilobitsPerSec(900); |
| 43 | constexpr DataRate kSecondClusterRate = DataRate::KilobitsPerSec(1800); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 44 | |
| 45 | // The error stems from truncating the time interval of probe packets to integer |
| 46 | // values. This results in probing slightly higher than the target bitrate. |
| 47 | // For 1.8 Mbps, this comes to be about 120 kbps with 1200 probe packets. |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 48 | constexpr DataRate kProbingErrorMargin = DataRate::KilobitsPerSec(150); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 49 | |
| 50 | const float kPaceMultiplier = 2.5f; |
| 51 | |
| 52 | constexpr uint32_t kAudioSsrc = 12345; |
| 53 | constexpr uint32_t kVideoSsrc = 234565; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 54 | |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 55 | constexpr DataRate kTargetRate = DataRate::KilobitsPerSec(800); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 56 | |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 57 | std::unique_ptr<RtpPacketToSend> BuildPacket(RtpPacketMediaType type, |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 58 | uint32_t ssrc, |
| 59 | uint16_t sequence_number, |
| 60 | int64_t capture_time_ms, |
| 61 | size_t size) { |
Mirko Bonadei | 317a1f0 | 2019-09-17 15:06:18 | [diff] [blame] | 62 | auto packet = std::make_unique<RtpPacketToSend>(nullptr); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 63 | packet->set_packet_type(type); |
| 64 | packet->SetSsrc(ssrc); |
| 65 | packet->SetSequenceNumber(sequence_number); |
Danil Chapovalov | 9af4aa7 | 2022-02-27 21:10:55 | [diff] [blame] | 66 | packet->set_capture_time(Timestamp::Millis(capture_time_ms)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 67 | packet->SetPayloadSize(size); |
| 68 | return packet; |
| 69 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 70 | |
| 71 | class MediaStream { |
| 72 | public: |
| 73 | MediaStream(SimulatedClock& clock, |
| 74 | RtpPacketMediaType type, |
| 75 | uint32_t ssrc, |
| 76 | size_t packet_size) |
| 77 | : clock_(clock), type_(type), ssrc_(ssrc), packet_size_(packet_size) {} |
| 78 | |
| 79 | std::unique_ptr<RtpPacketToSend> BuildNextPacket() { |
| 80 | return BuildPacket(type_, ssrc_, seq_num_++, clock_.TimeInMilliseconds(), |
| 81 | packet_size_); |
| 82 | } |
| 83 | std::unique_ptr<RtpPacketToSend> BuildNextPacket(size_t size) { |
| 84 | return BuildPacket(type_, ssrc_, seq_num_++, clock_.TimeInMilliseconds(), |
| 85 | size); |
| 86 | } |
| 87 | |
| 88 | private: |
| 89 | SimulatedClock& clock_; |
| 90 | const RtpPacketMediaType type_; |
| 91 | const uint32_t ssrc_; |
| 92 | const size_t packet_size_; |
| 93 | uint16_t seq_num_ = 1000; |
| 94 | }; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 95 | |
| 96 | // Mock callback proxy, where both new and old api redirects to common mock |
| 97 | // methods that focus on core aspects. |
| 98 | class MockPacingControllerCallback : public PacingController::PacketSender { |
| 99 | public: |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 | [diff] [blame] | 100 | void SendPacket(std::unique_ptr<RtpPacketToSend> packet, |
| 101 | const PacedPacketInfo& cluster_info) override { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 102 | SendPacket(packet->Ssrc(), packet->SequenceNumber(), |
Danil Chapovalov | 9af4aa7 | 2022-02-27 21:10:55 | [diff] [blame] | 103 | packet->capture_time().ms(), |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 104 | packet->packet_type() == RtpPacketMediaType::kRetransmission, |
| 105 | packet->packet_type() == RtpPacketMediaType::kPadding); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 106 | } |
| 107 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 108 | std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding( |
| 109 | DataSize target_size) override { |
| 110 | std::vector<std::unique_ptr<RtpPacketToSend>> ret; |
| 111 | size_t padding_size = SendPadding(target_size.bytes()); |
| 112 | if (padding_size > 0) { |
Mirko Bonadei | 317a1f0 | 2019-09-17 15:06:18 | [diff] [blame] | 113 | auto packet = std::make_unique<RtpPacketToSend>(nullptr); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 114 | packet->SetPayloadSize(padding_size); |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 115 | packet->set_packet_type(RtpPacketMediaType::kPadding); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 116 | ret.emplace_back(std::move(packet)); |
| 117 | } |
| 118 | return ret; |
| 119 | } |
| 120 | |
Danil Chapovalov | 014197b | 2020-05-26 17:18:17 | [diff] [blame] | 121 | MOCK_METHOD(void, |
| 122 | SendPacket, |
| 123 | (uint32_t ssrc, |
| 124 | uint16_t sequence_number, |
| 125 | int64_t capture_timestamp, |
| 126 | bool retransmission, |
| 127 | bool padding)); |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 128 | MOCK_METHOD(std::vector<std::unique_ptr<RtpPacketToSend>>, |
| 129 | FetchFec, |
| 130 | (), |
| 131 | (override)); |
Danil Chapovalov | 014197b | 2020-05-26 17:18:17 | [diff] [blame] | 132 | MOCK_METHOD(size_t, SendPadding, (size_t target_size)); |
Erik Språng | 767f504 | 2022-09-09 13:06:51 | [diff] [blame] | 133 | MOCK_METHOD(void, |
| 134 | OnAbortedRetransmissions, |
| 135 | (uint32_t, rtc::ArrayView<const uint16_t>), |
| 136 | (override)); |
| 137 | MOCK_METHOD(absl::optional<uint32_t>, |
| 138 | GetRtxSsrcForMedia, |
| 139 | (uint32_t), |
| 140 | (const, override)); |
Markus Handell | c8c4a28 | 2023-05-08 14:46:21 | [diff] [blame] | 141 | MOCK_METHOD(void, OnBatchComplete, (), (override)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 142 | }; |
| 143 | |
| 144 | // Mock callback implementing the raw api. |
| 145 | class MockPacketSender : public PacingController::PacketSender { |
| 146 | public: |
Danil Chapovalov | 014197b | 2020-05-26 17:18:17 | [diff] [blame] | 147 | MOCK_METHOD(void, |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 | [diff] [blame] | 148 | SendPacket, |
Danil Chapovalov | 014197b | 2020-05-26 17:18:17 | [diff] [blame] | 149 | (std::unique_ptr<RtpPacketToSend> packet, |
| 150 | const PacedPacketInfo& cluster_info), |
| 151 | (override)); |
| 152 | MOCK_METHOD(std::vector<std::unique_ptr<RtpPacketToSend>>, |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 153 | FetchFec, |
| 154 | (), |
| 155 | (override)); |
| 156 | |
| 157 | MOCK_METHOD(std::vector<std::unique_ptr<RtpPacketToSend>>, |
Danil Chapovalov | 014197b | 2020-05-26 17:18:17 | [diff] [blame] | 158 | GeneratePadding, |
| 159 | (DataSize target_size), |
| 160 | (override)); |
Erik Språng | 767f504 | 2022-09-09 13:06:51 | [diff] [blame] | 161 | MOCK_METHOD(void, |
| 162 | OnAbortedRetransmissions, |
| 163 | (uint32_t, rtc::ArrayView<const uint16_t>), |
| 164 | (override)); |
| 165 | MOCK_METHOD(absl::optional<uint32_t>, |
| 166 | GetRtxSsrcForMedia, |
| 167 | (uint32_t), |
| 168 | (const, override)); |
Markus Handell | c8c4a28 | 2023-05-08 14:46:21 | [diff] [blame] | 169 | MOCK_METHOD(void, OnBatchComplete, (), (override)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 170 | }; |
| 171 | |
| 172 | class PacingControllerPadding : public PacingController::PacketSender { |
| 173 | public: |
| 174 | static const size_t kPaddingPacketSize = 224; |
| 175 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 176 | PacingControllerPadding() : padding_sent_(0), total_bytes_sent_(0) {} |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 177 | |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 | [diff] [blame] | 178 | void SendPacket(std::unique_ptr<RtpPacketToSend> packet, |
| 179 | const PacedPacketInfo& pacing_info) override { |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 180 | total_bytes_sent_ += packet->payload_size(); |
| 181 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 182 | |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 183 | std::vector<std::unique_ptr<RtpPacketToSend>> FetchFec() override { |
| 184 | return {}; |
| 185 | } |
| 186 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 187 | std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding( |
| 188 | DataSize target_size) override { |
| 189 | size_t num_packets = |
| 190 | (target_size.bytes() + kPaddingPacketSize - 1) / kPaddingPacketSize; |
| 191 | std::vector<std::unique_ptr<RtpPacketToSend>> packets; |
| 192 | for (size_t i = 0; i < num_packets; ++i) { |
Mirko Bonadei | 317a1f0 | 2019-09-17 15:06:18 | [diff] [blame] | 193 | packets.emplace_back(std::make_unique<RtpPacketToSend>(nullptr)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 194 | packets.back()->SetPadding(kPaddingPacketSize); |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 195 | packets.back()->set_packet_type(RtpPacketMediaType::kPadding); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 196 | padding_sent_ += kPaddingPacketSize; |
| 197 | } |
| 198 | return packets; |
| 199 | } |
| 200 | |
Erik Språng | 767f504 | 2022-09-09 13:06:51 | [diff] [blame] | 201 | void OnAbortedRetransmissions(uint32_t, |
| 202 | rtc::ArrayView<const uint16_t>) override {} |
| 203 | absl::optional<uint32_t> GetRtxSsrcForMedia(uint32_t) const override { |
| 204 | return absl::nullopt; |
| 205 | } |
| 206 | |
Markus Handell | c8c4a28 | 2023-05-08 14:46:21 | [diff] [blame] | 207 | void OnBatchComplete() override {} |
| 208 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 209 | size_t padding_sent() { return padding_sent_; } |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 210 | size_t total_bytes_sent() { return total_bytes_sent_; } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 211 | |
| 212 | private: |
| 213 | size_t padding_sent_; |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 214 | size_t total_bytes_sent_; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 215 | }; |
| 216 | |
| 217 | class PacingControllerProbing : public PacingController::PacketSender { |
| 218 | public: |
Per K | ffdecdc | 2023-02-22 12:53:27 | [diff] [blame] | 219 | PacingControllerProbing() = default; |
| 220 | // Controls if padding can be generated or not. |
| 221 | // In real implementation, padding can only be generated after a sent |
| 222 | // media packet, or if the sender support RTX. |
| 223 | void SetCanGeneratePadding(bool can_generate) { |
| 224 | can_generate_padding_ = can_generate; |
| 225 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 226 | |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 | [diff] [blame] | 227 | void SendPacket(std::unique_ptr<RtpPacketToSend> packet, |
| 228 | const PacedPacketInfo& pacing_info) override { |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 229 | if (packet->packet_type() != RtpPacketMediaType::kPadding) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 230 | ++packets_sent_; |
Per K | ffdecdc | 2023-02-22 12:53:27 | [diff] [blame] | 231 | } else { |
| 232 | ++padding_packets_sent_; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 233 | } |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 234 | last_pacing_info_ = pacing_info; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 235 | } |
| 236 | |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 237 | std::vector<std::unique_ptr<RtpPacketToSend>> FetchFec() override { |
| 238 | return {}; |
| 239 | } |
| 240 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 241 | std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding( |
| 242 | DataSize target_size) override { |
Per K | ffdecdc | 2023-02-22 12:53:27 | [diff] [blame] | 243 | if (!can_generate_padding_) { |
| 244 | return {}; |
| 245 | } |
Erik Språng | b210eeb | 2019-11-05 10:21:48 | [diff] [blame] | 246 | // From RTPSender: |
| 247 | // Max in the RFC 3550 is 255 bytes, we limit it to be modulus 32 for SRTP. |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 248 | const DataSize kMaxPadding = DataSize::Bytes(224); |
Erik Språng | b210eeb | 2019-11-05 10:21:48 | [diff] [blame] | 249 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 250 | std::vector<std::unique_ptr<RtpPacketToSend>> packets; |
Erik Språng | b210eeb | 2019-11-05 10:21:48 | [diff] [blame] | 251 | while (target_size > DataSize::Zero()) { |
| 252 | DataSize padding_size = std::min(kMaxPadding, target_size); |
| 253 | packets.emplace_back(std::make_unique<RtpPacketToSend>(nullptr)); |
| 254 | packets.back()->SetPadding(padding_size.bytes()); |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 255 | packets.back()->set_packet_type(RtpPacketMediaType::kPadding); |
Erik Språng | b210eeb | 2019-11-05 10:21:48 | [diff] [blame] | 256 | padding_sent_ += padding_size.bytes(); |
| 257 | target_size -= padding_size; |
| 258 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 259 | return packets; |
| 260 | } |
| 261 | |
Erik Språng | 767f504 | 2022-09-09 13:06:51 | [diff] [blame] | 262 | void OnAbortedRetransmissions(uint32_t, |
| 263 | rtc::ArrayView<const uint16_t>) override {} |
| 264 | absl::optional<uint32_t> GetRtxSsrcForMedia(uint32_t) const override { |
| 265 | return absl::nullopt; |
| 266 | } |
Markus Handell | c8c4a28 | 2023-05-08 14:46:21 | [diff] [blame] | 267 | void OnBatchComplete() override {} |
Erik Språng | 767f504 | 2022-09-09 13:06:51 | [diff] [blame] | 268 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 269 | int packets_sent() const { return packets_sent_; } |
Per K | ffdecdc | 2023-02-22 12:53:27 | [diff] [blame] | 270 | int padding_packets_sent() const { return padding_packets_sent_; } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 271 | int padding_sent() const { return padding_sent_; } |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 272 | int total_packets_sent() const { return packets_sent_ + padding_sent_; } |
| 273 | PacedPacketInfo last_pacing_info() const { return last_pacing_info_; } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 274 | |
| 275 | private: |
Per K | ffdecdc | 2023-02-22 12:53:27 | [diff] [blame] | 276 | bool can_generate_padding_ = true; |
| 277 | int packets_sent_ = 0; |
| 278 | int padding_packets_sent_ = 0; |
| 279 | int padding_sent_ = 0; |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 280 | PacedPacketInfo last_pacing_info_; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 281 | }; |
| 282 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 283 | class PacingControllerTest : public ::testing::Test { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 284 | protected: |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 285 | PacingControllerTest() : clock_(123456), trials_("") {} |
Erik Språng | 9acc18d | 2020-04-16 17:41:07 | [diff] [blame] | 286 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 287 | void SendAndExpectPacket(PacingController* pacer, |
| 288 | RtpPacketMediaType type, |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 289 | uint32_t ssrc, |
| 290 | uint16_t sequence_number, |
| 291 | int64_t capture_time_ms, |
| 292 | size_t size) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 293 | pacer->EnqueuePacket( |
| 294 | BuildPacket(type, ssrc, sequence_number, capture_time_ms, size)); |
| 295 | |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 296 | EXPECT_CALL(callback_, |
| 297 | SendPacket(ssrc, sequence_number, capture_time_ms, |
Erik Språng | 41bbc3d | 2021-10-05 08:17:39 | [diff] [blame] | 298 | type == RtpPacketMediaType::kRetransmission, false)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 299 | } |
| 300 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 301 | void AdvanceTimeUntil(webrtc::Timestamp time) { |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 302 | Timestamp now = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 303 | clock_.AdvanceTime(std::max(TimeDelta::Zero(), time - now)); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 304 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 305 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 306 | void ConsumeInitialBudget(PacingController* pacer) { |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 307 | const uint32_t kSsrc = 54321; |
| 308 | uint16_t sequence_number = 1234; |
| 309 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
| 310 | const size_t kPacketSize = 250; |
| 311 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 312 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 313 | |
| 314 | // Due to the multiplicative factor we can send 5 packets during a send |
| 315 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 316 | // (packet size * #send intervals per second) |
| 317 | const size_t packets_to_send_per_interval = |
| 318 | kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200); |
| 319 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 320 | SendAndExpectPacket(pacer, RtpPacketMediaType::kVideo, kSsrc, |
| 321 | sequence_number++, capture_time_ms, kPacketSize); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 322 | } |
| 323 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 324 | while (pacer->QueueSizePackets() > 0) { |
| 325 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 326 | pacer->ProcessPackets(); |
| 327 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 328 | } |
| 329 | |
| 330 | SimulatedClock clock_; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 331 | |
| 332 | MediaStream audio_ = MediaStream(clock_, |
| 333 | /*type*/ RtpPacketMediaType::kAudio, |
| 334 | /*ssrc*/ kAudioSsrc, |
| 335 | /*packet_size*/ 100); |
| 336 | MediaStream video_ = MediaStream(clock_, |
| 337 | /*type*/ RtpPacketMediaType::kVideo, |
| 338 | /*ssrc*/ kVideoSsrc, |
| 339 | /*packet_size*/ 1000); |
| 340 | |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 341 | ::testing::NiceMock<MockPacingControllerCallback> callback_; |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 342 | ExplicitKeyValueConfig trials_; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 343 | }; |
| 344 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 345 | TEST_F(PacingControllerTest, DefaultNoPaddingInSilence) { |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 346 | const test::ExplicitKeyValueConfig trials(""); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 347 | PacingController pacer(&clock_, &callback_, trials); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 348 | pacer.SetPacingRates(kTargetRate, DataRate::Zero()); |
| 349 | // Video packet to reset last send time and provide padding data. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 350 | pacer.EnqueuePacket(video_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 351 | EXPECT_CALL(callback_, SendPacket).Times(1); |
| 352 | clock_.AdvanceTimeMilliseconds(5); |
| 353 | pacer.ProcessPackets(); |
| 354 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 355 | // Waiting 500 ms should not trigger sending of padding. |
| 356 | clock_.AdvanceTimeMilliseconds(500); |
| 357 | pacer.ProcessPackets(); |
| 358 | } |
| 359 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 360 | TEST_F(PacingControllerTest, PaddingInSilenceWithTrial) { |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 361 | const test::ExplicitKeyValueConfig trials( |
| 362 | "WebRTC-Pacer-PadInSilence/Enabled/"); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 363 | PacingController pacer(&clock_, &callback_, trials); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 364 | pacer.SetPacingRates(kTargetRate, DataRate::Zero()); |
| 365 | // Video packet to reset last send time and provide padding data. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 366 | pacer.EnqueuePacket(video_.BuildNextPacket()); |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 367 | EXPECT_CALL(callback_, SendPacket).Times(2); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 368 | clock_.AdvanceTimeMilliseconds(5); |
| 369 | pacer.ProcessPackets(); |
| 370 | EXPECT_CALL(callback_, SendPadding).WillOnce(Return(1000)); |
| 371 | // Waiting 500 ms should trigger sending of padding. |
| 372 | clock_.AdvanceTimeMilliseconds(500); |
| 373 | pacer.ProcessPackets(); |
| 374 | } |
| 375 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 376 | TEST_F(PacingControllerTest, CongestionWindowAffectsAudioInTrial) { |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 377 | const test::ExplicitKeyValueConfig trials("WebRTC-Pacer-BlockAudio/Enabled/"); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 378 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 379 | PacingController pacer(&clock_, &callback_, trials); |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 380 | pacer.SetPacingRates(DataRate::KilobitsPerSec(10000), DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 381 | // Video packet fills congestion window. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 382 | pacer.EnqueuePacket(video_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 383 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 384 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 385 | pacer.ProcessPackets(); |
Erik Språng | 6673437 | 2022-03-16 13:20:49 | [diff] [blame] | 386 | pacer.SetCongested(true); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 387 | // Audio packet blocked due to congestion. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 388 | pacer.EnqueuePacket(audio_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 389 | EXPECT_CALL(callback_, SendPacket).Times(0); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 390 | // Forward time to where we send keep-alive. |
| 391 | EXPECT_CALL(callback_, SendPadding(1)).Times(2); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 392 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 393 | pacer.ProcessPackets(); |
| 394 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 395 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 396 | // Audio packet unblocked when congestion window clear. |
| 397 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
Erik Språng | 6673437 | 2022-03-16 13:20:49 | [diff] [blame] | 398 | pacer.SetCongested(false); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 399 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 400 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 401 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 402 | } |
| 403 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 404 | TEST_F(PacingControllerTest, DefaultCongestionWindowDoesNotAffectAudio) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 405 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 406 | const test::ExplicitKeyValueConfig trials(""); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 407 | PacingController pacer(&clock_, &callback_, trials); |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 408 | pacer.SetPacingRates(DataRate::BitsPerSec(10000000), DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 409 | // Video packet fills congestion window. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 410 | pacer.EnqueuePacket(video_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 411 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 412 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 413 | pacer.ProcessPackets(); |
Erik Språng | 6673437 | 2022-03-16 13:20:49 | [diff] [blame] | 414 | pacer.SetCongested(true); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 415 | // Audio not blocked due to congestion. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 416 | pacer.EnqueuePacket(audio_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 417 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 418 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 419 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 420 | } |
| 421 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 422 | TEST_F(PacingControllerTest, BudgetAffectsAudioInTrial) { |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 423 | ExplicitKeyValueConfig trials("WebRTC-Pacer-BlockAudio/Enabled/"); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 424 | PacingController pacer(&clock_, &callback_, trials); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 425 | const size_t kPacketSize = 1000; |
| 426 | const int kProcessIntervalsPerSecond = 1000 / 5; |
| 427 | DataRate pacing_rate = |
| 428 | DataRate::BitsPerSec(kPacketSize / 3 * 8 * kProcessIntervalsPerSecond); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 429 | pacer.SetPacingRates(pacing_rate, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 430 | // Video fills budget for following process periods. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 431 | pacer.EnqueuePacket(video_.BuildNextPacket(kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 432 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 433 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 434 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 435 | // Audio packet blocked due to budget limit. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 436 | pacer.EnqueuePacket(audio_.BuildNextPacket()); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 437 | Timestamp wait_start_time = clock_.CurrentTime(); |
| 438 | Timestamp wait_end_time = Timestamp::MinusInfinity(); |
Erik Språng | 1a08096 | 2022-03-17 14:16:59 | [diff] [blame] | 439 | EXPECT_CALL(callback_, SendPacket).WillOnce(WithoutArgs([&]() { |
| 440 | wait_end_time = clock_.CurrentTime(); |
| 441 | })); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 442 | while (!wait_end_time.IsFinite()) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 443 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 444 | pacer.ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 445 | } |
| 446 | const TimeDelta expected_wait_time = |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 447 | DataSize::Bytes(kPacketSize) / pacing_rate; |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 448 | // Verify delay is near expectation, within timing margin. |
| 449 | EXPECT_LT(((wait_end_time - wait_start_time) - expected_wait_time).Abs(), |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 450 | PacingController::kMinSleepTime); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 451 | } |
| 452 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 453 | TEST_F(PacingControllerTest, DefaultBudgetDoesNotAffectAudio) { |
| 454 | const size_t kPacketSize = 1000; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 455 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 456 | const test::ExplicitKeyValueConfig trials(""); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 457 | PacingController pacer(&clock_, &callback_, trials); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 458 | const int kProcessIntervalsPerSecond = 1000 / 5; |
| 459 | pacer.SetPacingRates( |
| 460 | DataRate::BitsPerSec(kPacketSize / 3 * 8 * kProcessIntervalsPerSecond), |
| 461 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 462 | // Video fills budget for following process periods. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 463 | pacer.EnqueuePacket(video_.BuildNextPacket(kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 464 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 465 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 466 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 467 | // Audio packet not blocked due to budget limit. |
| 468 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 469 | pacer.EnqueuePacket(audio_.BuildNextPacket()); |
| 470 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 471 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 472 | } |
| 473 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 474 | TEST_F(PacingControllerTest, FirstSentPacketTimeIsSet) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 475 | const Timestamp kStartTime = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 476 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 477 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 478 | |
| 479 | // No packet sent. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 480 | EXPECT_FALSE(pacer->FirstSentPacketTime().has_value()); |
| 481 | pacer->EnqueuePacket(video_.BuildNextPacket()); |
| 482 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 483 | pacer->ProcessPackets(); |
| 484 | EXPECT_EQ(kStartTime, pacer->FirstSentPacketTime()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 485 | } |
| 486 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 487 | TEST_F(PacingControllerTest, QueueAndPacePackets) { |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 488 | const uint32_t kSsrc = 12345; |
| 489 | uint16_t sequence_number = 1234; |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 490 | const DataSize kPackeSize = DataSize::Bytes(250); |
Danil Chapovalov | 5528402 | 2020-02-07 13:53:52 | [diff] [blame] | 491 | const TimeDelta kSendInterval = TimeDelta::Millis(5); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 492 | |
| 493 | // Due to the multiplicative factor we can send 5 packets during a 5ms send |
| 494 | // interval. (send interval * network capacity * multiplier / packet size) |
| 495 | const size_t kPacketsToSend = (kSendInterval * kTargetRate).bytes() * |
| 496 | kPaceMultiplier / kPackeSize.bytes(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 497 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 498 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 499 | |
| 500 | for (size_t i = 0; i < kPacketsToSend; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 501 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 502 | sequence_number++, clock_.TimeInMilliseconds(), |
| 503 | kPackeSize.bytes()); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 504 | } |
| 505 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 506 | |
| 507 | // Enqueue one extra packet. |
| 508 | int64_t queued_packet_timestamp = clock_.TimeInMilliseconds(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 509 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kSsrc, |
| 510 | sequence_number, queued_packet_timestamp, |
| 511 | kPackeSize.bytes())); |
| 512 | EXPECT_EQ(kPacketsToSend + 1, pacer->QueueSizePackets()); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 513 | |
| 514 | // Send packets until the initial kPacketsToSend packets are done. |
| 515 | Timestamp start_time = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 516 | while (pacer->QueueSizePackets() > 1) { |
| 517 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 518 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 519 | } |
| 520 | EXPECT_LT(clock_.CurrentTime() - start_time, kSendInterval); |
| 521 | |
| 522 | // Proceed till last packet can be sent. |
| 523 | EXPECT_CALL(callback_, SendPacket(kSsrc, sequence_number, |
| 524 | queued_packet_timestamp, false, false)) |
| 525 | .Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 526 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 527 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 528 | EXPECT_GE(clock_.CurrentTime() - start_time, kSendInterval); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 529 | EXPECT_EQ(pacer->QueueSizePackets(), 0u); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 530 | } |
| 531 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 532 | TEST_F(PacingControllerTest, PaceQueuedPackets) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 533 | uint32_t ssrc = 12345; |
| 534 | uint16_t sequence_number = 1234; |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 535 | const size_t kPacketSize = 250; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 536 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 537 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 538 | |
| 539 | // Due to the multiplicative factor we can send 5 packets during a send |
| 540 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 541 | // (packet size * #send intervals per second) |
| 542 | const size_t packets_to_send_per_interval = |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 543 | kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 544 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 545 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 546 | sequence_number++, clock_.TimeInMilliseconds(), |
| 547 | kPacketSize); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 548 | } |
| 549 | |
| 550 | for (size_t j = 0; j < packets_to_send_per_interval * 10; ++j) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 551 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 552 | sequence_number++, |
| 553 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 554 | } |
| 555 | EXPECT_EQ(packets_to_send_per_interval + packets_to_send_per_interval * 10, |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 556 | pacer->QueueSizePackets()); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 557 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 558 | while (pacer->QueueSizePackets() > packets_to_send_per_interval * 10) { |
| 559 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 560 | pacer->ProcessPackets(); |
| 561 | } |
| 562 | EXPECT_EQ(pacer->QueueSizePackets(), packets_to_send_per_interval * 10); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 563 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 564 | |
| 565 | EXPECT_CALL(callback_, SendPacket(ssrc, _, _, false, false)) |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 566 | .Times(pacer->QueueSizePackets()); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 567 | const TimeDelta expected_pace_time = |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 568 | DataSize::Bytes(pacer->QueueSizePackets() * kPacketSize) / |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 569 | (kPaceMultiplier * kTargetRate); |
| 570 | Timestamp start_time = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 571 | while (pacer->QueueSizePackets() > 0) { |
| 572 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 573 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 574 | } |
| 575 | const TimeDelta actual_pace_time = clock_.CurrentTime() - start_time; |
Danil Chapovalov | 5528402 | 2020-02-07 13:53:52 | [diff] [blame] | 576 | EXPECT_LT((actual_pace_time - expected_pace_time).Abs(), |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 577 | PacingController::kMinSleepTime); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 578 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 579 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
| 580 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 581 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
| 582 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 583 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 584 | // Send some more packet, just show that we can..? |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 585 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 586 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 587 | sequence_number++, clock_.TimeInMilliseconds(), 250); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 588 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 589 | EXPECT_EQ(packets_to_send_per_interval, pacer->QueueSizePackets()); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 590 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 591 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 592 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 593 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 594 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 595 | } |
| 596 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 597 | TEST_F(PacingControllerTest, RepeatedRetransmissionsAllowed) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 598 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 599 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
| 600 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 601 | // Send one packet, then two retransmissions of that packet. |
| 602 | for (size_t i = 0; i < 3; i++) { |
| 603 | constexpr uint32_t ssrc = 333; |
| 604 | constexpr uint16_t sequence_number = 444; |
| 605 | constexpr size_t bytes = 250; |
| 606 | bool is_retransmission = (i != 0); // Original followed by retransmissions. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 607 | SendAndExpectPacket(pacer.get(), |
| 608 | is_retransmission ? RtpPacketMediaType::kRetransmission |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 609 | : RtpPacketMediaType::kVideo, |
| 610 | ssrc, sequence_number, clock_.TimeInMilliseconds(), |
| 611 | bytes); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 612 | clock_.AdvanceTimeMilliseconds(5); |
| 613 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 614 | while (pacer->QueueSizePackets() > 0) { |
| 615 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 616 | pacer->ProcessPackets(); |
| 617 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 618 | } |
| 619 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 620 | TEST_F(PacingControllerTest, |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 621 | CanQueuePacketsWithSameSequenceNumberOnDifferentSsrcs) { |
| 622 | uint32_t ssrc = 12345; |
| 623 | uint16_t sequence_number = 1234; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 624 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 625 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 626 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 627 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 628 | sequence_number, clock_.TimeInMilliseconds(), 250); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 629 | |
| 630 | // Expect packet on second ssrc to be queued and sent as well. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 631 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc + 1, |
| 632 | sequence_number, clock_.TimeInMilliseconds(), 250); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 633 | |
| 634 | clock_.AdvanceTimeMilliseconds(1000); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 635 | while (pacer->QueueSizePackets() > 0) { |
| 636 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 637 | pacer->ProcessPackets(); |
| 638 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 639 | } |
| 640 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 641 | TEST_F(PacingControllerTest, Padding) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 642 | uint32_t ssrc = 12345; |
| 643 | uint16_t sequence_number = 1234; |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 644 | const size_t kPacketSize = 250; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 645 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 646 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 647 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 648 | const size_t kPacketsToSend = 20; |
| 649 | for (size_t i = 0; i < kPacketsToSend; ++i) { |
| 650 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 651 | sequence_number++, clock_.TimeInMilliseconds(), |
| 652 | kPacketSize); |
| 653 | } |
| 654 | const TimeDelta expected_pace_time = |
| 655 | DataSize::Bytes(pacer->QueueSizePackets() * kPacketSize) / |
| 656 | (kPaceMultiplier * kTargetRate); |
| 657 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 658 | // Only the media packets should be sent. |
| 659 | Timestamp start_time = clock_.CurrentTime(); |
| 660 | while (pacer->QueueSizePackets() > 0) { |
| 661 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 662 | pacer->ProcessPackets(); |
| 663 | } |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 664 | const TimeDelta actual_pace_time = clock_.CurrentTime() - start_time; |
| 665 | EXPECT_LE((actual_pace_time - expected_pace_time).Abs(), |
| 666 | PacingController::kMinSleepTime); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 667 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 668 | // Pacing media happens at 2.5x, but padding was configured with 1.0x |
| 669 | // factor. We have to wait until the padding debt is gone before we start |
| 670 | // sending padding. |
| 671 | const TimeDelta time_to_padding_debt_free = |
| 672 | (expected_pace_time * kPaceMultiplier) - actual_pace_time; |
| 673 | clock_.AdvanceTime(time_to_padding_debt_free - |
| 674 | PacingController::kMinSleepTime); |
| 675 | pacer->ProcessPackets(); |
| 676 | |
| 677 | // Send 10 padding packets. |
| 678 | const size_t kPaddingPacketsToSend = 10; |
| 679 | DataSize padding_sent = DataSize::Zero(); |
| 680 | size_t packets_sent = 0; |
| 681 | Timestamp first_send_time = Timestamp::MinusInfinity(); |
| 682 | Timestamp last_send_time = Timestamp::MinusInfinity(); |
| 683 | |
| 684 | EXPECT_CALL(callback_, SendPadding) |
| 685 | .Times(kPaddingPacketsToSend) |
| 686 | .WillRepeatedly([&](size_t target_size) { |
| 687 | ++packets_sent; |
| 688 | if (packets_sent < kPaddingPacketsToSend) { |
| 689 | // Don't count bytes of last packet, instead just |
| 690 | // use this as the time the last packet finished |
| 691 | // sending. |
| 692 | padding_sent += DataSize::Bytes(target_size); |
| 693 | } |
| 694 | if (first_send_time.IsInfinite()) { |
| 695 | first_send_time = clock_.CurrentTime(); |
| 696 | } else { |
| 697 | last_send_time = clock_.CurrentTime(); |
| 698 | } |
| 699 | return target_size; |
| 700 | }); |
| 701 | EXPECT_CALL(callback_, SendPacket(_, _, _, false, true)) |
| 702 | .Times(kPaddingPacketsToSend); |
| 703 | |
| 704 | while (packets_sent < kPaddingPacketsToSend) { |
| 705 | AdvanceTimeUntil(pacer->NextSendTime()); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 706 | pacer->ProcessPackets(); |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 707 | } |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 708 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 709 | // Verify rate of sent padding. |
| 710 | TimeDelta padding_duration = last_send_time - first_send_time; |
| 711 | DataRate padding_rate = padding_sent / padding_duration; |
| 712 | EXPECT_EQ(padding_rate, kTargetRate); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 713 | } |
| 714 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 715 | TEST_F(PacingControllerTest, NoPaddingBeforeNormalPacket) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 716 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 717 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 718 | |
| 719 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 720 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 721 | pacer->ProcessPackets(); |
| 722 | AdvanceTimeUntil(pacer->NextSendTime()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 723 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 724 | pacer->ProcessPackets(); |
| 725 | AdvanceTimeUntil(pacer->NextSendTime()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 726 | |
| 727 | uint32_t ssrc = 12345; |
| 728 | uint16_t sequence_number = 1234; |
| 729 | int64_t capture_time_ms = 56789; |
| 730 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 731 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 732 | sequence_number++, capture_time_ms, 250); |
Erik Språng | b1ccae2 | 2019-11-25 17:22:09 | [diff] [blame] | 733 | bool padding_sent = false; |
| 734 | EXPECT_CALL(callback_, SendPadding).WillOnce([&](size_t padding) { |
| 735 | padding_sent = true; |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 736 | return padding; |
| 737 | }); |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 738 | EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1); |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 739 | while (!padding_sent) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 740 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 741 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 742 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 743 | } |
| 744 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 745 | TEST_F(PacingControllerTest, VerifyAverageBitrateVaryingMediaPayload) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 746 | uint32_t ssrc = 12345; |
| 747 | uint16_t sequence_number = 1234; |
| 748 | int64_t capture_time_ms = 56789; |
Danil Chapovalov | 5528402 | 2020-02-07 13:53:52 | [diff] [blame] | 749 | const TimeDelta kAveragingWindowLength = TimeDelta::Seconds(10); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 750 | PacingControllerPadding callback; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 751 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 752 | pacer->SetProbingEnabled(false); |
| 753 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 754 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 755 | Timestamp start_time = clock_.CurrentTime(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 756 | size_t media_bytes = 0; |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 757 | while (clock_.CurrentTime() - start_time < kAveragingWindowLength) { |
| 758 | // Maybe add some new media packets corresponding to expected send rate. |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 759 | int rand_value = rand(); // NOLINT (rand_r instead of rand) |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 760 | while ( |
| 761 | media_bytes < |
| 762 | (kTargetRate * (clock_.CurrentTime() - start_time)).bytes<size_t>()) { |
| 763 | size_t media_payload = rand_value % 400 + 800; // [400, 1200] bytes. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 764 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 765 | sequence_number++, capture_time_ms, |
| 766 | media_payload)); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 767 | media_bytes += media_payload; |
| 768 | } |
| 769 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 770 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 771 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 772 | } |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 773 | |
| 774 | EXPECT_NEAR( |
| 775 | kTargetRate.bps(), |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 776 | (DataSize::Bytes(callback.total_bytes_sent()) / kAveragingWindowLength) |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 777 | .bps(), |
| 778 | (kTargetRate * 0.01 /* 1% error marging */).bps()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 779 | } |
| 780 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 781 | TEST_F(PacingControllerTest, Priority) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 782 | uint32_t ssrc_low_priority = 12345; |
| 783 | uint32_t ssrc = 12346; |
| 784 | uint16_t sequence_number = 1234; |
| 785 | int64_t capture_time_ms = 56789; |
| 786 | int64_t capture_time_ms_low_priority = 1234567; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 787 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 788 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 789 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 790 | ConsumeInitialBudget(pacer.get()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 791 | |
| 792 | // Expect normal and low priority to be queued and high to pass through. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 793 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, |
| 794 | ssrc_low_priority, sequence_number++, |
| 795 | capture_time_ms_low_priority, 250)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 796 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 797 | const size_t packets_to_send_per_interval = |
| 798 | kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 799 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 800 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, ssrc, |
| 801 | sequence_number++, capture_time_ms, 250)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 802 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 803 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kAudio, ssrc, |
| 804 | sequence_number++, capture_time_ms, 250)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 805 | |
| 806 | // Expect all high and normal priority to be sent out first. |
| 807 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 808 | EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, _, _)) |
| 809 | .Times(packets_to_send_per_interval + 1); |
| 810 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 811 | while (pacer->QueueSizePackets() > 1) { |
| 812 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 813 | pacer->ProcessPackets(); |
| 814 | } |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 815 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 816 | EXPECT_EQ(1u, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 817 | |
| 818 | EXPECT_CALL(callback_, SendPacket(ssrc_low_priority, _, |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 819 | capture_time_ms_low_priority, _, _)); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 820 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 821 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 822 | } |
| 823 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 824 | TEST_F(PacingControllerTest, RetransmissionPriority) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 825 | uint32_t ssrc = 12345; |
| 826 | uint16_t sequence_number = 1234; |
| 827 | int64_t capture_time_ms = 45678; |
| 828 | int64_t capture_time_ms_retransmission = 56789; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 829 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 830 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 831 | |
| 832 | // Due to the multiplicative factor we can send 5 packets during a send |
| 833 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 834 | // (packet size * #send intervals per second) |
| 835 | const size_t packets_to_send_per_interval = |
| 836 | kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 837 | pacer->ProcessPackets(); |
| 838 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 839 | |
| 840 | // Alternate retransmissions and normal packets. |
| 841 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 842 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 843 | sequence_number++, capture_time_ms, 250)); |
| 844 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, ssrc, |
| 845 | sequence_number++, |
| 846 | capture_time_ms_retransmission, 250)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 847 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 848 | EXPECT_EQ(2 * packets_to_send_per_interval, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 849 | |
| 850 | // Expect all retransmissions to be sent out first despite having a later |
| 851 | // capture time. |
| 852 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 853 | EXPECT_CALL(callback_, SendPacket(_, _, _, false, _)).Times(0); |
| 854 | EXPECT_CALL(callback_, |
| 855 | SendPacket(ssrc, _, capture_time_ms_retransmission, true, _)) |
| 856 | .Times(packets_to_send_per_interval); |
| 857 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 858 | while (pacer->QueueSizePackets() > packets_to_send_per_interval) { |
| 859 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 860 | pacer->ProcessPackets(); |
| 861 | } |
| 862 | EXPECT_EQ(packets_to_send_per_interval, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 863 | |
| 864 | // Expect the remaining (non-retransmission) packets to be sent. |
| 865 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 866 | EXPECT_CALL(callback_, SendPacket(_, _, _, true, _)).Times(0); |
| 867 | EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, false, _)) |
| 868 | .Times(packets_to_send_per_interval); |
| 869 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 870 | while (pacer->QueueSizePackets() > 0) { |
| 871 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 872 | pacer->ProcessPackets(); |
| 873 | } |
| 874 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 875 | } |
| 876 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 877 | TEST_F(PacingControllerTest, HighPrioDoesntAffectBudget) { |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 878 | const size_t kPacketSize = 250; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 879 | uint32_t ssrc = 12346; |
| 880 | uint16_t sequence_number = 1234; |
| 881 | int64_t capture_time_ms = 56789; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 882 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 883 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 884 | |
| 885 | // As high prio packets doesn't affect the budget, we should be able to send |
| 886 | // a high number of them at once. |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 887 | const size_t kNumAudioPackets = 25; |
| 888 | for (size_t i = 0; i < kNumAudioPackets; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 889 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, ssrc, |
| 890 | sequence_number++, capture_time_ms, kPacketSize); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 891 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 892 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 893 | // Low prio packets does affect the budget. |
| 894 | // Due to the multiplicative factor we can send 5 packets during a send |
| 895 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 896 | // (packet size * #send intervals per second) |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 897 | const size_t kPacketsToSendPerInterval = |
| 898 | kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200); |
| 899 | for (size_t i = 0; i < kPacketsToSendPerInterval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 900 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 901 | sequence_number++, clock_.TimeInMilliseconds(), |
| 902 | kPacketSize); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 903 | } |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 904 | |
| 905 | // Send all packets and measure pace time. |
| 906 | Timestamp start_time = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 907 | while (pacer->QueueSizePackets() > 0) { |
| 908 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 909 | pacer->ProcessPackets(); |
| 910 | } |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 911 | |
| 912 | // Measure pacing time. Expect only low-prio packets to affect this. |
| 913 | TimeDelta pacing_time = clock_.CurrentTime() - start_time; |
| 914 | TimeDelta expected_pacing_time = |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 915 | DataSize::Bytes(kPacketsToSendPerInterval * kPacketSize) / |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 916 | (kTargetRate * kPaceMultiplier); |
| 917 | EXPECT_NEAR(pacing_time.us<double>(), expected_pacing_time.us<double>(), |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 918 | PacingController::kMinSleepTime.us<double>()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 919 | } |
| 920 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 921 | TEST_F(PacingControllerTest, SendsOnlyPaddingWhenCongested) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 922 | uint32_t ssrc = 202020; |
| 923 | uint16_t sequence_number = 1000; |
| 924 | int kPacketSize = 250; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 925 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 926 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 927 | |
Erik Språng | 6673437 | 2022-03-16 13:20:49 | [diff] [blame] | 928 | // Send an initial packet so we have a last send time. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 929 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 930 | sequence_number++, clock_.TimeInMilliseconds(), |
| 931 | kPacketSize); |
| 932 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 933 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 934 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
Erik Språng | 6673437 | 2022-03-16 13:20:49 | [diff] [blame] | 935 | |
| 936 | // Set congested state, we should not send anything until the 500ms since |
| 937 | // last send time limit for keep-alives is triggered. |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 938 | EXPECT_CALL(callback_, SendPacket).Times(0); |
| 939 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 940 | pacer->SetCongested(true); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 941 | size_t blocked_packets = 0; |
| 942 | int64_t expected_time_until_padding = 500; |
| 943 | while (expected_time_until_padding > 5) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 944 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 945 | sequence_number++, |
| 946 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 947 | blocked_packets++; |
| 948 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 949 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 950 | expected_time_until_padding -= 5; |
| 951 | } |
Erik Språng | 6673437 | 2022-03-16 13:20:49 | [diff] [blame] | 952 | |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 953 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 954 | EXPECT_CALL(callback_, SendPadding(1)).WillOnce(Return(1)); |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 955 | EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 956 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 957 | pacer->ProcessPackets(); |
| 958 | EXPECT_EQ(blocked_packets, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 959 | } |
| 960 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 961 | TEST_F(PacingControllerTest, DoesNotAllowOveruseAfterCongestion) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 962 | uint32_t ssrc = 202020; |
| 963 | uint16_t seq_num = 1000; |
| 964 | int size = 1000; |
| 965 | auto now_ms = [this] { return clock_.TimeInMilliseconds(); }; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 966 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 967 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 968 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 969 | // The pacing rate is low enough that the budget should not allow two packets |
| 970 | // to be sent in a row. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 971 | pacer->SetPacingRates(DataRate::BitsPerSec(400 * 8 * 1000 / 5), |
| 972 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 973 | // Not yet budget limited or congested, packet is sent. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 974 | pacer->EnqueuePacket( |
| 975 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 976 | EXPECT_CALL(callback_, SendPacket).Times(1); |
| 977 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 978 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 979 | // Packet blocked due to congestion. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 980 | pacer->SetCongested(true); |
| 981 | pacer->EnqueuePacket( |
| 982 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 983 | EXPECT_CALL(callback_, SendPacket).Times(0); |
| 984 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 985 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 986 | // Packet blocked due to congestion. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 987 | pacer->EnqueuePacket( |
| 988 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 989 | EXPECT_CALL(callback_, SendPacket).Times(0); |
| 990 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 991 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 992 | // Congestion removed and budget has recovered, packet is sent. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 993 | pacer->EnqueuePacket( |
| 994 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 995 | EXPECT_CALL(callback_, SendPacket).Times(1); |
| 996 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 997 | pacer->SetCongested(false); |
| 998 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 999 | // Should be blocked due to budget limitation as congestion has be removed. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1000 | pacer->EnqueuePacket( |
| 1001 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1002 | EXPECT_CALL(callback_, SendPacket).Times(0); |
| 1003 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1004 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1005 | } |
| 1006 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1007 | TEST_F(PacingControllerTest, Pause) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1008 | uint32_t ssrc_low_priority = 12345; |
| 1009 | uint32_t ssrc = 12346; |
| 1010 | uint32_t ssrc_high_priority = 12347; |
| 1011 | uint16_t sequence_number = 1234; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1012 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1013 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1014 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1015 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1016 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1017 | ConsumeInitialBudget(pacer.get()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1018 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1019 | pacer->Pause(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1020 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1021 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
| 1022 | const size_t packets_to_send_per_interval = |
| 1023 | kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1024 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1025 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, |
| 1026 | ssrc_low_priority, sequence_number++, |
| 1027 | capture_time_ms, 250)); |
| 1028 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, ssrc, |
| 1029 | sequence_number++, capture_time_ms, 250)); |
| 1030 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kAudio, |
| 1031 | ssrc_high_priority, sequence_number++, |
| 1032 | capture_time_ms, 250)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1033 | } |
| 1034 | clock_.AdvanceTimeMilliseconds(10000); |
| 1035 | int64_t second_capture_time_ms = clock_.TimeInMilliseconds(); |
| 1036 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1037 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, |
| 1038 | ssrc_low_priority, sequence_number++, |
| 1039 | second_capture_time_ms, 250)); |
| 1040 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, ssrc, |
| 1041 | sequence_number++, second_capture_time_ms, |
| 1042 | 250)); |
| 1043 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kAudio, |
| 1044 | ssrc_high_priority, sequence_number++, |
| 1045 | second_capture_time_ms, 250)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1046 | } |
| 1047 | |
| 1048 | // Expect everything to be queued. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1049 | EXPECT_EQ(capture_time_ms, pacer->OldestPacketEnqueueTime().ms()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1050 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1051 | // Process triggers keep-alive packet. |
| 1052 | EXPECT_CALL(callback_, SendPadding).WillOnce([](size_t padding) { |
| 1053 | return padding; |
| 1054 | }); |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 1055 | EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1056 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1057 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1058 | // Verify no packets sent for the rest of the paused process interval. |
Danil Chapovalov | 5528402 | 2020-02-07 13:53:52 | [diff] [blame] | 1059 | const TimeDelta kProcessInterval = TimeDelta::Millis(5); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1060 | TimeDelta expected_time_until_send = PacingController::kPausedProcessInterval; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1061 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1062 | while (expected_time_until_send >= kProcessInterval) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1063 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1064 | clock_.AdvanceTime(kProcessInterval); |
| 1065 | expected_time_until_send -= kProcessInterval; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1066 | } |
| 1067 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1068 | // New keep-alive packet. |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1069 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1070 | EXPECT_CALL(callback_, SendPadding).WillOnce([](size_t padding) { |
| 1071 | return padding; |
| 1072 | }); |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 1073 | EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1074 | clock_.AdvanceTime(kProcessInterval); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1075 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1076 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1077 | |
| 1078 | // Expect high prio packets to come out first followed by normal |
| 1079 | // prio packets and low prio packets (all in capture order). |
| 1080 | { |
| 1081 | ::testing::InSequence sequence; |
| 1082 | EXPECT_CALL(callback_, |
| 1083 | SendPacket(ssrc_high_priority, _, capture_time_ms, _, _)) |
| 1084 | .Times(packets_to_send_per_interval); |
| 1085 | EXPECT_CALL(callback_, |
| 1086 | SendPacket(ssrc_high_priority, _, second_capture_time_ms, _, _)) |
| 1087 | .Times(packets_to_send_per_interval); |
| 1088 | |
| 1089 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 1090 | EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, _, _)) |
| 1091 | .Times(1); |
| 1092 | } |
| 1093 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 1094 | EXPECT_CALL(callback_, SendPacket(ssrc, _, second_capture_time_ms, _, _)) |
| 1095 | .Times(1); |
| 1096 | } |
| 1097 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 1098 | EXPECT_CALL(callback_, |
| 1099 | SendPacket(ssrc_low_priority, _, capture_time_ms, _, _)) |
| 1100 | .Times(1); |
| 1101 | } |
| 1102 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 1103 | EXPECT_CALL(callback_, SendPacket(ssrc_low_priority, _, |
| 1104 | second_capture_time_ms, _, _)) |
| 1105 | .Times(1); |
| 1106 | } |
| 1107 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1108 | pacer->Resume(); |
| 1109 | while (pacer->QueueSizePackets() > 0) { |
| 1110 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1111 | pacer->ProcessPackets(); |
| 1112 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1113 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1114 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1115 | } |
| 1116 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1117 | TEST_F(PacingControllerTest, InactiveFromStart) { |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1118 | // Recreate the pacer without the inital time forwarding. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1119 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1120 | pacer->SetProbingEnabled(false); |
| 1121 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1122 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1123 | // No packets sent, there should be no keep-alives sent either. |
| 1124 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 1125 | EXPECT_CALL(callback_, SendPacket).Times(0); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1126 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1127 | |
| 1128 | const Timestamp start_time = clock_.CurrentTime(); |
| 1129 | |
| 1130 | // Determine the margin need so we can advance to the last possible moment |
| 1131 | // that will not cause a process event. |
| 1132 | const TimeDelta time_margin = |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1133 | PacingController::kMinSleepTime + TimeDelta::Micros(1); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1134 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1135 | EXPECT_EQ(pacer->NextSendTime() - start_time, |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1136 | PacingController::kPausedProcessInterval); |
| 1137 | clock_.AdvanceTime(PacingController::kPausedProcessInterval - time_margin); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1138 | pacer->ProcessPackets(); |
| 1139 | EXPECT_EQ(pacer->NextSendTime() - start_time, |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1140 | PacingController::kPausedProcessInterval); |
| 1141 | |
| 1142 | clock_.AdvanceTime(time_margin); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1143 | pacer->ProcessPackets(); |
| 1144 | EXPECT_EQ(pacer->NextSendTime() - start_time, |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1145 | 2 * PacingController::kPausedProcessInterval); |
| 1146 | } |
| 1147 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1148 | TEST_F(PacingControllerTest, QueueTimeGrowsOverTime) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1149 | uint32_t ssrc = 12346; |
| 1150 | uint16_t sequence_number = 1234; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1151 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1152 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
| 1153 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1154 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1155 | pacer->SetPacingRates(DataRate::BitsPerSec(30000 * kPaceMultiplier), |
| 1156 | DataRate::Zero()); |
| 1157 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 1158 | sequence_number, clock_.TimeInMilliseconds(), 1200); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1159 | |
| 1160 | clock_.AdvanceTimeMilliseconds(500); |
Jianhui Dai | 9445779 | 2021-12-07 11:34:36 | [diff] [blame] | 1161 | EXPECT_EQ(clock_.TimeInMilliseconds() - 500, |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1162 | pacer->OldestPacketEnqueueTime().ms()); |
| 1163 | pacer->ProcessPackets(); |
| 1164 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1165 | } |
| 1166 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1167 | TEST_F(PacingControllerTest, ProbingWithInsertedPackets) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1168 | const size_t kPacketSize = 1200; |
| 1169 | const int kInitialBitrateBps = 300000; |
| 1170 | uint32_t ssrc = 12346; |
| 1171 | uint16_t sequence_number = 1234; |
| 1172 | |
| 1173 | PacingControllerProbing packet_sender; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1174 | auto pacer = |
| 1175 | std::make_unique<PacingController>(&clock_, &packet_sender, trials_); |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 1176 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1177 | {.at_time = clock_.CurrentTime(), |
| 1178 | .target_data_rate = kFirstClusterRate, |
| 1179 | .target_duration = TimeDelta::Millis(15), |
| 1180 | .target_probe_count = 5, |
| 1181 | .id = 0}, |
| 1182 | {.at_time = clock_.CurrentTime(), |
| 1183 | .target_data_rate = kSecondClusterRate, |
| 1184 | .target_duration = TimeDelta::Millis(15), |
| 1185 | .target_probe_count = 5, |
| 1186 | .id = 1}}; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1187 | pacer->CreateProbeClusters(probe_clusters); |
| 1188 | pacer->SetPacingRates( |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 1189 | DataRate::BitsPerSec(kInitialBitrateBps * kPaceMultiplier), |
| 1190 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1191 | |
| 1192 | for (int i = 0; i < 10; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1193 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1194 | sequence_number++, |
| 1195 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1196 | } |
| 1197 | |
| 1198 | int64_t start = clock_.TimeInMilliseconds(); |
| 1199 | while (packet_sender.packets_sent() < 5) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1200 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1201 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1202 | } |
| 1203 | int packets_sent = packet_sender.packets_sent(); |
| 1204 | // Validate first cluster bitrate. Note that we have to account for number |
| 1205 | // of intervals and hence (packets_sent - 1) on the first cluster. |
| 1206 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 1207 | (clock_.TimeInMilliseconds() - start), |
| 1208 | kFirstClusterRate.bps(), kProbingErrorMargin.bps()); |
Erik Språng | 279f370 | 2020-10-13 19:55:07 | [diff] [blame] | 1209 | // Probing always starts with a small padding packet. |
| 1210 | EXPECT_EQ(1, packet_sender.padding_sent()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1211 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1212 | AdvanceTimeUntil(pacer->NextSendTime()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1213 | start = clock_.TimeInMilliseconds(); |
| 1214 | while (packet_sender.packets_sent() < 10) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1215 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1216 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1217 | } |
| 1218 | packets_sent = packet_sender.packets_sent() - packets_sent; |
| 1219 | // Validate second cluster bitrate. |
| 1220 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 1221 | (clock_.TimeInMilliseconds() - start), |
| 1222 | kSecondClusterRate.bps(), kProbingErrorMargin.bps()); |
| 1223 | } |
| 1224 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1225 | TEST_F(PacingControllerTest, SkipsProbesWhenProcessIntervalTooLarge) { |
Erik Språng | b210eeb | 2019-11-05 10:21:48 | [diff] [blame] | 1226 | const size_t kPacketSize = 1200; |
| 1227 | const int kInitialBitrateBps = 300000; |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1228 | const uint32_t ssrc = 12346; |
| 1229 | const int kProbeClusterId = 3; |
Erik Språng | b210eeb | 2019-11-05 10:21:48 | [diff] [blame] | 1230 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1231 | uint16_t sequence_number = 1234; |
Erik Språng | b210eeb | 2019-11-05 10:21:48 | [diff] [blame] | 1232 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1233 | PacingControllerProbing packet_sender; |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1234 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1235 | const test::ExplicitKeyValueConfig trials( |
| 1236 | "WebRTC-Bwe-ProbingBehavior/max_probe_delay:2ms/"); |
| 1237 | auto pacer = |
| 1238 | std::make_unique<PacingController>(&clock_, &packet_sender, trials); |
| 1239 | pacer->SetPacingRates( |
| 1240 | DataRate::BitsPerSec(kInitialBitrateBps * kPaceMultiplier), |
| 1241 | DataRate::BitsPerSec(kInitialBitrateBps)); |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1242 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1243 | for (int i = 0; i < 10; ++i) { |
| 1244 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1245 | sequence_number++, |
| 1246 | clock_.TimeInMilliseconds(), kPacketSize)); |
| 1247 | } |
| 1248 | while (pacer->QueueSizePackets() > 0) { |
| 1249 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1250 | pacer->ProcessPackets(); |
| 1251 | } |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1252 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1253 | // Probe at a very high rate. |
| 1254 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1255 | {.at_time = clock_.CurrentTime(), |
| 1256 | .target_data_rate = DataRate::KilobitsPerSec(10000), // 10 Mbps, |
| 1257 | .target_duration = TimeDelta::Millis(15), |
| 1258 | .target_probe_count = 5, |
| 1259 | .id = kProbeClusterId}}; |
| 1260 | pacer->CreateProbeClusters(probe_clusters); |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 1261 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1262 | // We need one packet to start the probe. |
| 1263 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1264 | sequence_number++, |
| 1265 | clock_.TimeInMilliseconds(), kPacketSize)); |
| 1266 | const int packets_sent_before_probe = packet_sender.packets_sent(); |
| 1267 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1268 | pacer->ProcessPackets(); |
| 1269 | EXPECT_EQ(packet_sender.packets_sent(), packets_sent_before_probe + 1); |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1270 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1271 | // Figure out how long between probe packets. |
| 1272 | Timestamp start_time = clock_.CurrentTime(); |
| 1273 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1274 | TimeDelta time_between_probes = clock_.CurrentTime() - start_time; |
| 1275 | // Advance that distance again + 1ms. |
| 1276 | clock_.AdvanceTime(time_between_probes); |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1277 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1278 | // Send second probe packet. |
| 1279 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1280 | sequence_number++, |
| 1281 | clock_.TimeInMilliseconds(), kPacketSize)); |
| 1282 | pacer->ProcessPackets(); |
| 1283 | EXPECT_EQ(packet_sender.packets_sent(), packets_sent_before_probe + 2); |
| 1284 | PacedPacketInfo last_pacing_info = packet_sender.last_pacing_info(); |
| 1285 | EXPECT_EQ(last_pacing_info.probe_cluster_id, kProbeClusterId); |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1286 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1287 | // We're exactly where we should be for the next probe. |
| 1288 | const Timestamp probe_time = clock_.CurrentTime(); |
| 1289 | EXPECT_EQ(pacer->NextSendTime(), clock_.CurrentTime()); |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1290 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1291 | BitrateProberConfig probing_config(&trials); |
| 1292 | EXPECT_GT(probing_config.max_probe_delay.Get(), TimeDelta::Zero()); |
| 1293 | // Advance to within max probe delay, should still return same target. |
| 1294 | clock_.AdvanceTime(probing_config.max_probe_delay.Get()); |
| 1295 | EXPECT_EQ(pacer->NextSendTime(), probe_time); |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1296 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1297 | // Too high probe delay, drop it! |
| 1298 | clock_.AdvanceTime(TimeDelta::Micros(1)); |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1299 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1300 | int packets_sent_before_timeout = packet_sender.total_packets_sent(); |
| 1301 | // Expected next process time is unchanged, but calling should not |
| 1302 | // generate new packets. |
| 1303 | EXPECT_EQ(pacer->NextSendTime(), probe_time); |
| 1304 | pacer->ProcessPackets(); |
| 1305 | EXPECT_EQ(packet_sender.total_packets_sent(), packets_sent_before_timeout); |
Erik Språng | b9d3809 | 2020-07-17 10:06:12 | [diff] [blame] | 1306 | |
Jared Siskin | c018bae | 2023-04-19 23:24:03 | [diff] [blame] | 1307 | // Next packet sent is not part of probe. |
| 1308 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1309 | pacer->ProcessPackets(); |
| 1310 | const int expected_probe_id = PacedPacketInfo::kNotAProbe; |
| 1311 | EXPECT_EQ(packet_sender.last_pacing_info().probe_cluster_id, |
| 1312 | expected_probe_id); |
Erik Språng | b210eeb | 2019-11-05 10:21:48 | [diff] [blame] | 1313 | } |
| 1314 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1315 | TEST_F(PacingControllerTest, ProbingWithPaddingSupport) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1316 | const size_t kPacketSize = 1200; |
| 1317 | const int kInitialBitrateBps = 300000; |
| 1318 | uint32_t ssrc = 12346; |
| 1319 | uint16_t sequence_number = 1234; |
| 1320 | |
| 1321 | PacingControllerProbing packet_sender; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1322 | auto pacer = |
| 1323 | std::make_unique<PacingController>(&clock_, &packet_sender, trials_); |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 1324 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1325 | {.at_time = clock_.CurrentTime(), |
| 1326 | .target_data_rate = kFirstClusterRate, |
| 1327 | .target_duration = TimeDelta::Millis(15), |
| 1328 | .target_probe_count = 5, |
| 1329 | .id = 0}}; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1330 | pacer->CreateProbeClusters(probe_clusters); |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 1331 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1332 | pacer->SetPacingRates( |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 1333 | DataRate::BitsPerSec(kInitialBitrateBps * kPaceMultiplier), |
| 1334 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1335 | |
| 1336 | for (int i = 0; i < 3; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1337 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1338 | sequence_number++, |
| 1339 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1340 | } |
| 1341 | |
| 1342 | int64_t start = clock_.TimeInMilliseconds(); |
| 1343 | int process_count = 0; |
| 1344 | while (process_count < 5) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1345 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1346 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1347 | ++process_count; |
| 1348 | } |
| 1349 | int packets_sent = packet_sender.packets_sent(); |
| 1350 | int padding_sent = packet_sender.padding_sent(); |
| 1351 | EXPECT_GT(packets_sent, 0); |
| 1352 | EXPECT_GT(padding_sent, 0); |
| 1353 | // Note that the number of intervals here for kPacketSize is |
| 1354 | // packets_sent due to padding in the same cluster. |
| 1355 | EXPECT_NEAR((packets_sent * kPacketSize * 8000 + padding_sent) / |
| 1356 | (clock_.TimeInMilliseconds() - start), |
| 1357 | kFirstClusterRate.bps(), kProbingErrorMargin.bps()); |
| 1358 | } |
| 1359 | |
Per K | ffdecdc | 2023-02-22 12:53:27 | [diff] [blame] | 1360 | TEST_F(PacingControllerTest, CanProbeWithPaddingBeforeFirstMediaPacket) { |
| 1361 | // const size_t kPacketSize = 1200; |
| 1362 | const int kInitialBitrateBps = 300000; |
| 1363 | |
| 1364 | PacingControllerProbing packet_sender; |
| 1365 | const test::ExplicitKeyValueConfig trials( |
| 1366 | "WebRTC-Bwe-ProbingBehavior/min_packet_size:0/"); |
| 1367 | auto pacer = |
| 1368 | std::make_unique<PacingController>(&clock_, &packet_sender, trials); |
| 1369 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1370 | {.at_time = clock_.CurrentTime(), |
| 1371 | .target_data_rate = kFirstClusterRate, |
| 1372 | .target_duration = TimeDelta::Millis(15), |
| 1373 | .target_probe_count = 5, |
| 1374 | .id = 0}}; |
| 1375 | pacer->CreateProbeClusters(probe_clusters); |
| 1376 | |
| 1377 | pacer->SetPacingRates( |
| 1378 | DataRate::BitsPerSec(kInitialBitrateBps * kPaceMultiplier), |
| 1379 | DataRate::Zero()); |
| 1380 | |
| 1381 | Timestamp start = clock_.CurrentTime(); |
| 1382 | Timestamp next_process = pacer->NextSendTime(); |
| 1383 | while (clock_.CurrentTime() < start + TimeDelta::Millis(100) && |
| 1384 | next_process.IsFinite()) { |
| 1385 | AdvanceTimeUntil(next_process); |
| 1386 | pacer->ProcessPackets(); |
| 1387 | next_process = pacer->NextSendTime(); |
| 1388 | } |
| 1389 | EXPECT_GT(packet_sender.padding_packets_sent(), 5); |
| 1390 | } |
| 1391 | |
| 1392 | TEST_F(PacingControllerTest, CanNotProbeWithPaddingIfGeneratePaddingFails) { |
| 1393 | // const size_t kPacketSize = 1200; |
| 1394 | const int kInitialBitrateBps = 300000; |
| 1395 | |
| 1396 | PacingControllerProbing packet_sender; |
| 1397 | packet_sender.SetCanGeneratePadding(false); |
| 1398 | const test::ExplicitKeyValueConfig trials( |
| 1399 | "WebRTC-Bwe-ProbingBehavior/min_packet_size:0/"); |
| 1400 | auto pacer = |
| 1401 | std::make_unique<PacingController>(&clock_, &packet_sender, trials); |
| 1402 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1403 | {.at_time = clock_.CurrentTime(), |
| 1404 | .target_data_rate = kFirstClusterRate, |
| 1405 | .target_duration = TimeDelta::Millis(15), |
| 1406 | .target_probe_count = 5, |
| 1407 | .id = 0}}; |
| 1408 | pacer->CreateProbeClusters(probe_clusters); |
| 1409 | |
| 1410 | pacer->SetPacingRates( |
| 1411 | DataRate::BitsPerSec(kInitialBitrateBps * kPaceMultiplier), |
| 1412 | DataRate::Zero()); |
| 1413 | |
| 1414 | Timestamp start = clock_.CurrentTime(); |
| 1415 | int process_count = 0; |
| 1416 | Timestamp next_process = pacer->NextSendTime(); |
| 1417 | while (clock_.CurrentTime() < start + TimeDelta::Millis(100) && |
| 1418 | next_process.IsFinite()) { |
| 1419 | AdvanceTimeUntil(next_process); |
| 1420 | pacer->ProcessPackets(); |
| 1421 | ++process_count; |
| 1422 | next_process = pacer->NextSendTime(); |
| 1423 | } |
| 1424 | |
| 1425 | EXPECT_LT(process_count, 10); |
| 1426 | EXPECT_EQ(packet_sender.padding_packets_sent(), 0); |
| 1427 | } |
| 1428 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1429 | TEST_F(PacingControllerTest, PaddingOveruse) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1430 | uint32_t ssrc = 12346; |
| 1431 | uint16_t sequence_number = 1234; |
| 1432 | const size_t kPacketSize = 1200; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1433 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1434 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1435 | |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1436 | // Initially no padding rate. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1437 | pacer->ProcessPackets(); |
| 1438 | pacer->SetPacingRates(DataRate::BitsPerSec(60000 * kPaceMultiplier), |
| 1439 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1440 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1441 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 1442 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1443 | kPacketSize); |
| 1444 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1445 | |
| 1446 | // Add 30kbit padding. When increasing budget, media budget will increase from |
| 1447 | // negative (overuse) while padding budget will increase from 0. |
| 1448 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1449 | pacer->SetPacingRates(DataRate::BitsPerSec(60000 * kPaceMultiplier), |
| 1450 | DataRate::BitsPerSec(30000)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1451 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1452 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 1453 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1454 | kPacketSize); |
| 1455 | EXPECT_LT(TimeDelta::Millis(5), pacer->ExpectedQueueTime()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1456 | // Don't send padding if queue is non-empty, even if padding budget > 0. |
| 1457 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1458 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1459 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1460 | } |
| 1461 | |
Markus Handell | c8c4a28 | 2023-05-08 14:46:21 | [diff] [blame] | 1462 | TEST_F(PacingControllerTest, ProvidesOnBatchCompleteToPacketSender) { |
| 1463 | MockPacketSender callback; |
| 1464 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 1465 | EXPECT_CALL(callback, OnBatchComplete); |
| 1466 | pacer->ProcessPackets(); |
| 1467 | } |
| 1468 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1469 | TEST_F(PacingControllerTest, ProbeClusterId) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1470 | MockPacketSender callback; |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1471 | uint32_t ssrc = 12346; |
| 1472 | uint16_t sequence_number = 1234; |
| 1473 | const size_t kPacketSize = 1200; |
| 1474 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1475 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 1476 | pacer->CreateProbeClusters(std::vector<ProbeClusterConfig>( |
| 1477 | {{.at_time = clock_.CurrentTime(), |
| 1478 | .target_data_rate = kFirstClusterRate, |
| 1479 | .target_duration = TimeDelta::Millis(15), |
| 1480 | .target_probe_count = 5, |
| 1481 | .id = 0}, |
| 1482 | {.at_time = clock_.CurrentTime(), |
| 1483 | .target_data_rate = kSecondClusterRate, |
| 1484 | .target_duration = TimeDelta::Millis(15), |
| 1485 | .target_probe_count = 5, |
| 1486 | .id = 1}})); |
| 1487 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
| 1488 | pacer->SetProbingEnabled(true); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1489 | for (int i = 0; i < 10; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1490 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1491 | sequence_number++, |
| 1492 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1493 | } |
| 1494 | |
| 1495 | // First probing cluster. |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 1496 | EXPECT_CALL(callback, |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 | [diff] [blame] | 1497 | SendPacket(_, Field(&PacedPacketInfo::probe_cluster_id, 0))) |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 1498 | .Times(5); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1499 | |
| 1500 | for (int i = 0; i < 5; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1501 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1502 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1503 | } |
| 1504 | |
| 1505 | // Second probing cluster. |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 1506 | EXPECT_CALL(callback, |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 | [diff] [blame] | 1507 | SendPacket(_, Field(&PacedPacketInfo::probe_cluster_id, 1))) |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 1508 | .Times(5); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1509 | |
| 1510 | for (int i = 0; i < 5; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1511 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1512 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1513 | } |
| 1514 | |
| 1515 | // Needed for the Field comparer below. |
| 1516 | const int kNotAProbe = PacedPacketInfo::kNotAProbe; |
| 1517 | // No more probing packets. |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 1518 | EXPECT_CALL(callback, GeneratePadding).WillOnce([&](DataSize padding_size) { |
| 1519 | std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets; |
| 1520 | padding_packets.emplace_back( |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 1521 | BuildPacket(RtpPacketMediaType::kPadding, ssrc, sequence_number++, |
Erik Språng | f5815fa | 2019-08-21 12:27:31 | [diff] [blame] | 1522 | clock_.TimeInMilliseconds(), padding_size.bytes())); |
| 1523 | return padding_packets; |
| 1524 | }); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1525 | bool non_probe_packet_seen = false; |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 | [diff] [blame] | 1526 | EXPECT_CALL(callback, SendPacket) |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1527 | .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet, |
| 1528 | const PacedPacketInfo& cluster_info) { |
| 1529 | EXPECT_EQ(cluster_info.probe_cluster_id, kNotAProbe); |
| 1530 | non_probe_packet_seen = true; |
| 1531 | }); |
| 1532 | while (!non_probe_packet_seen) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1533 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1534 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1535 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1536 | } |
| 1537 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1538 | TEST_F(PacingControllerTest, OwnedPacketPrioritizedOnType) { |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1539 | MockPacketSender callback; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1540 | uint32_t ssrc = 123; |
| 1541 | |
| 1542 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 1543 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1544 | |
| 1545 | // Insert a packet of each type, from low to high priority. Since priority |
| 1546 | // is weighted higher than insert order, these should come out of the pacer |
| 1547 | // in backwards order with the exception of FEC and Video. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1548 | |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 1549 | for (RtpPacketMediaType type : |
| 1550 | {RtpPacketMediaType::kPadding, |
| 1551 | RtpPacketMediaType::kForwardErrorCorrection, RtpPacketMediaType::kVideo, |
| 1552 | RtpPacketMediaType::kRetransmission, RtpPacketMediaType::kAudio}) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1553 | pacer->EnqueuePacket(BuildPacket(type, ++ssrc, /*sequence_number=*/123, |
| 1554 | clock_.TimeInMilliseconds(), |
| 1555 | /*size=*/150)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1556 | } |
| 1557 | |
| 1558 | ::testing::InSequence seq; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1559 | EXPECT_CALL(callback, |
| 1560 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1561 | RtpPacketMediaType::kAudio)), |
| 1562 | _)); |
| 1563 | EXPECT_CALL(callback, |
| 1564 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1565 | RtpPacketMediaType::kRetransmission)), |
| 1566 | _)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1567 | |
| 1568 | // FEC and video actually have the same priority, so will come out in |
| 1569 | // insertion order. |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1570 | EXPECT_CALL( |
| 1571 | callback, |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1572 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1573 | RtpPacketMediaType::kForwardErrorCorrection)), |
| 1574 | _)); |
| 1575 | EXPECT_CALL(callback, |
| 1576 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1577 | RtpPacketMediaType::kVideo)), |
| 1578 | _)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1579 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1580 | EXPECT_CALL(callback, |
| 1581 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1582 | RtpPacketMediaType::kPadding)), |
| 1583 | _)); |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1584 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1585 | while (pacer->QueueSizePackets() > 0) { |
| 1586 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1587 | pacer->ProcessPackets(); |
| 1588 | } |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 1589 | } |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1590 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1591 | TEST_F(PacingControllerTest, SmallFirstProbePacket) { |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1592 | MockPacketSender callback; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1593 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 1594 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1595 | {.at_time = clock_.CurrentTime(), |
| 1596 | .target_data_rate = kFirstClusterRate, |
| 1597 | .target_duration = TimeDelta::Millis(15), |
| 1598 | .target_probe_count = 5, |
| 1599 | .id = 0}}; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1600 | pacer->CreateProbeClusters(probe_clusters); |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 1601 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1602 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1603 | |
| 1604 | // Add high prio media. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1605 | pacer->EnqueuePacket(audio_.BuildNextPacket(234)); |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1606 | |
| 1607 | // Expect small padding packet to be requested. |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 1608 | EXPECT_CALL(callback, GeneratePadding(DataSize::Bytes(1))) |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1609 | .WillOnce([&](DataSize padding_size) { |
| 1610 | std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets; |
| 1611 | padding_packets.emplace_back( |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 1612 | BuildPacket(RtpPacketMediaType::kPadding, kAudioSsrc, 1, |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1613 | clock_.TimeInMilliseconds(), 1)); |
| 1614 | return padding_packets; |
| 1615 | }); |
| 1616 | |
| 1617 | size_t packets_sent = 0; |
| 1618 | bool media_seen = false; |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 | [diff] [blame] | 1619 | EXPECT_CALL(callback, SendPacket) |
Erik Språng | e03862b | 2022-11-29 08:44:51 | [diff] [blame] | 1620 | .Times(AnyNumber()) |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1621 | .WillRepeatedly([&](std::unique_ptr<RtpPacketToSend> packet, |
| 1622 | const PacedPacketInfo& cluster_info) { |
| 1623 | if (packets_sent == 0) { |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 1624 | EXPECT_EQ(packet->packet_type(), RtpPacketMediaType::kPadding); |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1625 | } else { |
Björn Terelius | 31d0f7c | 2020-02-06 15:35:46 | [diff] [blame] | 1626 | if (packet->packet_type() == RtpPacketMediaType::kAudio) { |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1627 | media_seen = true; |
| 1628 | } |
| 1629 | } |
| 1630 | packets_sent++; |
| 1631 | }); |
| 1632 | while (!media_seen) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1633 | pacer->ProcessPackets(); |
Erik Språng | 78c82a4 | 2019-10-03 16:46:04 | [diff] [blame] | 1634 | clock_.AdvanceTimeMilliseconds(5); |
| 1635 | } |
| 1636 | } |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1637 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1638 | TEST_F(PacingControllerTest, TaskLate) { |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1639 | // Set a low send rate to more easily test timing issues. |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 1640 | DataRate kSendRate = DataRate::KilobitsPerSec(30); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1641 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1642 | pacer->SetPacingRates(kSendRate, DataRate::Zero()); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1643 | |
| 1644 | // Add four packets of equal size and priority. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1645 | pacer->EnqueuePacket(video_.BuildNextPacket(1000)); |
| 1646 | pacer->EnqueuePacket(video_.BuildNextPacket(1000)); |
| 1647 | pacer->EnqueuePacket(video_.BuildNextPacket(1000)); |
| 1648 | pacer->EnqueuePacket(video_.BuildNextPacket(1000)); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1649 | |
| 1650 | // Process packets, only first should be sent. |
| 1651 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1652 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1653 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1654 | Timestamp next_send_time = pacer->NextSendTime(); |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1655 | // Determine time between packets (ca 62ms) |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1656 | const TimeDelta time_between_packets = next_send_time - clock_.CurrentTime(); |
| 1657 | |
| 1658 | // Simulate a late process call, executed just before we allow sending the |
| 1659 | // fourth packet. |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1660 | const TimeDelta kOffset = TimeDelta::Millis(1); |
| 1661 | clock_.AdvanceTime((time_between_packets * 3) - kOffset); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1662 | |
| 1663 | EXPECT_CALL(callback_, SendPacket).Times(2); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1664 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1665 | |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1666 | // Check that next scheduled send time is in ca 1ms. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1667 | next_send_time = pacer->NextSendTime(); |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1668 | const TimeDelta time_left = next_send_time - clock_.CurrentTime(); |
| 1669 | EXPECT_EQ(time_left.RoundTo(TimeDelta::Millis(1)), kOffset); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1670 | |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1671 | clock_.AdvanceTime(time_left); |
| 1672 | EXPECT_CALL(callback_, SendPacket); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1673 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 13:15:15 | [diff] [blame] | 1674 | } |
| 1675 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1676 | TEST_F(PacingControllerTest, NoProbingWhilePaused) { |
Erik Språng | ae10029 | 2019-12-17 16:49:49 | [diff] [blame] | 1677 | uint32_t ssrc = 12345; |
| 1678 | uint16_t sequence_number = 1234; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1679 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1680 | pacer->SetProbingEnabled(true); |
| 1681 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
| 1682 | pacer->CreateProbeClusters(std::vector<ProbeClusterConfig>( |
| 1683 | {{.at_time = clock_.CurrentTime(), |
| 1684 | .target_data_rate = kFirstClusterRate, |
| 1685 | .target_duration = TimeDelta::Millis(15), |
| 1686 | .target_probe_count = 5, |
| 1687 | .id = 0}, |
| 1688 | {.at_time = clock_.CurrentTime(), |
| 1689 | .target_data_rate = kSecondClusterRate, |
| 1690 | .target_duration = TimeDelta::Millis(15), |
| 1691 | .target_probe_count = 5, |
| 1692 | .id = 1}})); |
Erik Språng | ae10029 | 2019-12-17 16:49:49 | [diff] [blame] | 1693 | |
| 1694 | // Send at least one packet so probing can initate. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1695 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 1696 | sequence_number, clock_.TimeInMilliseconds(), 250); |
| 1697 | while (pacer->QueueSizePackets() > 0) { |
| 1698 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1699 | pacer->ProcessPackets(); |
| 1700 | } |
Erik Språng | ae10029 | 2019-12-17 16:49:49 | [diff] [blame] | 1701 | |
| 1702 | // Trigger probing. |
Per Kjellander | 88af203 | 2022-05-16 17:58:40 | [diff] [blame] | 1703 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1704 | {.at_time = clock_.CurrentTime(), |
| 1705 | .target_data_rate = DataRate::KilobitsPerSec(10000), // 10 Mbps. |
| 1706 | .target_duration = TimeDelta::Millis(15), |
| 1707 | .target_probe_count = 5, |
| 1708 | .id = 3}}; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1709 | pacer->CreateProbeClusters(probe_clusters); |
Erik Språng | ae10029 | 2019-12-17 16:49:49 | [diff] [blame] | 1710 | |
| 1711 | // Time to next send time should be small. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1712 | EXPECT_LT(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | ae10029 | 2019-12-17 16:49:49 | [diff] [blame] | 1713 | PacingController::kPausedProcessInterval); |
| 1714 | |
| 1715 | // Pause pacer, time to next send time should now be the pause process |
| 1716 | // interval. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1717 | pacer->Pause(); |
Erik Språng | ae10029 | 2019-12-17 16:49:49 | [diff] [blame] | 1718 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1719 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | ae10029 | 2019-12-17 16:49:49 | [diff] [blame] | 1720 | PacingController::kPausedProcessInterval); |
| 1721 | } |
| 1722 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1723 | TEST_F(PacingControllerTest, AudioNotPacedEvenWhenAccountedFor) { |
Erik Språng | 9cb58d5 | 2020-03-28 16:15:54 | [diff] [blame] | 1724 | const uint32_t kSsrc = 12345; |
| 1725 | uint16_t sequence_number = 1234; |
| 1726 | const size_t kPacketSize = 123; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1727 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | 9cb58d5 | 2020-03-28 16:15:54 | [diff] [blame] | 1728 | |
| 1729 | // Account for audio - so that audio packets can cause pushback on other |
| 1730 | // types such as video. Audio packet should still be immediated passed |
| 1731 | // through though ("WebRTC-Pacer-BlockAudio" needs to be enabled in order |
| 1732 | // to pace audio packets). |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1733 | pacer->SetAccountForAudioPackets(true); |
Erik Språng | 9cb58d5 | 2020-03-28 16:15:54 | [diff] [blame] | 1734 | |
| 1735 | // Set pacing rate to 1 packet/s, no padding. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1736 | pacer->SetPacingRates(DataSize::Bytes(kPacketSize) / TimeDelta::Seconds(1), |
| 1737 | DataRate::Zero()); |
Erik Språng | 9cb58d5 | 2020-03-28 16:15:54 | [diff] [blame] | 1738 | |
| 1739 | // Add and send an audio packet. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1740 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, kSsrc, |
| 1741 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1742 | kPacketSize); |
| 1743 | pacer->ProcessPackets(); |
Erik Språng | 9cb58d5 | 2020-03-28 16:15:54 | [diff] [blame] | 1744 | |
| 1745 | // Advance time, add another audio packet and process. It should be sent |
| 1746 | // immediately. |
| 1747 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1748 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, kSsrc, |
| 1749 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1750 | kPacketSize); |
| 1751 | pacer->ProcessPackets(); |
Erik Språng | 9cb58d5 | 2020-03-28 16:15:54 | [diff] [blame] | 1752 | } |
| 1753 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1754 | TEST_F(PacingControllerTest, |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1755 | PaddingResumesAfterSaturationEvenWithConcurrentAudio) { |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1756 | const uint32_t kSsrc = 12345; |
| 1757 | const DataRate kPacingDataRate = DataRate::KilobitsPerSec(125); |
| 1758 | const DataRate kPaddingDataRate = DataRate::KilobitsPerSec(100); |
| 1759 | const TimeDelta kMaxBufferInTime = TimeDelta::Millis(500); |
| 1760 | const DataSize kPacketSize = DataSize::Bytes(130); |
| 1761 | const TimeDelta kAudioPacketInterval = TimeDelta::Millis(20); |
| 1762 | |
| 1763 | // In this test, we fist send a burst of video in order to saturate the |
| 1764 | // padding debt level. |
| 1765 | // We then proceed to send audio at a bitrate that is slightly lower than |
| 1766 | // the padding rate, meaning there will be a period with audio but no |
| 1767 | // padding sent while the debt is draining, then audio and padding will |
| 1768 | // be interlieved. |
| 1769 | |
| 1770 | // Verify both with and without accounting for audio. |
| 1771 | for (bool account_for_audio : {false, true}) { |
| 1772 | uint16_t sequence_number = 1234; |
| 1773 | MockPacketSender callback; |
Erik Språng | e03862b | 2022-11-29 08:44:51 | [diff] [blame] | 1774 | EXPECT_CALL(callback, SendPacket).Times(AnyNumber()); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1775 | auto pacer = |
| 1776 | std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 1777 | pacer->SetAccountForAudioPackets(account_for_audio); |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1778 | |
| 1779 | // First, saturate the padding budget. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1780 | pacer->SetPacingRates(kPacingDataRate, kPaddingDataRate); |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1781 | |
| 1782 | const TimeDelta kPaddingSaturationTime = |
| 1783 | kMaxBufferInTime * kPaddingDataRate / |
| 1784 | (kPacingDataRate - kPaddingDataRate); |
| 1785 | const DataSize kVideoToSend = kPaddingSaturationTime * kPacingDataRate; |
| 1786 | const DataSize kVideoPacketSize = DataSize::Bytes(1200); |
| 1787 | DataSize video_sent = DataSize::Zero(); |
| 1788 | while (video_sent < kVideoToSend) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1789 | pacer->EnqueuePacket( |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1790 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc, sequence_number++, |
| 1791 | clock_.TimeInMilliseconds(), kVideoPacketSize.bytes())); |
| 1792 | video_sent += kVideoPacketSize; |
| 1793 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1794 | while (pacer->QueueSizePackets() > 0) { |
| 1795 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1796 | pacer->ProcessPackets(); |
| 1797 | } |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1798 | |
| 1799 | // Add a stream of audio packets at a rate slightly lower than the padding |
| 1800 | // rate, once the padding debt is paid off we expect padding to be |
| 1801 | // generated. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1802 | pacer->SetPacingRates(kPacingDataRate, kPaddingDataRate); |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1803 | bool padding_seen = false; |
| 1804 | EXPECT_CALL(callback, GeneratePadding).WillOnce([&](DataSize padding_size) { |
| 1805 | padding_seen = true; |
| 1806 | std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets; |
| 1807 | padding_packets.emplace_back( |
| 1808 | BuildPacket(RtpPacketMediaType::kPadding, kSsrc, sequence_number++, |
| 1809 | clock_.TimeInMilliseconds(), padding_size.bytes())); |
| 1810 | return padding_packets; |
| 1811 | }); |
| 1812 | |
| 1813 | Timestamp start_time = clock_.CurrentTime(); |
| 1814 | Timestamp last_audio_time = start_time; |
| 1815 | while (!padding_seen) { |
| 1816 | Timestamp now = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1817 | Timestamp next_send_time = pacer->NextSendTime(); |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1818 | TimeDelta sleep_time = |
| 1819 | std::min(next_send_time, last_audio_time + kAudioPacketInterval) - |
| 1820 | now; |
| 1821 | clock_.AdvanceTime(sleep_time); |
| 1822 | while (clock_.CurrentTime() >= last_audio_time + kAudioPacketInterval) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1823 | pacer->EnqueuePacket( |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1824 | BuildPacket(RtpPacketMediaType::kAudio, kSsrc, sequence_number++, |
| 1825 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
| 1826 | last_audio_time += kAudioPacketInterval; |
| 1827 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1828 | pacer->ProcessPackets(); |
Erik Språng | 0920d5d | 2020-03-30 15:14:08 | [diff] [blame] | 1829 | } |
| 1830 | |
| 1831 | // Verify how long it took to drain the padding debt. Allow 2% error margin. |
| 1832 | const DataRate kAudioDataRate = kPacketSize / kAudioPacketInterval; |
| 1833 | const TimeDelta expected_drain_time = |
| 1834 | account_for_audio ? (kMaxBufferInTime * kPaddingDataRate / |
| 1835 | (kPaddingDataRate - kAudioDataRate)) |
| 1836 | : kMaxBufferInTime; |
| 1837 | const TimeDelta actual_drain_time = clock_.CurrentTime() - start_time; |
| 1838 | EXPECT_NEAR(actual_drain_time.ms(), expected_drain_time.ms(), |
| 1839 | expected_drain_time.ms() * 0.02) |
| 1840 | << " where account_for_audio = " |
| 1841 | << (account_for_audio ? "true" : "false"); |
| 1842 | } |
| 1843 | } |
| 1844 | |
Erik Språng | df9e51a | 2022-06-10 09:42:15 | [diff] [blame] | 1845 | TEST_F(PacingControllerTest, AccountsForAudioEnqueueTime) { |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1846 | const uint32_t kSsrc = 12345; |
| 1847 | const DataRate kPacingDataRate = DataRate::KilobitsPerSec(125); |
| 1848 | const DataRate kPaddingDataRate = DataRate::Zero(); |
| 1849 | const DataSize kPacketSize = DataSize::Bytes(130); |
| 1850 | const TimeDelta kPacketPacingTime = kPacketSize / kPacingDataRate; |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1851 | uint32_t sequnce_number = 1; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1852 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1853 | // Audio not paced, but still accounted for in budget. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1854 | pacer->SetAccountForAudioPackets(true); |
| 1855 | pacer->SetPacingRates(kPacingDataRate, kPaddingDataRate); |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1856 | |
| 1857 | // Enqueue two audio packets, advance clock to where one packet |
| 1858 | // should have drained the buffer already, has they been sent |
| 1859 | // immediately. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1860 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, kSsrc, |
| 1861 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1862 | kPacketSize.bytes()); |
| 1863 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, kSsrc, |
| 1864 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1865 | kPacketSize.bytes()); |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1866 | clock_.AdvanceTime(kPacketPacingTime); |
| 1867 | // Now process and make sure both packets were sent. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1868 | pacer->ProcessPackets(); |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1869 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1870 | |
| 1871 | // Add a video packet. I can't be sent until debt from audio |
| 1872 | // packets have been drained. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1873 | pacer->EnqueuePacket( |
| 1874 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc + 1, sequnce_number++, |
| 1875 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
| 1876 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), kPacketPacingTime); |
Erik Språng | b571ff4 | 2020-04-04 15:20:37 | [diff] [blame] | 1877 | } |
| 1878 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1879 | TEST_F(PacingControllerTest, NextSendTimeAccountsForPadding) { |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1880 | const uint32_t kSsrc = 12345; |
| 1881 | const DataRate kPacingDataRate = DataRate::KilobitsPerSec(125); |
| 1882 | const DataSize kPacketSize = DataSize::Bytes(130); |
| 1883 | const TimeDelta kPacketPacingTime = kPacketSize / kPacingDataRate; |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1884 | uint32_t sequnce_number = 1; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1885 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1886 | |
| 1887 | // Start with no padding. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1888 | pacer->SetPacingRates(kPacingDataRate, DataRate::Zero()); |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1889 | |
| 1890 | // Send a single packet. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1891 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 1892 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1893 | kPacketSize.bytes()); |
| 1894 | pacer->ProcessPackets(); |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1895 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1896 | |
| 1897 | // With current conditions, no need to wake until next keep-alive. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1898 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1899 | PacingController::kPausedProcessInterval); |
| 1900 | |
| 1901 | // Enqueue a new packet, that can't be sent until previous buffer has |
| 1902 | // drained. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1903 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 1904 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1905 | kPacketSize.bytes()); |
| 1906 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), kPacketPacingTime); |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1907 | clock_.AdvanceTime(kPacketPacingTime); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1908 | pacer->ProcessPackets(); |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1909 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1910 | |
| 1911 | // With current conditions, again no need to wake until next keep-alive. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1912 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1913 | PacingController::kPausedProcessInterval); |
| 1914 | |
| 1915 | // Set a non-zero padding rate. Padding also can't be sent until |
| 1916 | // previous debt has cleared. Since padding was disabled before, there |
| 1917 | // currently is no padding debt. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1918 | pacer->SetPacingRates(kPacingDataRate, kPacingDataRate / 2); |
| 1919 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), kPacketPacingTime); |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1920 | |
| 1921 | // Advance time, expect padding. |
| 1922 | EXPECT_CALL(callback_, SendPadding).WillOnce(Return(kPacketSize.bytes())); |
| 1923 | clock_.AdvanceTime(kPacketPacingTime); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1924 | pacer->ProcessPackets(); |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1925 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1926 | |
| 1927 | // Since padding rate is half of pacing rate, next time we can send |
| 1928 | // padding is double the packet pacing time. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1929 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1930 | kPacketPacingTime * 2); |
| 1931 | |
| 1932 | // Insert a packet to be sent, this take precedence again. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1933 | pacer->EnqueuePacket( |
| 1934 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc, sequnce_number++, |
| 1935 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
| 1936 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), kPacketPacingTime); |
Erik Språng | be152f5 | 2020-04-06 14:30:23 | [diff] [blame] | 1937 | } |
| 1938 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1939 | TEST_F(PacingControllerTest, PaddingTargetAccountsForPaddingRate) { |
Erik Språng | c52e627 | 2022-07-07 10:41:57 | [diff] [blame] | 1940 | // Target size for a padding packet is 5ms * padding rate. |
| 1941 | const TimeDelta kPaddingTarget = TimeDelta::Millis(5); |
Erik Språng | e486a7b | 2022-03-15 14:13:25 | [diff] [blame] | 1942 | srand(0); |
| 1943 | // Need to initialize PacingController after we initialize clock. |
Erik Språng | c52e627 | 2022-07-07 10:41:57 | [diff] [blame] | 1944 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | 9acc18d | 2020-04-16 17:41:07 | [diff] [blame] | 1945 | |
| 1946 | const uint32_t kSsrc = 12345; |
| 1947 | const DataRate kPacingDataRate = DataRate::KilobitsPerSec(125); |
| 1948 | const DataSize kPacketSize = DataSize::Bytes(130); |
| 1949 | |
| 1950 | uint32_t sequnce_number = 1; |
| 1951 | |
| 1952 | // Start with pacing and padding rate equal. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1953 | pacer->SetPacingRates(kPacingDataRate, kPacingDataRate); |
Erik Språng | 9acc18d | 2020-04-16 17:41:07 | [diff] [blame] | 1954 | |
| 1955 | // Send a single packet. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1956 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 1957 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1958 | kPacketSize.bytes()); |
| 1959 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1960 | pacer->ProcessPackets(); |
Erik Språng | 9acc18d | 2020-04-16 17:41:07 | [diff] [blame] | 1961 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1962 | |
| 1963 | size_t expected_padding_target_bytes = |
| 1964 | (kPaddingTarget * kPacingDataRate).bytes(); |
| 1965 | EXPECT_CALL(callback_, SendPadding(expected_padding_target_bytes)) |
| 1966 | .WillOnce(Return(expected_padding_target_bytes)); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1967 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1968 | pacer->ProcessPackets(); |
Erik Språng | 9acc18d | 2020-04-16 17:41:07 | [diff] [blame] | 1969 | |
| 1970 | // Half the padding rate - expect half the padding target. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1971 | pacer->SetPacingRates(kPacingDataRate, kPacingDataRate / 2); |
Erik Språng | 9acc18d | 2020-04-16 17:41:07 | [diff] [blame] | 1972 | EXPECT_CALL(callback_, SendPadding(expected_padding_target_bytes / 2)) |
| 1973 | .WillOnce(Return(expected_padding_target_bytes / 2)); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1974 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1975 | pacer->ProcessPackets(); |
Erik Språng | 9acc18d | 2020-04-16 17:41:07 | [diff] [blame] | 1976 | } |
| 1977 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 1978 | TEST_F(PacingControllerTest, SendsFecPackets) { |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 1979 | const uint32_t kSsrc = 12345; |
| 1980 | const uint32_t kFlexSsrc = 54321; |
| 1981 | uint16_t sequence_number = 1234; |
| 1982 | uint16_t flexfec_sequence_number = 4321; |
| 1983 | const size_t kPacketSize = 123; |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1984 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 1985 | |
| 1986 | // Set pacing rate to 1000 packet/s, no padding. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1987 | pacer->SetPacingRates( |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 1988 | DataSize::Bytes(1000 * kPacketSize) / TimeDelta::Seconds(1), |
| 1989 | DataRate::Zero()); |
| 1990 | |
| 1991 | int64_t now = clock_.TimeInMilliseconds(); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 1992 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kSsrc, |
| 1993 | sequence_number, now, kPacketSize)); |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 1994 | EXPECT_CALL(callback_, SendPacket(kSsrc, sequence_number, now, false, false)); |
| 1995 | EXPECT_CALL(callback_, FetchFec).WillOnce([&]() { |
| 1996 | EXPECT_CALL(callback_, SendPacket(kFlexSsrc, flexfec_sequence_number, now, |
| 1997 | false, false)); |
| 1998 | EXPECT_CALL(callback_, FetchFec); |
| 1999 | std::vector<std::unique_ptr<RtpPacketToSend>> fec_packets; |
| 2000 | fec_packets.push_back( |
| 2001 | BuildPacket(RtpPacketMediaType::kForwardErrorCorrection, kFlexSsrc, |
| 2002 | flexfec_sequence_number, now, kPacketSize)); |
| 2003 | return fec_packets; |
| 2004 | }); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2005 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 2006 | pacer->ProcessPackets(); |
| 2007 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 2008 | pacer->ProcessPackets(); |
Erik Språng | 1d50cb6 | 2020-07-02 15:41:32 | [diff] [blame] | 2009 | } |
| 2010 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 2011 | TEST_F(PacingControllerTest, GapInPacingDoesntAccumulateBudget) { |
Erik Språng | 41bbc3d | 2021-10-05 08:17:39 | [diff] [blame] | 2012 | const uint32_t kSsrc = 12345; |
| 2013 | uint16_t sequence_number = 1234; |
| 2014 | const DataSize kPackeSize = DataSize::Bytes(250); |
| 2015 | const TimeDelta kPacketSendTime = TimeDelta::Millis(15); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2016 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | 41bbc3d | 2021-10-05 08:17:39 | [diff] [blame] | 2017 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2018 | pacer->SetPacingRates(kPackeSize / kPacketSendTime, |
| 2019 | /*padding_rate=*/DataRate::Zero()); |
Erik Språng | 41bbc3d | 2021-10-05 08:17:39 | [diff] [blame] | 2020 | |
| 2021 | // Send an initial packet. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2022 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 2023 | sequence_number++, clock_.TimeInMilliseconds(), |
| 2024 | kPackeSize.bytes()); |
| 2025 | pacer->ProcessPackets(); |
Erik Språng | 41bbc3d | 2021-10-05 08:17:39 | [diff] [blame] | 2026 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 2027 | |
| 2028 | // Advance time kPacketSendTime past where the media debt should be 0. |
| 2029 | clock_.AdvanceTime(2 * kPacketSendTime); |
| 2030 | |
| 2031 | // Enqueue two new packets. Expect only one to be sent one ProcessPackets(). |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2032 | pacer->EnqueuePacket( |
| 2033 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc, sequence_number + 1, |
| 2034 | clock_.TimeInMilliseconds(), kPackeSize.bytes())); |
| 2035 | pacer->EnqueuePacket( |
| 2036 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc, sequence_number + 2, |
| 2037 | clock_.TimeInMilliseconds(), kPackeSize.bytes())); |
Erik Språng | 41bbc3d | 2021-10-05 08:17:39 | [diff] [blame] | 2038 | EXPECT_CALL(callback_, SendPacket(kSsrc, sequence_number + 1, |
| 2039 | clock_.TimeInMilliseconds(), false, false)); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2040 | pacer->ProcessPackets(); |
Erik Språng | 41bbc3d | 2021-10-05 08:17:39 | [diff] [blame] | 2041 | } |
| 2042 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 2043 | TEST_F(PacingControllerTest, HandlesSubMicrosecondSendIntervals) { |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2044 | static constexpr DataSize kPacketSize = DataSize::Bytes(1); |
| 2045 | static constexpr TimeDelta kPacketSendTime = TimeDelta::Micros(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2046 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2047 | |
| 2048 | // Set pacing rate such that a packet is sent in 0.5us. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2049 | pacer->SetPacingRates(/*pacing_rate=*/2 * kPacketSize / kPacketSendTime, |
| 2050 | /*padding_rate=*/DataRate::Zero()); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2051 | |
| 2052 | // Enqueue three packets, the first two should be sent immediately - the third |
| 2053 | // should cause a non-zero delta to the next process time. |
| 2054 | EXPECT_CALL(callback_, SendPacket).Times(2); |
| 2055 | for (int i = 0; i < 3; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2056 | pacer->EnqueuePacket(BuildPacket( |
| 2057 | RtpPacketMediaType::kVideo, /*ssrc=*/12345, /*sequence_number=*/i, |
| 2058 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2059 | } |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2060 | pacer->ProcessPackets(); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2061 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2062 | EXPECT_GT(pacer->NextSendTime(), clock_.CurrentTime()); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2063 | } |
| 2064 | |
Erik Språng | 6aa5cea | 2022-05-16 11:20:36 | [diff] [blame] | 2065 | TEST_F(PacingControllerTest, HandlesSubMicrosecondPaddingInterval) { |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2066 | static constexpr DataSize kPacketSize = DataSize::Bytes(1); |
| 2067 | static constexpr TimeDelta kPacketSendTime = TimeDelta::Micros(1); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2068 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2069 | |
| 2070 | // Set both pacing and padding rates to 1 byte per 0.5us. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2071 | pacer->SetPacingRates(/*pacing_rate=*/2 * kPacketSize / kPacketSendTime, |
| 2072 | /*padding_rate=*/2 * kPacketSize / kPacketSendTime); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2073 | |
| 2074 | // Enqueue and send one packet. |
| 2075 | EXPECT_CALL(callback_, SendPacket); |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2076 | pacer->EnqueuePacket(BuildPacket( |
| 2077 | RtpPacketMediaType::kVideo, /*ssrc=*/12345, /*sequence_number=*/1234, |
| 2078 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
| 2079 | pacer->ProcessPackets(); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2080 | |
| 2081 | // The padding debt is now 1 byte, and the pacing time for that is lower than |
| 2082 | // the precision of a TimeStamp tick. Make sure the pacer still indicates a |
| 2083 | // non-zero sleep time is needed until the next process. |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2084 | EXPECT_GT(pacer->NextSendTime(), clock_.CurrentTime()); |
Erik Språng | b844dd8 | 2022-04-22 10:18:17 | [diff] [blame] | 2085 | } |
| 2086 | |
Per Kjellander | 8d847f0 | 2022-06-01 18:21:58 | [diff] [blame] | 2087 | TEST_F(PacingControllerTest, SendsPacketsInBurstImmediately) { |
| 2088 | constexpr TimeDelta kMaxDelay = TimeDelta::Millis(20); |
| 2089 | PacingController pacer(&clock_, &callback_, trials_); |
| 2090 | pacer.SetSendBurstInterval(kMaxDelay); |
| 2091 | pacer.SetPacingRates(DataRate::BytesPerSec(10000), DataRate::Zero()); |
| 2092 | |
| 2093 | // Max allowed send burst size is 100000*20/1000) = 200byte |
| 2094 | pacer.EnqueuePacket(video_.BuildNextPacket(100)); |
| 2095 | pacer.EnqueuePacket(video_.BuildNextPacket(100)); |
| 2096 | pacer.EnqueuePacket(video_.BuildNextPacket(100)); |
| 2097 | pacer.ProcessPackets(); |
| 2098 | EXPECT_EQ(pacer.QueueSizePackets(), 1u); |
| 2099 | EXPECT_EQ(pacer.NextSendTime(), clock_.CurrentTime() + kMaxDelay); |
| 2100 | |
| 2101 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 2102 | pacer.ProcessPackets(); |
| 2103 | EXPECT_EQ(pacer.QueueSizePackets(), 0u); |
| 2104 | } |
| 2105 | |
| 2106 | TEST_F(PacingControllerTest, SendsPacketsInBurstEvenIfNotEnqueedAtSameTime) { |
| 2107 | constexpr TimeDelta kMaxDelay = TimeDelta::Millis(20); |
| 2108 | PacingController pacer(&clock_, &callback_, trials_); |
| 2109 | pacer.SetSendBurstInterval(kMaxDelay); |
| 2110 | pacer.SetPacingRates(DataRate::BytesPerSec(10000), DataRate::Zero()); |
| 2111 | pacer.EnqueuePacket(video_.BuildNextPacket(200)); |
| 2112 | EXPECT_EQ(pacer.NextSendTime(), clock_.CurrentTime()); |
| 2113 | pacer.ProcessPackets(); |
| 2114 | clock_.AdvanceTime(TimeDelta::Millis(1)); |
| 2115 | pacer.EnqueuePacket(video_.BuildNextPacket(200)); |
| 2116 | EXPECT_EQ(pacer.NextSendTime(), clock_.CurrentTime()); |
| 2117 | pacer.ProcessPackets(); |
| 2118 | EXPECT_EQ(pacer.QueueSizePackets(), 0u); |
| 2119 | } |
| 2120 | |
| 2121 | TEST_F(PacingControllerTest, RespectsTargetRateWhenSendingPacketsInBursts) { |
| 2122 | PacingController pacer(&clock_, &callback_, trials_); |
| 2123 | pacer.SetSendBurstInterval(TimeDelta::Millis(20)); |
| 2124 | pacer.SetAccountForAudioPackets(true); |
| 2125 | pacer.SetPacingRates(DataRate::KilobitsPerSec(1000), DataRate::Zero()); |
| 2126 | Timestamp start_time = clock_.CurrentTime(); |
| 2127 | // Inject 100 packets, with size 1000bytes over 100ms. |
| 2128 | // Expect only 1Mbps / (8*1000) / 10 = 12 packets to be sent. |
| 2129 | // Packets are sent in burst. Each burst is then 3 packets * 1000bytes at |
| 2130 | // 1Mbits = 24ms long. Thus, expect 4 bursts. |
| 2131 | EXPECT_CALL(callback_, SendPacket).Times(12); |
| 2132 | int number_of_bursts = 0; |
| 2133 | while (clock_.CurrentTime() < start_time + TimeDelta::Millis(100)) { |
| 2134 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2135 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2136 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2137 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2138 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2139 | if (pacer.NextSendTime() <= clock_.CurrentTime()) { |
| 2140 | pacer.ProcessPackets(); |
| 2141 | ++number_of_bursts; |
| 2142 | } |
| 2143 | clock_.AdvanceTime(TimeDelta::Millis(5)); |
| 2144 | } |
| 2145 | EXPECT_EQ(pacer.QueueSizePackets(), 88u); |
| 2146 | EXPECT_EQ(number_of_bursts, 4); |
| 2147 | } |
| 2148 | |
Erik Språng | df9e51a | 2022-06-10 09:42:15 | [diff] [blame] | 2149 | TEST_F(PacingControllerTest, RespectsQueueTimeLimit) { |
| 2150 | static constexpr DataSize kPacketSize = DataSize::Bytes(100); |
| 2151 | static constexpr DataRate kNominalPacingRate = DataRate::KilobitsPerSec(200); |
| 2152 | static constexpr TimeDelta kPacketPacingTime = |
| 2153 | kPacketSize / kNominalPacingRate; |
| 2154 | static constexpr TimeDelta kQueueTimeLimit = TimeDelta::Millis(1000); |
| 2155 | |
| 2156 | PacingController pacer(&clock_, &callback_, trials_); |
| 2157 | pacer.SetPacingRates(kNominalPacingRate, /*padding_rate=*/DataRate::Zero()); |
| 2158 | pacer.SetQueueTimeLimit(kQueueTimeLimit); |
| 2159 | |
| 2160 | // Fill pacer up to queue time limit. |
| 2161 | static constexpr int kNumPackets = kQueueTimeLimit / kPacketPacingTime; |
| 2162 | for (int i = 0; i < kNumPackets; ++i) { |
| 2163 | pacer.EnqueuePacket(video_.BuildNextPacket(kPacketSize.bytes())); |
| 2164 | } |
| 2165 | EXPECT_EQ(pacer.ExpectedQueueTime(), kQueueTimeLimit); |
| 2166 | EXPECT_EQ(pacer.pacing_rate(), kNominalPacingRate); |
| 2167 | |
| 2168 | // Double the amount of packets in the queue, the queue time limit should |
| 2169 | // effectively double the pacing rate in response. |
| 2170 | for (int i = 0; i < kNumPackets; ++i) { |
| 2171 | pacer.EnqueuePacket(video_.BuildNextPacket(kPacketSize.bytes())); |
| 2172 | } |
| 2173 | EXPECT_EQ(pacer.ExpectedQueueTime(), kQueueTimeLimit); |
| 2174 | EXPECT_EQ(pacer.pacing_rate(), 2 * kNominalPacingRate); |
| 2175 | |
| 2176 | // Send all the packets, should take as long as the queue time limit. |
| 2177 | Timestamp start_time = clock_.CurrentTime(); |
| 2178 | while (pacer.QueueSizePackets() > 0) { |
| 2179 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 2180 | pacer.ProcessPackets(); |
| 2181 | } |
| 2182 | EXPECT_EQ(clock_.CurrentTime() - start_time, kQueueTimeLimit); |
| 2183 | |
| 2184 | // We're back in a normal state - pacing rate should be back to previous |
| 2185 | // levels. |
| 2186 | EXPECT_EQ(pacer.pacing_rate(), kNominalPacingRate); |
| 2187 | } |
| 2188 | |
Erik Språng | c18a8fd | 2022-08-20 12:34:20 | [diff] [blame] | 2189 | TEST_F(PacingControllerTest, BudgetDoesNotAffectRetransmissionInsTrial) { |
| 2190 | const DataSize kPacketSize = DataSize::Bytes(1000); |
| 2191 | |
| 2192 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 2193 | const test::ExplicitKeyValueConfig trials( |
| 2194 | "WebRTC-Pacer-FastRetransmissions/Enabled/"); |
| 2195 | PacingController pacer(&clock_, &callback_, trials); |
| 2196 | pacer.SetPacingRates(kTargetRate, /*padding_rate=*/DataRate::Zero()); |
| 2197 | |
| 2198 | // Send a video packet so that we have a bit debt. |
| 2199 | pacer.EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kVideoSsrc, |
| 2200 | /*sequence_number=*/1, |
| 2201 | /*capture_time=*/1, kPacketSize.bytes())); |
| 2202 | EXPECT_CALL(callback_, SendPacket); |
| 2203 | pacer.ProcessPackets(); |
| 2204 | EXPECT_GT(pacer.NextSendTime(), clock_.CurrentTime()); |
| 2205 | |
| 2206 | // A retransmission packet should still be immediately processed. |
| 2207 | EXPECT_CALL(callback_, SendPacket); |
| 2208 | pacer.EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, |
| 2209 | kVideoSsrc, |
| 2210 | /*sequence_number=*/1, |
| 2211 | /*capture_time=*/1, kPacketSize.bytes())); |
| 2212 | pacer.ProcessPackets(); |
| 2213 | } |
| 2214 | |
Erik Språng | e158b77 | 2022-11-17 10:46:28 | [diff] [blame] | 2215 | TEST_F(PacingControllerTest, AbortsAfterReachingCircuitBreakLimit) { |
| 2216 | const DataSize kPacketSize = DataSize::Bytes(1000); |
| 2217 | |
| 2218 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 2219 | PacingController pacer(&clock_, &callback_, trials_); |
| 2220 | pacer.SetPacingRates(kTargetRate, /*padding_rate=*/DataRate::Zero()); |
| 2221 | |
| 2222 | // Set the circuit breaker to abort after one iteration of the main |
| 2223 | // sending loop. |
| 2224 | pacer.SetCircuitBreakerThreshold(1); |
| 2225 | EXPECT_CALL(callback_, SendPacket).Times(1); |
| 2226 | |
| 2227 | // Send two packets. |
| 2228 | pacer.EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kVideoSsrc, |
| 2229 | /*sequence_number=*/1, |
| 2230 | /*capture_time=*/1, kPacketSize.bytes())); |
| 2231 | pacer.EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kVideoSsrc, |
| 2232 | /*sequence_number=*/2, |
| 2233 | /*capture_time=*/2, kPacketSize.bytes())); |
| 2234 | |
| 2235 | // Advance time to way past where both should be eligible for sending. |
| 2236 | clock_.AdvanceTime(TimeDelta::Seconds(1)); |
| 2237 | |
| 2238 | pacer.ProcessPackets(); |
| 2239 | } |
| 2240 | |
Erik Språng | e03862b | 2022-11-29 08:44:51 | [diff] [blame] | 2241 | TEST_F(PacingControllerTest, DoesNotPadIfProcessThreadIsBorked) { |
| 2242 | PacingControllerPadding callback; |
| 2243 | PacingController pacer(&clock_, &callback, trials_); |
| 2244 | |
| 2245 | // Set both pacing and padding rate to be non-zero. |
| 2246 | pacer.SetPacingRates(kTargetRate, /*padding_rate=*/kTargetRate); |
| 2247 | |
| 2248 | // Add one packet to the queue, but do not send it yet. |
| 2249 | pacer.EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kVideoSsrc, |
| 2250 | /*sequence_number=*/1, |
| 2251 | /*capture_time=*/1, |
| 2252 | /*size=*/1000)); |
| 2253 | |
| 2254 | // Advance time to waaay after the packet should have been sent. |
| 2255 | clock_.AdvanceTime(TimeDelta::Seconds(42)); |
| 2256 | |
| 2257 | // `ProcessPackets()` should send the delayed packet, followed by a small |
| 2258 | // amount of missed padding. |
| 2259 | pacer.ProcessPackets(); |
| 2260 | |
| 2261 | // The max padding window is the max replay duration + the target padding |
| 2262 | // duration. |
| 2263 | const DataSize kMaxPadding = (PacingController::kMaxPaddingReplayDuration + |
| 2264 | PacingController::kTargetPaddingDuration) * |
| 2265 | kTargetRate; |
| 2266 | |
| 2267 | EXPECT_LE(callback.padding_sent(), kMaxPadding.bytes<size_t>()); |
| 2268 | } |
| 2269 | |
Erik Språng | aab1bde | 2023-04-06 13:47:07 | [diff] [blame] | 2270 | TEST_F(PacingControllerTest, FlushesPacketsOnKeyFrames) { |
| 2271 | const uint32_t kSsrc = 12345; |
| 2272 | const uint32_t kRtxSsrc = 12346; |
| 2273 | |
| 2274 | const test::ExplicitKeyValueConfig trials( |
| 2275 | "WebRTC-Pacer-KeyframeFlushing/Enabled/"); |
| 2276 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials); |
| 2277 | EXPECT_CALL(callback_, GetRtxSsrcForMedia(kSsrc)) |
| 2278 | .WillRepeatedly(Return(kRtxSsrc)); |
| 2279 | pacer->SetPacingRates(kTargetRate, DataRate::Zero()); |
| 2280 | |
| 2281 | // Enqueue a video packet and a retransmission of that video stream. |
| 2282 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kSsrc, |
| 2283 | /*sequence_number=*/1, /*capture_time=*/1, |
| 2284 | /*size_bytes=*/100)); |
| 2285 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, |
| 2286 | kRtxSsrc, |
| 2287 | /*sequence_number=*/10, /*capture_time=*/1, |
| 2288 | /*size_bytes=*/100)); |
| 2289 | EXPECT_EQ(pacer->QueueSizePackets(), 2u); |
| 2290 | |
| 2291 | // Enqueue the first packet of a keyframe for said stream. |
| 2292 | auto packet = BuildPacket(RtpPacketMediaType::kVideo, kSsrc, |
| 2293 | /*sequence_number=*/2, /*capture_time=*/2, |
| 2294 | /*size_bytes=*/1000); |
| 2295 | packet->set_is_key_frame(true); |
| 2296 | packet->set_first_packet_of_frame(true); |
| 2297 | pacer->EnqueuePacket(std::move(packet)); |
| 2298 | |
| 2299 | // Only they new keyframe packet should be left in the queue. |
| 2300 | EXPECT_EQ(pacer->QueueSizePackets(), 1u); |
| 2301 | |
| 2302 | EXPECT_CALL(callback_, SendPacket(kSsrc, /*sequence_number=*/2, |
| 2303 | /*timestamp=*/2, /*is_retrnamission=*/false, |
| 2304 | /*is_padding=*/false)); |
| 2305 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 2306 | pacer->ProcessPackets(); |
| 2307 | } |
| 2308 | |
Per Kjellander | bfd3065 | 2022-05-27 11:15:17 | [diff] [blame] | 2309 | } // namespace |
Erik Språng | d05edec | 2019-08-14 08:43:47 | [diff] [blame] | 2310 | } // namespace webrtc |