blob: cac7cd77cced1b12e98c7a603e2fd01cc5029ddf [file] [log] [blame]
Danil Chapovalov33b716f2019-01-22 17:15:371/*
2 * Copyright 2019 The WebRTC Project Authors. All rights reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10#include "api/task_queue/task_queue_test.h"
11
Danil Chapovalov8feb6fd2022-07-05 09:01:2712#include <memory>
13
14#include "absl/cleanup/cleanup.h"
Danil Chapovalov33b716f2019-01-22 17:15:3715#include "absl/strings/string_view.h"
Markus Handell82da9322022-12-16 14:50:2416#include "api/task_queue/task_queue_base.h"
Danil Chapovalov8feb6fd2022-07-05 09:01:2717#include "api/units/time_delta.h"
Danil Chapovalov33b716f2019-01-22 17:15:3718#include "rtc_base/event.h"
Danil Chapovalovf504dd32019-06-05 12:16:5919#include "rtc_base/ref_counter.h"
Steve Antonf3802842019-01-25 03:07:4020#include "rtc_base/time_utils.h"
Danil Chapovalov33b716f2019-01-22 17:15:3721
22namespace webrtc {
23namespace {
24
Markus Handell82da9322022-12-16 14:50:2425// Avoids a dependency to system_wrappers.
26void SleepFor(TimeDelta duration) {
27 rtc::ScopedAllowBaseSyncPrimitivesForTesting allow;
28 rtc::Event event;
29 event.Wait(duration);
30}
31
Danil Chapovalov33b716f2019-01-22 17:15:3732std::unique_ptr<TaskQueueBase, TaskQueueDeleter> CreateTaskQueue(
Danil Chapovalov710f3d32019-02-06 15:00:4433 const std::unique_ptr<webrtc::TaskQueueFactory>& factory,
Danil Chapovalov33b716f2019-01-22 17:15:3734 absl::string_view task_queue_name,
35 TaskQueueFactory::Priority priority = TaskQueueFactory::Priority::NORMAL) {
36 return factory->CreateTaskQueue(task_queue_name, priority);
37}
38
39TEST_P(TaskQueueTest, Construct) {
Ali Tofigh4b681942022-08-23 10:57:1640 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov710f3d32019-02-06 15:00:4441 auto queue = CreateTaskQueue(factory, "Construct");
Danil Chapovalov33b716f2019-01-22 17:15:3742 EXPECT_FALSE(queue->IsCurrent());
43}
44
45TEST_P(TaskQueueTest, PostAndCheckCurrent) {
Ali Tofigh4b681942022-08-23 10:57:1646 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov33b716f2019-01-22 17:15:3747 rtc::Event event;
Danil Chapovalov710f3d32019-02-06 15:00:4448 auto queue = CreateTaskQueue(factory, "PostAndCheckCurrent");
Danil Chapovalov33b716f2019-01-22 17:15:3749
Artem Titov0e61fdd2021-07-25 19:50:1450 // We're not running a task, so `queue` shouldn't be current.
Tommi6866dc72020-05-15 08:11:5651 // Note that because rtc::Thread also supports the TQ interface and
52 // TestMainImpl::Init wraps the main test thread (bugs.webrtc.org/9714), that
53 // means that TaskQueueBase::Current() will still return a valid value.
Danil Chapovalov33b716f2019-01-22 17:15:3754 EXPECT_FALSE(queue->IsCurrent());
Danil Chapovalov33b716f2019-01-22 17:15:3755
Danil Chapovalov8feb6fd2022-07-05 09:01:2756 queue->PostTask([&event, &queue] {
Danil Chapovalov33b716f2019-01-22 17:15:3757 EXPECT_TRUE(queue->IsCurrent());
58 event.Set();
Danil Chapovalov8feb6fd2022-07-05 09:01:2759 });
Markus Handell2cfc1af2022-08-19 08:16:4860 EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1)));
Danil Chapovalov33b716f2019-01-22 17:15:3761}
62
63TEST_P(TaskQueueTest, PostCustomTask) {
Ali Tofigh4b681942022-08-23 10:57:1664 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov33b716f2019-01-22 17:15:3765 rtc::Event ran;
Danil Chapovalov710f3d32019-02-06 15:00:4466 auto queue = CreateTaskQueue(factory, "PostCustomImplementation");
Danil Chapovalov33b716f2019-01-22 17:15:3767
Danil Chapovalov8feb6fd2022-07-05 09:01:2768 class CustomTask {
Danil Chapovalov33b716f2019-01-22 17:15:3769 public:
70 explicit CustomTask(rtc::Event* ran) : ran_(ran) {}
71
Danil Chapovalov8feb6fd2022-07-05 09:01:2772 void operator()() { ran_->Set(); }
Danil Chapovalov33b716f2019-01-22 17:15:3773
Danil Chapovalov8feb6fd2022-07-05 09:01:2774 private:
Danil Chapovalov33b716f2019-01-22 17:15:3775 rtc::Event* const ran_;
76 } my_task(&ran);
77
Danil Chapovalov8feb6fd2022-07-05 09:01:2778 queue->PostTask(my_task);
Markus Handell2cfc1af2022-08-19 08:16:4879 EXPECT_TRUE(ran.Wait(TimeDelta::Seconds(1)));
Danil Chapovalov33b716f2019-01-22 17:15:3780}
81
82TEST_P(TaskQueueTest, PostDelayedZero) {
Ali Tofigh4b681942022-08-23 10:57:1683 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov33b716f2019-01-22 17:15:3784 rtc::Event event;
Danil Chapovalov710f3d32019-02-06 15:00:4485 auto queue = CreateTaskQueue(factory, "PostDelayedZero");
Danil Chapovalov33b716f2019-01-22 17:15:3786
Danil Chapovalov8feb6fd2022-07-05 09:01:2787 queue->PostDelayedTask([&event] { event.Set(); }, TimeDelta::Zero());
Markus Handell2cfc1af2022-08-19 08:16:4888 EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1)));
Danil Chapovalov33b716f2019-01-22 17:15:3789}
90
91TEST_P(TaskQueueTest, PostFromQueue) {
Ali Tofigh4b681942022-08-23 10:57:1692 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov33b716f2019-01-22 17:15:3793 rtc::Event event;
Danil Chapovalov710f3d32019-02-06 15:00:4494 auto queue = CreateTaskQueue(factory, "PostFromQueue");
Danil Chapovalov33b716f2019-01-22 17:15:3795
Danil Chapovalov8feb6fd2022-07-05 09:01:2796 queue->PostTask(
97 [&event, &queue] { queue->PostTask([&event] { event.Set(); }); });
Markus Handell2cfc1af2022-08-19 08:16:4898 EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1)));
Danil Chapovalov33b716f2019-01-22 17:15:3799}
100
101TEST_P(TaskQueueTest, PostDelayed) {
Ali Tofigh4b681942022-08-23 10:57:16102 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov33b716f2019-01-22 17:15:37103 rtc::Event event;
Danil Chapovalov710f3d32019-02-06 15:00:44104 auto queue =
105 CreateTaskQueue(factory, "PostDelayed", TaskQueueFactory::Priority::HIGH);
Danil Chapovalov33b716f2019-01-22 17:15:37106
107 int64_t start = rtc::TimeMillis();
Danil Chapovalov8feb6fd2022-07-05 09:01:27108 queue->PostDelayedTask(
109 [&event, &queue] {
110 EXPECT_TRUE(queue->IsCurrent());
111 event.Set();
112 },
113 TimeDelta::Millis(100));
Markus Handell2cfc1af2022-08-19 08:16:48114 EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1)));
Danil Chapovalov33b716f2019-01-22 17:15:37115 int64_t end = rtc::TimeMillis();
116 // These tests are a little relaxed due to how "powerful" our test bots can
117 // be. Most recently we've seen windows bots fire the callback after 94-99ms,
118 // which is why we have a little bit of leeway backwards as well.
119 EXPECT_GE(end - start, 90u);
120 EXPECT_NEAR(end - start, 190u, 100u); // Accept 90-290.
121}
122
123TEST_P(TaskQueueTest, PostMultipleDelayed) {
Ali Tofigh4b681942022-08-23 10:57:16124 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov710f3d32019-02-06 15:00:44125 auto queue = CreateTaskQueue(factory, "PostMultipleDelayed");
Danil Chapovalov33b716f2019-01-22 17:15:37126
127 std::vector<rtc::Event> events(100);
128 for (int i = 0; i < 100; ++i) {
129 rtc::Event* event = &events[i];
Danil Chapovalov8feb6fd2022-07-05 09:01:27130 queue->PostDelayedTask(
131 [event, &queue] {
132 EXPECT_TRUE(queue->IsCurrent());
133 event->Set();
134 },
135 TimeDelta::Millis(i));
Danil Chapovalov33b716f2019-01-22 17:15:37136 }
137
138 for (rtc::Event& e : events)
Markus Handell2cfc1af2022-08-19 08:16:48139 EXPECT_TRUE(e.Wait(TimeDelta::Seconds(1)));
Danil Chapovalov33b716f2019-01-22 17:15:37140}
141
142TEST_P(TaskQueueTest, PostDelayedAfterDestruct) {
Ali Tofigh4b681942022-08-23 10:57:16143 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov33b716f2019-01-22 17:15:37144 rtc::Event run;
145 rtc::Event deleted;
Danil Chapovalov710f3d32019-02-06 15:00:44146 auto queue = CreateTaskQueue(factory, "PostDelayedAfterDestruct");
Danil Chapovalov8feb6fd2022-07-05 09:01:27147 absl::Cleanup cleanup = [&deleted] { deleted.Set(); };
148 queue->PostDelayedTask([&run, cleanup = std::move(cleanup)] { run.Set(); },
149 TimeDelta::Millis(100));
Danil Chapovalov33b716f2019-01-22 17:15:37150 // Destroy the queue.
151 queue = nullptr;
152 // Task might outlive the TaskQueue, but still should be deleted.
Markus Handell2cfc1af2022-08-19 08:16:48153 EXPECT_TRUE(deleted.Wait(TimeDelta::Seconds(1)));
154 EXPECT_FALSE(run.Wait(TimeDelta::Zero())); // and should not run.
Danil Chapovalov33b716f2019-01-22 17:15:37155}
156
Markus Handell82da9322022-12-16 14:50:24157TEST_P(TaskQueueTest, PostDelayedHighPrecisionAfterDestruct) {
158 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
159 rtc::Event run;
160 rtc::Event deleted;
161 auto queue =
162 CreateTaskQueue(factory, "PostDelayedHighPrecisionAfterDestruct");
163 absl::Cleanup cleanup = [&deleted] { deleted.Set(); };
164 queue->PostDelayedHighPrecisionTask(
165 [&run, cleanup = std::move(cleanup)] { run.Set(); },
166 TimeDelta::Millis(100));
167 // Destroy the queue.
168 queue = nullptr;
169 // Task might outlive the TaskQueue, but still should be deleted.
170 EXPECT_TRUE(deleted.Wait(TimeDelta::Seconds(1)));
171 EXPECT_FALSE(run.Wait(TimeDelta::Zero())); // and should not run.
172}
173
174TEST_P(TaskQueueTest, PostedUnexecutedClosureDestroyedOnTaskQueue) {
175 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
176 auto queue =
177 CreateTaskQueue(factory, "PostedUnexecutedClosureDestroyedOnTaskQueue");
178 TaskQueueBase* queue_ptr = queue.get();
179 queue->PostTask([] { SleepFor(TimeDelta::Millis(100)); });
Per K18aba662023-06-16 13:42:00180 // Give the task queue a chance to start executing the first lambda.
Markus Handell82da9322022-12-16 14:50:24181 SleepFor(TimeDelta::Millis(10));
Per K18aba662023-06-16 13:42:00182 rtc::Event finished;
183 // Then ensure the next lambda (which is likely not executing yet) is
184 // destroyed in the task queue context when the queue is deleted.
185 auto cleanup = absl::Cleanup([queue_ptr, &finished] {
186 EXPECT_EQ(queue_ptr, TaskQueueBase::Current());
187 finished.Set();
188 });
Markus Handell82da9322022-12-16 14:50:24189 queue->PostTask([cleanup = std::move(cleanup)] {});
190 queue = nullptr;
Per K18aba662023-06-16 13:42:00191 finished.Wait(TimeDelta::Seconds(1));
192}
193
194TEST_P(TaskQueueTest, PostedClosureDestroyedOnTaskQueue) {
195 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
196 auto queue = CreateTaskQueue(factory, "PostedClosureDestroyedOnTaskQueue");
197 TaskQueueBase* queue_ptr = queue.get();
198 rtc::Event finished;
199 auto cleanup = absl::Cleanup([queue_ptr, &finished] {
200 EXPECT_EQ(queue_ptr, TaskQueueBase::Current());
201 finished.Set();
202 });
203 // The cleanup task may or may not have had time to execute when the task
204 // queue is destroyed. Regardless, the task should be destroyed on the
205 // queue.
206 queue->PostTask([cleanup = std::move(cleanup)] {});
207 queue = nullptr;
208 finished.Wait(TimeDelta::Seconds(1));
Markus Handell82da9322022-12-16 14:50:24209}
210
211TEST_P(TaskQueueTest, PostedExecutedClosureDestroyedOnTaskQueue) {
212 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
213 auto queue =
214 CreateTaskQueue(factory, "PostedExecutedClosureDestroyedOnTaskQueue");
215 TaskQueueBase* queue_ptr = queue.get();
216 // Ensure an executed lambda is destroyed on the task queue.
217 rtc::Event finished;
218 queue->PostTask([cleanup = absl::Cleanup([queue_ptr, &finished] {
219 EXPECT_EQ(queue_ptr, TaskQueueBase::Current());
220 finished.Set();
221 })] {});
Per K18aba662023-06-16 13:42:00222 finished.Wait(TimeDelta::Seconds(1));
Markus Handell82da9322022-12-16 14:50:24223}
224
Danil Chapovalov33b716f2019-01-22 17:15:37225TEST_P(TaskQueueTest, PostAndReuse) {
Ali Tofigh4b681942022-08-23 10:57:16226 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalov33b716f2019-01-22 17:15:37227 rtc::Event event;
Danil Chapovalov710f3d32019-02-06 15:00:44228 auto post_queue = CreateTaskQueue(factory, "PostQueue");
229 auto reply_queue = CreateTaskQueue(factory, "ReplyQueue");
Danil Chapovalov33b716f2019-01-22 17:15:37230
231 int call_count = 0;
232
Danil Chapovalov8feb6fd2022-07-05 09:01:27233 class ReusedTask {
Danil Chapovalov33b716f2019-01-22 17:15:37234 public:
235 ReusedTask(int* counter, TaskQueueBase* reply_queue, rtc::Event* event)
236 : counter_(*counter), reply_queue_(reply_queue), event_(*event) {
237 EXPECT_EQ(counter_, 0);
238 }
Danil Chapovalov8feb6fd2022-07-05 09:01:27239 ReusedTask(ReusedTask&&) = default;
240 ReusedTask& operator=(ReusedTask&&) = delete;
Danil Chapovalov33b716f2019-01-22 17:15:37241
Danil Chapovalov8feb6fd2022-07-05 09:01:27242 void operator()() && {
Danil Chapovalov33b716f2019-01-22 17:15:37243 if (++counter_ == 1) {
Danil Chapovalov8feb6fd2022-07-05 09:01:27244 reply_queue_->PostTask(std::move(*this));
245 // At this point, the object is in the moved-from state.
Danil Chapovalov33b716f2019-01-22 17:15:37246 } else {
247 EXPECT_EQ(counter_, 2);
248 EXPECT_TRUE(reply_queue_->IsCurrent());
249 event_.Set();
Danil Chapovalov33b716f2019-01-22 17:15:37250 }
251 }
252
Danil Chapovalov8feb6fd2022-07-05 09:01:27253 private:
Danil Chapovalov33b716f2019-01-22 17:15:37254 int& counter_;
255 TaskQueueBase* const reply_queue_;
256 rtc::Event& event_;
257 };
258
Danil Chapovalov8feb6fd2022-07-05 09:01:27259 ReusedTask task(&call_count, reply_queue.get(), &event);
Danil Chapovalov33b716f2019-01-22 17:15:37260 post_queue->PostTask(std::move(task));
Markus Handell2cfc1af2022-08-19 08:16:48261 EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1)));
Danil Chapovalov33b716f2019-01-22 17:15:37262}
263
Danil Chapovalov33b716f2019-01-22 17:15:37264TEST_P(TaskQueueTest, PostALot) {
Artem Titov0e61fdd2021-07-25 19:50:14265 // Waits until DecrementCount called `count` times. Thread safe.
Danil Chapovalovf504dd32019-06-05 12:16:59266 class BlockingCounter {
267 public:
268 explicit BlockingCounter(int initial_count) : count_(initial_count) {}
269
270 void DecrementCount() {
Harald Alvestrand78f905e2023-11-02 14:09:26271 if (count_.DecRef() == webrtc::RefCountReleaseStatus::kDroppedLastRef) {
Danil Chapovalovf504dd32019-06-05 12:16:59272 event_.Set();
273 }
274 }
Markus Handell2cfc1af2022-08-19 08:16:48275 bool Wait(TimeDelta give_up_after) { return event_.Wait(give_up_after); }
Danil Chapovalovf504dd32019-06-05 12:16:59276
277 private:
278 webrtc_impl::RefCounter count_;
279 rtc::Event event_;
280 };
281
Ali Tofigh4b681942022-08-23 10:57:16282 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Danil Chapovalovf504dd32019-06-05 12:16:59283 static constexpr int kTaskCount = 0xffff;
284 rtc::Event posting_done;
285 BlockingCounter all_destroyed(kTaskCount);
Danil Chapovalov33b716f2019-01-22 17:15:37286
287 int tasks_executed = 0;
Danil Chapovalovf504dd32019-06-05 12:16:59288 auto task_queue = CreateTaskQueue(factory, "PostALot");
Danil Chapovalov33b716f2019-01-22 17:15:37289
Danil Chapovalov8feb6fd2022-07-05 09:01:27290 task_queue->PostTask([&] {
Danil Chapovalovf504dd32019-06-05 12:16:59291 // Post tasks from the queue to guarantee that the 1st task won't be
292 // executed before the last one is posted.
293 for (int i = 0; i < kTaskCount; ++i) {
Danil Chapovalov8feb6fd2022-07-05 09:01:27294 absl::Cleanup cleanup = [&] { all_destroyed.DecrementCount(); };
295 task_queue->PostTask([&tasks_executed, cleanup = std::move(cleanup)] {
296 ++tasks_executed;
297 });
Danil Chapovalovf504dd32019-06-05 12:16:59298 }
Danil Chapovalov33b716f2019-01-22 17:15:37299
Danil Chapovalovf504dd32019-06-05 12:16:59300 posting_done.Set();
Danil Chapovalov8feb6fd2022-07-05 09:01:27301 });
Danil Chapovalov33b716f2019-01-22 17:15:37302
Danil Chapovalovf504dd32019-06-05 12:16:59303 // Before destroying the task queue wait until all child tasks are posted.
Danil Chapovalov95e0a602019-06-11 11:49:20304 posting_done.Wait(rtc::Event::kForever);
Danil Chapovalovf504dd32019-06-05 12:16:59305 // Destroy the task queue.
306 task_queue = nullptr;
Danil Chapovalov33b716f2019-01-22 17:15:37307
Danil Chapovalovf504dd32019-06-05 12:16:59308 // Expect all tasks are destroyed eventually. In some task queue
309 // implementations that might happen on a different thread after task queue is
310 // destroyed.
Markus Handell2cfc1af2022-08-19 08:16:48311 EXPECT_TRUE(all_destroyed.Wait(TimeDelta::Minutes(1)));
Danil Chapovalovf504dd32019-06-05 12:16:59312 EXPECT_LE(tasks_executed, kTaskCount);
Danil Chapovalov33b716f2019-01-22 17:15:37313}
314
Artem Titov01f64e02019-01-31 12:31:09315// Test posting two tasks that have shared state not protected by a
316// lock. The TaskQueue should guarantee memory read-write order and
317// FIFO task execution order, so the second task should always see the
318// changes that were made by the first task.
319//
320// If the TaskQueue doesn't properly synchronize the execution of
321// tasks, there will be a data race, which is undefined behavior. The
322// EXPECT calls may randomly catch this, but to make the most of this
323// unit test, run it under TSan or some other tool that is able to
324// directly detect data races.
325TEST_P(TaskQueueTest, PostTwoWithSharedUnprotectedState) {
Ali Tofigh4b681942022-08-23 10:57:16326 std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr);
Artem Titov01f64e02019-01-31 12:31:09327 struct SharedState {
328 // First task will set this value to 1 and second will assert it.
329 int state = 0;
330 } state;
331
Danil Chapovalov710f3d32019-02-06 15:00:44332 auto queue = CreateTaskQueue(factory, "PostTwoWithSharedUnprotectedState");
Artem Titov01f64e02019-01-31 12:31:09333 rtc::Event done;
Danil Chapovalov8feb6fd2022-07-05 09:01:27334 queue->PostTask([&state, &queue, &done] {
Artem Titov01f64e02019-01-31 12:31:09335 // Post tasks from queue to guarantee, that 1st task won't be
336 // executed before the second one will be posted.
Danil Chapovalov8feb6fd2022-07-05 09:01:27337 queue->PostTask([&state] { state.state = 1; });
338 queue->PostTask([&state, &done] {
Artem Titov01f64e02019-01-31 12:31:09339 EXPECT_EQ(state.state, 1);
340 done.Set();
Danil Chapovalov8feb6fd2022-07-05 09:01:27341 });
Artem Titov01f64e02019-01-31 12:31:09342 // Check, that state changing tasks didn't start yet.
343 EXPECT_EQ(state.state, 0);
Danil Chapovalov8feb6fd2022-07-05 09:01:27344 });
Markus Handell2cfc1af2022-08-19 08:16:48345 EXPECT_TRUE(done.Wait(TimeDelta::Seconds(1)));
Artem Titov01f64e02019-01-31 12:31:09346}
347
Danil Chapovalov5ad16a52020-06-09 12:44:31348// TaskQueueTest is a set of tests for any implementation of the TaskQueueBase.
349// Tests are instantiated next to the concrete implementation(s).
350// https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#creating-value-parameterized-abstract-tests
351GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TaskQueueTest);
352
Danil Chapovalov33b716f2019-01-22 17:15:37353} // namespace
354} // namespace webrtc