blob: c267778951654eb884207e4c210033c5aa330b5d [file] [log] [blame]
henrike@webrtc.orgf0488722014-05-13 18:00:261/*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 04:47:3111#include "rtc_base/logging.h"
Yves Gerey3e707812018-11-28 15:47:4912
Artem Titov6a4a1462019-11-26 15:24:4613#if RTC_LOG_ENABLED()
14
Yves Gerey3e707812018-11-28 15:47:4915#include <string.h>
Jonas Olssona4d87372019-07-05 17:08:3316
Yves Gerey3e707812018-11-28 15:47:4917#include <algorithm>
18
Ali Tofigh6364d082022-03-14 12:32:0419#include "absl/strings/string_view.h"
Tommifef05002018-02-27 12:51:0820#include "rtc_base/arraysize.h"
21#include "rtc_base/checks.h"
22#include "rtc_base/event.h"
Tommifef05002018-02-27 12:51:0823#include "rtc_base/platform_thread.h"
Steve Anton10542f22019-01-11 17:11:0024#include "rtc_base/time_utils.h"
Evan Shrubsole7765f9e2022-04-25 09:04:1225#include "test/gmock.h"
Yves Gerey3e707812018-11-28 15:47:4926#include "test/gtest.h"
henrike@webrtc.orgf0488722014-05-13 18:00:2627
28namespace rtc {
29
Niels Möllered3f9ec2021-03-29 10:12:2930class LogSinkImpl : public LogSink {
Niels Möllerff3dd0c2018-06-20 08:27:5331 public:
Niels Möllered3f9ec2021-03-29 10:12:2932 explicit LogSinkImpl(std::string* log_data) : log_data_(log_data) {}
Tommi0eefb4d2015-05-23 07:54:0733
Yves Gerey665174f2018-06-19 13:03:0534 template <typename P>
Niels Möllered3f9ec2021-03-29 10:12:2935 explicit LogSinkImpl(P* p) {}
Tommi0eefb4d2015-05-23 07:54:0736
37 private:
38 void OnLogMessage(const std::string& message) override {
Ali Tofigh6364d082022-03-14 12:32:0439 OnLogMessage(absl::string_view(message));
40 }
41 void OnLogMessage(absl::string_view message) override {
42 log_data_->append(message.begin(), message.end());
Tommi0eefb4d2015-05-23 07:54:0743 }
Niels Möllered3f9ec2021-03-29 10:12:2944 std::string* const log_data_;
Tommi0eefb4d2015-05-23 07:54:0745};
46
Tommifef05002018-02-27 12:51:0847class LogMessageForTesting : public LogMessage {
48 public:
49 LogMessageForTesting(const char* file,
50 int line,
51 LoggingSeverity sev,
52 LogErrorContext err_ctx = ERRCTX_NONE,
53 int err = 0)
54 : LogMessage(file, line, sev, err_ctx, err) {}
55
56 const std::string& get_extra() const { return extra_; }
Paulina Hensmanf1e3cb42018-06-20 12:07:0557#if defined(WEBRTC_ANDROID)
58 const char* get_tag() const { return tag_; }
59#endif
Tommifef05002018-02-27 12:51:0860
61 // Returns the contents of the internal log stream.
62 // Note that parts of the stream won't (as is) be available until *after* the
63 // dtor of the parent class has run. So, as is, this only represents a
64 // partially built stream.
65 std::string GetPrintStream() {
66 RTC_DCHECK(!is_finished_);
67 is_finished_ = true;
68 FinishPrintStream();
Jonas Olssond8c50782018-09-07 09:21:2869 return print_stream_.Release();
Tommifef05002018-02-27 12:51:0870 }
71
72 private:
73 bool is_finished_ = false;
74};
75
henrike@webrtc.orgf0488722014-05-13 18:00:2676// Test basic logging operation. We should get the INFO log but not the VERBOSE.
77// We should restore the correct global state at the end.
78TEST(LogTest, SingleStream) {
deadbeef37f5ecf2017-02-27 22:06:4179 int sev = LogMessage::GetLogToStream(nullptr);
henrike@webrtc.orgf0488722014-05-13 18:00:2680
81 std::string str;
Niels Möllered3f9ec2021-03-29 10:12:2982 LogSinkImpl stream(&str);
henrike@webrtc.orgf0488722014-05-13 18:00:2683 LogMessage::AddLogToStream(&stream, LS_INFO);
84 EXPECT_EQ(LS_INFO, LogMessage::GetLogToStream(&stream));
85
Mirko Bonadei675513b2017-11-09 10:09:2586 RTC_LOG(LS_INFO) << "INFO";
87 RTC_LOG(LS_VERBOSE) << "VERBOSE";
henrike@webrtc.orgf0488722014-05-13 18:00:2688 EXPECT_NE(std::string::npos, str.find("INFO"));
89 EXPECT_EQ(std::string::npos, str.find("VERBOSE"));
90
Jonas Olssonf2ce37c2018-09-12 13:32:4791 int i = 1;
92 long l = 2l;
93 long long ll = 3ll;
94
95 unsigned int u = 4u;
96 unsigned long ul = 5ul;
97 unsigned long long ull = 6ull;
98
99 std::string s1 = "char*";
100 std::string s2 = "std::string";
101 std::string s3 = "absl::stringview";
Niels Möller65835be2019-02-04 18:23:58102 const char* null_string = nullptr;
Jonas Olssonf2ce37c2018-09-12 13:32:47103 void* p = reinterpret_cast<void*>(0xabcd);
104
105 // Log all suported types(except doubles/floats) as a sanity-check.
106 RTC_LOG(LS_INFO) << "|" << i << "|" << l << "|" << ll << "|" << u << "|" << ul
107 << "|" << ull << "|" << s1.c_str() << "|" << s2 << "|"
Niels Möller65835be2019-02-04 18:23:58108 << absl::string_view(s3) << "|" << p << "|" << null_string
109 << "|";
Jonas Olssonf2ce37c2018-09-12 13:32:47110
111 // Signed integers
112 EXPECT_NE(std::string::npos, str.find("|1|"));
113 EXPECT_NE(std::string::npos, str.find("|2|"));
114 EXPECT_NE(std::string::npos, str.find("|3|"));
115
116 // Unsigned integers
117 EXPECT_NE(std::string::npos, str.find("|4|"));
118 EXPECT_NE(std::string::npos, str.find("|5|"));
119 EXPECT_NE(std::string::npos, str.find("|6|"));
120
121 // Strings
122 EXPECT_NE(std::string::npos, str.find("|char*|"));
123 EXPECT_NE(std::string::npos, str.find("|std::string|"));
124 EXPECT_NE(std::string::npos, str.find("|absl::stringview|"));
125
126 // void*
127 EXPECT_NE(std::string::npos, str.find("|abcd|"));
128
Niels Möller65835be2019-02-04 18:23:58129 // null char*
130 EXPECT_NE(std::string::npos, str.find("|(null)|"));
131
henrike@webrtc.orgf0488722014-05-13 18:00:26132 LogMessage::RemoveLogToStream(&stream);
Tommi0eefb4d2015-05-23 07:54:07133 EXPECT_EQ(LS_NONE, LogMessage::GetLogToStream(&stream));
deadbeef37f5ecf2017-02-27 22:06:41134 EXPECT_EQ(sev, LogMessage::GetLogToStream(nullptr));
henrike@webrtc.orgf0488722014-05-13 18:00:26135}
136
137// Test using multiple log streams. The INFO stream should get the INFO message,
138// the VERBOSE stream should get the INFO and the VERBOSE.
139// We should restore the correct global state at the end.
140TEST(LogTest, MultipleStreams) {
deadbeef37f5ecf2017-02-27 22:06:41141 int sev = LogMessage::GetLogToStream(nullptr);
henrike@webrtc.orgf0488722014-05-13 18:00:26142
143 std::string str1, str2;
Niels Möllered3f9ec2021-03-29 10:12:29144 LogSinkImpl stream1(&str1), stream2(&str2);
henrike@webrtc.orgf0488722014-05-13 18:00:26145 LogMessage::AddLogToStream(&stream1, LS_INFO);
146 LogMessage::AddLogToStream(&stream2, LS_VERBOSE);
147 EXPECT_EQ(LS_INFO, LogMessage::GetLogToStream(&stream1));
148 EXPECT_EQ(LS_VERBOSE, LogMessage::GetLogToStream(&stream2));
149
Mirko Bonadei675513b2017-11-09 10:09:25150 RTC_LOG(LS_INFO) << "INFO";
151 RTC_LOG(LS_VERBOSE) << "VERBOSE";
henrike@webrtc.orgf0488722014-05-13 18:00:26152
153 EXPECT_NE(std::string::npos, str1.find("INFO"));
154 EXPECT_EQ(std::string::npos, str1.find("VERBOSE"));
155 EXPECT_NE(std::string::npos, str2.find("INFO"));
156 EXPECT_NE(std::string::npos, str2.find("VERBOSE"));
157
158 LogMessage::RemoveLogToStream(&stream2);
159 LogMessage::RemoveLogToStream(&stream1);
Tommi0eefb4d2015-05-23 07:54:07160 EXPECT_EQ(LS_NONE, LogMessage::GetLogToStream(&stream2));
161 EXPECT_EQ(LS_NONE, LogMessage::GetLogToStream(&stream1));
henrike@webrtc.orgf0488722014-05-13 18:00:26162
deadbeef37f5ecf2017-02-27 22:06:41163 EXPECT_EQ(sev, LogMessage::GetLogToStream(nullptr));
henrike@webrtc.orgf0488722014-05-13 18:00:26164}
165
Tommifef05002018-02-27 12:51:08166class LogThread {
henrike@webrtc.orgf0488722014-05-13 18:00:26167 public:
Markus Handellad5037b2021-05-07 13:02:36168 void Start() {
169 thread_ = PlatformThread::SpawnJoinable(
170 [] { RTC_LOG(LS_VERBOSE) << "RTC_LOG"; }, "LogThread");
171 }
henrike@webrtc.orgf0488722014-05-13 18:00:26172
173 private:
Tommifef05002018-02-27 12:51:08174 PlatformThread thread_;
henrike@webrtc.orgf0488722014-05-13 18:00:26175};
176
Tommifef05002018-02-27 12:51:08177// Ensure we don't crash when adding/removing streams while threads are going.
178// We should restore the correct global state at the end.
henrike@webrtc.orgc732a3e2014-10-09 22:08:15179TEST(LogTest, MultipleThreads) {
deadbeef37f5ecf2017-02-27 22:06:41180 int sev = LogMessage::GetLogToStream(nullptr);
henrike@webrtc.orgf0488722014-05-13 18:00:26181
182 LogThread thread1, thread2, thread3;
183 thread1.Start();
184 thread2.Start();
185 thread3.Start();
186
Niels Möllerff3dd0c2018-06-20 08:27:53187 std::string s1, s2, s3;
Niels Möllered3f9ec2021-03-29 10:12:29188 LogSinkImpl stream1(&s1), stream2(&s2), stream3(&s3);
henrike@webrtc.orgf0488722014-05-13 18:00:26189 for (int i = 0; i < 1000; ++i) {
Niels Möller25aefd32018-11-21 08:34:11190 LogMessage::AddLogToStream(&stream1, LS_WARNING);
191 LogMessage::AddLogToStream(&stream2, LS_INFO);
192 LogMessage::AddLogToStream(&stream3, LS_VERBOSE);
henrike@webrtc.orgf0488722014-05-13 18:00:26193 LogMessage::RemoveLogToStream(&stream1);
194 LogMessage::RemoveLogToStream(&stream2);
195 LogMessage::RemoveLogToStream(&stream3);
196 }
197
deadbeef37f5ecf2017-02-27 22:06:41198 EXPECT_EQ(sev, LogMessage::GetLogToStream(nullptr));
henrike@webrtc.orgf0488722014-05-13 18:00:26199}
200
henrike@webrtc.orgf0488722014-05-13 18:00:26201TEST(LogTest, WallClockStartTime) {
Peter Boström0c4e06b2015-10-07 10:23:21202 uint32_t time = LogMessage::WallClockStartTime();
henrike@webrtc.orgf0488722014-05-13 18:00:26203 // Expect the time to be in a sensible range, e.g. > 2012-01-01.
204 EXPECT_GT(time, 1325376000u);
205}
206
Tommifef05002018-02-27 12:51:08207TEST(LogTest, CheckExtraErrorField) {
208 LogMessageForTesting log_msg("some/path/myfile.cc", 100, LS_WARNING,
209 ERRCTX_ERRNO, 0xD);
Tommifef05002018-02-27 12:51:08210 log_msg.stream() << "This gets added at dtor time";
phoglundbb738732016-07-15 10:57:12211
Tommifef05002018-02-27 12:51:08212 const std::string& extra = log_msg.get_extra();
213 const size_t length_to_check = arraysize("[0x12345678]") - 1;
214 ASSERT_GE(extra.length(), length_to_check);
215 EXPECT_EQ(std::string("[0x0000000D]"), extra.substr(0, length_to_check));
216}
henrike@webrtc.orgf0488722014-05-13 18:00:26217
Tommifef05002018-02-27 12:51:08218TEST(LogTest, CheckFilePathParsed) {
219 LogMessageForTesting log_msg("some/path/myfile.cc", 100, LS_INFO);
Tommifef05002018-02-27 12:51:08220 log_msg.stream() << "<- Does this look right?";
221
222 const std::string stream = log_msg.GetPrintStream();
Paulina Hensmanf1e3cb42018-06-20 12:07:05223#if defined(WEBRTC_ANDROID)
224 const char* tag = log_msg.get_tag();
225 EXPECT_NE(nullptr, strstr(tag, "myfile.cc"));
226 EXPECT_NE(std::string::npos, stream.find("100"));
227#else
Tommifef05002018-02-27 12:51:08228 EXPECT_NE(std::string::npos, stream.find("(myfile.cc:100)"));
Paulina Hensmanf1e3cb42018-06-20 12:07:05229#endif
Tommifef05002018-02-27 12:51:08230}
231
Paulina Hensmanf1e3cb42018-06-20 12:07:05232#if defined(WEBRTC_ANDROID)
233TEST(LogTest, CheckTagAddedToStringInDefaultOnLogMessageAndroid) {
234 std::string str;
Niels Möllered3f9ec2021-03-29 10:12:29235 LogSinkImpl stream(&str);
Paulina Hensmanf1e3cb42018-06-20 12:07:05236 LogMessage::AddLogToStream(&stream, LS_INFO);
237 EXPECT_EQ(LS_INFO, LogMessage::GetLogToStream(&stream));
238
239 RTC_LOG_TAG(LS_INFO, "my_tag") << "INFO";
240 EXPECT_NE(std::string::npos, str.find("INFO"));
241 EXPECT_NE(std::string::npos, str.find("my_tag"));
242}
243#endif
244
Tommifef05002018-02-27 12:51:08245// Test the time required to write 1000 80-character logs to a string.
246TEST(LogTest, Perf) {
247 std::string str;
Niels Möllered3f9ec2021-03-29 10:12:29248 LogSinkImpl stream(&str);
Niels Möller25aefd32018-11-21 08:34:11249 LogMessage::AddLogToStream(&stream, LS_VERBOSE);
henrike@webrtc.orgf0488722014-05-13 18:00:26250
Tommifef05002018-02-27 12:51:08251 const std::string message(80, 'X');
Niels Möller25aefd32018-11-21 08:34:11252 { LogMessageForTesting sanity_check_msg(__FILE__, __LINE__, LS_VERBOSE); }
Tommifef05002018-02-27 12:51:08253
254 // We now know how many bytes the logging framework will tag onto every msg.
255 const size_t logging_overhead = str.size();
256 // Reset the stream to 0 size.
257 str.clear();
258 str.reserve(120000);
259 static const int kRepetitions = 1000;
260
Honghai Zhang82d78622016-05-06 18:29:15261 int64_t start = TimeMillis(), finish;
Tommifef05002018-02-27 12:51:08262 for (int i = 0; i < kRepetitions; ++i) {
Niels Möller25aefd32018-11-21 08:34:11263 LogMessageForTesting(__FILE__, __LINE__, LS_VERBOSE).stream() << message;
henrike@webrtc.orgf0488722014-05-13 18:00:26264 }
Honghai Zhang82d78622016-05-06 18:29:15265 finish = TimeMillis();
henrike@webrtc.orgf0488722014-05-13 18:00:26266
267 LogMessage::RemoveLogToStream(&stream);
henrike@webrtc.orgf0488722014-05-13 18:00:26268
Tommifef05002018-02-27 12:51:08269 EXPECT_EQ(str.size(), (message.size() + logging_overhead) * kRepetitions);
Jonas Olssonb2b20312020-01-14 11:11:31270 RTC_LOG(LS_INFO) << "Total log time: " << TimeDiff(finish, start)
271 << " ms "
272 " total bytes logged: "
273 << str.size();
henrike@webrtc.orgf0488722014-05-13 18:00:26274}
275
Amit Hilbuch10c5a932019-03-18 20:09:18276TEST(LogTest, EnumsAreSupported) {
277 enum class TestEnum { kValue0 = 0, kValue1 = 1 };
278 std::string str;
Niels Möllered3f9ec2021-03-29 10:12:29279 LogSinkImpl stream(&str);
Amit Hilbuch10c5a932019-03-18 20:09:18280 LogMessage::AddLogToStream(&stream, LS_INFO);
281 RTC_LOG(LS_INFO) << "[" << TestEnum::kValue0 << "]";
282 EXPECT_NE(std::string::npos, str.find("[0]"));
283 EXPECT_EQ(std::string::npos, str.find("[1]"));
284 RTC_LOG(LS_INFO) << "[" << TestEnum::kValue1 << "]";
285 EXPECT_NE(std::string::npos, str.find("[1]"));
286 LogMessage::RemoveLogToStream(&stream);
Amit Hilbuch10c5a932019-03-18 20:09:18287}
288
Tomas Gunnarssonedd7f9e2020-09-21 14:44:55289TEST(LogTest, NoopSeverityDoesNotRunStringFormatting) {
290 if (!LogMessage::IsNoop(LS_VERBOSE)) {
291 RTC_LOG(LS_WARNING) << "Skipping test since verbose logging is turned on.";
292 return;
293 }
294 bool was_called = false;
295 auto cb = [&was_called]() {
296 was_called = true;
297 return "This could be an expensive callback.";
298 };
299 RTC_LOG(LS_VERBOSE) << "This should not be logged: " << cb();
300 EXPECT_FALSE(was_called);
301}
302
Evan Shrubsole7765f9e2022-04-25 09:04:12303struct TestStruct {};
304std::string ToLogString(TestStruct foo) {
305 return "bar";
306}
307
308TEST(LogTest, ToLogStringUsedForUnknownTypes) {
309 std::string str;
310 LogSinkImpl stream(&str);
311 LogMessage::AddLogToStream(&stream, LS_INFO);
312 TestStruct t;
313 RTC_LOG(LS_INFO) << t;
314 EXPECT_THAT(str, ::testing::HasSubstr("bar"));
315 LogMessage::RemoveLogToStream(&stream);
316}
317
henrike@webrtc.orgf0488722014-05-13 18:00:26318} // namespace rtc
Tomas Gunnarssonedd7f9e2020-09-21 14:44:55319#endif // RTC_LOG_ENABLED()