blob: 7d1ed2490971385c32fb21bbf966f6e9f2bbed5d [file] [view]
<!-- go/cmark -->
<!--* freshness: {owner: 'danilchap' reviewed: '2026-06-17'} *-->
# Plan: Iterative Removal of Deprecated Symbols
This document outlines the iterative process for identifying and removing
deprecated symbols from the WebRTC codebase. The goal is to safely retire old
APIs that have zero footprint in internal and external downstream projects.
The tracking bug for this work is webrtc:42224904
## Removal Criteria
A symbol is a candidate for removal only if it meets **all** of the following:
1. **Zero Usage:** No references found in WebRTC internals or downstream
projects.
2. **Maturity:** The `[[deprecated]]` tag was added at least **3 months** ago.
3. **Batch Size:** No more than **10 symbols** are processed in a single
iteration.
______________________________________________________________________
## Phase 1: Candidate Identification (Iterative)
Perform the following steps to generate a list of exactly 10 candidates for the
current removal cycle:
1. **Discovery:** Search the entire WebRTC codebase (excluding `third_party/`)
for the `[[deprecated]]` attribute.
2. **Age Verification:** Use `git blame` on the identified lines. Discard any
symbols where the deprecation tag was added less than 3 months ago.
3. **Internal Audit:** Run `git grep <SymbolName>` in the WebRTC repository.
Discard any symbols that still have internal call-sites (these must be
migrated first). Discard the oldest symbols first.
4. **Downstream Audit (CodeSearch):** For each matured symbol, perform searches
in downstream projects, excluding the WebRTC mirror.
- **Reference Check:** Use the `usage:` filter with the fully qualified name
(including the `webrtc::` namespace) to find semantic references.
- *Example:*
`cs "usage:webrtc::PeerConnectionInterface::kPlanB -file:stable/webrtc"`
- **Override Check (Virtual Methods):** For virtual methods, use the `func:`
filter to identify if the symbol is overridden in downstream
implementations.
- *Example:* `cs "func:InsertEmptyPacket -file:stable/webrtc"`
- **Broad Audit (Verification):** Even if `usage:` returns zero results,
perform a `content:` search for the symbol name (combining with `webrtc`
and language filters to reduce noise) to verify. This avoids missing usages
due to indexer limitations.
- *Example:* `cs "content:ApplyGain webrtc -file:stable/webrtc lang:cpp"`
- *Note:* A symbol is only a candidate for removal if **all** searches
(including content search) return zero results in downstream projects. Do
not exclude `third_party/webrtc` entirely; only exclude the mirror path
(e.g. `stable/webrtc`), as downstream internal projects may reside in other
subdirectories like `third_party/webrtc/internal`.
5. **Iteration Stop:** Continue the audit process until exactly **10 symbols**
have been confirmed to have zero results. Once 10 are found, stop the search.
6. **Documentation:** List the 10 selected symbols, their locations, and their
modern equivalents.
______________________________________________________________________
## Phase 2: Execution and Validation
For the 10 selected candidates:
1. **Test Migration:** Update any internal WebRTC unit tests or regression tests
that still use the deprecated symbol.
2. **Code Removal:** Delete the deprecated declarations and implementation.
3. **Bug Tracking:** If a `TODO` with a bug number was attached to the
deprecated function and removed, add that bug number with a `webrtc:` prefix
to the `Bug:` line in the commit message. If no specific bug is associated
with the removed code, use `Bug: webrtc:42224904` as the default tracking
bug.
4. **Local Build:** Perform a clean build of all major targets (e.g.,
`rtc_unittests`, `rtc_pc_unittests`, `peerconnection_unittests`).
5. **Verification:** Run the relevant test suites and ensure 100% pass rate.
6. **Gerrit Upload:** Submit the changes for review. The CL description should
refer to "downstream projects" generally and MUST NOT contain the specific
names of these projects.
______________________________________________________________________
## Phase 3: High-Usage Coordination
Symbols that return non-zero usage in downstream projects must not be removed
using this process. Instead:
1. Identify the owner of the consuming code.
2. File a bug against the consuming team referencing the WebRTC deprecation.
3. Wait for the consuming team to migrate before moving the symbol to Phase 1 in
a future iteration.