blob: 44f105b1d9d3cade8895f621e026026543bf0371 [file] [log] [blame]
Henrik Boström933d8b02017-10-10 17:05:161/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Yves Gerey3e707812018-11-28 15:47:4911#include <stdint.h>
Jonas Olssona4d87372019-07-05 17:08:3312
Henrik Boström933d8b02017-10-10 17:05:1613#include <memory>
Yves Gerey3e707812018-11-28 15:47:4914#include <string>
15#include <utility>
Henrik Boström933d8b02017-10-10 17:05:1616#include <vector>
17
Yves Gerey3e707812018-11-28 15:47:4918#include "absl/types/optional.h"
19#include "api/audio/audio_mixer.h"
20#include "api/audio_codecs/audio_decoder_factory.h"
21#include "api/audio_codecs/audio_encoder_factory.h"
Karl Wiberg1b0eae32017-10-17 12:48:5422#include "api/audio_codecs/builtin_audio_decoder_factory.h"
23#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Mirko Bonadei2ff3f492018-11-22 08:00:1324#include "api/create_peerconnection_factory.h"
Henrik Boström933d8b02017-10-10 17:05:1625#include "api/jsep.h"
Steve Anton10542f22019-01-11 17:11:0026#include "api/media_stream_interface.h"
27#include "api/media_types.h"
28#include "api/peer_connection_interface.h"
29#include "api/rtc_error.h"
30#include "api/rtp_parameters.h"
31#include "api/rtp_receiver_interface.h"
32#include "api/rtp_sender_interface.h"
33#include "api/rtp_transceiver_interface.h"
Mirko Bonadeid9708072019-01-25 19:26:4834#include "api/scoped_refptr.h"
Steve Anton10542f22019-01-11 17:11:0035#include "api/set_remote_description_observer_interface.h"
36#include "api/uma_metrics.h"
Anders Carlsson67537952018-05-03 09:28:2937#include "api/video_codecs/builtin_video_decoder_factory.h"
38#include "api/video_codecs/builtin_video_encoder_factory.h"
Yves Gerey3e707812018-11-28 15:47:4939#include "api/video_codecs/video_decoder_factory.h"
40#include "api/video_codecs/video_encoder_factory.h"
Steve Anton10542f22019-01-11 17:11:0041#include "media/base/stream_params.h"
Yves Gerey3e707812018-11-28 15:47:4942#include "modules/audio_device/include/audio_device.h"
43#include "modules/audio_processing/include/audio_processing.h"
Steve Anton10542f22019-01-11 17:11:0044#include "p2p/base/port_allocator.h"
45#include "pc/media_session.h"
46#include "pc/peer_connection_wrapper.h"
47#include "pc/sdp_utils.h"
48#include "pc/session_description.h"
49#include "pc/test/fake_audio_capture_module.h"
50#include "pc/test/mock_peer_connection_observers.h"
Henrik Boström933d8b02017-10-10 17:05:1651#include "rtc_base/checks.h"
52#include "rtc_base/gunit.h"
Steve Anton10542f22019-01-11 17:11:0053#include "rtc_base/ref_counted_object.h"
54#include "rtc_base/rtc_certificate_generator.h"
Henrik Boström933d8b02017-10-10 17:05:1655#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 06:51:1056#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 21:01:5257#include "test/gmock.h"
Yves Gerey3e707812018-11-28 15:47:4958#include "test/gtest.h"
Henrik Boström933d8b02017-10-10 17:05:1659
60// This file contains tests for RTP Media API-related behavior of
61// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
62
Steve Anton9158ef62017-11-27 21:01:5263namespace webrtc {
64
65using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
66using ::testing::ElementsAre;
Steve Antonc1e6e862019-03-04 22:43:4467using ::testing::Pair;
Steve Anton9158ef62017-11-27 21:01:5268using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 22:30:1869using ::testing::Values;
Henrik Boström933d8b02017-10-10 17:05:1670
Henrik Boström31638672017-11-23 16:48:3271const uint32_t kDefaultTimeout = 10000u;
72
73template <typename MethodFunctor>
74class OnSuccessObserver : public rtc::RefCountedObject<
75 webrtc::SetRemoteDescriptionObserverInterface> {
76 public:
77 explicit OnSuccessObserver(MethodFunctor on_success)
78 : on_success_(std::move(on_success)) {}
79
80 // webrtc::SetRemoteDescriptionObserverInterface implementation.
81 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
82 RTC_CHECK(error.ok());
83 on_success_();
84 }
85
86 private:
87 MethodFunctor on_success_;
88};
89
Mirko Bonadei6a489f22019-04-09 13:11:1290class PeerConnectionRtpBaseTest : public ::testing::Test {
Henrik Boström933d8b02017-10-10 17:05:1691 public:
Steve Anton3172c032018-05-03 22:30:1892 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
93 : sdp_semantics_(sdp_semantics),
94 pc_factory_(
Steve Anton9158ef62017-11-27 21:01:5295 CreatePeerConnectionFactory(rtc::Thread::Current(),
96 rtc::Thread::Current(),
97 rtc::Thread::Current(),
98 FakeAudioCaptureModule::Create(),
99 CreateBuiltinAudioEncoderFactory(),
100 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 09:28:29101 CreateBuiltinVideoEncoderFactory(),
102 CreateBuiltinVideoDecoderFactory(),
103 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 19:54:53104 nullptr /* audio_processing */)) {
105 webrtc::metrics::Reset();
106 }
Henrik Boström933d8b02017-10-10 17:05:16107
Steve Anton9158ef62017-11-27 21:01:52108 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
109 return CreatePeerConnection(RTCConfiguration());
110 }
111
Steve Antone831b8c2018-02-01 20:22:16112 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
113 RTCConfiguration config;
114 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 22:30:18115 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 20:22:16116 }
117
Steve Anton9158ef62017-11-27 21:01:52118 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
119 RTCConfiguration config;
120 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 22:30:18121 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 21:01:52122 }
123
124 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
125 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 22:30:18126 RTCConfiguration modified_config = config;
127 modified_config.sdp_semantics = sdp_semantics_;
128 return CreatePeerConnectionInternal(modified_config);
129 }
130
131 protected:
132 const SdpSemantics sdp_semantics_;
133 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
134
135 private:
136 // Private so that tests don't accidentally bypass the SdpSemantics
137 // adjustment.
138 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
139 const RTCConfiguration& config) {
Mirko Bonadei317a1f02019-09-17 15:06:18140 auto observer = std::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 17:05:16141 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
142 observer.get());
Yves Gerey4e933292018-10-31 14:36:05143 EXPECT_TRUE(pc.get());
144 observer->SetPeerConnectionInterface(pc.get());
Mirko Bonadei317a1f02019-09-17 15:06:18145 return std::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
146 std::move(observer));
Henrik Boström933d8b02017-10-10 17:05:16147 }
Steve Anton3172c032018-05-03 22:30:18148};
Henrik Boström933d8b02017-10-10 17:05:16149
Steve Anton3172c032018-05-03 22:30:18150class PeerConnectionRtpTest
151 : public PeerConnectionRtpBaseTest,
152 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 17:05:16153 protected:
Steve Anton3172c032018-05-03 22:30:18154 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
155};
156
157class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
158 protected:
159 PeerConnectionRtpTestPlanB()
160 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
161};
162
163class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
164 protected:
165 PeerConnectionRtpTestUnifiedPlan()
166 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 17:05:16167};
168
Henrik Boström31638672017-11-23 16:48:32169// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
170// setting the remote description.
Henrik Boström31638672017-11-23 16:48:32171
Steve Anton3172c032018-05-03 22:30:18172TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 17:05:16173 auto caller = CreatePeerConnection();
174 auto callee = CreatePeerConnection();
175
Steve Anton3172c032018-05-03 22:30:18176 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 18:16:33177 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 17:05:16178
Henrik Boström31638672017-11-23 16:48:32179 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 22:30:18180 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 12:41:51181 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 22:30:18182
183 if (sdp_semantics_ == SdpSemantics::kPlanB) {
184 // Since we are not supporting the no stream case with Plan B, there should
185 // be a generated stream, even though we didn't set one with AddTrack.
186 ASSERT_EQ(1u, add_track_event.streams.size());
187 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
188 } else {
189 EXPECT_EQ(0u, add_track_event.streams.size());
190 }
Henrik Boström933d8b02017-10-10 17:05:16191}
192
Steve Anton3172c032018-05-03 22:30:18193TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 17:05:16194 auto caller = CreatePeerConnection();
195 auto callee = CreatePeerConnection();
196
Steve Anton3172c032018-05-03 22:30:18197 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 18:16:33198 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 17:05:16199
Henrik Boström31638672017-11-23 16:48:32200 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 12:41:51201 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 16:48:32202 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 23:05:28203 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 12:41:51204 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
205 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 17:05:16206}
207
Steve Anton3172c032018-05-03 22:30:18208TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 17:05:16209 auto caller = CreatePeerConnection();
210 auto callee = CreatePeerConnection();
211
Steve Anton3172c032018-05-03 22:30:18212 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 18:16:33213 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 16:48:32214 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 22:30:18215 ASSERT_TRUE(
216 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
217
Henrik Boström933d8b02017-10-10 17:05:16218 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 18:16:33219 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 17:05:16220
Henrik Boström31638672017-11-23 16:48:32221 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 17:05:16222 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
223 callee->observer()->remove_track_events_);
224}
225
Steve Anton3172c032018-05-03 22:30:18226TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 17:05:16227 auto caller = CreatePeerConnection();
228 auto callee = CreatePeerConnection();
229
Steve Anton3172c032018-05-03 22:30:18230 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 18:16:33231 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 16:48:32232 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 22:30:18233 ASSERT_TRUE(
234 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
235
Henrik Boström933d8b02017-10-10 17:05:16236 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 18:16:33237 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 17:05:16238
Henrik Boström31638672017-11-23 16:48:32239 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 17:05:16240 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
241 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 22:30:18242 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 17:05:16243}
244
Steve Anton3172c032018-05-03 22:30:18245TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 17:05:16246 auto caller = CreatePeerConnection();
247 auto callee = CreatePeerConnection();
248
Seth Hampson845e8782018-03-02 19:34:10249 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 22:30:18250 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
251 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 18:16:33252 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 16:48:32253 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 22:30:18254 ASSERT_TRUE(
255 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 17:05:16256
257 // Remove "audio_track1".
258 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 18:16:33259 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 16:48:32260 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 17:05:16261 EXPECT_EQ(
Steve Anton9158ef62017-11-27 21:01:52262 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 17:05:16263 callee->observer()->add_track_events_[0].receiver},
264 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 22:30:18265 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
266 ASSERT_TRUE(
267 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 17:05:16268
269 // Remove "audio_track2".
270 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 18:16:33271 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 16:48:32272 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 17:05:16273 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
274 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 22:30:18275 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 17:05:16276}
277
Seth Hampson5b4f0752018-04-02 23:31:36278// Tests the edge case that if a stream ID changes for a given track that both
279// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 22:30:18280TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 23:31:36281 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
282 auto caller = CreatePeerConnection();
283 auto callee = CreatePeerConnection();
284
285 const char kStreamId1[] = "stream1";
286 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 22:30:18287 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 18:16:33288 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 23:31:36289 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
290
291 // Change the stream ID of the sender in the session description.
292 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 22:30:18293 auto* audio_desc =
294 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 23:31:36295 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
296 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 22:30:18297 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 23:31:36298
299 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
300 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
301 kStreamId2);
302 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
303 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
304 kStreamId1);
305}
306
Steve Anton8b815cd2018-02-17 00:14:42307// Tests that setting a remote description with sending transceivers will fire
308// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 23:31:36309// with receive only transceivers will not call OnTrack. One transceiver is
310// created without any stream_ids, while the other is created with multiple
311// stream_ids.
Steve Anton3172c032018-05-03 22:30:18312TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 23:31:36313 const std::string kStreamId1 = "video_stream1";
314 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 22:30:18315 auto caller = CreatePeerConnection();
316 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-17 00:14:42317
318 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 23:31:36319 RtpTransceiverInit video_transceiver_init;
320 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
321 auto video_transceiver =
322 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-17 00:14:42323
324 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
325
326 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
327 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
328 EXPECT_EQ(audio_transceiver->mid(),
329 callee->pc()->GetTransceivers()[0]->mid());
330 EXPECT_EQ(video_transceiver->mid(),
331 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 23:31:36332 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
333 callee->pc()->GetTransceivers()[0]->receiver()->streams();
334 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
335 callee->pc()->GetTransceivers()[1]->receiver()->streams();
336 ASSERT_EQ(0u, audio_streams.size());
337 ASSERT_EQ(2u, video_streams.size());
338 EXPECT_EQ(kStreamId1, video_streams[0]->id());
339 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-17 00:14:42340}
341
342// Test that doing additional offer/answer exchanges with no changes to tracks
343// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 22:30:18344TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
345 auto caller = CreatePeerConnection();
346 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-17 00:14:42347
348 caller->AddAudioTrack("audio");
349 callee->AddAudioTrack("audio");
350
351 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
352 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
353 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
354
355 // If caller reoffers with no changes expect no additional OnTrack calls.
356 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
357 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
358 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
359
360 // Also if callee reoffers with no changes expect no additional OnTrack calls.
361 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
362 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
363 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
364}
365
366// Test that OnTrack is called when the transceiver direction changes to send
367// the track.
Steve Anton3172c032018-05-03 22:30:18368TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
369 auto caller = CreatePeerConnection();
370 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-17 00:14:42371
372 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Harald Alvestrand6060df52020-08-11 07:54:02373 EXPECT_TRUE(
374 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
375 .ok());
Steve Anton8b815cd2018-02-17 00:14:42376 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
377 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
378 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
379
Harald Alvestrand6060df52020-08-11 07:54:02380 EXPECT_TRUE(
381 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendOnly)
382 .ok());
Steve Anton8b815cd2018-02-17 00:14:42383 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
384 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
385 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
386
387 // If the direction changes but it is still receiving on the remote side, then
388 // OnTrack should not be fired again.
Harald Alvestrand6060df52020-08-11 07:54:02389 EXPECT_TRUE(
390 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv)
391 .ok());
Steve Anton8b815cd2018-02-17 00:14:42392 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
393 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
394 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
395}
396
397// Test that OnTrack is called twice when a sendrecv call is started, the callee
398// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 22:30:18399TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
400 auto caller = CreatePeerConnection();
401 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-17 00:14:42402
403 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
404
405 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
406 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
407 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
408
409 // Put the call on hold by no longer receiving the track.
Harald Alvestrand6060df52020-08-11 07:54:02410 EXPECT_TRUE(callee->pc()
411 ->GetTransceivers()[0]
412 ->SetDirectionWithError(RtpTransceiverDirection::kInactive)
413 .ok());
Steve Anton8b815cd2018-02-17 00:14:42414
415 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
416 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
417 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
418
419 // Resume the call by changing the direction to recvonly. This should call
420 // OnTrack again on the callee side.
Harald Alvestrand6060df52020-08-11 07:54:02421 EXPECT_TRUE(callee->pc()
422 ->GetTransceivers()[0]
423 ->SetDirectionWithError(RtpTransceiverDirection::kRecvOnly)
424 .ok());
Steve Anton8b815cd2018-02-17 00:14:42425
426 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
427 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
428 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
429}
430
Steve Anton3172c032018-05-03 22:30:18431// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 21:25:36432// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 22:30:18433TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 21:25:36434 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 16:48:32435 auto caller = CreatePeerConnection();
436 auto callee = CreatePeerConnection();
437
Steve Anton3172c032018-05-03 22:30:18438 caller->AddAudioTrack("audio_track", {});
439
Amit Hilbuchae3df542019-01-07 20:13:08440 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 22:30:18441 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
442
Amit Hilbuchae3df542019-01-07 20:13:08443 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton0f5400a2018-07-17 21:25:36444 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 22:30:18445}
446
447// Test that setting a remote offer twice with no answer in the middle and the
448// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 21:25:36449// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 22:30:18450TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 21:25:36451 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 22:30:18452 auto caller = CreatePeerConnection();
453 auto callee = CreatePeerConnection();
454
455 auto sender = caller->AddAudioTrack("audio_track", {});
456
Amit Hilbuchae3df542019-01-07 20:13:08457 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 22:30:18458 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 21:25:36459 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 22:30:18460
461 caller->pc()->RemoveTrack(sender);
462
Amit Hilbuchae3df542019-01-07 20:13:08463 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 22:30:18464 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 21:25:36465 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
466}
467
468// Test that changing the direction from receiving to not receiving between
469// setting the remote offer and creating / setting the local answer results in
470// a remove track event when SetLocalDescription is called.
471TEST_F(PeerConnectionRtpTestUnifiedPlan,
472 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
473 auto caller = CreatePeerConnection();
474 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
475 auto callee = CreatePeerConnection();
476 callee->AddAudioTrack("audio_track", {});
477
478 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
479 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 22:30:18480 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 21:25:36481
482 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
Harald Alvestrand6060df52020-08-11 07:54:02483 EXPECT_TRUE(callee_transceiver
484 ->SetDirectionWithError(RtpTransceiverDirection::kSendOnly)
485 .ok());
Steve Anton0f5400a2018-07-17 21:25:36486
487 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
488 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
489 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 22:30:18490}
491
Henrik Boströmafa07dd2018-12-20 10:06:02492TEST_F(PeerConnectionRtpTestUnifiedPlan, ChangeMsidWhileReceiving) {
493 auto caller = CreatePeerConnection();
494 caller->AddAudioTrack("audio_track", {"stream1"});
495 auto callee = CreatePeerConnection();
Amit Hilbuchae3df542019-01-07 20:13:08496 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 10:06:02497
498 ASSERT_EQ(1u, callee->observer()->on_track_transceivers_.size());
499 auto transceiver = callee->observer()->on_track_transceivers_[0];
500 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
501 EXPECT_EQ("stream1", transceiver->receiver()->streams()[0]->id());
502
Amit Hilbuchae3df542019-01-07 20:13:08503 ASSERT_TRUE(callee->CreateAnswerAndSetAsLocal());
Henrik Boströmafa07dd2018-12-20 10:06:02504
505 // Change the stream ID in the offer.
Guido Urdaneta1ff16c82019-05-20 17:31:53506 caller->pc()->GetSenders()[0]->SetStreams({"stream2"});
507 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 10:06:02508 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
509 EXPECT_EQ("stream2", transceiver->receiver()->streams()[0]->id());
510}
511
Steve Anton3172c032018-05-03 22:30:18512// These tests examine the state of the peer connection as a result of
513// performing SetRemoteDescription().
514
515TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
516 auto caller = CreatePeerConnection();
517 auto callee = CreatePeerConnection();
518
519 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 18:16:33520 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 16:48:32521
522 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
523 auto receiver_added = callee->pc()->GetReceivers()[0];
524 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 22:30:18525
526 if (sdp_semantics_ == SdpSemantics::kPlanB) {
527 // Since we are not supporting the no stream case with Plan B, there should
528 // be a generated stream, even though we didn't set one with AddTrack.
529 ASSERT_EQ(1u, receiver_added->streams().size());
530 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
531 } else {
532 EXPECT_EQ(0u, receiver_added->streams().size());
533 }
Henrik Boström31638672017-11-23 16:48:32534}
535
Steve Anton3172c032018-05-03 22:30:18536TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 16:48:32537 auto caller = CreatePeerConnection();
538 auto callee = CreatePeerConnection();
539
Steve Anton3172c032018-05-03 22:30:18540 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 18:16:33541 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 16:48:32542
543 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
544 auto receiver_added = callee->pc()->GetReceivers()[0];
545 EXPECT_EQ("audio_track", receiver_added->track()->id());
546 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 23:05:28547 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 16:48:32548 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
549}
550
Steve Anton3172c032018-05-03 22:30:18551TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 16:48:32552 auto caller = CreatePeerConnection();
553 auto callee = CreatePeerConnection();
554
Steve Anton3172c032018-05-03 22:30:18555 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 16:48:32556 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 22:30:18557 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
558
Henrik Boström31638672017-11-23 16:48:32559 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
560 auto receiver = callee->pc()->GetReceivers()[0];
561 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 22:30:18562 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 16:48:32563
Steve Anton3172c032018-05-03 22:30:18564 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
565 // With Unified Plan the receiver stays but the transceiver transitions to
566 // inactive.
567 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
568 EXPECT_EQ(RtpTransceiverDirection::kInactive,
569 callee->pc()->GetTransceivers()[0]->current_direction());
570 } else {
571 // With Plan B the receiver is removed.
572 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
573 }
Henrik Boström31638672017-11-23 16:48:32574}
575
Steve Anton3172c032018-05-03 22:30:18576TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 16:48:32577 auto caller = CreatePeerConnection();
578 auto callee = CreatePeerConnection();
579
Steve Anton3172c032018-05-03 22:30:18580 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 16:48:32581 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 22:30:18582 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 16:48:32583 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
584 auto receiver = callee->pc()->GetReceivers()[0];
585 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 22:30:18586 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 16:48:32587
Steve Anton3172c032018-05-03 22:30:18588 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
589 // With Unified Plan the receiver stays but the transceiver transitions to
590 // inactive.
591 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
592 EXPECT_EQ(RtpTransceiverDirection::kInactive,
593 callee->pc()->GetTransceivers()[0]->current_direction());
594 } else {
595 // With Plan B the receiver is removed.
596 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
597 }
Henrik Boström31638672017-11-23 16:48:32598}
599
Steve Anton3172c032018-05-03 22:30:18600TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 16:48:32601 auto caller = CreatePeerConnection();
602 auto callee = CreatePeerConnection();
603
Seth Hampson845e8782018-03-02 19:34:10604 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 22:30:18605 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
606 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
607 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
608 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 16:48:32609
610 // Remove "audio_track1".
611 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 22:30:18612 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
613
614 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
615 // With Unified Plan the receiver stays but the transceiver transitions to
616 // inactive.
617 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
618 auto transceiver = callee->pc()->GetTransceivers()[0];
619 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
620 EXPECT_EQ(RtpTransceiverDirection::kInactive,
621 transceiver->current_direction());
622 } else {
623 // With Plan B the receiver is removed.
624 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
625 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
626 }
Henrik Boström31638672017-11-23 16:48:32627
628 // Remove "audio_track2".
629 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 22:30:18630 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
631
632 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
633 // With Unified Plan the receiver stays but the transceiver transitions to
634 // inactive.
635 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
636 auto transceiver = callee->pc()->GetTransceivers()[1];
637 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
638 EXPECT_EQ(RtpTransceiverDirection::kInactive,
639 transceiver->current_direction());
640 } else {
641 // With Plan B the receiver is removed.
642 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
643 }
Henrik Boström31638672017-11-23 16:48:32644}
645
Florent Castelliabe301f2018-06-12 16:33:49646TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
647 auto caller = CreatePeerConnection();
648 auto callee = CreatePeerConnection();
649 auto sender = caller->AddAudioTrack("audio_track");
650 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
651
652 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
653 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
654
655 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
656 auto receiver = callee->pc()->GetReceivers()[0];
657 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
658}
659
660TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
661 auto caller = CreatePeerConnection();
662 auto callee = CreatePeerConnection();
663 auto sender = caller->AddVideoTrack("video_track");
664 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
665
666 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
667 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
668
669 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
670 auto receiver = callee->pc()->GetReceivers()[0];
671 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
672}
673
Henrik Boström31638672017-11-23 16:48:32674// Invokes SetRemoteDescription() twice in a row without synchronizing the two
675// calls and examine the state of the peer connection inside the callbacks to
676// ensure that the second call does not occur prematurely, contaminating the
677// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 22:30:18678TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 16:48:32679 StatesCorrelateWithSetRemoteDescriptionCall) {
680 auto caller = CreatePeerConnection();
681 auto callee = CreatePeerConnection();
682
Henrik Boström31638672017-11-23 16:48:32683 // Create SDP for adding a track and for removing it. This will be used in the
684 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 22:30:18685 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 16:48:32686 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
687 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
688 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
689
690 // In the first SetRemoteDescription() callback, check that we have a
691 // receiver for the track.
692 auto pc = callee->pc();
693 bool srd1_callback_called = false;
694 auto srd1_callback = [&srd1_callback_called, &pc]() {
695 EXPECT_EQ(pc->GetReceivers().size(), 1u);
696 srd1_callback_called = true;
697 };
698
699 // In the second SetRemoteDescription() callback, check that the receiver has
700 // been removed.
701 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
702 // Instead, the transceiver owning the receiver will become inactive.
703 // https://crbug.com/webrtc/7600
704 bool srd2_callback_called = false;
705 auto srd2_callback = [&srd2_callback_called, &pc]() {
706 EXPECT_TRUE(pc->GetReceivers().empty());
707 srd2_callback_called = true;
708 };
709
710 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
711 // calls. The callbacks verify that the two calls are synchronized, as in, the
712 // effects of the second SetRemoteDescription() call must not have happened by
713 // the time the first callback is invoked. If it has then the receiver that is
714 // added as a result of the first SetRemoteDescription() call will already
715 // have been removed as a result of the second SetRemoteDescription() call
716 // when the first callback is invoked.
717 callee->pc()->SetRemoteDescription(
718 std::move(srd1_sdp),
719 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
720 callee->pc()->SetRemoteDescription(
721 std::move(srd2_sdp),
722 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
723 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
724 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
725}
726
Seth Hampson5897a6e2018-04-03 18:16:33727// Tests that a remote track is created with the signaled MSIDs when they are
728// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
729// lines).
Steve Anton3172c032018-05-03 22:30:18730TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
731 auto caller = CreatePeerConnection();
732 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 18:16:33733 const char kStreamId1[] = "stream1";
734 const char kStreamId2[] = "stream2";
735 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
736 {kStreamId1, kStreamId2});
737
738 auto offer = caller->CreateOfferAndSetAsLocal();
739 // Munge the offer to take out everything but the stream_ids.
740 auto contents = offer->description()->contents();
741 ASSERT_TRUE(!contents.empty());
742 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
743 std::vector<std::string> stream_ids =
744 contents[0].media_description()->streams()[0].stream_ids();
745 contents[0].media_description()->mutable_streams().clear();
746 cricket::StreamParams new_stream;
747 new_stream.set_stream_ids(stream_ids);
748 contents[0].media_description()->AddStream(new_stream);
749
750 // Set the remote description and verify that the streams were added to the
751 // receiver correctly.
752 ASSERT_TRUE(
753 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
754 auto receivers = callee->pc()->GetReceivers();
755 ASSERT_EQ(receivers.size(), 1u);
756 ASSERT_EQ(receivers[0]->streams().size(), 2u);
757 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
758 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
759}
760
Seth Hampson5b4f0752018-04-02 23:31:36761// Tests that with Unified Plan if the the stream id changes for a track when
762// when setting a new remote description, that the media stream is updated
763// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 21:25:36764// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
765// test.
766TEST_F(PeerConnectionRtpTestUnifiedPlan,
767 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 22:30:18768 auto caller = CreatePeerConnection();
769 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 23:31:36770
771 const char kStreamId1[] = "stream1";
772 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 21:25:36773 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 18:16:33774 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 23:31:36775 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
776
777 // Change the stream id of the sender in the session description.
778 auto offer = caller->CreateOfferAndSetAsLocal();
779 auto contents = offer->description()->contents();
780 ASSERT_EQ(contents.size(), 1u);
781 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
782 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
783 {kStreamId2});
784
Steve Anton0f5400a2018-07-17 21:25:36785 // Set the remote description and verify that the stream was updated
786 // properly.
787 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 23:31:36788 auto receivers = callee->pc()->GetReceivers();
789 ASSERT_EQ(receivers.size(), 1u);
790 ASSERT_EQ(receivers[0]->streams().size(), 1u);
791 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
792}
793
794// This tests a regression caught by a downstream client, that occured when
795// applying a remote description with a SessionDescription object that
796// contained StreamParams that didn't have ids. Although there were multiple
797// remote audio senders, FindSenderInfo didn't find them as unique, because
798// it looked up by StreamParam.id, which none had. This meant only one
799// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 22:30:18800TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 23:31:36801 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
802 auto caller = CreatePeerConnection();
803 auto callee = CreatePeerConnection();
804
805 const char kStreamId1[] = "stream1";
806 const char kStreamId2[] = "stream2";
807 caller->AddAudioTrack("audio_track1", {kStreamId1});
808 caller->AddAudioTrack("audio_track2", {kStreamId2});
809
810 auto offer = caller->CreateOfferAndSetAsLocal();
811 auto mutable_streams =
812 cricket::GetFirstAudioContentDescription(offer->description())
813 ->mutable_streams();
814 ASSERT_EQ(mutable_streams.size(), 2u);
815 // Clear the IDs in the StreamParams.
816 mutable_streams[0].id.clear();
817 mutable_streams[1].id.clear();
818 ASSERT_TRUE(
819 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
820
821 auto receivers = callee->pc()->GetReceivers();
822 ASSERT_EQ(receivers.size(), 2u);
823 ASSERT_EQ(receivers[0]->streams().size(), 1u);
824 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
825 ASSERT_EQ(receivers[1]->streams().size(), 1u);
826 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
827}
828
Henrik Boström31638672017-11-23 16:48:32829// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 16:48:32830
831// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 22:30:18832TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 16:48:32833 auto caller = CreatePeerConnection();
834 auto callee = CreatePeerConnection();
835
836 std::string error;
837 ASSERT_TRUE(
838 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
839}
840
841// Verifies legacy behavior: The observer is not called if if the peer
842// connection is destroyed because the asynchronous callback is executed in the
843// peer connection's message handler.
Steve Anton3172c032018-05-03 22:30:18844TEST_P(PeerConnectionRtpTest,
845 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 16:48:32846 auto caller = CreatePeerConnection();
847 auto callee = CreatePeerConnection();
848
849 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
850 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
851
852 auto offer = caller->CreateOfferAndSetAsLocal();
853 callee->pc()->SetRemoteDescription(observer, offer.release());
854 callee = nullptr;
855 rtc::Thread::Current()->ProcessMessages(0);
856 EXPECT_FALSE(observer->called());
857}
858
Steve Antonf9381f02017-12-14 18:23:57859// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 21:01:52860
861// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 22:30:18862TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
863 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 21:01:52864 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
865}
866
867// Test that a transceiver created with the audio kind has the correct initial
868// properties.
Steve Anton3172c032018-05-03 22:30:18869TEST_F(PeerConnectionRtpTestUnifiedPlan,
870 AddTransceiverHasCorrectInitProperties) {
871 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 21:01:52872
873 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 14:47:43874 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 21:01:52875 EXPECT_FALSE(transceiver->stopped());
876 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 14:47:43877 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 21:01:52878}
879
880// Test that adding a transceiver with the audio kind creates an audio sender
881// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 22:30:18882TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 21:01:52883 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 22:30:18884 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 21:01:52885
886 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 19:43:08887 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 21:01:52888
889 ASSERT_TRUE(transceiver->sender());
890 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
891
892 ASSERT_TRUE(transceiver->receiver());
893 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
894
895 auto track = transceiver->receiver()->track();
896 ASSERT_TRUE(track);
897 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
898 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
899}
900
901// Test that adding a transceiver with the video kind creates an video sender
902// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 22:30:18903TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 21:01:52904 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 22:30:18905 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 21:01:52906
907 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 19:43:08908 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 21:01:52909
910 ASSERT_TRUE(transceiver->sender());
911 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
912
913 ASSERT_TRUE(transceiver->receiver());
914 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
915
916 auto track = transceiver->receiver()->track();
917 ASSERT_TRUE(track);
918 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
919 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
920}
921
922// Test that after a call to AddTransceiver, the transceiver shows in
923// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
924// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 22:30:18925TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
926 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 21:01:52927
928 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
929 EXPECT_EQ(
930 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
931 caller->pc()->GetTransceivers());
932 EXPECT_EQ(
933 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
934 transceiver->sender()},
935 caller->pc()->GetSenders());
936 EXPECT_EQ(
937 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
938 transceiver->receiver()},
939 caller->pc()->GetReceivers());
940}
941
942// Test that the direction passed in through the AddTransceiver init parameter
943// is set in the returned transceiver.
Steve Anton3172c032018-05-03 22:30:18944TEST_F(PeerConnectionRtpTestUnifiedPlan,
945 AddTransceiverWithDirectionIsReflected) {
946 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 21:01:52947
948 RtpTransceiverInit init;
949 init.direction = RtpTransceiverDirection::kSendOnly;
950 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
951 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
952}
953
Steve Anton9158ef62017-11-27 21:01:52954// Test that calling AddTransceiver with a track creates a transceiver which has
955// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 22:30:18956TEST_F(PeerConnectionRtpTestUnifiedPlan,
957 AddTransceiverWithTrackCreatesSenderWithTrack) {
958 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 21:01:52959
960 auto audio_track = caller->CreateAudioTrack("audio track");
961 auto transceiver = caller->AddTransceiver(audio_track);
962
963 auto sender = transceiver->sender();
964 ASSERT_TRUE(sender->track());
965 EXPECT_EQ(audio_track, sender->track());
966
967 auto receiver = transceiver->receiver();
968 ASSERT_TRUE(receiver->track());
969 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
970 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
971 receiver->track()->state());
972}
973
974// Test that calling AddTransceiver twice with the same track creates distinct
975// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 22:30:18976TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 21:01:52977 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 22:30:18978 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 21:01:52979
980 auto audio_track = caller->CreateAudioTrack("audio track");
981
982 auto transceiver1 = caller->AddTransceiver(audio_track);
983 auto transceiver2 = caller->AddTransceiver(audio_track);
984
985 EXPECT_NE(transceiver1, transceiver2);
986
987 auto sender1 = transceiver1->sender();
988 auto sender2 = transceiver2->sender();
989 EXPECT_NE(sender1, sender2);
990 EXPECT_EQ(audio_track, sender1->track());
991 EXPECT_EQ(audio_track, sender2->track());
992
993 EXPECT_THAT(caller->pc()->GetTransceivers(),
994 UnorderedElementsAre(transceiver1, transceiver2));
995 EXPECT_THAT(caller->pc()->GetSenders(),
996 UnorderedElementsAre(sender1, sender2));
997}
998
Steve Anton3fe1b152017-12-12 18:20:08999// RtpTransceiver error handling tests.
1000
Steve Anton3172c032018-05-03 22:30:181001TEST_F(PeerConnectionRtpTestUnifiedPlan,
1002 AddTransceiverWithInvalidKindReturnsError) {
1003 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 18:20:081004
1005 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
1006 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
1007}
1008
Steve Anton3172c032018-05-03 22:30:181009TEST_F(PeerConnectionRtpTestUnifiedPlan,
1010 CanClosePeerConnectionWithoutCrashing) {
1011 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 18:20:081012
1013 caller->pc()->Close();
1014}
1015
Steve Antonf9381f02017-12-14 18:23:571016// Unified Plan AddTrack tests.
1017
Steve Antonf9381f02017-12-14 18:23:571018// Test that adding an audio track creates a new audio RtpSender with the given
1019// track.
Steve Anton3172c032018-05-03 22:30:181020TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
1021 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571022
1023 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-06 01:10:521024 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 18:23:571025 ASSERT_TRUE(sender);
1026
1027 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
1028 EXPECT_EQ(audio_track, sender->track());
1029}
1030
1031// Test that adding a video track creates a new video RtpSender with the given
1032// track.
Steve Anton3172c032018-05-03 22:30:181033TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
1034 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571035
1036 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-06 01:10:521037 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 18:23:571038 ASSERT_TRUE(sender);
1039
1040 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
1041 EXPECT_EQ(video_track, sender->track());
1042}
1043
1044// Test that adding a track to a new PeerConnection creates an RtpTransceiver
1045// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 22:30:181046TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
1047 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571048
1049 auto sender = caller->AddAudioTrack("a");
1050 ASSERT_TRUE(sender);
1051
1052 auto transceivers = caller->pc()->GetTransceivers();
1053 ASSERT_EQ(1u, transceivers.size());
1054 EXPECT_EQ(sender, transceivers[0]->sender());
1055 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1056}
1057
1058// Test that if a transceiver of the same type but no track had been added to
1059// the PeerConnection and later a call to AddTrack is made, the resulting sender
1060// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 22:30:181061TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1062 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571063
1064 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1065 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-06 01:10:521066 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 18:23:571067 ASSERT_TRUE(sender);
1068
1069 auto transceivers = caller->pc()->GetTransceivers();
1070 ASSERT_EQ(1u, transceivers.size());
1071 EXPECT_EQ(transceiver, transceivers[0]);
1072 EXPECT_EQ(sender, transceiver->sender());
1073 EXPECT_EQ(audio_track, sender->track());
1074}
1075
1076// Test that adding two tracks to a new PeerConnection creates two
1077// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 22:30:181078TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1079 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571080
1081 auto sender1 = caller->AddAudioTrack("a");
1082 auto sender2 = caller->AddVideoTrack("v");
1083 ASSERT_TRUE(sender2);
1084
1085 auto transceivers = caller->pc()->GetTransceivers();
1086 ASSERT_EQ(2u, transceivers.size());
1087 EXPECT_EQ(sender1, transceivers[0]->sender());
1088 EXPECT_EQ(sender2, transceivers[1]->sender());
1089}
1090
1091// Test that if there are multiple transceivers with no sending track then a
1092// later call to AddTrack will use the one of the same type as the newly-added
1093// track.
Steve Anton3172c032018-05-03 22:30:181094TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1095 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571096
1097 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1098 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1099 auto sender = caller->AddVideoTrack("v");
1100
1101 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1102 EXPECT_NE(sender, audio_transceiver->sender());
1103 EXPECT_EQ(sender, video_transceiver->sender());
1104}
1105
1106// Test that if the only transceivers that do not have a sending track have a
1107// different type from the added track, then AddTrack will create a new
1108// transceiver for the track.
Steve Anton3172c032018-05-03 22:30:181109TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 18:23:571110 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 22:30:181111 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571112
1113 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1114 auto sender = caller->AddVideoTrack("v");
1115
1116 auto transceivers = caller->pc()->GetTransceivers();
1117 ASSERT_EQ(2u, transceivers.size());
1118 EXPECT_NE(sender, transceivers[0]->sender());
1119 EXPECT_EQ(sender, transceivers[1]->sender());
1120}
1121
1122// Test that the first available transceiver is reused by AddTrack when multiple
1123// are available.
Steve Anton3172c032018-05-03 22:30:181124TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 18:23:571125 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 22:30:181126 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571127
1128 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1129 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1130 auto sender = caller->AddAudioTrack("a");
1131
1132 auto transceivers = caller->pc()->GetTransceivers();
1133 ASSERT_EQ(2u, transceivers.size());
1134 EXPECT_EQ(sender, transceivers[0]->sender());
1135 EXPECT_NE(sender, transceivers[1]->sender());
1136}
1137
1138// Test that a call to AddTrack that reuses a transceiver will change the
1139// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 22:30:181140TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 18:23:571141 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 22:30:181142 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 10:24:141143 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571144
1145 RtpTransceiverInit init;
1146 init.direction = RtpTransceiverDirection::kInactive;
1147 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Henrik Boströme574a312020-08-25 08:20:111148 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1149 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571150
Guido Urdaneta70c2db12019-04-16 10:24:141151 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 08:20:111152 caller->observer()->clear_legacy_renegotiation_needed();
1153 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 18:23:571154 ASSERT_TRUE(caller->AddAudioTrack("a"));
Henrik Boströme574a312020-08-25 08:20:111155 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1156 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571157
1158 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1159}
1160
1161// Test that a call to AddTrack that reuses a transceiver will change the
1162// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 22:30:181163TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 18:23:571164 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 22:30:181165 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 10:24:141166 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571167
1168 RtpTransceiverInit init;
1169 init.direction = RtpTransceiverDirection::kRecvOnly;
1170 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Henrik Boströme574a312020-08-25 08:20:111171 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1172 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571173
Guido Urdaneta70c2db12019-04-16 10:24:141174 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 08:20:111175 caller->observer()->clear_legacy_renegotiation_needed();
1176 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 18:23:571177 ASSERT_TRUE(caller->AddAudioTrack("a"));
Henrik Boströme574a312020-08-25 08:20:111178 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1179 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571180
1181 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1182}
1183
Steve Anton3172c032018-05-03 22:30:181184TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-11 00:26:061185 const std::string kTrackId = "audio_track";
1186
Steve Anton3172c032018-05-03 22:30:181187 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-11 00:26:061188
1189 auto audio_track = caller->CreateAudioTrack(kTrackId);
1190 auto sender = caller->AddTrack(audio_track);
1191
1192 EXPECT_EQ(kTrackId, sender->id());
1193}
1194
Steve Antonf9381f02017-12-14 18:23:571195// Unified Plan AddTrack error handling.
1196
Steve Anton3172c032018-05-03 22:30:181197TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1198 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571199
1200 auto audio_track = caller->CreateAudioTrack("a");
1201 caller->pc()->Close();
1202
Henrik Boströme574a312020-08-25 08:20:111203 caller->observer()->clear_legacy_renegotiation_needed();
1204 caller->observer()->clear_latest_negotiation_needed_event();
Yves Gerey665174f2018-06-19 13:03:051205 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-06 01:10:521206 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Henrik Boströme574a312020-08-25 08:20:111207 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1208 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571209}
1210
Steve Anton3172c032018-05-03 22:30:181211TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1212 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571213
1214 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-06 01:10:521215 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 18:23:571216
Henrik Boströme574a312020-08-25 08:20:111217 caller->observer()->clear_legacy_renegotiation_needed();
1218 caller->observer()->clear_latest_negotiation_needed_event();
Yves Gerey665174f2018-06-19 13:03:051219 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-06 01:10:521220 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Henrik Boströme574a312020-08-25 08:20:111221 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1222 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571223}
1224
1225// Unified Plan RemoveTrack tests.
1226
1227// Test that calling RemoveTrack on a sender with a previously-added track
1228// clears the sender's track.
Steve Anton3172c032018-05-03 22:30:181229TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1230 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571231
1232 auto sender = caller->AddAudioTrack("a");
1233 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1234
1235 EXPECT_FALSE(sender->track());
1236}
1237
1238// Test that calling RemoveTrack on a sender where the transceiver is configured
1239// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 22:30:181240TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 18:23:571241 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 22:30:181242 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 10:24:141243 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571244
1245 RtpTransceiverInit init;
1246 init.direction = RtpTransceiverDirection::kSendRecv;
1247 auto transceiver =
1248 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 08:20:111249 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1250 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571251
Guido Urdaneta70c2db12019-04-16 10:24:141252 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 08:20:111253 caller->observer()->clear_legacy_renegotiation_needed();
1254 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 10:24:141255
Steve Antonf9381f02017-12-14 18:23:571256 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
Henrik Boströme574a312020-08-25 08:20:111257 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1258 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571259
1260 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
Steve Antonf9381f02017-12-14 18:23:571261}
1262
1263// Test that calling RemoveTrack on a sender where the transceiver is configured
1264// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 22:30:181265TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 18:23:571266 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 22:30:181267 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 10:24:141268 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571269
1270 RtpTransceiverInit init;
1271 init.direction = RtpTransceiverDirection::kSendOnly;
1272 auto transceiver =
1273 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 08:20:111274 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1275 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571276
Guido Urdaneta70c2db12019-04-16 10:24:141277 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 08:20:111278 caller->observer()->clear_legacy_renegotiation_needed();
1279 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 10:24:141280
Steve Antonf9381f02017-12-14 18:23:571281 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
Henrik Boströme574a312020-08-25 08:20:111282 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1283 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571284
1285 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1286}
1287
1288// Test that calling RemoveTrack with a sender that has a null track results in
1289// no change in state.
Steve Anton3172c032018-05-03 22:30:181290TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1291 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571292
1293 auto sender = caller->AddAudioTrack("a");
1294 auto transceiver = caller->pc()->GetTransceivers()[0];
1295 ASSERT_TRUE(sender->SetTrack(nullptr));
1296
Henrik Boströme574a312020-08-25 08:20:111297 caller->observer()->clear_legacy_renegotiation_needed();
1298 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 18:23:571299 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Henrik Boströme574a312020-08-25 08:20:111300 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1301 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571302
1303 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1304}
1305
1306// Unified Plan RemoveTrack error handling.
1307
Steve Anton3172c032018-05-03 22:30:181308TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1309 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571310
1311 auto sender = caller->AddAudioTrack("a");
1312 caller->pc()->Close();
1313
Henrik Boströme574a312020-08-25 08:20:111314 caller->observer()->clear_legacy_renegotiation_needed();
1315 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 18:23:571316 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
Henrik Boströme574a312020-08-25 08:20:111317 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1318 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571319}
1320
Steve Anton3172c032018-05-03 22:30:181321TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 18:23:571322 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 22:30:181323 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 18:23:571324
1325 auto sender = caller->AddAudioTrack("a");
1326 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1327
Henrik Boströme574a312020-08-25 08:20:111328 caller->observer()->clear_legacy_renegotiation_needed();
1329 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 18:23:571330 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Henrik Boströme574a312020-08-25 08:20:111331 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1332 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 18:23:571333}
1334
Steve Anton60b6c1d2018-06-13 18:32:271335// Test that setting offers that add/remove/add a track repeatedly without
1336// setting the appropriate answer in between works.
1337// These are regression tests for bugs.webrtc.org/9401
1338TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1339 auto caller = CreatePeerConnection();
1340
1341 auto sender1 = caller->AddAudioTrack("audio1");
1342 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1343
1344 caller->pc()->RemoveTrack(sender1);
1345 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1346
1347 // This will re-use the transceiver created by the first AddTrack.
1348 auto sender2 = caller->AddAudioTrack("audio2");
1349 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1350
1351 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1352 EXPECT_EQ(sender1, sender2);
1353}
1354TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1355 auto caller = CreatePeerConnection();
1356
1357 auto sender1 = caller->AddVideoTrack("video1");
1358 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1359
1360 caller->pc()->RemoveTrack(sender1);
1361 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1362
1363 // This will re-use the transceiver created by the first AddTrack.
1364 auto sender2 = caller->AddVideoTrack("video2");
1365 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1366
1367 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1368 EXPECT_EQ(sender1, sender2);
1369}
1370
Steve Anton07563732018-06-26 18:13:501371// Test that CreateOffer succeeds if two tracks with the same label are added.
1372TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1373 auto caller = CreatePeerConnection();
1374
1375 auto audio_sender = caller->AddAudioTrack("track", {});
1376 auto video_sender = caller->AddVideoTrack("track", {});
1377
1378 EXPECT_TRUE(caller->CreateOffer());
1379
1380 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1381 EXPECT_NE(audio_sender->id(), video_sender->id());
1382}
1383
1384// Test that CreateAnswer succeeds if two tracks with the same label are added.
1385TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1386 auto caller = CreatePeerConnection();
1387 auto callee = CreatePeerConnection();
1388
1389 RtpTransceiverInit recvonly;
1390 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1391 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1392 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1393
1394 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1395
1396 auto audio_sender = callee->AddAudioTrack("track", {});
1397 auto video_sender = callee->AddVideoTrack("track", {});
1398
1399 EXPECT_TRUE(callee->CreateAnswer());
1400
1401 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1402 EXPECT_NE(audio_sender->id(), video_sender->id());
1403}
1404
1405// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1406// m= section with a random sender id (different from the first, now rejected,
1407// m= section).
1408TEST_F(PeerConnectionRtpTestUnifiedPlan,
1409 AddRemoveAddTrackGeneratesNewSenderId) {
1410 auto caller = CreatePeerConnection();
1411 auto callee = CreatePeerConnection();
1412
1413 auto track = caller->CreateVideoTrack("video");
1414 auto sender1 = caller->AddTrack(track);
1415 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1416
1417 caller->pc()->RemoveTrack(sender1);
1418 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1419
1420 auto sender2 = caller->AddTrack(track);
1421
1422 EXPECT_NE(sender1, sender2);
1423 EXPECT_NE(sender1->id(), sender2->id());
1424 std::string sender2_id = sender2->id();
1425
1426 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1427
1428 // The sender's ID should not change after negotiation.
1429 EXPECT_EQ(sender2_id, sender2->id());
1430}
1431
Steve Anton52d86772018-02-20 23:48:121432// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1433// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 22:30:181434TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 23:48:121435 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 22:30:181436 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 10:24:141437 auto callee = CreatePeerConnection();
Henrik Boströme574a312020-08-25 08:20:111438 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1439 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 23:48:121440
1441 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Henrik Boströme574a312020-08-25 08:20:111442 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1443 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 23:48:121444
Guido Urdaneta70c2db12019-04-16 10:24:141445 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 08:20:111446 caller->observer()->clear_legacy_renegotiation_needed();
1447 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 10:24:141448
Harald Alvestrand6060df52020-08-11 07:54:021449 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive);
Henrik Boströme574a312020-08-25 08:20:111450 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1451 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 23:48:121452}
1453
1454// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1455// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 22:30:181456TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 23:48:121457 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 22:30:181458 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 23:48:121459
1460 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1461
Henrik Boströme574a312020-08-25 08:20:111462 caller->observer()->clear_legacy_renegotiation_needed();
1463 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand6060df52020-08-11 07:54:021464 transceiver->SetDirectionWithError(transceiver->direction());
Henrik Boströme574a312020-08-25 08:20:111465 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1466 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 23:48:121467}
1468
1469// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1470// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 22:30:181471TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 23:48:121472 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 22:30:181473 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 23:48:121474
1475 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Harald Alvestrand6060df52020-08-11 07:54:021476 transceiver->StopInternal();
Steve Anton52d86772018-02-20 23:48:121477
Henrik Boströme574a312020-08-25 08:20:111478 caller->observer()->clear_legacy_renegotiation_needed();
1479 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand6060df52020-08-11 07:54:021480 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive);
Henrik Boströme574a312020-08-25 08:20:111481 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1482 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 23:48:121483}
1484
Harald Alvestrand6060df52020-08-11 07:54:021485// Test that currentDirection returnes "stopped" if the transceiver was stopped.
1486TEST_F(PeerConnectionRtpTestUnifiedPlan,
1487 CheckStoppedCurrentDirectionOnStoppedTransceiver) {
1488 auto caller = CreatePeerConnection();
1489
1490 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1491 transceiver->StopInternal();
1492
1493 EXPECT_TRUE(transceiver->stopping());
1494 EXPECT_TRUE(transceiver->stopped());
1495 EXPECT_EQ(RtpTransceiverDirection::kStopped,
1496 transceiver->current_direction());
1497}
1498
1499// Test that InvalidState is thrown on a stopping transceiver.
1500TEST_F(PeerConnectionRtpTestUnifiedPlan,
1501 CheckForInvalidStateOnStoppingTransceiver) {
1502 auto caller = CreatePeerConnection();
1503
1504 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1505 transceiver->StopStandard();
1506
1507 EXPECT_TRUE(transceiver->stopping());
1508 EXPECT_FALSE(transceiver->stopped());
1509 EXPECT_EQ(
1510 RTCErrorType::INVALID_STATE,
1511 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
1512 .type());
1513}
1514
1515// Test that InvalidState is thrown on a stopped transceiver.
1516TEST_F(PeerConnectionRtpTestUnifiedPlan,
1517 CheckForInvalidStateOnStoppedTransceiver) {
1518 auto caller = CreatePeerConnection();
1519
1520 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1521 transceiver->StopInternal();
1522
1523 EXPECT_TRUE(transceiver->stopping());
1524 EXPECT_TRUE(transceiver->stopped());
1525 EXPECT_EQ(
1526 RTCErrorType::INVALID_STATE,
1527 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
1528 .type());
1529}
1530
1531// Test that TypeError is thrown if the direction is set to "stopped".
1532TEST_F(PeerConnectionRtpTestUnifiedPlan,
1533 CheckForTypeErrorForStoppedOnTransceiver) {
1534 auto caller = CreatePeerConnection();
1535
1536 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1537 EXPECT_EQ(
1538 RTCErrorType::INVALID_PARAMETER,
1539 transceiver->SetDirectionWithError(RtpTransceiverDirection::kStopped)
1540 .type());
1541}
1542
Harald Alvestrand198cd732020-09-16 12:41:231543// Test that you can do createOffer/setLocalDescription with a stopped
1544// media section.
1545TEST_F(PeerConnectionRtpTestUnifiedPlan,
1546 SetLocalDescriptionWithStoppedMediaSection) {
1547 auto caller = CreatePeerConnection();
1548 auto callee = CreatePeerConnection();
1549 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1550 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1551 callee->pc()->GetTransceivers()[0]->StopStandard();
1552 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
1553 EXPECT_EQ(RtpTransceiverDirection::kStopped,
1554 transceiver->current_direction());
1555 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1556}
1557
Florent Castelli892acf02018-10-01 20:47:201558// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1559// parameters with the send_encodings parameters.
1560TEST_F(PeerConnectionRtpTestUnifiedPlan,
1561 CheckForUnsupportedEncodingParameters) {
1562 auto caller = CreatePeerConnection();
1563
1564 RtpTransceiverInit init;
1565 init.send_encodings.emplace_back();
1566
1567 auto default_send_encodings = init.send_encodings;
1568
Henrik Grunelle1301a82018-12-13 12:13:221569 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
Amit Hilbuchaa584152019-02-07 01:09:521570 // ptime, scale_framerate_down_by, dependency_rids.
Florent Castelli892acf02018-10-01 20:47:201571 init.send_encodings[0].ssrc = 1;
1572 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1573 caller->pc()
1574 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1575 .error()
1576 .type());
1577 init.send_encodings = default_send_encodings;
Florent Castelli892acf02018-10-01 20:47:201578}
1579
Florent Castellic1a0bcb2019-01-29 13:26:481580// Test that AddTransceiver fails if trying to use invalid RTP encoding
1581// parameters with the send_encodings parameters.
1582TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForInvalidEncodingParameters) {
1583 auto caller = CreatePeerConnection();
1584
1585 RtpTransceiverInit init;
1586 init.send_encodings.emplace_back();
1587
1588 auto default_send_encodings = init.send_encodings;
1589
1590 init.send_encodings[0].scale_resolution_down_by = 0.5;
1591 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1592 caller->pc()
1593 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1594 .error()
1595 .type());
1596 init.send_encodings = default_send_encodings;
1597
1598 init.send_encodings[0].bitrate_priority = 0;
1599 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1600 caller->pc()
1601 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1602 .error()
1603 .type());
1604 init.send_encodings = default_send_encodings;
1605
1606 init.send_encodings[0].min_bitrate_bps = 200000;
1607 init.send_encodings[0].max_bitrate_bps = 100000;
1608 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1609 caller->pc()
1610 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1611 .error()
1612 .type());
1613 init.send_encodings = default_send_encodings;
1614
1615 init.send_encodings[0].num_temporal_layers = 0;
1616 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1617 caller->pc()
1618 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1619 .error()
1620 .type());
1621 init.send_encodings = default_send_encodings;
1622
1623 init.send_encodings[0].num_temporal_layers = 5;
1624 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1625 caller->pc()
1626 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1627 .error()
1628 .type());
1629 init.send_encodings = default_send_encodings;
1630}
1631
Florent Castelli892acf02018-10-01 20:47:201632// Test that AddTransceiver transfers the send_encodings to the sender and they
1633// are retained after SetLocalDescription().
1634TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1635 auto caller = CreatePeerConnection();
1636
1637 RtpTransceiverInit init;
1638 init.send_encodings.emplace_back();
1639 init.send_encodings[0].active = false;
1640 init.send_encodings[0].max_bitrate_bps = 180000;
1641
1642 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1643 ASSERT_TRUE(result.ok());
1644
1645 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1646 EXPECT_FALSE(init_send_encodings[0].active);
1647 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1648
1649 auto parameters = result.value()->sender()->GetParameters();
1650 EXPECT_FALSE(parameters.encodings[0].active);
1651 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1652
1653 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1654
1655 parameters = result.value()->sender()->GetParameters();
1656 EXPECT_FALSE(parameters.encodings[0].active);
1657 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1658}
1659
Steve Antone831b8c2018-02-01 20:22:161660// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1661// options for this kind of signaling: media section based (a=msid) and ssrc
1662// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1663// we want to ensure compatibility with older Plan B endpoints that might expect
1664// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1665// types but answers with the same type as the offer.
1666
Steve Anton3172c032018-05-03 22:30:181667class PeerConnectionMsidSignalingTest
1668 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 20:22:161669
1670TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1671 auto caller = CreatePeerConnectionWithUnifiedPlan();
1672 caller->AddAudioTrack("caller_audio");
1673 auto callee = CreatePeerConnectionWithUnifiedPlan();
1674 callee->AddAudioTrack("callee_audio");
1675
1676 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1677
1678 // Offer should have had both a=msid and a=ssrc MSID lines.
1679 auto* offer = callee->pc()->remote_description();
1680 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1681 cricket::kMsidSignalingSsrcAttribute),
1682 offer->description()->msid_signaling());
1683
1684 // Answer should have had only a=msid lines.
1685 auto* answer = caller->pc()->remote_description();
1686 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1687 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 22:48:001688 // Check that this is counted correctly
Ying Wangef3998f2019-12-09 12:06:531689 EXPECT_METRIC_THAT(
1690 metrics::Samples("WebRTC.PeerConnection.SdpSemanticNegotiated"),
1691 ElementsAre(Pair(kSdpSemanticNegotiatedUnifiedPlan, 2)));
Steve Antone831b8c2018-02-01 20:22:161692}
1693
1694TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1695 auto caller = CreatePeerConnectionWithPlanB();
1696 caller->AddAudioTrack("caller_audio");
1697 auto callee = CreatePeerConnectionWithUnifiedPlan();
1698 callee->AddAudioTrack("callee_audio");
1699
1700 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1701
1702 // Offer should have only a=ssrc MSID lines.
1703 auto* offer = callee->pc()->remote_description();
1704 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1705 offer->description()->msid_signaling());
1706
1707 // Answer should have only a=ssrc MSID lines to match the offer.
1708 auto* answer = caller->pc()->remote_description();
1709 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1710 answer->description()->msid_signaling());
1711}
1712
Seth Hampson5b4f0752018-04-02 23:31:361713// This tests that a Plan B endpoint appropriately sets the remote description
1714// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1715// that signal no stream ids or multiple stream ids we expect that the Plan B
1716// endpoint always has exactly one media stream per track.
1717TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1718 const std::string kStreamId1 = "audio_stream_1";
1719 const std::string kStreamId2 = "audio_stream_2";
1720
1721 auto caller = CreatePeerConnectionWithUnifiedPlan();
1722 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1723 caller->AddVideoTrack("caller_video", {});
1724 auto callee = CreatePeerConnectionWithPlanB();
1725 callee->AddAudioTrack("callee_audio");
1726 caller->AddVideoTrack("callee_video");
1727
1728 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1729
1730 // Offer should have had both a=msid and a=ssrc MSID lines.
1731 auto* offer = callee->pc()->remote_description();
1732 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1733 cricket::kMsidSignalingSsrcAttribute),
1734 offer->description()->msid_signaling());
1735
1736 // Callee should always have 1 stream for all of it's receivers.
1737 const auto& track_events = callee->observer()->add_track_events_;
1738 ASSERT_EQ(2u, track_events.size());
1739 ASSERT_EQ(1u, track_events[0].streams.size());
1740 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1741 ASSERT_EQ(1u, track_events[1].streams.size());
1742 // This autogenerated a stream id for the empty one signalled.
1743 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1744}
1745
Steve Antone831b8c2018-02-01 20:22:161746TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1747 auto caller = CreatePeerConnectionWithUnifiedPlan();
1748 caller->AddAudioTrack("caller_audio");
1749 auto callee = CreatePeerConnectionWithUnifiedPlan();
1750 callee->AddAudioTrack("callee_audio");
1751
1752 auto offer = caller->CreateOffer();
1753 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1754 // section only.
1755 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1756
1757 ASSERT_TRUE(
1758 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1759 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1760
1761 // Answer should have only a=msid to match the offer.
1762 auto answer = callee->CreateAnswer();
1763 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1764 answer->description()->msid_signaling());
1765}
1766
Steve Anton8e20f172018-03-06 18:55:041767// Test that the correct UMA metrics are reported for simple/complex SDP.
1768
Steve Anton3172c032018-05-03 22:30:181769class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 18:55:041770
1771#ifdef HAVE_SCTP
1772TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1773 auto caller = CreatePeerConnectionWithUnifiedPlan();
1774 caller->CreateDataChannel("dc");
1775 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 18:55:041776
1777 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 19:54:531778 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 12:06:531779 EXPECT_METRIC_THAT(
1780 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1781 ElementsAre(Pair(kSdpFormatReceivedNoTracks, 1)));
Steve Anton8e20f172018-03-06 18:55:041782}
1783#endif // HAVE_SCTP
1784
1785TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1786 auto caller = CreatePeerConnectionWithUnifiedPlan();
1787 caller->AddAudioTrack("audio");
1788 caller->AddVideoTrack("video");
1789 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 18:55:041790
1791 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 19:54:531792 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 12:06:531793 EXPECT_METRIC_THAT(
1794 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1795 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 18:55:041796}
1797
1798TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1799 auto caller = CreatePeerConnectionWithPlanB();
1800 caller->AddVideoTrack("video"); // Video only.
1801 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 18:55:041802
1803 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Antonc1e6e862019-03-04 22:43:441804 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 12:06:531805 EXPECT_METRIC_THAT(
1806 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1807 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 18:55:041808}
1809
1810TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1811 auto caller = CreatePeerConnectionWithUnifiedPlan();
1812 caller->AddAudioTrack("audio1");
1813 caller->AddAudioTrack("audio2");
1814 caller->AddVideoTrack("video");
1815 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 18:55:041816
1817 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 19:54:531818 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 12:06:531819 EXPECT_METRIC_THAT(
1820 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1821 ElementsAre(Pair(kSdpFormatReceivedComplexUnifiedPlan, 1)));
Steve Anton8e20f172018-03-06 18:55:041822}
1823
1824TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1825 auto caller = CreatePeerConnectionWithPlanB();
1826 caller->AddVideoTrack("video1");
1827 caller->AddVideoTrack("video2");
1828 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 18:55:041829
Steve Antonba42e992018-04-09 21:10:011830 // This fails since Unified Plan cannot set a session description with
1831 // multiple "Plan B tracks" in the same media section. But we still expect the
1832 // SDP Format to be recorded.
1833 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 19:54:531834 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 12:06:531835 EXPECT_METRIC_THAT(
1836 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1837 ElementsAre(Pair(kSdpFormatReceivedComplexPlanB, 1)));
Steve Anton8e20f172018-03-06 18:55:041838}
1839
Henrik Boström91d039b2018-01-11 16:43:301840// Sender setups in a call.
1841
Steve Anton3172c032018-05-03 22:30:181842TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 16:43:301843 auto caller = CreatePeerConnection();
1844 auto callee = CreatePeerConnection();
1845
1846 auto track = caller->CreateAudioTrack("audio_track");
1847 auto sender1 = caller->AddTrack(track);
1848 ASSERT_TRUE(sender1);
1849 // We need to temporarily reset the track for the subsequent AddTrack() to
1850 // succeed.
1851 EXPECT_TRUE(sender1->SetTrack(nullptr));
1852 auto sender2 = caller->AddTrack(track);
1853 EXPECT_TRUE(sender2);
1854 EXPECT_TRUE(sender1->SetTrack(track));
1855
Steve Anton3172c032018-05-03 22:30:181856 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1857 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1858 // return true, and doing |callee->SetRemoteDescription()| should work.
1859 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1860 } else {
1861 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1862 }
Henrik Boström91d039b2018-01-11 16:43:301863}
1864
Guido Urdaneta70c2db12019-04-16 10:24:141865// This test exercises the code path that fires a NegotiationNeeded
1866// notification when the stream IDs of the local description differ from
Guido Urdaneta1ff16c82019-05-20 17:31:531867// the ones in the transceiver.
Guido Urdaneta70c2db12019-04-16 10:24:141868TEST_F(PeerConnectionRtpTestUnifiedPlan,
1869 ChangeAssociatedStreamsTriggersRenegotiation) {
1870 auto caller = CreatePeerConnection();
1871 auto callee = CreatePeerConnection();
1872
1873 RtpTransceiverInit init;
1874 init.direction = RtpTransceiverDirection::kSendRecv;
1875 auto transceiver =
1876 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 08:20:111877 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1878 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Guido Urdaneta70c2db12019-04-16 10:24:141879
1880 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 08:20:111881 caller->observer()->clear_legacy_renegotiation_needed();
1882 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 10:24:141883
Guido Urdaneta1ff16c82019-05-20 17:31:531884 transceiver->sender()->SetStreams({"stream3", "stream4", "stream5"});
Henrik Boströme574a312020-08-25 08:20:111885 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1886 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Guido Urdaneta1ff16c82019-05-20 17:31:531887
1888 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
1889 auto callee_streams = callee->pc()->GetReceivers()[0]->streams();
1890 ASSERT_EQ(3u, callee_streams.size());
1891 EXPECT_EQ("stream3", callee_streams[0]->id());
1892 EXPECT_EQ("stream4", callee_streams[1]->id());
1893 EXPECT_EQ("stream5", callee_streams[2]->id());
Guido Urdaneta70c2db12019-04-16 10:24:141894}
1895
Mirko Bonadeic84f6612019-01-31 11:20:571896INSTANTIATE_TEST_SUITE_P(PeerConnectionRtpTest,
1897 PeerConnectionRtpTest,
1898 Values(SdpSemantics::kPlanB,
1899 SdpSemantics::kUnifiedPlan));
Steve Anton3172c032018-05-03 22:30:181900
Steve Anton9158ef62017-11-27 21:01:521901} // namespace webrtc