Tightening visibility and removing a public_dep.
This CL aligns the visibility and the dependency between the _objc
and the _generic targets to the standard decided in:
https://codereview.webrtc.org/3001623003.
BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/3010133002
Cr-Original-Commit-Position: refs/heads/master@{#19687}
Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc
Cr-Mirrored-Commit: 9c296b3490a40491455061209fdf409ce5214b19
diff --git a/test/BUILD.gn b/test/BUILD.gn
index 4faff71..0858468 100644
--- a/test/BUILD.gn
+++ b/test/BUILD.gn
@@ -113,7 +113,7 @@
if (is_ios) {
rtc_source_set("test_support_objc") {
testonly = true
- visibility = [ ":*" ]
+ visibility = [ ":test_support" ]
sources = [
"ios/test_support.h",
"ios/test_support.mm",
@@ -349,7 +349,7 @@
if (is_ios) {
rtc_source_set("fileutils_objc") {
- visibility = [ ":*" ]
+ visibility = [ ":fileutils" ]
sources = [
"testsupport/iosfileutils.mm",
]
@@ -363,7 +363,12 @@
rtc_source_set("fileutils") {
testonly = true
- visibility = [ ":*" ]
+ visibility = [
+ ":fileutils_unittests",
+ ":test_support_test_output",
+ ":test_support",
+ ":video_test_support",
+ ]
sources = [
"testsupport/fileutils.cc",
"testsupport/fileutils.h",
@@ -394,8 +399,6 @@
}
rtc_source_set("run_test_interface") {
- testonly = true
- visibility = [ ":*" ]
sources = [
"run_test.h",
]
@@ -404,11 +407,11 @@
if (is_mac) {
rtc_source_set("run_test_objc") {
testonly = true
- visibility = [ ":*" ]
+ visibility = [ ":run_test" ]
sources = [
"mac/run_test.mm",
]
- public_deps = [
+ deps = [
":run_test_interface",
]
}
@@ -416,11 +419,11 @@
rtc_source_set("run_test_generic") {
testonly = true
- visibility = [ ":*" ]
+ visibility = [ ":run_test" ]
sources = [
"run_test.cc",
]
- public_deps = [
+ deps = [
":run_test_interface",
]
}
@@ -593,30 +596,25 @@
}
rtc_source_set("test_renderer") {
+ public_deps = [
+ ":test_renderer_generic",
+ ]
testonly = true
if (is_mac) {
- public_deps = [
- ":test_renderer_objc",
- ]
- } else {
- public_deps = [
- ":test_renderer_generic",
- ]
+ public_deps += [ ":test_renderer_objc" ]
}
}
if (is_mac) {
rtc_source_set("test_renderer_objc") {
testonly = true
- visibility = [ ":*" ]
+ visibility = [ ":test_renderer" ]
sources = [
"mac/video_renderer_mac.h",
"mac/video_renderer_mac.mm",
]
- public_deps = [
- ":test_renderer_generic",
- ]
deps = [
+ ":test_renderer_generic",
"../rtc_base:rtc_base_approved",
]
libs = [
@@ -633,7 +631,10 @@
rtc_source_set("test_renderer_generic") {
testonly = true
- visibility = [ ":*" ]
+ visibility = [
+ ":test_renderer",
+ ":test_renderer_objc",
+ ]
libs = []
sources = [
"linux/glx_renderer.cc",
diff --git a/video/BUILD.gn b/video/BUILD.gn
index f3bba0e..c93ef8c 100644
--- a/video/BUILD.gn
+++ b/video/BUILD.gn
@@ -165,6 +165,7 @@
"../system_wrappers:metrics_default",
"../test:field_trial",
"../test:run_test",
+ "../test:run_test_interface",
"../test:test_common",
"../test:test_renderer",
"../test:test_support",
@@ -189,6 +190,7 @@
"../system_wrappers:metrics_default",
"../test:field_trial",
"../test:run_test",
+ "../test:run_test_interface",
"../test:test_common",
"../test:test_renderer",
"../test:test_support",
@@ -218,6 +220,7 @@
"../test:field_trial",
"../test:rtp_test_utils",
"../test:run_test",
+ "../test:run_test_interface",
"../test:test_common",
"../test:test_renderer",
"../test:test_support",
