commit de7e2645d81d55d0265b6a95003648c1b20abb21
author ilnik <ilnik@webrtc.org> Wed Aug 23 07:44:27 2017
committer Commit Bot <commit-bot@chromium.org> Wed Aug 23 07:44:27 2017
tree 9699305791fd3dcad7ab673ade03d2b90ade60ea
parent 8fcb50d0748fe6ec3285a7004d2caccf1e0c9faf

Remove WebRTC-videocontenttypeextension field trial completely

BUG=webrtc:7420

Review-Url: https://codereview.webrtc.org/3003673002
Cr-Original-Commit-Position: refs/heads/master@{#19459}
Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc
Cr-Mirrored-Commit: 41cadbcb0a3535353a4b431b67c96798f8eed06d

video/end_to_end_tests.cc

diff --git a/video/end_to_end_tests.cc b/video/end_to_end_tests.cc
index 5ef5845..91a544c 100644
--- a/video/end_to_end_tests.cc
+++ b/video/end_to_end_tests.cc
@@ -2954,15 +2954,13 @@
     int num_frames_received_ GUARDED_BY(&crit_);
   } test;
 
-  test::ScopedFieldTrials override_field_trials(
-      "WebRTC-VideoContentTypeExtension/Enabled/");
   metrics::Reset();
 
   Call::Config send_config(test.GetSenderCallConfig());
   Call::Config recv_config(test.GetReceiverCallConfig());
   VideoEncoderConfig encoder_config_with_screenshare;
 
-  task_queue_.SendTask([this, &test, &override_field_trials, &send_config,
+  task_queue_.SendTask([this, &test, &send_config,
                         &recv_config, &encoder_config_with_screenshare]() {
     CreateSenderCall(send_config);
     CreateReceiverCall(recv_config);
@@ -3056,8 +3054,6 @@
   const bool kEnabledRtx = false;
   const bool kEnabledRed = false;
   const bool kScreenshare = true;
-  test::ScopedFieldTrials override_field_trials(
-      "WebRTC-VideoContentTypeExtension/Enabled/");
   VerifyHistogramStats(kEnabledRtx, kEnabledRed, kScreenshare);
 }
 

video/video_send_stream.cc

diff --git a/video/video_send_stream.cc b/video/video_send_stream.cc
index e1afdf0..4b75f95 100644
--- a/video/video_send_stream.cc
+++ b/video/video_send_stream.cc
@@ -740,10 +740,6 @@
     RTC_DCHECK_GE(id, 1);
     RTC_DCHECK_LE(id, 14);
     RTC_DCHECK(RtpExtension::IsSupportedForVideo(extension));
-    if (StringToRtpExtensionType(extension) == kRtpExtensionVideoContentType &&
-        !field_trial::IsEnabled("WebRTC-VideoContentTypeExtension")) {
-      continue;
-    }
     for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
       RTC_CHECK_EQ(0, rtp_rtcp->RegisterSendRtpHeaderExtension(
                           StringToRtpExtensionType(extension), id));

video/video_send_stream_tests.cc

diff --git a/video/video_send_stream_tests.cc b/video/video_send_stream_tests.cc
index 9db0b65..1944937 100644
--- a/video/video_send_stream_tests.cc
+++ b/video/video_send_stream_tests.cc
@@ -340,8 +340,6 @@
     }
   } test;
 
-  test::ScopedFieldTrials override_field_trials(
-      "WebRTC-VideoContentTypeExtension/Enabled/");
   RunBaseTest(&test);
 }