Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2021 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | #include "net/dcsctp/rx/data_tracker.h" |
| 11 | |
| 12 | #include <cstdint> |
| 13 | #include <initializer_list> |
| 14 | #include <memory> |
| 15 | |
| 16 | #include "absl/types/optional.h" |
| 17 | #include "api/array_view.h" |
Henrik Boström | b951dc6 | 2022-01-26 17:38:13 | [diff] [blame] | 18 | #include "api/task_queue/task_queue_base.h" |
Sergey Sukhanov | 3852698 | 2021-09-20 09:35:59 | [diff] [blame] | 19 | #include "net/dcsctp/common/handover_testing.h" |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 20 | #include "net/dcsctp/packet/chunk/sack_chunk.h" |
| 21 | #include "net/dcsctp/timer/fake_timeout.h" |
| 22 | #include "net/dcsctp/timer/timer.h" |
| 23 | #include "rtc_base/gunit.h" |
| 24 | #include "test/gmock.h" |
| 25 | |
| 26 | namespace dcsctp { |
| 27 | namespace { |
| 28 | using ::testing::ElementsAre; |
| 29 | using ::testing::IsEmpty; |
Victor Boivie | c09c581 | 2021-05-19 12:03:22 | [diff] [blame] | 30 | using ::testing::SizeIs; |
Victor Boivie | 3a45d32 | 2021-05-19 11:40:55 | [diff] [blame] | 31 | using ::testing::UnorderedElementsAre; |
Victor Boivie | 82cbbcc | 2023-11-08 15:31:44 | [diff] [blame] | 32 | using ::webrtc::TimeDelta; |
| 33 | using ::webrtc::Timestamp; |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 34 | |
| 35 | constexpr size_t kArwnd = 10000; |
Victor Boivie | c54f672 | 2021-04-13 09:23:16 | [diff] [blame] | 36 | constexpr TSN kInitialTSN(11); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 37 | |
| 38 | class DataTrackerTest : public testing::Test { |
| 39 | protected: |
| 40 | DataTrackerTest() |
| 41 | : timeout_manager_([this]() { return now_; }), |
Henrik Boström | b951dc6 | 2022-01-26 17:38:13 | [diff] [blame] | 42 | timer_manager_([this](webrtc::TaskQueueBase::DelayPrecision precision) { |
| 43 | return timeout_manager_.CreateTimeout(precision); |
| 44 | }), |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 45 | timer_(timer_manager_.CreateTimer( |
| 46 | "test/delayed_ack", |
Victor Boivie | 4397482 | 2023-10-26 14:24:30 | [diff] [blame] | 47 | []() { return TimeDelta::Zero(); }, |
| 48 | TimerOptions(TimeDelta::Zero()))), |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 49 | tracker_( |
| 50 | std::make_unique<DataTracker>("log: ", timer_.get(), kInitialTSN)) { |
| 51 | } |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 52 | |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 53 | void Observer(std::initializer_list<uint32_t> tsns, |
| 54 | bool expect_as_duplicate = false) { |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 55 | for (const uint32_t tsn : tsns) { |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 56 | if (expect_as_duplicate) { |
| 57 | EXPECT_FALSE( |
| 58 | tracker_->Observe(TSN(tsn), AnyDataChunk::ImmediateAckFlag(false))); |
| 59 | } else { |
| 60 | EXPECT_TRUE( |
| 61 | tracker_->Observe(TSN(tsn), AnyDataChunk::ImmediateAckFlag(false))); |
| 62 | } |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 63 | } |
| 64 | } |
| 65 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 66 | void HandoverTracker() { |
| 67 | EXPECT_TRUE(tracker_->GetHandoverReadiness().IsReady()); |
| 68 | DcSctpSocketHandoverState state; |
| 69 | tracker_->AddHandoverState(state); |
Sergey Sukhanov | 3852698 | 2021-09-20 09:35:59 | [diff] [blame] | 70 | g_handover_state_transformer_for_test(&state); |
Victor Boivie | 2cffde7 | 2022-06-27 20:35:37 | [diff] [blame] | 71 | tracker_ = |
| 72 | std::make_unique<DataTracker>("log: ", timer_.get(), kInitialTSN); |
| 73 | tracker_->RestoreFromState(state); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 74 | } |
| 75 | |
Victor Boivie | 82cbbcc | 2023-11-08 15:31:44 | [diff] [blame] | 76 | Timestamp now_ = Timestamp::Zero(); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 77 | FakeTimeoutManager timeout_manager_; |
| 78 | TimerManager timer_manager_; |
| 79 | std::unique_ptr<Timer> timer_; |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 80 | std::unique_ptr<DataTracker> tracker_; |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 81 | }; |
| 82 | |
| 83 | TEST_F(DataTrackerTest, Empty) { |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 84 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 85 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 86 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 87 | EXPECT_THAT(sack.duplicate_tsns(), IsEmpty()); |
| 88 | } |
| 89 | |
| 90 | TEST_F(DataTrackerTest, ObserverSingleInOrderPacket) { |
| 91 | Observer({11}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 92 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 93 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(11)); |
| 94 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 95 | EXPECT_THAT(sack.duplicate_tsns(), IsEmpty()); |
| 96 | } |
| 97 | |
| 98 | TEST_F(DataTrackerTest, ObserverManyInOrderMovesCumulativeTsnAck) { |
| 99 | Observer({11, 12, 13}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 100 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 101 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(13)); |
| 102 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 103 | EXPECT_THAT(sack.duplicate_tsns(), IsEmpty()); |
| 104 | } |
| 105 | |
| 106 | TEST_F(DataTrackerTest, ObserveOutOfOrderMovesCumulativeTsnAck) { |
| 107 | Observer({12, 13, 14, 11}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 108 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 109 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(14)); |
| 110 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 111 | EXPECT_THAT(sack.duplicate_tsns(), IsEmpty()); |
| 112 | } |
| 113 | |
| 114 | TEST_F(DataTrackerTest, SingleGap) { |
| 115 | Observer({12}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 116 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 117 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 118 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 2))); |
| 119 | EXPECT_THAT(sack.duplicate_tsns(), IsEmpty()); |
| 120 | } |
| 121 | |
| 122 | TEST_F(DataTrackerTest, ExampleFromRFC4960Section334) { |
| 123 | Observer({11, 12, 14, 15, 17}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 124 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 125 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(12)); |
| 126 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 3), |
| 127 | SackChunk::GapAckBlock(5, 5))); |
| 128 | EXPECT_THAT(sack.duplicate_tsns(), IsEmpty()); |
| 129 | } |
| 130 | |
| 131 | TEST_F(DataTrackerTest, AckAlreadyReceivedChunk) { |
| 132 | Observer({11}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 133 | SackChunk sack1 = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 134 | EXPECT_EQ(sack1.cumulative_tsn_ack(), TSN(11)); |
| 135 | EXPECT_THAT(sack1.gap_ack_blocks(), IsEmpty()); |
| 136 | |
| 137 | // Receive old chunk |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 138 | Observer({8}, /*expect_as_duplicate=*/true); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 139 | SackChunk sack2 = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 140 | EXPECT_EQ(sack2.cumulative_tsn_ack(), TSN(11)); |
| 141 | EXPECT_THAT(sack2.gap_ack_blocks(), IsEmpty()); |
| 142 | } |
| 143 | |
| 144 | TEST_F(DataTrackerTest, DoubleSendRetransmittedChunk) { |
| 145 | Observer({11, 13, 14, 15}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 146 | SackChunk sack1 = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 147 | EXPECT_EQ(sack1.cumulative_tsn_ack(), TSN(11)); |
| 148 | EXPECT_THAT(sack1.gap_ack_blocks(), |
| 149 | ElementsAre(SackChunk::GapAckBlock(2, 4))); |
| 150 | |
| 151 | // Fill in the hole. |
| 152 | Observer({12, 16, 17, 18}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 153 | SackChunk sack2 = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 154 | EXPECT_EQ(sack2.cumulative_tsn_ack(), TSN(18)); |
| 155 | EXPECT_THAT(sack2.gap_ack_blocks(), IsEmpty()); |
| 156 | |
| 157 | // Receive chunk 12 again. |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 158 | Observer({12}, /*expect_as_duplicate=*/true); |
| 159 | Observer({19, 20, 21}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 160 | SackChunk sack3 = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 161 | EXPECT_EQ(sack3.cumulative_tsn_ack(), TSN(21)); |
| 162 | EXPECT_THAT(sack3.gap_ack_blocks(), IsEmpty()); |
| 163 | } |
| 164 | |
| 165 | TEST_F(DataTrackerTest, ForwardTsnSimple) { |
| 166 | // Messages (11, 12, 13), (14, 15) - first message expires. |
| 167 | Observer({11, 12, 15}); |
| 168 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 169 | tracker_->HandleForwardTsn(TSN(13)); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 170 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 171 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 172 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(13)); |
| 173 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 2))); |
| 174 | } |
| 175 | |
| 176 | TEST_F(DataTrackerTest, ForwardTsnSkipsFromGapBlock) { |
| 177 | // Messages (11, 12, 13), (14, 15) - first message expires. |
| 178 | Observer({11, 12, 14}); |
| 179 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 180 | tracker_->HandleForwardTsn(TSN(13)); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 181 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 182 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 183 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(14)); |
| 184 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 185 | } |
| 186 | |
| 187 | TEST_F(DataTrackerTest, ExampleFromRFC3758) { |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 188 | tracker_->HandleForwardTsn(TSN(102)); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 189 | |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 190 | Observer({102}, /*expect_as_duplicate=*/true); |
| 191 | Observer({104, 105, 107}); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 192 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 193 | tracker_->HandleForwardTsn(TSN(103)); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 194 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 195 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 196 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(105)); |
| 197 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 2))); |
| 198 | } |
| 199 | |
| 200 | TEST_F(DataTrackerTest, EmptyAllAcks) { |
| 201 | Observer({11, 13, 14, 15}); |
| 202 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 203 | tracker_->HandleForwardTsn(TSN(100)); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 204 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 205 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 206 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(100)); |
| 207 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 208 | } |
| 209 | |
| 210 | TEST_F(DataTrackerTest, SetsArwndCorrectly) { |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 211 | SackChunk sack1 = tracker_->CreateSelectiveAck(/*a_rwnd=*/100); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 212 | EXPECT_EQ(sack1.a_rwnd(), 100u); |
| 213 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 214 | SackChunk sack2 = tracker_->CreateSelectiveAck(/*a_rwnd=*/101); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 215 | EXPECT_EQ(sack2.a_rwnd(), 101u); |
| 216 | } |
| 217 | |
| 218 | TEST_F(DataTrackerTest, WillIncreaseCumAckTsn) { |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 219 | EXPECT_EQ(tracker_->last_cumulative_acked_tsn(), TSN(10)); |
| 220 | EXPECT_FALSE(tracker_->will_increase_cum_ack_tsn(TSN(10))); |
| 221 | EXPECT_TRUE(tracker_->will_increase_cum_ack_tsn(TSN(11))); |
| 222 | EXPECT_FALSE(tracker_->will_increase_cum_ack_tsn(TSN(12))); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 223 | |
| 224 | Observer({11, 12, 13, 14, 15}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 225 | EXPECT_EQ(tracker_->last_cumulative_acked_tsn(), TSN(15)); |
| 226 | EXPECT_FALSE(tracker_->will_increase_cum_ack_tsn(TSN(15))); |
| 227 | EXPECT_TRUE(tracker_->will_increase_cum_ack_tsn(TSN(16))); |
| 228 | EXPECT_FALSE(tracker_->will_increase_cum_ack_tsn(TSN(17))); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 229 | } |
| 230 | |
| 231 | TEST_F(DataTrackerTest, ForceShouldSendSackImmediately) { |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 232 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 233 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 234 | tracker_->ForceImmediateSack(); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 235 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 236 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 237 | } |
Victor Boivie | c54f672 | 2021-04-13 09:23:16 | [diff] [blame] | 238 | |
| 239 | TEST_F(DataTrackerTest, WillAcceptValidTSNs) { |
| 240 | // The initial TSN is always one more than the last, which is our base. |
| 241 | TSN last_tsn = TSN(*kInitialTSN - 1); |
| 242 | int limit = static_cast<int>(DataTracker::kMaxAcceptedOutstandingFragments); |
| 243 | |
| 244 | for (int i = -limit; i <= limit; ++i) { |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 245 | EXPECT_TRUE(tracker_->IsTSNValid(TSN(*last_tsn + i))); |
Victor Boivie | c54f672 | 2021-04-13 09:23:16 | [diff] [blame] | 246 | } |
| 247 | } |
| 248 | |
| 249 | TEST_F(DataTrackerTest, WillNotAcceptInvalidTSNs) { |
| 250 | // The initial TSN is always one more than the last, which is our base. |
| 251 | TSN last_tsn = TSN(*kInitialTSN - 1); |
| 252 | |
| 253 | size_t limit = DataTracker::kMaxAcceptedOutstandingFragments; |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 254 | EXPECT_FALSE(tracker_->IsTSNValid(TSN(*last_tsn + limit + 1))); |
| 255 | EXPECT_FALSE(tracker_->IsTSNValid(TSN(*last_tsn - (limit + 1)))); |
| 256 | EXPECT_FALSE(tracker_->IsTSNValid(TSN(*last_tsn + 0x8000000))); |
| 257 | EXPECT_FALSE(tracker_->IsTSNValid(TSN(*last_tsn - 0x8000000))); |
Victor Boivie | c54f672 | 2021-04-13 09:23:16 | [diff] [blame] | 258 | } |
| 259 | |
Victor Boivie | 3a45d32 | 2021-05-19 11:40:55 | [diff] [blame] | 260 | TEST_F(DataTrackerTest, ReportSingleDuplicateTsns) { |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 261 | Observer({11, 12}); |
| 262 | Observer({11}, /*expect_as_duplicate=*/true); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 263 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 3a45d32 | 2021-05-19 11:40:55 | [diff] [blame] | 264 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(12)); |
| 265 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 266 | EXPECT_THAT(sack.duplicate_tsns(), UnorderedElementsAre(TSN(11))); |
| 267 | } |
| 268 | |
| 269 | TEST_F(DataTrackerTest, ReportMultipleDuplicateTsns) { |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 270 | Observer({11, 12, 13, 14}); |
| 271 | Observer({12, 13, 12, 13}, /*expect_as_duplicate=*/true); |
| 272 | Observer({15, 16}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 273 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 3a45d32 | 2021-05-19 11:40:55 | [diff] [blame] | 274 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(16)); |
| 275 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 276 | EXPECT_THAT(sack.duplicate_tsns(), UnorderedElementsAre(TSN(12), TSN(13))); |
| 277 | } |
| 278 | |
| 279 | TEST_F(DataTrackerTest, ReportDuplicateTsnsInGapAckBlocks) { |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 280 | Observer({11, /*12,*/ 13, 14}); |
| 281 | Observer({13, 14}, /*expect_as_duplicate=*/true); |
| 282 | Observer({15, 16}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 283 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 3a45d32 | 2021-05-19 11:40:55 | [diff] [blame] | 284 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(11)); |
| 285 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 5))); |
| 286 | EXPECT_THAT(sack.duplicate_tsns(), UnorderedElementsAre(TSN(13), TSN(14))); |
| 287 | } |
| 288 | |
| 289 | TEST_F(DataTrackerTest, ClearsDuplicateTsnsAfterCreatingSack) { |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 290 | Observer({11, 12, 13, 14}); |
| 291 | Observer({12, 13, 12, 13}, /*expect_as_duplicate=*/true); |
| 292 | Observer({15, 16}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 293 | SackChunk sack1 = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 3a45d32 | 2021-05-19 11:40:55 | [diff] [blame] | 294 | EXPECT_EQ(sack1.cumulative_tsn_ack(), TSN(16)); |
| 295 | EXPECT_THAT(sack1.gap_ack_blocks(), IsEmpty()); |
| 296 | EXPECT_THAT(sack1.duplicate_tsns(), UnorderedElementsAre(TSN(12), TSN(13))); |
| 297 | |
| 298 | Observer({17}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 299 | SackChunk sack2 = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 3a45d32 | 2021-05-19 11:40:55 | [diff] [blame] | 300 | EXPECT_EQ(sack2.cumulative_tsn_ack(), TSN(17)); |
| 301 | EXPECT_THAT(sack2.gap_ack_blocks(), IsEmpty()); |
| 302 | EXPECT_THAT(sack2.duplicate_tsns(), IsEmpty()); |
| 303 | } |
| 304 | |
Victor Boivie | c09c581 | 2021-05-19 12:03:22 | [diff] [blame] | 305 | TEST_F(DataTrackerTest, LimitsNumberOfDuplicatesReported) { |
| 306 | for (size_t i = 0; i < DataTracker::kMaxDuplicateTsnReported + 10; ++i) { |
| 307 | TSN tsn(11 + i); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 308 | tracker_->Observe(tsn, AnyDataChunk::ImmediateAckFlag(false)); |
| 309 | tracker_->Observe(tsn, AnyDataChunk::ImmediateAckFlag(false)); |
Victor Boivie | c09c581 | 2021-05-19 12:03:22 | [diff] [blame] | 310 | } |
| 311 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 312 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | c09c581 | 2021-05-19 12:03:22 | [diff] [blame] | 313 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 314 | EXPECT_THAT(sack.duplicate_tsns(), |
| 315 | SizeIs(DataTracker::kMaxDuplicateTsnReported)); |
| 316 | } |
| 317 | |
| 318 | TEST_F(DataTrackerTest, LimitsNumberOfGapAckBlocksReported) { |
| 319 | for (size_t i = 0; i < DataTracker::kMaxGapAckBlocksReported + 10; ++i) { |
| 320 | TSN tsn(11 + i * 2); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 321 | tracker_->Observe(tsn, AnyDataChunk::ImmediateAckFlag(false)); |
Victor Boivie | c09c581 | 2021-05-19 12:03:22 | [diff] [blame] | 322 | } |
| 323 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 324 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | c09c581 | 2021-05-19 12:03:22 | [diff] [blame] | 325 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(11)); |
| 326 | EXPECT_THAT(sack.gap_ack_blocks(), |
| 327 | SizeIs(DataTracker::kMaxGapAckBlocksReported)); |
| 328 | } |
| 329 | |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 330 | TEST_F(DataTrackerTest, SendsSackForFirstPacketObserved) { |
| 331 | Observer({11}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 332 | tracker_->ObservePacketEnd(); |
| 333 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 334 | EXPECT_FALSE(timer_->is_running()); |
| 335 | } |
| 336 | |
| 337 | TEST_F(DataTrackerTest, SendsSackEverySecondPacketWhenThereIsNoPacketLoss) { |
| 338 | Observer({11}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 339 | tracker_->ObservePacketEnd(); |
| 340 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 341 | EXPECT_FALSE(timer_->is_running()); |
| 342 | Observer({12}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 343 | tracker_->ObservePacketEnd(); |
| 344 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 345 | EXPECT_TRUE(timer_->is_running()); |
| 346 | Observer({13}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 347 | tracker_->ObservePacketEnd(); |
| 348 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 349 | EXPECT_FALSE(timer_->is_running()); |
| 350 | Observer({14}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 351 | tracker_->ObservePacketEnd(); |
| 352 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 353 | EXPECT_TRUE(timer_->is_running()); |
| 354 | Observer({15}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 355 | tracker_->ObservePacketEnd(); |
| 356 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 357 | EXPECT_FALSE(timer_->is_running()); |
| 358 | } |
| 359 | |
| 360 | TEST_F(DataTrackerTest, SendsSackEveryPacketOnPacketLoss) { |
| 361 | Observer({11}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 362 | tracker_->ObservePacketEnd(); |
| 363 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 364 | EXPECT_FALSE(timer_->is_running()); |
| 365 | Observer({13}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 366 | tracker_->ObservePacketEnd(); |
| 367 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 368 | EXPECT_FALSE(timer_->is_running()); |
| 369 | Observer({14}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 370 | tracker_->ObservePacketEnd(); |
| 371 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 372 | EXPECT_FALSE(timer_->is_running()); |
| 373 | Observer({15}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 374 | tracker_->ObservePacketEnd(); |
| 375 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 376 | EXPECT_FALSE(timer_->is_running()); |
| 377 | Observer({16}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 378 | tracker_->ObservePacketEnd(); |
| 379 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 380 | EXPECT_FALSE(timer_->is_running()); |
| 381 | // Fill the hole. |
| 382 | Observer({12}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 383 | tracker_->ObservePacketEnd(); |
| 384 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 385 | EXPECT_TRUE(timer_->is_running()); |
| 386 | // Goes back to every second packet |
| 387 | Observer({17}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 388 | tracker_->ObservePacketEnd(); |
| 389 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 390 | EXPECT_FALSE(timer_->is_running()); |
| 391 | Observer({18}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 392 | tracker_->ObservePacketEnd(); |
| 393 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 394 | EXPECT_TRUE(timer_->is_running()); |
| 395 | } |
| 396 | |
| 397 | TEST_F(DataTrackerTest, SendsSackOnDuplicateDataChunks) { |
| 398 | Observer({11}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 399 | tracker_->ObservePacketEnd(); |
| 400 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 401 | EXPECT_FALSE(timer_->is_running()); |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 402 | Observer({11}, /*expect_as_duplicate=*/true); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 403 | tracker_->ObservePacketEnd(); |
| 404 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 405 | EXPECT_FALSE(timer_->is_running()); |
| 406 | Observer({12}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 407 | tracker_->ObservePacketEnd(); |
| 408 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 409 | EXPECT_TRUE(timer_->is_running()); |
| 410 | // Goes back to every second packet |
| 411 | Observer({13}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 412 | tracker_->ObservePacketEnd(); |
| 413 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 414 | EXPECT_FALSE(timer_->is_running()); |
| 415 | // Duplicate again |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 416 | Observer({12}, /*expect_as_duplicate=*/true); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 417 | tracker_->ObservePacketEnd(); |
| 418 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
Victor Boivie | 5d4c3c5 | 2021-05-28 15:21:39 | [diff] [blame] | 419 | EXPECT_FALSE(timer_->is_running()); |
| 420 | } |
| 421 | |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 422 | TEST_F(DataTrackerTest, GapAckBlockAddSingleBlock) { |
| 423 | Observer({12}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 424 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 425 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 426 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 2))); |
| 427 | } |
| 428 | |
| 429 | TEST_F(DataTrackerTest, GapAckBlockAddsAnother) { |
| 430 | Observer({12}); |
| 431 | Observer({14}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 432 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 433 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 434 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 2), |
| 435 | SackChunk::GapAckBlock(4, 4))); |
| 436 | } |
| 437 | |
| 438 | TEST_F(DataTrackerTest, GapAckBlockAddsDuplicate) { |
| 439 | Observer({12}); |
Victor Boivie | 568bc23 | 2022-03-20 18:59:03 | [diff] [blame] | 440 | Observer({12}, /*expect_as_duplicate=*/true); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 441 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 442 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 443 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 2))); |
| 444 | EXPECT_THAT(sack.duplicate_tsns(), ElementsAre(TSN(12))); |
| 445 | } |
| 446 | |
| 447 | TEST_F(DataTrackerTest, GapAckBlockExpandsToRight) { |
| 448 | Observer({12}); |
| 449 | Observer({13}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 450 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 451 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 452 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 3))); |
| 453 | } |
| 454 | |
| 455 | TEST_F(DataTrackerTest, GapAckBlockExpandsToRightWithOther) { |
| 456 | Observer({12}); |
| 457 | Observer({20}); |
| 458 | Observer({30}); |
| 459 | Observer({21}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 460 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 461 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 462 | EXPECT_THAT(sack.gap_ack_blocks(), |
| 463 | ElementsAre(SackChunk::GapAckBlock(2, 2), // |
| 464 | SackChunk::GapAckBlock(10, 11), // |
| 465 | SackChunk::GapAckBlock(20, 20))); |
| 466 | } |
| 467 | |
| 468 | TEST_F(DataTrackerTest, GapAckBlockExpandsToLeft) { |
| 469 | Observer({13}); |
| 470 | Observer({12}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 471 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 472 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 473 | EXPECT_THAT(sack.gap_ack_blocks(), ElementsAre(SackChunk::GapAckBlock(2, 3))); |
| 474 | } |
| 475 | |
| 476 | TEST_F(DataTrackerTest, GapAckBlockExpandsToLeftWithOther) { |
| 477 | Observer({12}); |
| 478 | Observer({21}); |
| 479 | Observer({30}); |
| 480 | Observer({20}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 481 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 482 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 483 | EXPECT_THAT(sack.gap_ack_blocks(), |
| 484 | ElementsAre(SackChunk::GapAckBlock(2, 2), // |
| 485 | SackChunk::GapAckBlock(10, 11), // |
| 486 | SackChunk::GapAckBlock(20, 20))); |
| 487 | } |
| 488 | |
| 489 | TEST_F(DataTrackerTest, GapAckBlockExpandsToLRightAndMerges) { |
| 490 | Observer({12}); |
| 491 | Observer({20}); |
| 492 | Observer({22}); |
| 493 | Observer({30}); |
| 494 | Observer({21}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 495 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 496 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(10)); |
| 497 | EXPECT_THAT(sack.gap_ack_blocks(), |
| 498 | ElementsAre(SackChunk::GapAckBlock(2, 2), // |
| 499 | SackChunk::GapAckBlock(10, 12), // |
| 500 | SackChunk::GapAckBlock(20, 20))); |
| 501 | } |
| 502 | |
| 503 | TEST_F(DataTrackerTest, GapAckBlockMergesManyBlocksIntoOne) { |
| 504 | Observer({22}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 505 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 506 | ElementsAre(SackChunk::GapAckBlock(12, 12))); |
| 507 | Observer({30}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 508 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 509 | ElementsAre(SackChunk::GapAckBlock(12, 12), // |
| 510 | SackChunk::GapAckBlock(20, 20))); |
| 511 | Observer({24}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 512 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 513 | ElementsAre(SackChunk::GapAckBlock(12, 12), // |
| 514 | SackChunk::GapAckBlock(14, 14), // |
| 515 | SackChunk::GapAckBlock(20, 20))); |
| 516 | Observer({28}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 517 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 518 | ElementsAre(SackChunk::GapAckBlock(12, 12), // |
| 519 | SackChunk::GapAckBlock(14, 14), // |
| 520 | SackChunk::GapAckBlock(18, 18), // |
| 521 | SackChunk::GapAckBlock(20, 20))); |
| 522 | Observer({26}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 523 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 524 | ElementsAre(SackChunk::GapAckBlock(12, 12), // |
| 525 | SackChunk::GapAckBlock(14, 14), // |
| 526 | SackChunk::GapAckBlock(16, 16), // |
| 527 | SackChunk::GapAckBlock(18, 18), // |
| 528 | SackChunk::GapAckBlock(20, 20))); |
| 529 | Observer({29}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 530 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 531 | ElementsAre(SackChunk::GapAckBlock(12, 12), // |
| 532 | SackChunk::GapAckBlock(14, 14), // |
| 533 | SackChunk::GapAckBlock(16, 16), // |
| 534 | SackChunk::GapAckBlock(18, 20))); |
| 535 | Observer({23}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 536 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 537 | ElementsAre(SackChunk::GapAckBlock(12, 14), // |
| 538 | SackChunk::GapAckBlock(16, 16), // |
| 539 | SackChunk::GapAckBlock(18, 20))); |
| 540 | Observer({27}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 541 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 542 | ElementsAre(SackChunk::GapAckBlock(12, 14), // |
| 543 | SackChunk::GapAckBlock(16, 20))); |
| 544 | |
| 545 | Observer({25}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 546 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 547 | ElementsAre(SackChunk::GapAckBlock(12, 20))); |
| 548 | Observer({20}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 549 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 550 | ElementsAre(SackChunk::GapAckBlock(10, 10), // |
| 551 | SackChunk::GapAckBlock(12, 20))); |
| 552 | Observer({32}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 553 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 554 | ElementsAre(SackChunk::GapAckBlock(10, 10), // |
| 555 | SackChunk::GapAckBlock(12, 20), // |
| 556 | SackChunk::GapAckBlock(22, 22))); |
| 557 | Observer({21}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 558 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 559 | ElementsAre(SackChunk::GapAckBlock(10, 20), // |
| 560 | SackChunk::GapAckBlock(22, 22))); |
| 561 | Observer({31}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 562 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 563 | ElementsAre(SackChunk::GapAckBlock(10, 22))); |
| 564 | } |
| 565 | |
| 566 | TEST_F(DataTrackerTest, GapAckBlockRemoveBeforeCumAckTsn) { |
| 567 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 568 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 569 | tracker_->HandleForwardTsn(TSN(8)); |
| 570 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(10)); |
| 571 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 572 | ElementsAre(SackChunk::GapAckBlock(2, 4), // |
| 573 | SackChunk::GapAckBlock(10, 12), |
| 574 | SackChunk::GapAckBlock(20, 21))); |
| 575 | } |
| 576 | |
| 577 | TEST_F(DataTrackerTest, GapAckBlockRemoveBeforeFirstBlock) { |
| 578 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 579 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 580 | tracker_->HandleForwardTsn(TSN(11)); |
| 581 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(14)); |
| 582 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 583 | ElementsAre(SackChunk::GapAckBlock(6, 8), // |
| 584 | SackChunk::GapAckBlock(16, 17))); |
| 585 | } |
| 586 | |
| 587 | TEST_F(DataTrackerTest, GapAckBlockRemoveAtBeginningOfFirstBlock) { |
| 588 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 589 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 590 | tracker_->HandleForwardTsn(TSN(12)); |
| 591 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(14)); |
| 592 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 593 | ElementsAre(SackChunk::GapAckBlock(6, 8), // |
| 594 | SackChunk::GapAckBlock(16, 17))); |
| 595 | } |
| 596 | |
| 597 | TEST_F(DataTrackerTest, GapAckBlockRemoveAtMiddleOfFirstBlock) { |
| 598 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 599 | tracker_->HandleForwardTsn(TSN(13)); |
| 600 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(14)); |
| 601 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 602 | ElementsAre(SackChunk::GapAckBlock(6, 8), // |
| 603 | SackChunk::GapAckBlock(16, 17))); |
| 604 | } |
| 605 | |
| 606 | TEST_F(DataTrackerTest, GapAckBlockRemoveAtEndOfFirstBlock) { |
| 607 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 608 | tracker_->HandleForwardTsn(TSN(14)); |
| 609 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(14)); |
| 610 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 611 | ElementsAre(SackChunk::GapAckBlock(6, 8), // |
| 612 | SackChunk::GapAckBlock(16, 17))); |
| 613 | } |
| 614 | |
| 615 | TEST_F(DataTrackerTest, GapAckBlockRemoveRightAfterFirstBlock) { |
| 616 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 617 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 618 | tracker_->HandleForwardTsn(TSN(18)); |
| 619 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(18)); |
| 620 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 621 | ElementsAre(SackChunk::GapAckBlock(2, 4), // |
| 622 | SackChunk::GapAckBlock(12, 13))); |
| 623 | } |
| 624 | |
| 625 | TEST_F(DataTrackerTest, GapAckBlockRemoveRightBeforeSecondBlock) { |
| 626 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 627 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 628 | tracker_->HandleForwardTsn(TSN(19)); |
| 629 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(22)); |
| 630 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 631 | ElementsAre(SackChunk::GapAckBlock(8, 9))); |
| 632 | } |
| 633 | |
| 634 | TEST_F(DataTrackerTest, GapAckBlockRemoveRightAtStartOfSecondBlock) { |
| 635 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 636 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 637 | tracker_->HandleForwardTsn(TSN(20)); |
| 638 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(22)); |
| 639 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 640 | ElementsAre(SackChunk::GapAckBlock(8, 9))); |
| 641 | } |
| 642 | |
| 643 | TEST_F(DataTrackerTest, GapAckBlockRemoveRightAtMiddleOfSecondBlock) { |
| 644 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 645 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 646 | tracker_->HandleForwardTsn(TSN(21)); |
| 647 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(22)); |
| 648 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 649 | ElementsAre(SackChunk::GapAckBlock(8, 9))); |
| 650 | } |
| 651 | |
| 652 | TEST_F(DataTrackerTest, GapAckBlockRemoveRightAtEndOfSecondBlock) { |
| 653 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 654 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 655 | tracker_->HandleForwardTsn(TSN(22)); |
| 656 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(22)); |
| 657 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 658 | ElementsAre(SackChunk::GapAckBlock(8, 9))); |
| 659 | } |
| 660 | |
| 661 | TEST_F(DataTrackerTest, GapAckBlockRemoveeFarAfterAllBlocks) { |
| 662 | Observer({12, 13, 14, 20, 21, 22, 30, 31}); |
| 663 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 664 | tracker_->HandleForwardTsn(TSN(40)); |
| 665 | EXPECT_EQ(tracker_->CreateSelectiveAck(kArwnd).cumulative_tsn_ack(), TSN(40)); |
| 666 | EXPECT_THAT(tracker_->CreateSelectiveAck(kArwnd).gap_ack_blocks(), IsEmpty()); |
Victor Boivie | 27d2be3 | 2021-05-29 19:20:12 | [diff] [blame] | 667 | } |
| 668 | |
Sergey Sukhanov | 225cd47 | 2021-09-14 20:08:53 | [diff] [blame] | 669 | TEST_F(DataTrackerTest, HandoverEmpty) { |
| 670 | HandoverTracker(); |
| 671 | Observer({11}); |
| 672 | SackChunk sack = tracker_->CreateSelectiveAck(kArwnd); |
| 673 | EXPECT_EQ(sack.cumulative_tsn_ack(), TSN(11)); |
| 674 | EXPECT_THAT(sack.gap_ack_blocks(), IsEmpty()); |
| 675 | } |
| 676 | |
| 677 | TEST_F(DataTrackerTest, |
| 678 | HandoverWhileSendingSackEverySecondPacketWhenThereIsNoPacketLoss) { |
| 679 | Observer({11}); |
| 680 | tracker_->ObservePacketEnd(); |
| 681 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 682 | |
| 683 | HandoverTracker(); |
| 684 | |
| 685 | Observer({12}); |
| 686 | tracker_->ObservePacketEnd(); |
| 687 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
| 688 | Observer({13}); |
| 689 | tracker_->ObservePacketEnd(); |
| 690 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 691 | EXPECT_FALSE(timer_->is_running()); |
| 692 | Observer({14}); |
| 693 | tracker_->ObservePacketEnd(); |
| 694 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
| 695 | EXPECT_TRUE(timer_->is_running()); |
| 696 | Observer({15}); |
| 697 | tracker_->ObservePacketEnd(); |
| 698 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 699 | EXPECT_FALSE(timer_->is_running()); |
| 700 | } |
| 701 | |
| 702 | TEST_F(DataTrackerTest, HandoverWhileSendingSackEveryPacketOnPacketLoss) { |
| 703 | Observer({11}); |
| 704 | tracker_->ObservePacketEnd(); |
| 705 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 706 | Observer({13}); |
| 707 | EXPECT_EQ(tracker_->GetHandoverReadiness(), |
| 708 | HandoverReadinessStatus().Add( |
| 709 | HandoverUnreadinessReason::kDataTrackerTsnBlocksPending)); |
| 710 | tracker_->ObservePacketEnd(); |
| 711 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 712 | Observer({14}); |
| 713 | tracker_->ObservePacketEnd(); |
| 714 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 715 | EXPECT_EQ(tracker_->GetHandoverReadiness(), |
| 716 | HandoverReadinessStatus( |
| 717 | HandoverUnreadinessReason::kDataTrackerTsnBlocksPending)); |
| 718 | Observer({15}); |
| 719 | tracker_->ObservePacketEnd(); |
| 720 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 721 | Observer({16}); |
| 722 | tracker_->ObservePacketEnd(); |
| 723 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 724 | // Fill the hole. |
| 725 | Observer({12}); |
| 726 | tracker_->ObservePacketEnd(); |
| 727 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
| 728 | // Goes back to every second packet |
| 729 | Observer({17}); |
| 730 | tracker_->ObservePacketEnd(); |
| 731 | EXPECT_TRUE(tracker_->ShouldSendAck()); |
| 732 | |
| 733 | HandoverTracker(); |
| 734 | |
| 735 | Observer({18}); |
| 736 | tracker_->ObservePacketEnd(); |
| 737 | EXPECT_FALSE(tracker_->ShouldSendAck()); |
| 738 | EXPECT_TRUE(timer_->is_running()); |
| 739 | } |
Victor Boivie | a557468 | 2023-09-25 11:32:59 | [diff] [blame] | 740 | |
| 741 | TEST_F(DataTrackerTest, DoesNotAcceptDataBeforeForwardTsn) { |
| 742 | Observer({12, 13, 14, 15, 17}); |
| 743 | tracker_->ObservePacketEnd(); |
| 744 | |
| 745 | tracker_->HandleForwardTsn(TSN(13)); |
| 746 | |
| 747 | EXPECT_FALSE(tracker_->Observe(TSN(11))); |
| 748 | } |
| 749 | |
| 750 | TEST_F(DataTrackerTest, DoesNotAcceptDataAtForwardTsn) { |
| 751 | Observer({12, 13, 14, 15, 17}); |
| 752 | tracker_->ObservePacketEnd(); |
| 753 | |
| 754 | tracker_->HandleForwardTsn(TSN(16)); |
| 755 | |
| 756 | EXPECT_FALSE(tracker_->Observe(TSN(16))); |
| 757 | } |
| 758 | |
| 759 | TEST_F(DataTrackerTest, DoesNotAcceptDataBeforeCumAckTsn) { |
| 760 | EXPECT_EQ(kInitialTSN, TSN(11)); |
| 761 | EXPECT_FALSE(tracker_->Observe(TSN(10))); |
| 762 | } |
| 763 | |
| 764 | TEST_F(DataTrackerTest, DoesNotAcceptContiguousDuplicateData) { |
| 765 | EXPECT_EQ(kInitialTSN, TSN(11)); |
| 766 | EXPECT_TRUE(tracker_->Observe(TSN(11))); |
| 767 | EXPECT_FALSE(tracker_->Observe(TSN(11))); |
| 768 | EXPECT_TRUE(tracker_->Observe(TSN(12))); |
| 769 | EXPECT_FALSE(tracker_->Observe(TSN(12))); |
| 770 | EXPECT_FALSE(tracker_->Observe(TSN(11))); |
| 771 | EXPECT_FALSE(tracker_->Observe(TSN(10))); |
| 772 | } |
| 773 | |
| 774 | TEST_F(DataTrackerTest, DoesNotAcceptGapsWithDuplicateData) { |
| 775 | EXPECT_EQ(kInitialTSN, TSN(11)); |
| 776 | EXPECT_TRUE(tracker_->Observe(TSN(11))); |
| 777 | EXPECT_FALSE(tracker_->Observe(TSN(11))); |
| 778 | |
| 779 | EXPECT_TRUE(tracker_->Observe(TSN(14))); |
| 780 | EXPECT_FALSE(tracker_->Observe(TSN(14))); |
| 781 | |
| 782 | EXPECT_TRUE(tracker_->Observe(TSN(13))); |
| 783 | EXPECT_FALSE(tracker_->Observe(TSN(13))); |
| 784 | |
| 785 | EXPECT_TRUE(tracker_->Observe(TSN(12))); |
| 786 | EXPECT_FALSE(tracker_->Observe(TSN(12))); |
| 787 | } |
| 788 | |
Victor Boivie | b506d68 | 2023-11-30 12:06:03 | [diff] [blame] | 789 | TEST_F(DataTrackerTest, NotReadyForHandoverWhenHavingTsnGaps) { |
| 790 | tracker_->Observe(TSN(10)); |
| 791 | tracker_->Observe(TSN(12)); |
| 792 | EXPECT_EQ(tracker_->GetHandoverReadiness(), |
| 793 | HandoverReadinessStatus().Add( |
| 794 | HandoverUnreadinessReason::kDataTrackerTsnBlocksPending)); |
| 795 | |
| 796 | tracker_->Observe(TSN(11)); |
| 797 | EXPECT_EQ(tracker_->GetHandoverReadiness(), HandoverReadinessStatus()); |
| 798 | } |
| 799 | |
Victor Boivie | b2d539b | 2021-04-01 21:36:03 | [diff] [blame] | 800 | } // namespace |
| 801 | } // namespace dcsctp |