pbos@webrtc.org | 119a1cc | 2013-08-20 13:14:07 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
henrik.lundin@webrtc.org | 1a3a6e5 | 2013-10-28 10:16:14 | [diff] [blame] | 10 | #include <algorithm> // max |
kwiberg | 27f982b | 2016-03-01 19:52:33 | [diff] [blame] | 11 | #include <memory> |
magjed@webrtc.org | 2d2a30c | 2015-03-24 12:37:36 | [diff] [blame] | 12 | #include <vector> |
henrik.lundin@webrtc.org | 1a3a6e5 | 2013-10-28 10:16:14 | [diff] [blame] | 13 | |
Steve Anton | 40d5533 | 2019-01-07 18:21:47 | [diff] [blame] | 14 | #include "absl/memory/memory.h" |
Artem Titov | 46c4e60 | 2018-08-17 12:26:54 | [diff] [blame] | 15 | #include "api/test/simulated_network.h" |
Niels Möller | 4dc66c5 | 2018-10-05 12:17:58 | [diff] [blame] | 16 | #include "api/video/encoded_image.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 17 | #include "call/call.h" |
Artem Titov | 4e199e9 | 2018-08-20 11:30:39 | [diff] [blame] | 18 | #include "call/fake_network_pipe.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 19 | #include "call/rtp_transport_controller_send.h" |
Artem Titov | 4e199e9 | 2018-08-20 11:30:39 | [diff] [blame] | 20 | #include "call/simulated_network.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 21 | #include "modules/rtp_rtcp/include/rtp_header_parser.h" |
| 22 | #include "modules/rtp_rtcp/include/rtp_rtcp.h" |
| 23 | #include "modules/rtp_rtcp/source/rtcp_sender.h" |
| 24 | #include "modules/rtp_rtcp/source/rtp_format_vp9.h" |
| 25 | #include "modules/video_coding/codecs/vp8/include/vp8.h" |
| 26 | #include "modules/video_coding/codecs/vp9/include/vp9.h" |
| 27 | #include "rtc_base/bind.h" |
| 28 | #include "rtc_base/checks.h" |
| 29 | #include "rtc_base/criticalsection.h" |
| 30 | #include "rtc_base/event.h" |
Sebastian Jansson | cabe383 | 2018-01-12 09:54:18 | [diff] [blame] | 31 | #include "rtc_base/experiments/alr_experiment.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 32 | #include "rtc_base/logging.h" |
| 33 | #include "rtc_base/platform_thread.h" |
| 34 | #include "rtc_base/rate_limiter.h" |
| 35 | #include "rtc_base/timeutils.h" |
| 36 | #include "system_wrappers/include/sleep.h" |
| 37 | #include "test/call_test.h" |
| 38 | #include "test/configurable_frame_size_encoder.h" |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 39 | #include "test/fake_encoder.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 40 | #include "test/fake_texture_frame.h" |
| 41 | #include "test/field_trial.h" |
| 42 | #include "test/frame_generator.h" |
| 43 | #include "test/frame_generator_capturer.h" |
| 44 | #include "test/frame_utils.h" |
Danil Chapovalov | 45d725d | 2018-02-19 18:09:53 | [diff] [blame] | 45 | #include "test/gmock.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 46 | #include "test/gtest.h" |
| 47 | #include "test/null_transport.h" |
| 48 | #include "test/rtcp_packet_parser.h" |
| 49 | #include "test/testsupport/perf_test.h" |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 50 | #include "test/video_encoder_proxy_factory.h" |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 51 | |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 52 | #include "call/video_send_stream.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 53 | #include "video/send_statistics_proxy.h" |
| 54 | #include "video/transport_adapter.h" |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 55 | #include "video/video_send_stream.h" |
pbos@webrtc.org | 119a1cc | 2013-08-20 13:14:07 | [diff] [blame] | 56 | |
| 57 | namespace webrtc { |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 58 | namespace test { |
| 59 | class VideoSendStreamPeer { |
| 60 | public: |
| 61 | explicit VideoSendStreamPeer(webrtc::VideoSendStream* base_class_stream) |
| 62 | : internal_stream_( |
| 63 | static_cast<internal::VideoSendStream*>(base_class_stream)) {} |
Danil Chapovalov | b9b146c | 2018-06-15 10:28:07 | [diff] [blame] | 64 | absl::optional<float> GetPacingFactorOverride() const { |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 65 | return internal_stream_->GetPacingFactorOverride(); |
| 66 | } |
| 67 | |
| 68 | private: |
| 69 | internal::VideoSendStream const* const internal_stream_; |
| 70 | }; |
| 71 | } // namespace test |
pbos@webrtc.org | 119a1cc | 2013-08-20 13:14:07 | [diff] [blame] | 72 | |
Jiawei Ou | 8b5d9d8 | 2018-11-16 00:44:37 | [diff] [blame] | 73 | namespace { |
| 74 | constexpr int64_t kRtcpIntervalMs = 1000; |
| 75 | |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 76 | enum VideoFormat { |
| 77 | kGeneric, |
| 78 | kVP8, |
| 79 | }; |
Jiawei Ou | 8b5d9d8 | 2018-11-16 00:44:37 | [diff] [blame] | 80 | } // namespace |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 81 | |
Miguel Casas-Sanchez | 4765070 | 2015-05-30 00:21:40 | [diff] [blame] | 82 | VideoFrame CreateVideoFrame(int width, int height, uint8_t data); |
wuchengli@chromium.org | f425b55 | 2014-06-20 12:04:05 | [diff] [blame] | 83 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 84 | class VideoSendStreamTest : public test::CallTest, |
| 85 | public testing::WithParamInterface<std::string> { |
| 86 | public: |
| 87 | VideoSendStreamTest() : field_trial_(GetParam()) {} |
| 88 | |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 89 | protected: |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 90 | void TestNackRetransmission(uint32_t retransmit_ssrc, |
stefan@webrtc.org | cb254aa | 2014-06-12 15:12:25 | [diff] [blame] | 91 | uint8_t retransmit_payload_type); |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 92 | void TestPacketFragmentationSize(VideoFormat format, bool with_fec); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 93 | |
| 94 | void TestVp9NonFlexMode(uint8_t num_temporal_layers, |
| 95 | uint8_t num_spatial_layers); |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 96 | |
| 97 | void TestRequestSourceRotateVideo(bool support_orientation_ext); |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 98 | |
| 99 | private: |
| 100 | test::ScopedFieldTrials field_trial_; |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 101 | }; |
| 102 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 103 | INSTANTIATE_TEST_CASE_P(Default, VideoSendStreamTest, ::testing::Values("")); |
| 104 | |
| 105 | INSTANTIATE_TEST_CASE_P( |
| 106 | TaskQueueTrial, |
| 107 | VideoSendStreamTest, |
| 108 | ::testing::Values("WebRTC-TaskQueueCongestionControl/Enabled/")); |
| 109 | |
| 110 | TEST_P(VideoSendStreamTest, CanStartStartedStream) { |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 111 | task_queue_.SendTask([this]() { |
Sebastian Jansson | 8e6602f | 2018-07-13 08:43:20 | [diff] [blame] | 112 | CreateSenderCall(); |
pbos@webrtc.org | f777cf2 | 2014-01-10 18:47:32 | [diff] [blame] | 113 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 114 | test::NullTransport transport; |
| 115 | CreateSendConfig(1, 0, 0, &transport); |
| 116 | CreateVideoStreams(); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 117 | GetVideoSendStream()->Start(); |
| 118 | GetVideoSendStream()->Start(); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 119 | DestroyStreams(); |
| 120 | DestroyCalls(); |
| 121 | }); |
pbos@webrtc.org | f777cf2 | 2014-01-10 18:47:32 | [diff] [blame] | 122 | } |
| 123 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 124 | TEST_P(VideoSendStreamTest, CanStopStoppedStream) { |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 125 | task_queue_.SendTask([this]() { |
Sebastian Jansson | 8e6602f | 2018-07-13 08:43:20 | [diff] [blame] | 126 | CreateSenderCall(); |
pbos@webrtc.org | f777cf2 | 2014-01-10 18:47:32 | [diff] [blame] | 127 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 128 | test::NullTransport transport; |
| 129 | CreateSendConfig(1, 0, 0, &transport); |
| 130 | CreateVideoStreams(); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 131 | GetVideoSendStream()->Stop(); |
| 132 | GetVideoSendStream()->Stop(); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 133 | DestroyStreams(); |
| 134 | DestroyCalls(); |
| 135 | }); |
pbos@webrtc.org | f777cf2 | 2014-01-10 18:47:32 | [diff] [blame] | 136 | } |
| 137 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 138 | TEST_P(VideoSendStreamTest, SupportsCName) { |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 139 | static std::string kCName = "PjQatC14dGfbVwGPUOA9IH7RlsFDbWl4AhXEiDsBizo="; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 140 | class CNameObserver : public test::SendTest { |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 141 | public: |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 142 | CNameObserver() : SendTest(kDefaultTimeoutMs) {} |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 143 | |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 144 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 145 | Action OnSendRtcp(const uint8_t* packet, size_t length) override { |
danilchap | 3dc929e | 2016-11-02 15:21:59 | [diff] [blame] | 146 | test::RtcpPacketParser parser; |
| 147 | EXPECT_TRUE(parser.Parse(packet, length)); |
| 148 | if (parser.sdes()->num_packets() > 0) { |
| 149 | EXPECT_EQ(1u, parser.sdes()->chunks().size()); |
| 150 | EXPECT_EQ(kCName, parser.sdes()->chunks()[0].cname); |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 151 | |
danilchap | 3dc929e | 2016-11-02 15:21:59 | [diff] [blame] | 152 | observation_complete_.Set(); |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 153 | } |
| 154 | |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 155 | return SEND_PACKET; |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 156 | } |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 157 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 158 | void ModifyVideoConfigs( |
| 159 | VideoSendStream::Config* send_config, |
| 160 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 161 | VideoEncoderConfig* encoder_config) override { |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 162 | send_config->rtp.c_name = kCName; |
| 163 | } |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 164 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 165 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 166 | EXPECT_TRUE(Wait()) << "Timed out while waiting for RTCP with CNAME."; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 167 | } |
| 168 | } test; |
pbos@webrtc.org | 013d994 | 2013-08-22 09:42:17 | [diff] [blame] | 169 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 170 | RunBaseTest(&test); |
pbos@webrtc.org | 119a1cc | 2013-08-20 13:14:07 | [diff] [blame] | 171 | } |
| 172 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 173 | TEST_P(VideoSendStreamTest, SupportsAbsoluteSendTime) { |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 174 | class AbsoluteSendTimeObserver : public test::SendTest { |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 175 | public: |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 176 | AbsoluteSendTimeObserver() : SendTest(kDefaultTimeoutMs) { |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 177 | EXPECT_TRUE(parser_->RegisterRtpHeaderExtension( |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 178 | kRtpExtensionAbsoluteSendTime, test::kAbsSendTimeExtensionId)); |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 179 | } |
| 180 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 181 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 182 | RTPHeader header; |
pbos@webrtc.org | 62bafae | 2014-07-08 12:10:51 | [diff] [blame] | 183 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 184 | |
pbos@webrtc.org | 5ab7567 | 2013-12-16 12:24:44 | [diff] [blame] | 185 | EXPECT_FALSE(header.extension.hasTransmissionTimeOffset); |
| 186 | EXPECT_TRUE(header.extension.hasAbsoluteSendTime); |
| 187 | EXPECT_EQ(header.extension.transmissionTimeOffset, 0); |
skvlad | c3f3515 | 2016-09-02 20:23:46 | [diff] [blame] | 188 | if (header.extension.absoluteSendTime != 0) { |
| 189 | // Wait for at least one packet with a non-zero send time. The send time |
| 190 | // is a 16-bit value derived from the system clock, and it is valid |
| 191 | // for a packet to have a zero send time. To tell that from an |
| 192 | // unpopulated value we'll wait for a packet with non-zero send time. |
| 193 | observation_complete_.Set(); |
| 194 | } else { |
Mirko Bonadei | 675513b | 2017-11-09 10:09:25 | [diff] [blame] | 195 | RTC_LOG(LS_WARNING) |
| 196 | << "Got a packet with zero absoluteSendTime, waiting" |
| 197 | " for another packet..."; |
skvlad | c3f3515 | 2016-09-02 20:23:46 | [diff] [blame] | 198 | } |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 199 | |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 200 | return SEND_PACKET; |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 201 | } |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 202 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 203 | void ModifyVideoConfigs( |
| 204 | VideoSendStream::Config* send_config, |
| 205 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 206 | VideoEncoderConfig* encoder_config) override { |
Erik Språng | 9526187 | 2015-04-10 09:58:49 | [diff] [blame] | 207 | send_config->rtp.extensions.clear(); |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 208 | send_config->rtp.extensions.push_back(RtpExtension( |
isheriff | 6f8d686 | 2016-05-26 18:24:55 | [diff] [blame] | 209 | RtpExtension::kAbsSendTimeUri, test::kAbsSendTimeExtensionId)); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 210 | } |
pbos@webrtc.org | dde16f1 | 2014-08-05 23:35:43 | [diff] [blame] | 211 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 212 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 213 | EXPECT_TRUE(Wait()) << "Timed out while waiting for single RTP packet."; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 214 | } |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 215 | } test; |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 216 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 217 | RunBaseTest(&test); |
pbos@webrtc.org | 5c678ea | 2013-09-11 19:00:39 | [diff] [blame] | 218 | } |
| 219 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 220 | TEST_P(VideoSendStreamTest, SupportsTransmissionTimeOffset) { |
asapersson@webrtc.org | 049e4ec | 2014-11-20 10:19:46 | [diff] [blame] | 221 | static const int kEncodeDelayMs = 5; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 222 | class TransmissionTimeOffsetObserver : public test::SendTest { |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 223 | public: |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 224 | TransmissionTimeOffsetObserver() |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 225 | : SendTest(kDefaultTimeoutMs), encoder_factory_([]() { |
Karl Wiberg | 918f50c | 2018-07-05 09:40:33 | [diff] [blame] | 226 | return absl::make_unique<test::DelayedEncoder>( |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 227 | Clock::GetRealTimeClock(), kEncodeDelayMs); |
| 228 | }) { |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 229 | EXPECT_TRUE(parser_->RegisterRtpHeaderExtension( |
Stefan Holmer | 1295297 | 2015-10-29 14:13:24 | [diff] [blame] | 230 | kRtpExtensionTransmissionTimeOffset, test::kTOffsetExtensionId)); |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 231 | } |
| 232 | |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 233 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 234 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 235 | RTPHeader header; |
pbos@webrtc.org | 62bafae | 2014-07-08 12:10:51 | [diff] [blame] | 236 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 237 | |
pbos@webrtc.org | 5ab7567 | 2013-12-16 12:24:44 | [diff] [blame] | 238 | EXPECT_TRUE(header.extension.hasTransmissionTimeOffset); |
| 239 | EXPECT_FALSE(header.extension.hasAbsoluteSendTime); |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 240 | EXPECT_GT(header.extension.transmissionTimeOffset, 0); |
pbos@webrtc.org | 5ab7567 | 2013-12-16 12:24:44 | [diff] [blame] | 241 | EXPECT_EQ(header.extension.absoluteSendTime, 0u); |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 242 | observation_complete_.Set(); |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 243 | |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 244 | return SEND_PACKET; |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 245 | } |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 246 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 247 | void ModifyVideoConfigs( |
| 248 | VideoSendStream::Config* send_config, |
| 249 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 250 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 251 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
Stefan Holmer | 1295297 | 2015-10-29 14:13:24 | [diff] [blame] | 252 | send_config->rtp.extensions.clear(); |
isheriff | 6f8d686 | 2016-05-26 18:24:55 | [diff] [blame] | 253 | send_config->rtp.extensions.push_back(RtpExtension( |
| 254 | RtpExtension::kTimestampOffsetUri, test::kTOffsetExtensionId)); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 255 | } |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 256 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 257 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 258 | EXPECT_TRUE(Wait()) << "Timed out while waiting for a single RTP packet."; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 259 | } |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 260 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 261 | test::FunctionVideoEncoderFactory encoder_factory_; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 262 | } test; |
| 263 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 264 | RunBaseTest(&test); |
pbos@webrtc.org | 2902328 | 2013-09-11 10:14:56 | [diff] [blame] | 265 | } |
| 266 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 267 | TEST_P(VideoSendStreamTest, SupportsTransportWideSequenceNumbers) { |
danilchap | 42ca68a | 2016-10-31 10:34:40 | [diff] [blame] | 268 | static const uint8_t kExtensionId = test::kTransportSequenceNumberExtensionId; |
sprang | 867fb52 | 2015-08-03 11:38:41 | [diff] [blame] | 269 | class TransportWideSequenceNumberObserver : public test::SendTest { |
| 270 | public: |
| 271 | TransportWideSequenceNumberObserver() |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 272 | : SendTest(kDefaultTimeoutMs), encoder_factory_([]() { |
Karl Wiberg | 918f50c | 2018-07-05 09:40:33 | [diff] [blame] | 273 | return absl::make_unique<test::FakeEncoder>( |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 274 | Clock::GetRealTimeClock()); |
| 275 | }) { |
sprang | 867fb52 | 2015-08-03 11:38:41 | [diff] [blame] | 276 | EXPECT_TRUE(parser_->RegisterRtpHeaderExtension( |
| 277 | kRtpExtensionTransportSequenceNumber, kExtensionId)); |
| 278 | } |
| 279 | |
| 280 | private: |
| 281 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 282 | RTPHeader header; |
| 283 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
| 284 | |
| 285 | EXPECT_TRUE(header.extension.hasTransportSequenceNumber); |
| 286 | EXPECT_FALSE(header.extension.hasTransmissionTimeOffset); |
| 287 | EXPECT_FALSE(header.extension.hasAbsoluteSendTime); |
| 288 | |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 289 | observation_complete_.Set(); |
sprang | 867fb52 | 2015-08-03 11:38:41 | [diff] [blame] | 290 | |
| 291 | return SEND_PACKET; |
| 292 | } |
| 293 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 294 | void ModifyVideoConfigs( |
| 295 | VideoSendStream::Config* send_config, |
| 296 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 297 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 298 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
sprang | 867fb52 | 2015-08-03 11:38:41 | [diff] [blame] | 299 | } |
| 300 | |
| 301 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 302 | EXPECT_TRUE(Wait()) << "Timed out while waiting for a single RTP packet."; |
sprang | 867fb52 | 2015-08-03 11:38:41 | [diff] [blame] | 303 | } |
| 304 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 305 | test::FunctionVideoEncoderFactory encoder_factory_; |
sprang | 867fb52 | 2015-08-03 11:38:41 | [diff] [blame] | 306 | } test; |
| 307 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 308 | RunBaseTest(&test); |
sprang | 867fb52 | 2015-08-03 11:38:41 | [diff] [blame] | 309 | } |
| 310 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 311 | TEST_P(VideoSendStreamTest, SupportsVideoRotation) { |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 312 | class VideoRotationObserver : public test::SendTest { |
| 313 | public: |
| 314 | VideoRotationObserver() : SendTest(kDefaultTimeoutMs) { |
| 315 | EXPECT_TRUE(parser_->RegisterRtpHeaderExtension( |
| 316 | kRtpExtensionVideoRotation, test::kVideoRotationExtensionId)); |
| 317 | } |
| 318 | |
| 319 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 320 | RTPHeader header; |
| 321 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
ilnik | 7a3006b | 2017-05-23 16:34:21 | [diff] [blame] | 322 | // Only the last packet of the frame is required to have the extension. |
| 323 | if (!header.markerBit) |
| 324 | return SEND_PACKET; |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 325 | EXPECT_TRUE(header.extension.hasVideoRotation); |
| 326 | EXPECT_EQ(kVideoRotation_90, header.extension.videoRotation); |
| 327 | observation_complete_.Set(); |
| 328 | return SEND_PACKET; |
| 329 | } |
| 330 | |
| 331 | void ModifyVideoConfigs( |
| 332 | VideoSendStream::Config* send_config, |
| 333 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 334 | VideoEncoderConfig* encoder_config) override { |
| 335 | send_config->rtp.extensions.clear(); |
| 336 | send_config->rtp.extensions.push_back(RtpExtension( |
| 337 | RtpExtension::kVideoRotationUri, test::kVideoRotationExtensionId)); |
| 338 | } |
| 339 | |
| 340 | void OnFrameGeneratorCapturerCreated( |
| 341 | test::FrameGeneratorCapturer* frame_generator_capturer) override { |
| 342 | frame_generator_capturer->SetFakeRotation(kVideoRotation_90); |
| 343 | } |
| 344 | |
| 345 | void PerformTest() override { |
| 346 | EXPECT_TRUE(Wait()) << "Timed out while waiting for single RTP packet."; |
| 347 | } |
| 348 | } test; |
| 349 | |
| 350 | RunBaseTest(&test); |
| 351 | } |
| 352 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 353 | TEST_P(VideoSendStreamTest, SupportsVideoContentType) { |
ilnik | 1089499 | 2017-06-21 15:23:19 | [diff] [blame] | 354 | class VideoContentTypeObserver : public test::SendTest { |
ilnik | 00d802b | 2017-04-11 17:34:31 | [diff] [blame] | 355 | public: |
Ilya Nikolaevskiy | efbb978 | 2018-03-12 09:42:08 | [diff] [blame] | 356 | VideoContentTypeObserver() |
| 357 | : SendTest(kDefaultTimeoutMs), first_frame_sent_(false) { |
ilnik | 00d802b | 2017-04-11 17:34:31 | [diff] [blame] | 358 | EXPECT_TRUE(parser_->RegisterRtpHeaderExtension( |
| 359 | kRtpExtensionVideoContentType, test::kVideoContentTypeExtensionId)); |
| 360 | } |
| 361 | |
| 362 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 363 | RTPHeader header; |
| 364 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
Ilya Nikolaevskiy | efbb978 | 2018-03-12 09:42:08 | [diff] [blame] | 365 | // Only the last packet of the key-frame must have extension. |
| 366 | if (!header.markerBit || first_frame_sent_) |
ilnik | 7a3006b | 2017-05-23 16:34:21 | [diff] [blame] | 367 | return SEND_PACKET; |
Ilya Nikolaevskiy | efbb978 | 2018-03-12 09:42:08 | [diff] [blame] | 368 | // First marker bit seen means that the first frame is sent. |
| 369 | first_frame_sent_ = true; |
ilnik | 00d802b | 2017-04-11 17:34:31 | [diff] [blame] | 370 | EXPECT_TRUE(header.extension.hasVideoContentType); |
ilnik | 6d5b4d6 | 2017-08-30 10:32:14 | [diff] [blame] | 371 | EXPECT_TRUE(videocontenttypehelpers::IsScreenshare( |
| 372 | header.extension.videoContentType)); |
ilnik | 00d802b | 2017-04-11 17:34:31 | [diff] [blame] | 373 | observation_complete_.Set(); |
| 374 | return SEND_PACKET; |
| 375 | } |
| 376 | |
| 377 | void ModifyVideoConfigs( |
| 378 | VideoSendStream::Config* send_config, |
| 379 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 380 | VideoEncoderConfig* encoder_config) override { |
| 381 | send_config->rtp.extensions.clear(); |
| 382 | send_config->rtp.extensions.push_back( |
| 383 | RtpExtension(RtpExtension::kVideoContentTypeUri, |
| 384 | test::kVideoContentTypeExtensionId)); |
| 385 | encoder_config->content_type = VideoEncoderConfig::ContentType::kScreen; |
| 386 | } |
| 387 | |
| 388 | void PerformTest() override { |
| 389 | EXPECT_TRUE(Wait()) << "Timed out while waiting for single RTP packet."; |
| 390 | } |
Ilya Nikolaevskiy | efbb978 | 2018-03-12 09:42:08 | [diff] [blame] | 391 | |
| 392 | private: |
| 393 | bool first_frame_sent_; |
ilnik | 00d802b | 2017-04-11 17:34:31 | [diff] [blame] | 394 | } test; |
| 395 | |
| 396 | RunBaseTest(&test); |
| 397 | } |
| 398 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 399 | TEST_P(VideoSendStreamTest, SupportsVideoTimingFrames) { |
ilnik | 1089499 | 2017-06-21 15:23:19 | [diff] [blame] | 400 | class VideoTimingObserver : public test::SendTest { |
ilnik | 04f4d12 | 2017-06-19 14:18:55 | [diff] [blame] | 401 | public: |
ilnik | 1089499 | 2017-06-21 15:23:19 | [diff] [blame] | 402 | VideoTimingObserver() : SendTest(kDefaultTimeoutMs) { |
ilnik | 04f4d12 | 2017-06-19 14:18:55 | [diff] [blame] | 403 | EXPECT_TRUE(parser_->RegisterRtpHeaderExtension( |
| 404 | kRtpExtensionVideoTiming, test::kVideoTimingExtensionId)); |
| 405 | } |
| 406 | |
| 407 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 408 | RTPHeader header; |
| 409 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
ilnik | 1089499 | 2017-06-21 15:23:19 | [diff] [blame] | 410 | // Only the last packet of the frame must have extension. |
| 411 | if (!header.markerBit) |
| 412 | return SEND_PACKET; |
| 413 | EXPECT_TRUE(header.extension.has_video_timing); |
| 414 | observation_complete_.Set(); |
ilnik | 04f4d12 | 2017-06-19 14:18:55 | [diff] [blame] | 415 | return SEND_PACKET; |
| 416 | } |
| 417 | |
| 418 | void ModifyVideoConfigs( |
| 419 | VideoSendStream::Config* send_config, |
| 420 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 421 | VideoEncoderConfig* encoder_config) override { |
| 422 | send_config->rtp.extensions.clear(); |
| 423 | send_config->rtp.extensions.push_back(RtpExtension( |
| 424 | RtpExtension::kVideoTimingUri, test::kVideoTimingExtensionId)); |
| 425 | } |
| 426 | |
| 427 | void PerformTest() override { |
| 428 | EXPECT_TRUE(Wait()) << "Timed out while waiting for timing frames."; |
| 429 | } |
| 430 | } test; |
| 431 | |
| 432 | RunBaseTest(&test); |
| 433 | } |
| 434 | |
danilchap | 901b2df | 2017-07-28 15:56:04 | [diff] [blame] | 435 | class FakeReceiveStatistics : public ReceiveStatisticsProvider { |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 436 | public: |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 437 | FakeReceiveStatistics(uint32_t send_ssrc, |
| 438 | uint32_t last_sequence_number, |
| 439 | uint32_t cumulative_lost, |
danilchap | 901b2df | 2017-07-28 15:56:04 | [diff] [blame] | 440 | uint8_t fraction_lost) { |
| 441 | stat_.SetMediaSsrc(send_ssrc); |
| 442 | stat_.SetExtHighestSeqNum(last_sequence_number); |
| 443 | stat_.SetCumulativeLost(cumulative_lost); |
| 444 | stat_.SetFractionLost(fraction_lost); |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 445 | } |
| 446 | |
danilchap | 901b2df | 2017-07-28 15:56:04 | [diff] [blame] | 447 | std::vector<rtcp::ReportBlock> RtcpReportBlocks(size_t max_blocks) override { |
| 448 | EXPECT_GE(max_blocks, 1u); |
| 449 | return {stat_}; |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 450 | } |
| 451 | |
| 452 | private: |
danilchap | 901b2df | 2017-07-28 15:56:04 | [diff] [blame] | 453 | rtcp::ReportBlock stat_; |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 454 | }; |
| 455 | |
brandtr | e602f0a | 2016-10-31 10:40:49 | [diff] [blame] | 456 | class UlpfecObserver : public test::EndToEndTest { |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 457 | public: |
brandtr | e602f0a | 2016-10-31 10:40:49 | [diff] [blame] | 458 | UlpfecObserver(bool header_extensions_enabled, |
brandtr | 65a1e77 | 2016-12-12 09:54:58 | [diff] [blame] | 459 | bool use_nack, |
| 460 | bool expect_red, |
| 461 | bool expect_ulpfec, |
brandtr | 696c9c6 | 2016-12-19 13:47:28 | [diff] [blame] | 462 | const std::string& codec, |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 463 | VideoEncoderFactory* encoder_factory) |
brandtr | 20d4547 | 2017-01-02 08:34:27 | [diff] [blame] | 464 | : EndToEndTest(kTimeoutMs), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 465 | encoder_factory_(encoder_factory), |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 466 | payload_name_(codec), |
| 467 | use_nack_(use_nack), |
| 468 | expect_red_(expect_red), |
brandtr | e602f0a | 2016-10-31 10:40:49 | [diff] [blame] | 469 | expect_ulpfec_(expect_ulpfec), |
brandtr | 65a1e77 | 2016-12-12 09:54:58 | [diff] [blame] | 470 | sent_media_(false), |
| 471 | sent_ulpfec_(false), |
brandtr | 696c9c6 | 2016-12-19 13:47:28 | [diff] [blame] | 472 | header_extensions_enabled_(header_extensions_enabled) {} |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 473 | |
brandtr | 20d4547 | 2017-01-02 08:34:27 | [diff] [blame] | 474 | // Some of the test cases are expected to time out and thus we are using |
| 475 | // a shorter timeout window than the default here. |
| 476 | static constexpr size_t kTimeoutMs = 10000; |
| 477 | |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 478 | private: |
| 479 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 480 | RTPHeader header; |
| 481 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
| 482 | |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 483 | int encapsulated_payload_type = -1; |
| 484 | if (header.payloadType == VideoSendStreamTest::kRedPayloadType) { |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 485 | EXPECT_TRUE(expect_red_); |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 486 | encapsulated_payload_type = static_cast<int>(packet[header.headerLength]); |
| 487 | if (encapsulated_payload_type != |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 488 | VideoSendStreamTest::kFakeVideoSendPayloadType) { |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 489 | EXPECT_EQ(VideoSendStreamTest::kUlpfecPayloadType, |
| 490 | encapsulated_payload_type); |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 491 | } |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 492 | } else { |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 493 | EXPECT_EQ(VideoSendStreamTest::kFakeVideoSendPayloadType, |
| 494 | header.payloadType); |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 495 | if (static_cast<size_t>(header.headerLength + header.paddingLength) < |
| 496 | length) { |
| 497 | // Not padding-only, media received outside of RED. |
| 498 | EXPECT_FALSE(expect_red_); |
brandtr | 65a1e77 | 2016-12-12 09:54:58 | [diff] [blame] | 499 | sent_media_ = true; |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 500 | } |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 501 | } |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 502 | |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 503 | if (header_extensions_enabled_) { |
| 504 | EXPECT_TRUE(header.extension.hasAbsoluteSendTime); |
| 505 | uint32_t kHalf24BitsSpace = 0xFFFFFF / 2; |
| 506 | if (header.extension.absoluteSendTime <= kHalf24BitsSpace && |
| 507 | prev_header_.extension.absoluteSendTime > kHalf24BitsSpace) { |
| 508 | // 24 bits wrap. |
| 509 | EXPECT_GT(prev_header_.extension.absoluteSendTime, |
| 510 | header.extension.absoluteSendTime); |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 511 | } else { |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 512 | EXPECT_GE(header.extension.absoluteSendTime, |
| 513 | prev_header_.extension.absoluteSendTime); |
Stefan Holmer | 01b4888 | 2015-05-05 08:21:24 | [diff] [blame] | 514 | } |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 515 | EXPECT_TRUE(header.extension.hasTransportSequenceNumber); |
| 516 | uint16_t seq_num_diff = header.extension.transportSequenceNumber - |
| 517 | prev_header_.extension.transportSequenceNumber; |
| 518 | EXPECT_EQ(1, seq_num_diff); |
| 519 | } |
Stefan Holmer | 01b4888 | 2015-05-05 08:21:24 | [diff] [blame] | 520 | |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 521 | if (encapsulated_payload_type != -1) { |
| 522 | if (encapsulated_payload_type == |
| 523 | VideoSendStreamTest::kUlpfecPayloadType) { |
brandtr | e602f0a | 2016-10-31 10:40:49 | [diff] [blame] | 524 | EXPECT_TRUE(expect_ulpfec_); |
brandtr | 65a1e77 | 2016-12-12 09:54:58 | [diff] [blame] | 525 | sent_ulpfec_ = true; |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 526 | } else { |
brandtr | 65a1e77 | 2016-12-12 09:54:58 | [diff] [blame] | 527 | sent_media_ = true; |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 528 | } |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 529 | } |
| 530 | |
brandtr | 20d4547 | 2017-01-02 08:34:27 | [diff] [blame] | 531 | if (sent_media_ && sent_ulpfec_) { |
| 532 | observation_complete_.Set(); |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 533 | } |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 534 | |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 535 | prev_header_ = header; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 536 | |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 537 | return SEND_PACKET; |
| 538 | } |
| 539 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 540 | test::PacketTransport* CreateSendTransport( |
| 541 | test::SingleThreadedTaskQueueForTesting* task_queue, |
| 542 | Call* sender_call) override { |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 543 | // At low RTT (< kLowRttNackMs) -> NACK only, no FEC. |
| 544 | // Configure some network delay. |
| 545 | const int kNetworkDelayMs = 100; |
Artem Titov | 75e3647 | 2018-10-08 10:28:56 | [diff] [blame] | 546 | BuiltInNetworkBehaviorConfig config; |
brandtr | 65a1e77 | 2016-12-12 09:54:58 | [diff] [blame] | 547 | config.loss_percent = 5; |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 548 | config.queue_delay_ms = kNetworkDelayMs; |
minyue | 20c84cc | 2017-04-10 23:57:57 | [diff] [blame] | 549 | return new test::PacketTransport( |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 550 | task_queue, sender_call, this, test::PacketTransport::kSender, |
Artem Titov | 4e199e9 | 2018-08-20 11:30:39 | [diff] [blame] | 551 | VideoSendStreamTest::payload_type_map_, |
| 552 | absl::make_unique<FakeNetworkPipe>( |
| 553 | Clock::GetRealTimeClock(), |
| 554 | absl::make_unique<SimulatedNetwork>(config))); |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 555 | } |
| 556 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 557 | void ModifyVideoConfigs( |
| 558 | VideoSendStream::Config* send_config, |
| 559 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 560 | VideoEncoderConfig* encoder_config) override { |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 561 | if (use_nack_) { |
| 562 | send_config->rtp.nack.rtp_history_ms = |
| 563 | (*receive_configs)[0].rtp.nack.rtp_history_ms = |
| 564 | VideoSendStreamTest::kNackRtpHistoryMs; |
| 565 | } |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 566 | send_config->encoder_settings.encoder_factory = encoder_factory_; |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 567 | send_config->rtp.payload_name = payload_name_; |
brandtr | b5f2c3f | 2016-10-05 06:28:39 | [diff] [blame] | 568 | send_config->rtp.ulpfec.red_payload_type = |
| 569 | VideoSendStreamTest::kRedPayloadType; |
| 570 | send_config->rtp.ulpfec.ulpfec_payload_type = |
| 571 | VideoSendStreamTest::kUlpfecPayloadType; |
stefan | b77c716 | 2017-02-06 14:29:38 | [diff] [blame] | 572 | EXPECT_FALSE(send_config->rtp.extensions.empty()); |
| 573 | if (!header_extensions_enabled_) { |
| 574 | send_config->rtp.extensions.clear(); |
| 575 | } else { |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 576 | send_config->rtp.extensions.push_back(RtpExtension( |
isheriff | 6f8d686 | 2016-05-26 18:24:55 | [diff] [blame] | 577 | RtpExtension::kAbsSendTimeUri, test::kAbsSendTimeExtensionId)); |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 578 | } |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 579 | encoder_config->codec_type = PayloadStringToCodecType(payload_name_); |
nisse | 3b3622f | 2017-09-26 09:49:21 | [diff] [blame] | 580 | (*receive_configs)[0].rtp.red_payload_type = |
brandtr | b5f2c3f | 2016-10-05 06:28:39 | [diff] [blame] | 581 | send_config->rtp.ulpfec.red_payload_type; |
nisse | 3b3622f | 2017-09-26 09:49:21 | [diff] [blame] | 582 | (*receive_configs)[0].rtp.ulpfec_payload_type = |
brandtr | b5f2c3f | 2016-10-05 06:28:39 | [diff] [blame] | 583 | send_config->rtp.ulpfec.ulpfec_payload_type; |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 584 | } |
| 585 | |
| 586 | void PerformTest() override { |
brandtr | 20d4547 | 2017-01-02 08:34:27 | [diff] [blame] | 587 | EXPECT_EQ(expect_ulpfec_, Wait()) |
| 588 | << "Timed out waiting for ULPFEC and/or media packets."; |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 589 | } |
| 590 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 591 | VideoEncoderFactory* encoder_factory_; |
brandtr | 696c9c6 | 2016-12-19 13:47:28 | [diff] [blame] | 592 | std::string payload_name_; |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 593 | const bool use_nack_; |
| 594 | const bool expect_red_; |
brandtr | e602f0a | 2016-10-31 10:40:49 | [diff] [blame] | 595 | const bool expect_ulpfec_; |
brandtr | 65a1e77 | 2016-12-12 09:54:58 | [diff] [blame] | 596 | bool sent_media_; |
| 597 | bool sent_ulpfec_; |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 598 | bool header_extensions_enabled_; |
| 599 | RTPHeader prev_header_; |
| 600 | }; |
| 601 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 602 | TEST_P(VideoSendStreamTest, SupportsUlpfecWithExtensions) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 603 | test::FunctionVideoEncoderFactory encoder_factory( |
| 604 | []() { return VP8Encoder::Create(); }); |
| 605 | UlpfecObserver test(true, false, true, true, "VP8", &encoder_factory); |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 606 | RunBaseTest(&test); |
Stefan Holmer | 4654d20 | 2015-12-08 08:10:43 | [diff] [blame] | 607 | } |
| 608 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 609 | TEST_P(VideoSendStreamTest, SupportsUlpfecWithoutExtensions) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 610 | test::FunctionVideoEncoderFactory encoder_factory( |
| 611 | []() { return VP8Encoder::Create(); }); |
| 612 | UlpfecObserver test(false, false, true, true, "VP8", &encoder_factory); |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 613 | RunBaseTest(&test); |
| 614 | } |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 615 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 616 | class VideoSendStreamWithoutUlpfecTest : public test::CallTest { |
stefan | 60e10c7 | 2017-08-23 17:40:00 | [diff] [blame] | 617 | protected: |
| 618 | VideoSendStreamWithoutUlpfecTest() |
| 619 | : field_trial_("WebRTC-DisableUlpFecExperiment/Enabled/") {} |
| 620 | |
| 621 | test::ScopedFieldTrials field_trial_; |
| 622 | }; |
| 623 | |
| 624 | TEST_F(VideoSendStreamWithoutUlpfecTest, NoUlpfecIfDisabledThroughFieldTrial) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 625 | test::FunctionVideoEncoderFactory encoder_factory( |
| 626 | []() { return VP8Encoder::Create(); }); |
Kári Tristan Helgason | 798ee75 | 2018-07-11 14:04:57 | [diff] [blame] | 627 | UlpfecObserver test(false, false, false, false, "VP8", &encoder_factory); |
stefan | 60e10c7 | 2017-08-23 17:40:00 | [diff] [blame] | 628 | RunBaseTest(&test); |
| 629 | } |
| 630 | |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 631 | // The FEC scheme used is not efficient for H264, so we should not use RED/FEC |
| 632 | // since we'll still have to re-request FEC packets, effectively wasting |
| 633 | // bandwidth since the receiver has to wait for FEC retransmissions to determine |
| 634 | // that the received state is actually decodable. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 635 | TEST_P(VideoSendStreamTest, DoesNotUtilizeUlpfecForH264WithNackEnabled) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 636 | test::FunctionVideoEncoderFactory encoder_factory([]() { |
Karl Wiberg | 918f50c | 2018-07-05 09:40:33 | [diff] [blame] | 637 | return absl::make_unique<test::FakeH264Encoder>(Clock::GetRealTimeClock()); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 638 | }); |
Kári Tristan Helgason | 798ee75 | 2018-07-11 14:04:57 | [diff] [blame] | 639 | UlpfecObserver test(false, true, false, false, "H264", &encoder_factory); |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 640 | RunBaseTest(&test); |
| 641 | } |
| 642 | |
| 643 | // Without retransmissions FEC for H264 is fine. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 644 | TEST_P(VideoSendStreamTest, DoesUtilizeUlpfecForH264WithoutNackEnabled) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 645 | test::FunctionVideoEncoderFactory encoder_factory([]() { |
Karl Wiberg | 918f50c | 2018-07-05 09:40:33 | [diff] [blame] | 646 | return absl::make_unique<test::FakeH264Encoder>(Clock::GetRealTimeClock()); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 647 | }); |
| 648 | UlpfecObserver test(false, false, true, true, "H264", &encoder_factory); |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 649 | RunBaseTest(&test); |
| 650 | } |
| 651 | |
danilchap | 9f5b622 | 2017-03-02 14:22:21 | [diff] [blame] | 652 | // Disabled as flaky, see https://crbug.com/webrtc/7285 for details. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 653 | TEST_P(VideoSendStreamTest, DISABLED_DoesUtilizeUlpfecForVp8WithNackEnabled) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 654 | test::FunctionVideoEncoderFactory encoder_factory( |
| 655 | []() { return VP8Encoder::Create(); }); |
| 656 | UlpfecObserver test(false, true, true, true, "VP8", &encoder_factory); |
Peter Boström | 3959397 | 2016-02-15 10:27:15 | [diff] [blame] | 657 | RunBaseTest(&test); |
| 658 | } |
| 659 | |
Mirko Bonadei | 8ef5793 | 2018-11-16 13:38:03 | [diff] [blame] | 660 | #if defined(RTC_ENABLE_VP9) |
danilchap | 9f5b622 | 2017-03-02 14:22:21 | [diff] [blame] | 661 | // Disabled as flaky, see https://crbug.com/webrtc/7285 for details. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 662 | TEST_P(VideoSendStreamTest, DISABLED_DoesUtilizeUlpfecForVp9WithNackEnabled) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 663 | test::FunctionVideoEncoderFactory encoder_factory( |
| 664 | []() { return VP9Encoder::Create(); }); |
| 665 | UlpfecObserver test(false, true, true, true, "VP9", &encoder_factory); |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 666 | RunBaseTest(&test); |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 667 | } |
Mirko Bonadei | 8ef5793 | 2018-11-16 13:38:03 | [diff] [blame] | 668 | #endif // defined(RTC_ENABLE_VP9) |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 669 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 670 | TEST_P(VideoSendStreamTest, SupportsUlpfecWithMultithreadedH264) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 671 | test::FunctionVideoEncoderFactory encoder_factory([]() { |
Karl Wiberg | 918f50c | 2018-07-05 09:40:33 | [diff] [blame] | 672 | return absl::make_unique<test::MultithreadedFakeH264Encoder>( |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 673 | Clock::GetRealTimeClock()); |
| 674 | }); |
| 675 | UlpfecObserver test(false, false, true, true, "H264", &encoder_factory); |
brandtr | 696c9c6 | 2016-12-19 13:47:28 | [diff] [blame] | 676 | RunBaseTest(&test); |
| 677 | } |
| 678 | |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 679 | // TODO(brandtr): Move these FlexFEC tests when we have created |
| 680 | // FlexfecSendStream. |
| 681 | class FlexfecObserver : public test::EndToEndTest { |
| 682 | public: |
| 683 | FlexfecObserver(bool header_extensions_enabled, |
| 684 | bool use_nack, |
brandtr | 696c9c6 | 2016-12-19 13:47:28 | [diff] [blame] | 685 | const std::string& codec, |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 686 | VideoEncoderFactory* encoder_factory, |
Danil Chapovalov | 45d725d | 2018-02-19 18:09:53 | [diff] [blame] | 687 | size_t num_video_streams) |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 688 | : EndToEndTest(VideoSendStreamTest::kDefaultTimeoutMs), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 689 | encoder_factory_(encoder_factory), |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 690 | payload_name_(codec), |
| 691 | use_nack_(use_nack), |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 692 | sent_media_(false), |
| 693 | sent_flexfec_(false), |
Danil Chapovalov | 45d725d | 2018-02-19 18:09:53 | [diff] [blame] | 694 | header_extensions_enabled_(header_extensions_enabled), |
| 695 | num_video_streams_(num_video_streams) {} |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 696 | |
| 697 | size_t GetNumFlexfecStreams() const override { return 1; } |
Danil Chapovalov | 45d725d | 2018-02-19 18:09:53 | [diff] [blame] | 698 | size_t GetNumVideoStreams() const override { return num_video_streams_; } |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 699 | |
| 700 | private: |
| 701 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 702 | RTPHeader header; |
| 703 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
| 704 | |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 705 | if (header.payloadType == VideoSendStreamTest::kFlexfecPayloadType) { |
| 706 | EXPECT_EQ(VideoSendStreamTest::kFlexfecSendSsrc, header.ssrc); |
| 707 | sent_flexfec_ = true; |
| 708 | } else { |
| 709 | EXPECT_EQ(VideoSendStreamTest::kFakeVideoSendPayloadType, |
| 710 | header.payloadType); |
Danil Chapovalov | 45d725d | 2018-02-19 18:09:53 | [diff] [blame] | 711 | EXPECT_THAT(testing::make_tuple(VideoSendStreamTest::kVideoSendSsrcs, |
| 712 | num_video_streams_), |
| 713 | testing::Contains(header.ssrc)); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 714 | sent_media_ = true; |
| 715 | } |
| 716 | |
| 717 | if (header_extensions_enabled_) { |
| 718 | EXPECT_TRUE(header.extension.hasAbsoluteSendTime); |
| 719 | EXPECT_TRUE(header.extension.hasTransmissionTimeOffset); |
| 720 | EXPECT_TRUE(header.extension.hasTransportSequenceNumber); |
| 721 | } |
| 722 | |
brandtr | 0c5a154 | 2016-11-23 12:42:26 | [diff] [blame] | 723 | if (sent_media_ && sent_flexfec_) { |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 724 | observation_complete_.Set(); |
| 725 | } |
| 726 | |
| 727 | return SEND_PACKET; |
| 728 | } |
| 729 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 730 | test::PacketTransport* CreateSendTransport( |
| 731 | test::SingleThreadedTaskQueueForTesting* task_queue, |
| 732 | Call* sender_call) override { |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 733 | // At low RTT (< kLowRttNackMs) -> NACK only, no FEC. |
| 734 | // Therefore we need some network delay. |
| 735 | const int kNetworkDelayMs = 100; |
Artem Titov | 75e3647 | 2018-10-08 10:28:56 | [diff] [blame] | 736 | BuiltInNetworkBehaviorConfig config; |
brandtr | d654a9b | 2016-12-05 13:38:19 | [diff] [blame] | 737 | config.loss_percent = 5; |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 738 | config.queue_delay_ms = kNetworkDelayMs; |
minyue | 20c84cc | 2017-04-10 23:57:57 | [diff] [blame] | 739 | return new test::PacketTransport( |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 740 | task_queue, sender_call, this, test::PacketTransport::kSender, |
Artem Titov | 4e199e9 | 2018-08-20 11:30:39 | [diff] [blame] | 741 | VideoSendStreamTest::payload_type_map_, |
| 742 | absl::make_unique<FakeNetworkPipe>( |
| 743 | Clock::GetRealTimeClock(), |
| 744 | absl::make_unique<SimulatedNetwork>(config))); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 745 | } |
| 746 | |
| 747 | void ModifyVideoConfigs( |
| 748 | VideoSendStream::Config* send_config, |
| 749 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 750 | VideoEncoderConfig* encoder_config) override { |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 751 | if (use_nack_) { |
| 752 | send_config->rtp.nack.rtp_history_ms = |
| 753 | (*receive_configs)[0].rtp.nack.rtp_history_ms = |
| 754 | VideoSendStreamTest::kNackRtpHistoryMs; |
| 755 | } |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 756 | send_config->encoder_settings.encoder_factory = encoder_factory_; |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 757 | send_config->rtp.payload_name = payload_name_; |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 758 | if (header_extensions_enabled_) { |
| 759 | send_config->rtp.extensions.push_back(RtpExtension( |
| 760 | RtpExtension::kAbsSendTimeUri, test::kAbsSendTimeExtensionId)); |
| 761 | send_config->rtp.extensions.push_back(RtpExtension( |
| 762 | RtpExtension::kTimestampOffsetUri, test::kTOffsetExtensionId)); |
stefan | b77c716 | 2017-02-06 14:29:38 | [diff] [blame] | 763 | } else { |
| 764 | send_config->rtp.extensions.clear(); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 765 | } |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 766 | encoder_config->codec_type = PayloadStringToCodecType(payload_name_); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 767 | } |
| 768 | |
| 769 | void PerformTest() override { |
| 770 | EXPECT_TRUE(Wait()) |
| 771 | << "Timed out waiting for FlexFEC and/or media packets."; |
| 772 | } |
| 773 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 774 | VideoEncoderFactory* encoder_factory_; |
brandtr | 696c9c6 | 2016-12-19 13:47:28 | [diff] [blame] | 775 | std::string payload_name_; |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 776 | const bool use_nack_; |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 777 | bool sent_media_; |
| 778 | bool sent_flexfec_; |
Danil Chapovalov | 45d725d | 2018-02-19 18:09:53 | [diff] [blame] | 779 | const bool header_extensions_enabled_; |
| 780 | const size_t num_video_streams_; |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 781 | }; |
| 782 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 783 | TEST_P(VideoSendStreamTest, SupportsFlexfecVp8) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 784 | test::FunctionVideoEncoderFactory encoder_factory( |
| 785 | []() { return VP8Encoder::Create(); }); |
| 786 | FlexfecObserver test(false, false, "VP8", &encoder_factory, 1); |
Danil Chapovalov | 45d725d | 2018-02-19 18:09:53 | [diff] [blame] | 787 | RunBaseTest(&test); |
| 788 | } |
| 789 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 790 | TEST_P(VideoSendStreamTest, SupportsFlexfecSimulcastVp8) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 791 | test::FunctionVideoEncoderFactory encoder_factory( |
| 792 | []() { return VP8Encoder::Create(); }); |
| 793 | FlexfecObserver test(false, false, "VP8", &encoder_factory, 2); |
brandtr | d654a9b | 2016-12-05 13:38:19 | [diff] [blame] | 794 | RunBaseTest(&test); |
| 795 | } |
| 796 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 797 | TEST_P(VideoSendStreamTest, SupportsFlexfecWithNackVp8) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 798 | test::FunctionVideoEncoderFactory encoder_factory( |
| 799 | []() { return VP8Encoder::Create(); }); |
| 800 | FlexfecObserver test(false, true, "VP8", &encoder_factory, 1); |
brandtr | d654a9b | 2016-12-05 13:38:19 | [diff] [blame] | 801 | RunBaseTest(&test); |
| 802 | } |
| 803 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 804 | TEST_P(VideoSendStreamTest, SupportsFlexfecWithRtpExtensionsVp8) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 805 | test::FunctionVideoEncoderFactory encoder_factory( |
| 806 | []() { return VP8Encoder::Create(); }); |
| 807 | FlexfecObserver test(true, false, "VP8", &encoder_factory, 1); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 808 | RunBaseTest(&test); |
| 809 | } |
| 810 | |
Mirko Bonadei | 8ef5793 | 2018-11-16 13:38:03 | [diff] [blame] | 811 | #if defined(RTC_ENABLE_VP9) |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 812 | TEST_P(VideoSendStreamTest, SupportsFlexfecVp9) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 813 | test::FunctionVideoEncoderFactory encoder_factory( |
| 814 | []() { return VP9Encoder::Create(); }); |
| 815 | FlexfecObserver test(false, false, "VP9", &encoder_factory, 1); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 816 | RunBaseTest(&test); |
| 817 | } |
| 818 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 819 | TEST_P(VideoSendStreamTest, SupportsFlexfecWithNackVp9) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 820 | test::FunctionVideoEncoderFactory encoder_factory( |
| 821 | []() { return VP9Encoder::Create(); }); |
| 822 | FlexfecObserver test(false, true, "VP9", &encoder_factory, 1); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 823 | RunBaseTest(&test); |
| 824 | } |
Mirko Bonadei | 8ef5793 | 2018-11-16 13:38:03 | [diff] [blame] | 825 | #endif // defined(RTC_ENABLE_VP9) |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 826 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 827 | TEST_P(VideoSendStreamTest, SupportsFlexfecH264) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 828 | test::FunctionVideoEncoderFactory encoder_factory([]() { |
Karl Wiberg | 918f50c | 2018-07-05 09:40:33 | [diff] [blame] | 829 | return absl::make_unique<test::FakeH264Encoder>(Clock::GetRealTimeClock()); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 830 | }); |
| 831 | FlexfecObserver test(false, false, "H264", &encoder_factory, 1); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 832 | RunBaseTest(&test); |
| 833 | } |
| 834 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 835 | TEST_P(VideoSendStreamTest, SupportsFlexfecWithNackH264) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 836 | test::FunctionVideoEncoderFactory encoder_factory([]() { |
Karl Wiberg | 918f50c | 2018-07-05 09:40:33 | [diff] [blame] | 837 | return absl::make_unique<test::FakeH264Encoder>(Clock::GetRealTimeClock()); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 838 | }); |
| 839 | FlexfecObserver test(false, true, "H264", &encoder_factory, 1); |
brandtr | 696c9c6 | 2016-12-19 13:47:28 | [diff] [blame] | 840 | RunBaseTest(&test); |
| 841 | } |
| 842 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 843 | TEST_P(VideoSendStreamTest, SupportsFlexfecWithMultithreadedH264) { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 844 | test::FunctionVideoEncoderFactory encoder_factory([]() { |
Karl Wiberg | 918f50c | 2018-07-05 09:40:33 | [diff] [blame] | 845 | return absl::make_unique<test::MultithreadedFakeH264Encoder>( |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 846 | Clock::GetRealTimeClock()); |
| 847 | }); |
| 848 | |
| 849 | FlexfecObserver test(false, false, "H264", &encoder_factory, 1); |
brandtr | 39f9729 | 2016-11-17 06:57:50 | [diff] [blame] | 850 | RunBaseTest(&test); |
| 851 | } |
| 852 | |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 853 | void VideoSendStreamTest::TestNackRetransmission( |
| 854 | uint32_t retransmit_ssrc, |
stefan@webrtc.org | cb254aa | 2014-06-12 15:12:25 | [diff] [blame] | 855 | uint8_t retransmit_payload_type) { |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 856 | class NackObserver : public test::SendTest { |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 857 | public: |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 858 | explicit NackObserver(uint32_t retransmit_ssrc, |
| 859 | uint8_t retransmit_payload_type) |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 860 | : SendTest(kDefaultTimeoutMs), |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 861 | send_count_(0), |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 862 | retransmit_count_(0), |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 863 | retransmit_ssrc_(retransmit_ssrc), |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 864 | retransmit_payload_type_(retransmit_payload_type) {} |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 865 | |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 866 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 867 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 868 | RTPHeader header; |
pbos@webrtc.org | 62bafae | 2014-07-08 12:10:51 | [diff] [blame] | 869 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 870 | |
Ilya Nikolaevskiy | 6003e7a | 2018-10-15 08:47:23 | [diff] [blame] | 871 | // NACK packets two times at some arbitrary points. |
| 872 | const int kNackedPacketsAtOnceCount = 3; |
| 873 | const int kRetransmitTarget = kNackedPacketsAtOnceCount * 2; |
| 874 | |
| 875 | // Skip padding packets because they will never be retransmitted. |
| 876 | if (header.paddingLength + header.headerLength == length) { |
| 877 | return SEND_PACKET; |
| 878 | } |
| 879 | |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 880 | ++send_count_; |
Ilya Nikolaevskiy | 6003e7a | 2018-10-15 08:47:23 | [diff] [blame] | 881 | |
| 882 | // NACK packets at arbitrary points. |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 883 | if (send_count_ == 5 || send_count_ == 25) { |
Ilya Nikolaevskiy | 6003e7a | 2018-10-15 08:47:23 | [diff] [blame] | 884 | nacked_sequence_numbers_.insert( |
| 885 | nacked_sequence_numbers_.end(), |
| 886 | non_padding_sequence_numbers_.end() - kNackedPacketsAtOnceCount, |
| 887 | non_padding_sequence_numbers_.end()); |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 888 | |
danilchap | 8a1d2a3 | 2017-08-01 10:21:37 | [diff] [blame] | 889 | RTCPSender rtcp_sender(false, Clock::GetRealTimeClock(), nullptr, |
Jiawei Ou | 3587b83 | 2018-02-01 06:08:26 | [diff] [blame] | 890 | nullptr, nullptr, transport_adapter_.get(), |
Jiawei Ou | 8b5d9d8 | 2018-11-16 00:44:37 | [diff] [blame] | 891 | kRtcpIntervalMs); |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 892 | |
pbos | da903ea | 2015-10-02 09:36:56 | [diff] [blame] | 893 | rtcp_sender.SetRTCPStatus(RtcpMode::kReducedSize); |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 894 | rtcp_sender.SetRemoteSSRC(kVideoSendSsrcs[0]); |
pbos@webrtc.org | 0e63e76 | 2013-09-20 11:56:26 | [diff] [blame] | 895 | |
| 896 | RTCPSender::FeedbackState feedback_state; |
| 897 | |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 898 | EXPECT_EQ(0, rtcp_sender.SendRTCP( |
| 899 | feedback_state, kRtcpNack, |
| 900 | static_cast<int>(nacked_sequence_numbers_.size()), |
| 901 | &nacked_sequence_numbers_.front())); |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 902 | } |
| 903 | |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 904 | uint16_t sequence_number = header.sequenceNumber; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 905 | if (header.ssrc == retransmit_ssrc_ && |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 906 | retransmit_ssrc_ != kVideoSendSsrcs[0]) { |
| 907 | // Not kVideoSendSsrcs[0], assume correct RTX packet. Extract sequence |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 908 | // number. |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 909 | const uint8_t* rtx_header = packet + header.headerLength; |
| 910 | sequence_number = (rtx_header[0] << 8) + rtx_header[1]; |
| 911 | } |
Ilya Nikolaevskiy | 6003e7a | 2018-10-15 08:47:23 | [diff] [blame] | 912 | |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 913 | auto found = std::find(nacked_sequence_numbers_.begin(), |
| 914 | nacked_sequence_numbers_.end(), sequence_number); |
| 915 | if (found != nacked_sequence_numbers_.end()) { |
| 916 | nacked_sequence_numbers_.erase(found); |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 917 | |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 918 | if (++retransmit_count_ == kRetransmitTarget) { |
| 919 | EXPECT_EQ(retransmit_ssrc_, header.ssrc); |
| 920 | EXPECT_EQ(retransmit_payload_type_, header.payloadType); |
| 921 | observation_complete_.Set(); |
| 922 | } |
Ilya Nikolaevskiy | 6003e7a | 2018-10-15 08:47:23 | [diff] [blame] | 923 | } else { |
| 924 | non_padding_sequence_numbers_.push_back(sequence_number); |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 925 | } |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 926 | |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 927 | return SEND_PACKET; |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 928 | } |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 929 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 930 | void ModifyVideoConfigs( |
| 931 | VideoSendStream::Config* send_config, |
| 932 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 933 | VideoEncoderConfig* encoder_config) override { |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 934 | transport_adapter_.reset( |
| 935 | new internal::TransportAdapter(send_config->send_transport)); |
| 936 | transport_adapter_->Enable(); |
pbos@webrtc.org | be9d2a4 | 2014-06-30 13:19:09 | [diff] [blame] | 937 | send_config->rtp.nack.rtp_history_ms = kNackRtpHistoryMs; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 938 | send_config->rtp.rtx.payload_type = retransmit_payload_type_; |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 939 | if (retransmit_ssrc_ != kVideoSendSsrcs[0]) |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 940 | send_config->rtp.rtx.ssrcs.push_back(retransmit_ssrc_); |
| 941 | } |
| 942 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 943 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 944 | EXPECT_TRUE(Wait()) << "Timed out while waiting for NACK retransmission."; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 945 | } |
| 946 | |
kwiberg | 27f982b | 2016-03-01 19:52:33 | [diff] [blame] | 947 | std::unique_ptr<internal::TransportAdapter> transport_adapter_; |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 948 | int send_count_; |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 949 | int retransmit_count_; |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 950 | uint32_t retransmit_ssrc_; |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 951 | uint8_t retransmit_payload_type_; |
Sebastian Jansson | d3f3816 | 2018-02-28 15:14:44 | [diff] [blame] | 952 | std::vector<uint16_t> nacked_sequence_numbers_; |
Ilya Nikolaevskiy | 6003e7a | 2018-10-15 08:47:23 | [diff] [blame] | 953 | std::vector<uint16_t> non_padding_sequence_numbers_; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 954 | } test(retransmit_ssrc, retransmit_payload_type); |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 955 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 956 | RunBaseTest(&test); |
pbos@webrtc.org | df531a2 | 2013-09-10 14:56:33 | [diff] [blame] | 957 | } |
| 958 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 959 | TEST_P(VideoSendStreamTest, RetransmitsNack) { |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 960 | // Normal NACKs should use the send SSRC. |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 961 | TestNackRetransmission(kVideoSendSsrcs[0], kFakeVideoSendPayloadType); |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 962 | } |
| 963 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 964 | TEST_P(VideoSendStreamTest, RetransmitsNackOverRtx) { |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 965 | // NACKs over RTX should use a separate SSRC. |
pbos@webrtc.org | 2bb1bda | 2014-07-07 13:06:48 | [diff] [blame] | 966 | TestNackRetransmission(kSendRtxSsrcs[0], kSendRtxPayloadType); |
pbos@webrtc.org | 5860de0 | 2013-09-16 13:01:47 | [diff] [blame] | 967 | } |
| 968 | |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 969 | void VideoSendStreamTest::TestPacketFragmentationSize(VideoFormat format, |
| 970 | bool with_fec) { |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 971 | // Use a fake encoder to output a frame of every size in the range [90, 290], |
| 972 | // for each size making sure that the exact number of payload bytes received |
| 973 | // is correct and that packets are fragmented to respect max packet size. |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 | [diff] [blame] | 974 | static const size_t kMaxPacketSize = 128; |
| 975 | static const size_t start = 90; |
| 976 | static const size_t stop = 290; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 977 | |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 978 | // Observer that verifies that the expected number of packets and bytes |
| 979 | // arrive for each frame size, from start_size to stop_size. |
Niels Möller | 759f959 | 2018-10-09 12:57:01 | [diff] [blame] | 980 | class FrameFragmentationTest : public test::SendTest { |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 981 | public: |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 | [diff] [blame] | 982 | FrameFragmentationTest(size_t max_packet_size, |
| 983 | size_t start_size, |
| 984 | size_t stop_size, |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 985 | bool test_generic_packetization, |
| 986 | bool use_fec) |
| 987 | : SendTest(kLongTimeoutMs), |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 988 | encoder_(stop), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 989 | encoder_factory_(&encoder_), |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 990 | max_packet_size_(max_packet_size), |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 991 | stop_size_(stop_size), |
| 992 | test_generic_packetization_(test_generic_packetization), |
| 993 | use_fec_(use_fec), |
| 994 | packet_count_(0), |
Sebastian Jansson | 56fa050 | 2018-02-01 12:00:57 | [diff] [blame] | 995 | packets_lost_(0), |
| 996 | last_packet_count_(0), |
| 997 | last_packets_lost_(0), |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 998 | accumulated_size_(0), |
| 999 | accumulated_payload_(0), |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1000 | fec_packet_received_(false), |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1001 | current_size_rtp_(start_size), |
Yuwei Huang | d9f99c1 | 2017-10-24 22:40:52 | [diff] [blame] | 1002 | current_size_frame_(static_cast<int>(start_size)) { |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1003 | // Fragmentation required, this test doesn't make sense without it. |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 | [diff] [blame] | 1004 | encoder_.SetFrameSize(start_size); |
henrikg | 91d6ede | 2015-09-17 07:24:34 | [diff] [blame] | 1005 | RTC_DCHECK_GT(stop_size, max_packet_size); |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 | [diff] [blame] | 1006 | if (!test_generic_packetization_) |
| 1007 | encoder_.SetCodecType(kVideoCodecVP8); |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1008 | } |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1009 | |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1010 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1011 | Action OnSendRtp(const uint8_t* packet, size_t size) override { |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 | [diff] [blame] | 1012 | size_t length = size; |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1013 | RTPHeader header; |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1014 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1015 | |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1016 | EXPECT_LE(length, max_packet_size_); |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1017 | |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1018 | if (use_fec_) { |
| 1019 | uint8_t payload_type = packet[header.headerLength]; |
| 1020 | bool is_fec = header.payloadType == kRedPayloadType && |
| 1021 | payload_type == kUlpfecPayloadType; |
| 1022 | if (is_fec) { |
| 1023 | fec_packet_received_ = true; |
| 1024 | return SEND_PACKET; |
| 1025 | } |
| 1026 | } |
| 1027 | |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1028 | accumulated_size_ += length; |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1029 | |
| 1030 | if (use_fec_) |
| 1031 | TriggerLossReport(header); |
| 1032 | |
| 1033 | if (test_generic_packetization_) { |
Stefan Holmer | 586b19b | 2015-09-18 09:14:31 | [diff] [blame] | 1034 | size_t overhead = header.headerLength + header.paddingLength; |
| 1035 | // Only remove payload header and RED header if the packet actually |
| 1036 | // contains payload. |
| 1037 | if (length > overhead) { |
| 1038 | overhead += (1 /* Generic header */); |
| 1039 | if (use_fec_) |
| 1040 | overhead += 1; // RED for FEC header. |
| 1041 | } |
| 1042 | EXPECT_GE(length, overhead); |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1043 | accumulated_payload_ += length - overhead; |
| 1044 | } |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1045 | |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1046 | // Marker bit set indicates last packet of a frame. |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1047 | if (header.markerBit) { |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1048 | if (use_fec_ && accumulated_payload_ == current_size_rtp_ - 1) { |
| 1049 | // With FEC enabled, frame size is incremented asynchronously, so |
| 1050 | // "old" frames one byte too small may arrive. Accept, but don't |
| 1051 | // increase expected frame size. |
| 1052 | accumulated_size_ = 0; |
| 1053 | accumulated_payload_ = 0; |
| 1054 | return SEND_PACKET; |
| 1055 | } |
| 1056 | |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1057 | EXPECT_GE(accumulated_size_, current_size_rtp_); |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1058 | if (test_generic_packetization_) { |
| 1059 | EXPECT_EQ(current_size_rtp_, accumulated_payload_); |
| 1060 | } |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1061 | |
| 1062 | // Last packet of frame; reset counters. |
| 1063 | accumulated_size_ = 0; |
| 1064 | accumulated_payload_ = 0; |
| 1065 | if (current_size_rtp_ == stop_size_) { |
| 1066 | // Done! (Don't increase size again, might arrive more @ stop_size). |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 1067 | observation_complete_.Set(); |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1068 | } else { |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1069 | // Increase next expected frame size. If testing with FEC, make sure |
| 1070 | // a FEC packet has been received for this frame size before |
| 1071 | // proceeding, to make sure that redundancy packets don't exceed |
| 1072 | // size limit. |
| 1073 | if (!use_fec_) { |
| 1074 | ++current_size_rtp_; |
| 1075 | } else if (fec_packet_received_) { |
| 1076 | fec_packet_received_ = false; |
| 1077 | ++current_size_rtp_; |
Yuwei Huang | d9f99c1 | 2017-10-24 22:40:52 | [diff] [blame] | 1078 | |
| 1079 | rtc::CritScope lock(&mutex_); |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1080 | ++current_size_frame_; |
| 1081 | } |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1082 | } |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1083 | } |
| 1084 | |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 1085 | return SEND_PACKET; |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1086 | } |
| 1087 | |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1088 | void TriggerLossReport(const RTPHeader& header) { |
| 1089 | // Send lossy receive reports to trigger FEC enabling. |
sprang | 4847ae6 | 2017-06-27 14:06:52 | [diff] [blame] | 1090 | const int kLossPercent = 5; |
Sebastian Jansson | 56fa050 | 2018-02-01 12:00:57 | [diff] [blame] | 1091 | if (++packet_count_ % (100 / kLossPercent) == 0) { |
| 1092 | packets_lost_++; |
| 1093 | int loss_delta = packets_lost_ - last_packets_lost_; |
| 1094 | int packets_delta = packet_count_ - last_packet_count_; |
| 1095 | last_packet_count_ = packet_count_; |
| 1096 | last_packets_lost_ = packets_lost_; |
| 1097 | uint8_t loss_ratio = |
| 1098 | static_cast<uint8_t>(loss_delta * 255 / packets_delta); |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1099 | FakeReceiveStatistics lossy_receive_stats( |
sprang | 4847ae6 | 2017-06-27 14:06:52 | [diff] [blame] | 1100 | kVideoSendSsrcs[0], header.sequenceNumber, |
Sebastian Jansson | 56fa050 | 2018-02-01 12:00:57 | [diff] [blame] | 1101 | packets_lost_, // Cumulative lost. |
| 1102 | loss_ratio); // Loss percent. |
Peter Boström | ac547a6 | 2015-09-17 21:03:57 | [diff] [blame] | 1103 | RTCPSender rtcp_sender(false, Clock::GetRealTimeClock(), |
terelius | 429c345 | 2016-01-21 13:42:04 | [diff] [blame] | 1104 | &lossy_receive_stats, nullptr, nullptr, |
Jiawei Ou | 8b5d9d8 | 2018-11-16 00:44:37 | [diff] [blame] | 1105 | transport_adapter_.get(), kRtcpIntervalMs); |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1106 | |
pbos | da903ea | 2015-10-02 09:36:56 | [diff] [blame] | 1107 | rtcp_sender.SetRTCPStatus(RtcpMode::kReducedSize); |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 1108 | rtcp_sender.SetRemoteSSRC(kVideoSendSsrcs[0]); |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1109 | |
| 1110 | RTCPSender::FeedbackState feedback_state; |
| 1111 | |
| 1112 | EXPECT_EQ(0, rtcp_sender.SendRTCP(feedback_state, kRtcpRr)); |
| 1113 | } |
| 1114 | } |
| 1115 | |
Niels Möller | 759f959 | 2018-10-09 12:57:01 | [diff] [blame] | 1116 | void UpdateConfiguration() { |
Yuwei Huang | d9f99c1 | 2017-10-24 22:40:52 | [diff] [blame] | 1117 | rtc::CritScope lock(&mutex_); |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1118 | // Increase frame size for next encoded frame, in the context of the |
| 1119 | // encoder thread. |
Yuwei Huang | d9f99c1 | 2017-10-24 22:40:52 | [diff] [blame] | 1120 | if (!use_fec_ && current_size_frame_ < static_cast<int32_t>(stop_size_)) { |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1121 | ++current_size_frame_; |
| 1122 | } |
Yuwei Huang | d9f99c1 | 2017-10-24 22:40:52 | [diff] [blame] | 1123 | encoder_.SetFrameSize(static_cast<size_t>(current_size_frame_)); |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1124 | } |
Niels Möller | de8e6e6 | 2018-11-13 14:10:33 | [diff] [blame] | 1125 | void ModifySenderBitrateConfig( |
| 1126 | BitrateConstraints* bitrate_config) override { |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 1127 | const int kMinBitrateBps = 30000; |
Niels Möller | de8e6e6 | 2018-11-13 14:10:33 | [diff] [blame] | 1128 | bitrate_config->min_bitrate_bps = kMinBitrateBps; |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 1129 | } |
| 1130 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 1131 | void ModifyVideoConfigs( |
| 1132 | VideoSendStream::Config* send_config, |
| 1133 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 1134 | VideoEncoderConfig* encoder_config) override { |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1135 | transport_adapter_.reset( |
| 1136 | new internal::TransportAdapter(send_config->send_transport)); |
| 1137 | transport_adapter_->Enable(); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1138 | if (use_fec_) { |
brandtr | b5f2c3f | 2016-10-05 06:28:39 | [diff] [blame] | 1139 | send_config->rtp.ulpfec.red_payload_type = kRedPayloadType; |
| 1140 | send_config->rtp.ulpfec.ulpfec_payload_type = kUlpfecPayloadType; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1141 | } |
| 1142 | |
| 1143 | if (!test_generic_packetization_) |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 1144 | send_config->rtp.payload_name = "VP8"; |
Philip Eliasson | d52a1a6 | 2018-09-07 13:03:55 | [diff] [blame] | 1145 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 1146 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1147 | send_config->rtp.max_packet_size = kMaxPacketSize; |
Niels Möller | 759f959 | 2018-10-09 12:57:01 | [diff] [blame] | 1148 | encoder_.RegisterPostEncodeCallback([this]() { UpdateConfiguration(); }); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1149 | |
Erik Språng | 9526187 | 2015-04-10 09:58:49 | [diff] [blame] | 1150 | // Make sure there is at least one extension header, to make the RTP |
| 1151 | // header larger than the base length of 12 bytes. |
| 1152 | EXPECT_FALSE(send_config->rtp.extensions.empty()); |
sprang | 4847ae6 | 2017-06-27 14:06:52 | [diff] [blame] | 1153 | |
| 1154 | // Setup screen content disables frame dropping which makes this easier. |
Åsa Persson | d34597c | 2018-10-22 15:34:02 | [diff] [blame] | 1155 | EXPECT_EQ(1u, encoder_config->simulcast_layers.size()); |
| 1156 | encoder_config->simulcast_layers[0].num_temporal_layers = 2; |
sprang | 4847ae6 | 2017-06-27 14:06:52 | [diff] [blame] | 1157 | encoder_config->content_type = VideoEncoderConfig::ContentType::kScreen; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1158 | } |
| 1159 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1160 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 1161 | EXPECT_TRUE(Wait()) << "Timed out while observing incoming RTP packets."; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1162 | } |
| 1163 | |
kwiberg | 27f982b | 2016-03-01 19:52:33 | [diff] [blame] | 1164 | std::unique_ptr<internal::TransportAdapter> transport_adapter_; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1165 | test::ConfigurableFrameSizeEncoder encoder_; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 1166 | test::VideoEncoderProxyFactory encoder_factory_; |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1167 | |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 | [diff] [blame] | 1168 | const size_t max_packet_size_; |
| 1169 | const size_t stop_size_; |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1170 | const bool test_generic_packetization_; |
| 1171 | const bool use_fec_; |
| 1172 | |
| 1173 | uint32_t packet_count_; |
Sebastian Jansson | 56fa050 | 2018-02-01 12:00:57 | [diff] [blame] | 1174 | uint32_t packets_lost_; |
| 1175 | uint32_t last_packet_count_; |
| 1176 | uint32_t last_packets_lost_; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 | [diff] [blame] | 1177 | size_t accumulated_size_; |
| 1178 | size_t accumulated_payload_; |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1179 | bool fec_packet_received_; |
| 1180 | |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 | [diff] [blame] | 1181 | size_t current_size_rtp_; |
Yuwei Huang | d9f99c1 | 2017-10-24 22:40:52 | [diff] [blame] | 1182 | rtc::CriticalSection mutex_; |
| 1183 | int current_size_frame_ RTC_GUARDED_BY(mutex_); |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1184 | }; |
| 1185 | |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1186 | // Don't auto increment if FEC is used; continue sending frame size until |
| 1187 | // a FEC packet has been received. |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 1188 | FrameFragmentationTest test(kMaxPacketSize, start, stop, format == kGeneric, |
| 1189 | with_fec); |
sprang@webrtc.org | 8b88192 | 2013-12-10 10:05:17 | [diff] [blame] | 1190 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 1191 | RunBaseTest(&test); |
sprang@webrtc.org | 5d957e2 | 2013-10-16 11:37:54 | [diff] [blame] | 1192 | } |
| 1193 | |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1194 | // TODO(sprang): Is there any way of speeding up these tests? |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1195 | TEST_P(VideoSendStreamTest, FragmentsGenericAccordingToMaxPacketSize) { |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1196 | TestPacketFragmentationSize(kGeneric, false); |
| 1197 | } |
| 1198 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1199 | TEST_P(VideoSendStreamTest, FragmentsGenericAccordingToMaxPacketSizeWithFec) { |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1200 | TestPacketFragmentationSize(kGeneric, true); |
| 1201 | } |
| 1202 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1203 | TEST_P(VideoSendStreamTest, FragmentsVp8AccordingToMaxPacketSize) { |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1204 | TestPacketFragmentationSize(kVP8, false); |
| 1205 | } |
| 1206 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1207 | TEST_P(VideoSendStreamTest, FragmentsVp8AccordingToMaxPacketSizeWithFec) { |
sprang@webrtc.org | 346094c | 2014-02-18 08:40:33 | [diff] [blame] | 1208 | TestPacketFragmentationSize(kVP8, true); |
| 1209 | } |
| 1210 | |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1211 | // The test will go through a number of phases. |
| 1212 | // 1. Start sending packets. |
| 1213 | // 2. As soon as the RTP stream has been detected, signal a low REMB value to |
henrik.lundin@webrtc.org | ce8e093 | 2013-11-18 12:18:43 | [diff] [blame] | 1214 | // suspend the stream. |
| 1215 | // 3. Wait until |kSuspendTimeFrames| have been captured without seeing any RTP |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1216 | // packets. |
henrik.lundin@webrtc.org | ce8e093 | 2013-11-18 12:18:43 | [diff] [blame] | 1217 | // 4. Signal a high REMB and then wait for the RTP stream to start again. |
henrik.lundin@webrtc.org | ed8b281 | 2014-03-18 08:43:29 | [diff] [blame] | 1218 | // When the stream is detected again, and the stats show that the stream |
| 1219 | // is no longer suspended, the test ends. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1220 | TEST_P(VideoSendStreamTest, SuspendBelowMinBitrate) { |
henrik.lundin@webrtc.org | ce8e093 | 2013-11-18 12:18:43 | [diff] [blame] | 1221 | static const int kSuspendTimeFrames = 60; // Suspend for 2 seconds @ 30 fps. |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1222 | |
Niels Möller | 412d185 | 2019-01-02 08:42:54 | [diff] [blame] | 1223 | class RembObserver : public test::SendTest { |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1224 | public: |
Niels Möller | 412d185 | 2019-01-02 08:42:54 | [diff] [blame] | 1225 | class CaptureObserver : public rtc::VideoSinkInterface<VideoFrame> { |
| 1226 | public: |
| 1227 | explicit CaptureObserver(RembObserver* remb_observer) |
| 1228 | : remb_observer_(remb_observer) {} |
| 1229 | |
| 1230 | void OnFrame(const VideoFrame&) { |
| 1231 | rtc::CritScope lock(&remb_observer_->crit_); |
| 1232 | if (remb_observer_->test_state_ == kDuringSuspend && |
| 1233 | ++remb_observer_->suspended_frame_count_ > kSuspendTimeFrames) { |
| 1234 | VideoSendStream::Stats stats = remb_observer_->stream_->GetStats(); |
| 1235 | EXPECT_TRUE(stats.suspended); |
| 1236 | remb_observer_->SendRtcpFeedback(remb_observer_->high_remb_bps_); |
| 1237 | remb_observer_->test_state_ = kWaitingForPacket; |
| 1238 | } |
| 1239 | } |
| 1240 | |
| 1241 | private: |
| 1242 | RembObserver* const remb_observer_; |
| 1243 | }; |
| 1244 | |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1245 | RembObserver() |
| 1246 | : SendTest(kDefaultTimeoutMs), |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1247 | clock_(Clock::GetRealTimeClock()), |
Niels Möller | 412d185 | 2019-01-02 08:42:54 | [diff] [blame] | 1248 | capture_observer_(this), |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 1249 | stream_(nullptr), |
henrik.lundin@webrtc.org | ce8e093 | 2013-11-18 12:18:43 | [diff] [blame] | 1250 | test_state_(kBeforeSuspend), |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1251 | rtp_count_(0), |
| 1252 | last_sequence_number_(0), |
henrik.lundin@webrtc.org | ce8e093 | 2013-11-18 12:18:43 | [diff] [blame] | 1253 | suspended_frame_count_(0), |
henrik.lundin@webrtc.org | 1a3a6e5 | 2013-10-28 10:16:14 | [diff] [blame] | 1254 | low_remb_bps_(0), |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 1255 | high_remb_bps_(0) {} |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1256 | |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1257 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1258 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 1259 | rtc::CritScope lock(&crit_); |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1260 | ++rtp_count_; |
| 1261 | RTPHeader header; |
pbos@webrtc.org | 62bafae | 2014-07-08 12:10:51 | [diff] [blame] | 1262 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1263 | last_sequence_number_ = header.sequenceNumber; |
| 1264 | |
henrik.lundin@webrtc.org | ce8e093 | 2013-11-18 12:18:43 | [diff] [blame] | 1265 | if (test_state_ == kBeforeSuspend) { |
| 1266 | // The stream has started. Try to suspend it. |
henrik.lundin@webrtc.org | 1a3a6e5 | 2013-10-28 10:16:14 | [diff] [blame] | 1267 | SendRtcpFeedback(low_remb_bps_); |
henrik.lundin@webrtc.org | ce8e093 | 2013-11-18 12:18:43 | [diff] [blame] | 1268 | test_state_ = kDuringSuspend; |
| 1269 | } else if (test_state_ == kDuringSuspend) { |
henrik.lundin@webrtc.org | 331d440 | 2013-11-21 14:05:40 | [diff] [blame] | 1270 | if (header.paddingLength == 0) { |
| 1271 | // Received non-padding packet during suspension period. Reset the |
| 1272 | // counter. |
henrik.lundin@webrtc.org | 331d440 | 2013-11-21 14:05:40 | [diff] [blame] | 1273 | suspended_frame_count_ = 0; |
| 1274 | } |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1275 | SendRtcpFeedback(0); // REMB is only sent if value is > 0. |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1276 | } else if (test_state_ == kWaitingForPacket) { |
henrik.lundin@webrtc.org | 331d440 | 2013-11-21 14:05:40 | [diff] [blame] | 1277 | if (header.paddingLength == 0) { |
henrik.lundin@webrtc.org | ed8b281 | 2014-03-18 08:43:29 | [diff] [blame] | 1278 | // Non-padding packet observed. Test is almost complete. Will just |
| 1279 | // have to wait for the stats to change. |
| 1280 | test_state_ = kWaitingForStats; |
| 1281 | } |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1282 | SendRtcpFeedback(0); // REMB is only sent if value is > 0. |
henrik.lundin@webrtc.org | ed8b281 | 2014-03-18 08:43:29 | [diff] [blame] | 1283 | } else if (test_state_ == kWaitingForStats) { |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1284 | VideoSendStream::Stats stats = stream_->GetStats(); |
henrik.lundin@webrtc.org | ed8b281 | 2014-03-18 08:43:29 | [diff] [blame] | 1285 | if (stats.suspended == false) { |
| 1286 | // Stats flipped to false. Test is complete. |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 1287 | observation_complete_.Set(); |
henrik.lundin@webrtc.org | 331d440 | 2013-11-21 14:05:40 | [diff] [blame] | 1288 | } |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1289 | SendRtcpFeedback(0); // REMB is only sent if value is > 0. |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1290 | } |
| 1291 | |
stefan@webrtc.org | 69969e2 | 2013-11-15 12:32:15 | [diff] [blame] | 1292 | return SEND_PACKET; |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1293 | } |
| 1294 | |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1295 | void set_low_remb_bps(int value) { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 1296 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1297 | low_remb_bps_ = value; |
| 1298 | } |
henrik.lundin@webrtc.org | 1a3a6e5 | 2013-10-28 10:16:14 | [diff] [blame] | 1299 | |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1300 | void set_high_remb_bps(int value) { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 1301 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1302 | high_remb_bps_ = value; |
| 1303 | } |
henrik.lundin@webrtc.org | 1a3a6e5 | 2013-10-28 10:16:14 | [diff] [blame] | 1304 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 1305 | void OnVideoStreamsCreated( |
pbos@webrtc.org | be9d2a4 | 2014-06-30 13:19:09 | [diff] [blame] | 1306 | VideoSendStream* send_stream, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1307 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1308 | stream_ = send_stream; |
| 1309 | } |
| 1310 | |
Niels Möller | 412d185 | 2019-01-02 08:42:54 | [diff] [blame] | 1311 | void OnFrameGeneratorCapturerCreated( |
| 1312 | test::FrameGeneratorCapturer* frame_generator_capturer) override { |
| 1313 | frame_generator_capturer->AddOrUpdateSink(&capture_observer_, |
| 1314 | rtc::VideoSinkWants()); |
| 1315 | } |
| 1316 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 1317 | void ModifyVideoConfigs( |
| 1318 | VideoSendStream::Config* send_config, |
| 1319 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 1320 | VideoEncoderConfig* encoder_config) override { |
kwiberg | af476c7 | 2016-11-28 23:21:39 | [diff] [blame] | 1321 | RTC_DCHECK_EQ(1, encoder_config->number_of_streams); |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1322 | transport_adapter_.reset( |
| 1323 | new internal::TransportAdapter(send_config->send_transport)); |
| 1324 | transport_adapter_->Enable(); |
pbos@webrtc.org | be9d2a4 | 2014-06-30 13:19:09 | [diff] [blame] | 1325 | send_config->rtp.nack.rtp_history_ms = kNackRtpHistoryMs; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1326 | send_config->suspend_below_min_bitrate = true; |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1327 | int min_bitrate_bps = |
| 1328 | test::DefaultVideoStreamFactory::kDefaultMinBitratePerStream[0]; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1329 | set_low_remb_bps(min_bitrate_bps - 10000); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 1330 | int threshold_window = std::max(min_bitrate_bps / 10, 20000); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1331 | ASSERT_GT(encoder_config->max_bitrate_bps, |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1332 | min_bitrate_bps + threshold_window + 5000); |
| 1333 | set_high_remb_bps(min_bitrate_bps + threshold_window + 5000); |
| 1334 | } |
| 1335 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1336 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 1337 | EXPECT_TRUE(Wait()) << "Timed out during suspend-below-min-bitrate test."; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1338 | } |
| 1339 | |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1340 | enum TestState { |
henrik.lundin@webrtc.org | ce8e093 | 2013-11-18 12:18:43 | [diff] [blame] | 1341 | kBeforeSuspend, |
| 1342 | kDuringSuspend, |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1343 | kWaitingForPacket, |
henrik.lundin@webrtc.org | ed8b281 | 2014-03-18 08:43:29 | [diff] [blame] | 1344 | kWaitingForStats |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1345 | }; |
| 1346 | |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1347 | virtual void SendRtcpFeedback(int remb_value) |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 1348 | RTC_EXCLUSIVE_LOCKS_REQUIRED(crit_) { |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 1349 | FakeReceiveStatistics receive_stats(kVideoSendSsrcs[0], |
| 1350 | last_sequence_number_, rtp_count_, 0); |
terelius | 429c345 | 2016-01-21 13:42:04 | [diff] [blame] | 1351 | RTCPSender rtcp_sender(false, clock_, &receive_stats, nullptr, nullptr, |
Jiawei Ou | 8b5d9d8 | 2018-11-16 00:44:37 | [diff] [blame] | 1352 | transport_adapter_.get(), kRtcpIntervalMs); |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1353 | |
pbos | da903ea | 2015-10-02 09:36:56 | [diff] [blame] | 1354 | rtcp_sender.SetRTCPStatus(RtcpMode::kReducedSize); |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 1355 | rtcp_sender.SetRemoteSSRC(kVideoSendSsrcs[0]); |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1356 | if (remb_value > 0) { |
Danil Chapovalov | f74d641 | 2017-10-18 11:32:57 | [diff] [blame] | 1357 | rtcp_sender.SetRemb(remb_value, std::vector<uint32_t>()); |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1358 | } |
| 1359 | RTCPSender::FeedbackState feedback_state; |
| 1360 | EXPECT_EQ(0, rtcp_sender.SendRTCP(feedback_state, kRtcpRr)); |
| 1361 | } |
| 1362 | |
kwiberg | 27f982b | 2016-03-01 19:52:33 | [diff] [blame] | 1363 | std::unique_ptr<internal::TransportAdapter> transport_adapter_; |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1364 | Clock* const clock_; |
Niels Möller | 412d185 | 2019-01-02 08:42:54 | [diff] [blame] | 1365 | CaptureObserver capture_observer_; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1366 | VideoSendStream* stream_; |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1367 | |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 1368 | rtc::CriticalSection crit_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 1369 | TestState test_state_ RTC_GUARDED_BY(crit_); |
| 1370 | int rtp_count_ RTC_GUARDED_BY(crit_); |
| 1371 | int last_sequence_number_ RTC_GUARDED_BY(crit_); |
| 1372 | int suspended_frame_count_ RTC_GUARDED_BY(crit_); |
| 1373 | int low_remb_bps_ RTC_GUARDED_BY(crit_); |
| 1374 | int high_remb_bps_ RTC_GUARDED_BY(crit_); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1375 | } test; |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1376 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 1377 | RunBaseTest(&test); |
henrik.lundin@webrtc.org | ba975e2 | 2013-10-23 11:04:57 | [diff] [blame] | 1378 | } |
| 1379 | |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1380 | // This test that padding stops being send after a while if the Camera stops |
| 1381 | // producing video frames and that padding resumes if the camera restarts. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1382 | TEST_P(VideoSendStreamTest, NoPaddingWhenVideoIsMuted) { |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1383 | class NoPaddingWhenVideoIsMuted : public test::SendTest { |
stefan@webrtc.org | 4ab4fc0 | 2013-11-25 11:54:24 | [diff] [blame] | 1384 | public: |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1385 | NoPaddingWhenVideoIsMuted() |
| 1386 | : SendTest(kDefaultTimeoutMs), |
stefan@webrtc.org | 4ab4fc0 | 2013-11-25 11:54:24 | [diff] [blame] | 1387 | clock_(Clock::GetRealTimeClock()), |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1388 | last_packet_time_ms_(-1), |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 1389 | capturer_(nullptr) {} |
stefan@webrtc.org | 4ab4fc0 | 2013-11-25 11:54:24 | [diff] [blame] | 1390 | |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1391 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1392 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 1393 | rtc::CritScope lock(&crit_); |
stefan@webrtc.org | 4ab4fc0 | 2013-11-25 11:54:24 | [diff] [blame] | 1394 | last_packet_time_ms_ = clock_->TimeInMilliseconds(); |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1395 | |
| 1396 | RTPHeader header; |
| 1397 | parser_->Parse(packet, length, &header); |
| 1398 | const bool only_padding = |
| 1399 | header.headerLength + header.paddingLength == length; |
| 1400 | |
| 1401 | if (test_state_ == kBeforeStopCapture) { |
Erik Språng | 4f3cc6e | 2018-11-06 11:17:32 | [diff] [blame] | 1402 | // Packets are flowing, stop camera. |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1403 | capturer_->Stop(); |
| 1404 | test_state_ = kWaitingForPadding; |
| 1405 | } else if (test_state_ == kWaitingForPadding && only_padding) { |
Erik Språng | 4f3cc6e | 2018-11-06 11:17:32 | [diff] [blame] | 1406 | // We're still getting padding, after stopping camera. |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1407 | test_state_ = kWaitingForNoPackets; |
Erik Språng | 4f3cc6e | 2018-11-06 11:17:32 | [diff] [blame] | 1408 | } else if (test_state_ == kWaitingForMediaAfterCameraRestart && |
| 1409 | !only_padding) { |
| 1410 | // Media packets are flowing again, stop camera a second time. |
| 1411 | capturer_->Stop(); |
| 1412 | test_state_ = kWaitingForPaddingAfterCameraStopsAgain; |
| 1413 | } else if (test_state_ == kWaitingForPaddingAfterCameraStopsAgain && |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1414 | only_padding) { |
Erik Språng | 4f3cc6e | 2018-11-06 11:17:32 | [diff] [blame] | 1415 | // Padding is still flowing, test ok. |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1416 | observation_complete_.Set(); |
| 1417 | } |
stefan@webrtc.org | 4ab4fc0 | 2013-11-25 11:54:24 | [diff] [blame] | 1418 | return SEND_PACKET; |
| 1419 | } |
| 1420 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1421 | Action OnSendRtcp(const uint8_t* packet, size_t length) override { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 1422 | rtc::CritScope lock(&crit_); |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1423 | const int kNoPacketsThresholdMs = 2000; |
| 1424 | if (test_state_ == kWaitingForNoPackets && |
| 1425 | (last_packet_time_ms_ > 0 && |
| 1426 | clock_->TimeInMilliseconds() - last_packet_time_ms_ > |
| 1427 | kNoPacketsThresholdMs)) { |
Erik Språng | 4f3cc6e | 2018-11-06 11:17:32 | [diff] [blame] | 1428 | // No packets seen for |kNoPacketsThresholdMs|, restart camera. |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1429 | capturer_->Start(); |
Erik Språng | 4f3cc6e | 2018-11-06 11:17:32 | [diff] [blame] | 1430 | test_state_ = kWaitingForMediaAfterCameraRestart; |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1431 | } |
stefan@webrtc.org | 4ab4fc0 | 2013-11-25 11:54:24 | [diff] [blame] | 1432 | return SEND_PACKET; |
| 1433 | } |
| 1434 | |
Erik Språng | 4f3cc6e | 2018-11-06 11:17:32 | [diff] [blame] | 1435 | void ModifyVideoConfigs( |
| 1436 | VideoSendStream::Config* send_config, |
| 1437 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 1438 | VideoEncoderConfig* encoder_config) override { |
| 1439 | // Make sure padding is sent if encoder is not producing media. |
| 1440 | encoder_config->min_transmit_bitrate_bps = 50000; |
| 1441 | } |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1442 | |
nisse | ef8b61e | 2016-04-29 13:09:15 | [diff] [blame] | 1443 | void OnFrameGeneratorCapturerCreated( |
| 1444 | test::FrameGeneratorCapturer* frame_generator_capturer) override { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 1445 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1446 | capturer_ = frame_generator_capturer; |
| 1447 | } |
| 1448 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1449 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 1450 | EXPECT_TRUE(Wait()) |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1451 | << "Timed out while waiting for RTP packets to stop being sent."; |
| 1452 | } |
| 1453 | |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1454 | enum TestState { |
| 1455 | kBeforeStopCapture, |
| 1456 | kWaitingForPadding, |
| 1457 | kWaitingForNoPackets, |
Erik Språng | 4f3cc6e | 2018-11-06 11:17:32 | [diff] [blame] | 1458 | kWaitingForMediaAfterCameraRestart, |
| 1459 | kWaitingForPaddingAfterCameraStopsAgain |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 1460 | }; |
| 1461 | |
| 1462 | TestState test_state_ = kBeforeStopCapture; |
pbos@webrtc.org | de1429e | 2014-04-28 13:00:21 | [diff] [blame] | 1463 | Clock* const clock_; |
kwiberg | 27f982b | 2016-03-01 19:52:33 | [diff] [blame] | 1464 | std::unique_ptr<internal::TransportAdapter> transport_adapter_; |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 1465 | rtc::CriticalSection crit_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 1466 | int64_t last_packet_time_ms_ RTC_GUARDED_BY(crit_); |
| 1467 | test::FrameGeneratorCapturer* capturer_ RTC_GUARDED_BY(crit_); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1468 | } test; |
stefan@webrtc.org | 4ab4fc0 | 2013-11-25 11:54:24 | [diff] [blame] | 1469 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 1470 | RunBaseTest(&test); |
stefan@webrtc.org | 4ab4fc0 | 2013-11-25 11:54:24 | [diff] [blame] | 1471 | } |
| 1472 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1473 | TEST_P(VideoSendStreamTest, PaddingIsPrimarilyRetransmissions) { |
isheriff | cc5903e | 2016-10-04 15:29:38 | [diff] [blame] | 1474 | const int kCapacityKbps = 10000; // 10 Mbps |
| 1475 | class PaddingIsPrimarilyRetransmissions : public test::EndToEndTest { |
| 1476 | public: |
| 1477 | PaddingIsPrimarilyRetransmissions() |
| 1478 | : EndToEndTest(kDefaultTimeoutMs), |
| 1479 | clock_(Clock::GetRealTimeClock()), |
| 1480 | padding_length_(0), |
| 1481 | total_length_(0), |
| 1482 | call_(nullptr) {} |
| 1483 | |
| 1484 | private: |
| 1485 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
| 1486 | call_ = sender_call; |
| 1487 | } |
| 1488 | |
| 1489 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 1490 | rtc::CritScope lock(&crit_); |
| 1491 | |
| 1492 | RTPHeader header; |
| 1493 | parser_->Parse(packet, length, &header); |
| 1494 | padding_length_ += header.paddingLength; |
| 1495 | total_length_ += length; |
| 1496 | return SEND_PACKET; |
| 1497 | } |
| 1498 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1499 | test::PacketTransport* CreateSendTransport( |
| 1500 | test::SingleThreadedTaskQueueForTesting* task_queue, |
| 1501 | Call* sender_call) override { |
isheriff | cc5903e | 2016-10-04 15:29:38 | [diff] [blame] | 1502 | const int kNetworkDelayMs = 50; |
Artem Titov | 75e3647 | 2018-10-08 10:28:56 | [diff] [blame] | 1503 | BuiltInNetworkBehaviorConfig config; |
isheriff | cc5903e | 2016-10-04 15:29:38 | [diff] [blame] | 1504 | config.loss_percent = 10; |
| 1505 | config.link_capacity_kbps = kCapacityKbps; |
| 1506 | config.queue_delay_ms = kNetworkDelayMs; |
Artem Titov | 4e199e9 | 2018-08-20 11:30:39 | [diff] [blame] | 1507 | return new test::PacketTransport( |
| 1508 | task_queue, sender_call, this, test::PacketTransport::kSender, |
| 1509 | payload_type_map_, |
| 1510 | absl::make_unique<FakeNetworkPipe>( |
| 1511 | Clock::GetRealTimeClock(), |
| 1512 | absl::make_unique<SimulatedNetwork>(config))); |
isheriff | cc5903e | 2016-10-04 15:29:38 | [diff] [blame] | 1513 | } |
| 1514 | |
| 1515 | void ModifyVideoConfigs( |
| 1516 | VideoSendStream::Config* send_config, |
| 1517 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 1518 | VideoEncoderConfig* encoder_config) override { |
isheriff | cc5903e | 2016-10-04 15:29:38 | [diff] [blame] | 1519 | // Turn on RTX. |
| 1520 | send_config->rtp.rtx.payload_type = kFakeVideoSendPayloadType; |
| 1521 | send_config->rtp.rtx.ssrcs.push_back(kVideoSendSsrcs[0]); |
isheriff | cc5903e | 2016-10-04 15:29:38 | [diff] [blame] | 1522 | } |
| 1523 | |
| 1524 | void PerformTest() override { |
| 1525 | // TODO(isheriff): Some platforms do not ramp up as expected to full |
| 1526 | // capacity due to packet scheduling delays. Fix that before getting |
| 1527 | // rid of this. |
| 1528 | SleepMs(5000); |
| 1529 | { |
| 1530 | rtc::CritScope lock(&crit_); |
| 1531 | // Expect padding to be a small percentage of total bytes sent. |
| 1532 | EXPECT_LT(padding_length_, .1 * total_length_); |
| 1533 | } |
| 1534 | } |
| 1535 | |
| 1536 | rtc::CriticalSection crit_; |
| 1537 | Clock* const clock_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 1538 | size_t padding_length_ RTC_GUARDED_BY(crit_); |
| 1539 | size_t total_length_ RTC_GUARDED_BY(crit_); |
isheriff | cc5903e | 2016-10-04 15:29:38 | [diff] [blame] | 1540 | Call* call_; |
| 1541 | } test; |
| 1542 | |
| 1543 | RunBaseTest(&test); |
| 1544 | } |
| 1545 | |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1546 | // This test first observes "high" bitrate use at which point it sends a REMB to |
| 1547 | // indicate that it should be lowered significantly. The test then observes that |
| 1548 | // the bitrate observed is sinking well below the min-transmit-bitrate threshold |
| 1549 | // to verify that the min-transmit bitrate respects incoming REMB. |
andresp@webrtc.org | 44caf01 | 2014-03-26 21:00:21 | [diff] [blame] | 1550 | // |
| 1551 | // Note that the test starts at "high" bitrate and does not ramp up to "higher" |
| 1552 | // bitrate since no receiver block or remb is sent in the initial phase. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1553 | TEST_P(VideoSendStreamTest, MinTransmitBitrateRespectsRemb) { |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1554 | static const int kMinTransmitBitrateBps = 400000; |
andresp@webrtc.org | 44caf01 | 2014-03-26 21:00:21 | [diff] [blame] | 1555 | static const int kHighBitrateBps = 150000; |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1556 | static const int kRembBitrateBps = 80000; |
| 1557 | static const int kRembRespectedBitrateBps = 100000; |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1558 | class BitrateObserver : public test::SendTest { |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1559 | public: |
| 1560 | BitrateObserver() |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1561 | : SendTest(kDefaultTimeoutMs), |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 1562 | retranmission_rate_limiter_(Clock::GetRealTimeClock(), 1000), |
| 1563 | stream_(nullptr), |
| 1564 | bitrate_capped_(false) {} |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1565 | |
| 1566 | private: |
nisse | ef8b61e | 2016-04-29 13:09:15 | [diff] [blame] | 1567 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
pbos@webrtc.org | 62bafae | 2014-07-08 12:10:51 | [diff] [blame] | 1568 | if (RtpHeaderParser::IsRtcp(packet, length)) |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1569 | return DROP_PACKET; |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1570 | |
| 1571 | RTPHeader header; |
pbos@webrtc.org | 62bafae | 2014-07-08 12:10:51 | [diff] [blame] | 1572 | if (!parser_->Parse(packet, length, &header)) |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1573 | return DROP_PACKET; |
Peter Boström | 74f6e9e | 2016-04-04 15:56:10 | [diff] [blame] | 1574 | RTC_DCHECK(stream_); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1575 | VideoSendStream::Stats stats = stream_->GetStats(); |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1576 | if (!stats.substreams.empty()) { |
| 1577 | EXPECT_EQ(1u, stats.substreams.size()); |
stefan@webrtc.org | 0bae1fa | 2014-11-05 14:05:29 | [diff] [blame] | 1578 | int total_bitrate_bps = |
| 1579 | stats.substreams.begin()->second.total_bitrate_bps; |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 1580 | test::PrintResult("bitrate_stats_", "min_transmit_bitrate_low_remb", |
| 1581 | "bitrate_bps", static_cast<size_t>(total_bitrate_bps), |
| 1582 | "bps", false); |
stefan@webrtc.org | 0bae1fa | 2014-11-05 14:05:29 | [diff] [blame] | 1583 | if (total_bitrate_bps > kHighBitrateBps) { |
Danil Chapovalov | 51e21aa | 2017-10-10 15:46:26 | [diff] [blame] | 1584 | rtp_rtcp_->SetRemb(kRembBitrateBps, |
| 1585 | std::vector<uint32_t>(1, header.ssrc)); |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1586 | rtp_rtcp_->Process(); |
| 1587 | bitrate_capped_ = true; |
| 1588 | } else if (bitrate_capped_ && |
stefan@webrtc.org | 0bae1fa | 2014-11-05 14:05:29 | [diff] [blame] | 1589 | total_bitrate_bps < kRembRespectedBitrateBps) { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 1590 | observation_complete_.Set(); |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1591 | } |
| 1592 | } |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1593 | // Packets don't have to be delivered since the test is the receiver. |
| 1594 | return DROP_PACKET; |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1595 | } |
| 1596 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 1597 | void OnVideoStreamsCreated( |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1598 | VideoSendStream* send_stream, |
| 1599 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
| 1600 | stream_ = send_stream; |
| 1601 | RtpRtcp::Configuration config; |
| 1602 | config.outgoing_transport = feedback_transport_.get(); |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 1603 | config.retransmission_rate_limiter = &retranmission_rate_limiter_; |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1604 | rtp_rtcp_.reset(RtpRtcp::CreateRtpRtcp(config)); |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1605 | rtp_rtcp_->SetRTCPStatus(RtcpMode::kReducedSize); |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1606 | } |
| 1607 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 1608 | void ModifyVideoConfigs( |
| 1609 | VideoSendStream::Config* send_config, |
| 1610 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 1611 | VideoEncoderConfig* encoder_config) override { |
stefan | f116bd0 | 2015-10-27 15:29:42 | [diff] [blame] | 1612 | feedback_transport_.reset( |
| 1613 | new internal::TransportAdapter(send_config->send_transport)); |
| 1614 | feedback_transport_->Enable(); |
pbos@webrtc.org | ad3b5a5 | 2014-10-24 09:23:21 | [diff] [blame] | 1615 | encoder_config->min_transmit_bitrate_bps = kMinTransmitBitrateBps; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1616 | } |
| 1617 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 1618 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 1619 | EXPECT_TRUE(Wait()) |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1620 | << "Timeout while waiting for low bitrate stats after REMB."; |
| 1621 | } |
| 1622 | |
kwiberg | 27f982b | 2016-03-01 19:52:33 | [diff] [blame] | 1623 | std::unique_ptr<RtpRtcp> rtp_rtcp_; |
| 1624 | std::unique_ptr<internal::TransportAdapter> feedback_transport_; |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 1625 | RateLimiter retranmission_rate_limiter_; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1626 | VideoSendStream* stream_; |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1627 | bool bitrate_capped_; |
pbos@webrtc.org | 994d0b7 | 2014-06-27 08:47:52 | [diff] [blame] | 1628 | } test; |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1629 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 1630 | RunBaseTest(&test); |
pbos@webrtc.org | 709e297 | 2014-03-19 10:59:52 | [diff] [blame] | 1631 | } |
| 1632 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1633 | TEST_P(VideoSendStreamTest, ChangingNetworkRoute) { |
Stefan Holmer | 280de9e | 2016-09-30 08:06:51 | [diff] [blame] | 1634 | static const int kStartBitrateBps = 300000; |
| 1635 | static const int kNewMaxBitrateBps = 1234567; |
danilchap | 42ca68a | 2016-10-31 10:34:40 | [diff] [blame] | 1636 | static const uint8_t kExtensionId = test::kTransportSequenceNumberExtensionId; |
Stefan Holmer | be40296 | 2016-07-08 14:16:41 | [diff] [blame] | 1637 | class ChangingNetworkRouteTest : public test::EndToEndTest { |
| 1638 | public: |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1639 | explicit ChangingNetworkRouteTest( |
| 1640 | test::SingleThreadedTaskQueueForTesting* task_queue) |
| 1641 | : EndToEndTest(test::CallTest::kDefaultTimeoutMs), |
| 1642 | task_queue_(task_queue), |
| 1643 | call_(nullptr) { |
Stefan Holmer | 280de9e | 2016-09-30 08:06:51 | [diff] [blame] | 1644 | EXPECT_TRUE(parser_->RegisterRtpHeaderExtension( |
| 1645 | kRtpExtensionTransportSequenceNumber, kExtensionId)); |
| 1646 | } |
Stefan Holmer | be40296 | 2016-07-08 14:16:41 | [diff] [blame] | 1647 | |
| 1648 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
| 1649 | call_ = sender_call; |
| 1650 | } |
| 1651 | |
Stefan Holmer | 280de9e | 2016-09-30 08:06:51 | [diff] [blame] | 1652 | void ModifyVideoConfigs( |
| 1653 | VideoSendStream::Config* send_config, |
| 1654 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 1655 | VideoEncoderConfig* encoder_config) override { |
| 1656 | send_config->rtp.extensions.clear(); |
| 1657 | send_config->rtp.extensions.push_back(RtpExtension( |
| 1658 | RtpExtension::kTransportSequenceNumberUri, kExtensionId)); |
| 1659 | (*receive_configs)[0].rtp.extensions = send_config->rtp.extensions; |
| 1660 | (*receive_configs)[0].rtp.transport_cc = true; |
| 1661 | } |
| 1662 | |
| 1663 | void ModifyAudioConfigs( |
| 1664 | AudioSendStream::Config* send_config, |
| 1665 | std::vector<AudioReceiveStream::Config>* receive_configs) override { |
| 1666 | send_config->rtp.extensions.clear(); |
| 1667 | send_config->rtp.extensions.push_back(RtpExtension( |
| 1668 | RtpExtension::kTransportSequenceNumberUri, kExtensionId)); |
| 1669 | (*receive_configs)[0].rtp.extensions.clear(); |
| 1670 | (*receive_configs)[0].rtp.extensions = send_config->rtp.extensions; |
| 1671 | (*receive_configs)[0].rtp.transport_cc = true; |
| 1672 | } |
| 1673 | |
Stefan Holmer | be40296 | 2016-07-08 14:16:41 | [diff] [blame] | 1674 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 1675 | if (call_->GetStats().send_bandwidth_bps > kStartBitrateBps) { |
| 1676 | observation_complete_.Set(); |
| 1677 | } |
| 1678 | |
| 1679 | return SEND_PACKET; |
| 1680 | } |
| 1681 | |
| 1682 | void PerformTest() override { |
Steve Anton | ea1bb35 | 2018-07-23 17:12:37 | [diff] [blame] | 1683 | rtc::NetworkRoute new_route; |
| 1684 | new_route.connected = true; |
| 1685 | new_route.local_network_id = 10; |
| 1686 | new_route.remote_network_id = 20; |
Sebastian Jansson | fc8d26b | 2018-02-21 08:52:06 | [diff] [blame] | 1687 | BitrateConstraints bitrate_config; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1688 | |
| 1689 | task_queue_->SendTask([this, &new_route, &bitrate_config]() { |
Sebastian Jansson | 8f83b42 | 2018-02-21 12:07:13 | [diff] [blame] | 1690 | call_->GetTransportControllerSend()->OnNetworkRouteChanged("transport", |
| 1691 | new_route); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1692 | bitrate_config.start_bitrate_bps = kStartBitrateBps; |
Sebastian Jansson | 8f83b42 | 2018-02-21 12:07:13 | [diff] [blame] | 1693 | call_->GetTransportControllerSend()->SetSdpBitrateParameters( |
| 1694 | bitrate_config); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1695 | }); |
| 1696 | |
Stefan Holmer | be40296 | 2016-07-08 14:16:41 | [diff] [blame] | 1697 | EXPECT_TRUE(Wait()) |
| 1698 | << "Timed out while waiting for start bitrate to be exceeded."; |
| 1699 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1700 | task_queue_->SendTask([this, &new_route, &bitrate_config]() { |
| 1701 | bitrate_config.start_bitrate_bps = -1; |
| 1702 | bitrate_config.max_bitrate_bps = kNewMaxBitrateBps; |
Sebastian Jansson | 8f83b42 | 2018-02-21 12:07:13 | [diff] [blame] | 1703 | call_->GetTransportControllerSend()->SetSdpBitrateParameters( |
| 1704 | bitrate_config); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1705 | // TODO(holmer): We should set the last sent packet id here and verify |
| 1706 | // that we correctly ignore any packet loss reported prior to that id. |
| 1707 | ++new_route.local_network_id; |
Sebastian Jansson | 8f83b42 | 2018-02-21 12:07:13 | [diff] [blame] | 1708 | call_->GetTransportControllerSend()->OnNetworkRouteChanged("transport", |
| 1709 | new_route); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1710 | EXPECT_GE(call_->GetStats().send_bandwidth_bps, kStartBitrateBps); |
| 1711 | }); |
Stefan Holmer | be40296 | 2016-07-08 14:16:41 | [diff] [blame] | 1712 | } |
| 1713 | |
| 1714 | private: |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1715 | test::SingleThreadedTaskQueueForTesting* const task_queue_; |
Stefan Holmer | be40296 | 2016-07-08 14:16:41 | [diff] [blame] | 1716 | Call* call_; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1717 | } test(&task_queue_); |
Stefan Holmer | be40296 | 2016-07-08 14:16:41 | [diff] [blame] | 1718 | |
| 1719 | RunBaseTest(&test); |
| 1720 | } |
| 1721 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1722 | TEST_P(VideoSendStreamTest, ChangingTransportOverhead) { |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1723 | class ChangingTransportOverheadTest : public test::EndToEndTest { |
| 1724 | public: |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1725 | explicit ChangingTransportOverheadTest( |
| 1726 | test::SingleThreadedTaskQueueForTesting* task_queue) |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1727 | : EndToEndTest(test::CallTest::kDefaultTimeoutMs), |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1728 | task_queue_(task_queue), |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1729 | call_(nullptr), |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 1730 | packets_sent_(0), |
| 1731 | transport_overhead_(0) {} |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1732 | |
| 1733 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
| 1734 | call_ = sender_call; |
| 1735 | } |
| 1736 | |
| 1737 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 1738 | EXPECT_LE(length, kMaxRtpPacketSize); |
sprang | 21253fc | 2017-02-27 11:35:47 | [diff] [blame] | 1739 | rtc::CritScope cs(&lock_); |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1740 | if (++packets_sent_ < 100) |
| 1741 | return SEND_PACKET; |
| 1742 | observation_complete_.Set(); |
| 1743 | return SEND_PACKET; |
| 1744 | } |
| 1745 | |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 1746 | void ModifyVideoConfigs( |
| 1747 | VideoSendStream::Config* send_config, |
| 1748 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 1749 | VideoEncoderConfig* encoder_config) override { |
| 1750 | send_config->rtp.max_packet_size = kMaxRtpPacketSize; |
| 1751 | } |
| 1752 | |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1753 | void PerformTest() override { |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1754 | task_queue_->SendTask([this]() { |
| 1755 | transport_overhead_ = 100; |
Stefan Holmer | 64be7fa | 2018-10-04 13:21:55 | [diff] [blame] | 1756 | call_->GetTransportControllerSend()->OnTransportOverheadChanged( |
| 1757 | transport_overhead_); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1758 | }); |
| 1759 | |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1760 | EXPECT_TRUE(Wait()); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1761 | |
sprang | 21253fc | 2017-02-27 11:35:47 | [diff] [blame] | 1762 | { |
| 1763 | rtc::CritScope cs(&lock_); |
| 1764 | packets_sent_ = 0; |
| 1765 | } |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1766 | |
| 1767 | task_queue_->SendTask([this]() { |
| 1768 | transport_overhead_ = 500; |
Stefan Holmer | 64be7fa | 2018-10-04 13:21:55 | [diff] [blame] | 1769 | call_->GetTransportControllerSend()->OnTransportOverheadChanged( |
| 1770 | transport_overhead_); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1771 | }); |
| 1772 | |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1773 | EXPECT_TRUE(Wait()); |
| 1774 | } |
| 1775 | |
| 1776 | private: |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1777 | test::SingleThreadedTaskQueueForTesting* const task_queue_; |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1778 | Call* call_; |
sprang | 21253fc | 2017-02-27 11:35:47 | [diff] [blame] | 1779 | rtc::CriticalSection lock_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 1780 | int packets_sent_ RTC_GUARDED_BY(lock_); |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1781 | int transport_overhead_; |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 1782 | const size_t kMaxRtpPacketSize = 1000; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1783 | } test(&task_queue_); |
michaelt | 79e0588 | 2016-11-08 10:50:09 | [diff] [blame] | 1784 | |
| 1785 | RunBaseTest(&test); |
| 1786 | } |
| 1787 | |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1788 | // Test class takes takes as argument a switch selecting if type switch should |
| 1789 | // occur and a function pointer to reset the send stream. This is necessary |
| 1790 | // since you cannot change the content type of a VideoSendStream, you need to |
| 1791 | // recreate it. Stopping and recreating the stream can only be done on the main |
| 1792 | // thread and in the context of VideoSendStreamTest (not BaseTest). |
| 1793 | template <typename T> |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1794 | class MaxPaddingSetTest : public test::SendTest { |
| 1795 | public: |
| 1796 | static const uint32_t kMinTransmitBitrateBps = 400000; |
| 1797 | static const uint32_t kActualEncodeBitrateBps = 40000; |
| 1798 | static const uint32_t kMinPacketsToSend = 50; |
| 1799 | |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1800 | explicit MaxPaddingSetTest(bool test_switch_content_type, T* stream_reset_fun) |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1801 | : SendTest(test::CallTest::kDefaultTimeoutMs), |
| 1802 | call_(nullptr), |
| 1803 | send_stream_(nullptr), |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1804 | send_stream_config_(nullptr), |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1805 | packets_sent_(0), |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1806 | running_without_padding_(test_switch_content_type), |
tommi | 39e1289 | 2017-03-13 12:15:14 | [diff] [blame] | 1807 | stream_resetter_(stream_reset_fun) { |
| 1808 | RTC_DCHECK(stream_resetter_); |
| 1809 | } |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1810 | |
| 1811 | void OnVideoStreamsCreated( |
| 1812 | VideoSendStream* send_stream, |
| 1813 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1814 | rtc::CritScope lock(&crit_); |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1815 | send_stream_ = send_stream; |
| 1816 | } |
| 1817 | |
| 1818 | void ModifyVideoConfigs( |
| 1819 | VideoSendStream::Config* send_config, |
| 1820 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 1821 | VideoEncoderConfig* encoder_config) override { |
kwiberg | af476c7 | 2016-11-28 23:21:39 | [diff] [blame] | 1822 | RTC_DCHECK_EQ(1, encoder_config->number_of_streams); |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1823 | if (RunningWithoutPadding()) { |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1824 | encoder_config->min_transmit_bitrate_bps = 0; |
| 1825 | encoder_config->content_type = |
| 1826 | VideoEncoderConfig::ContentType::kRealtimeVideo; |
| 1827 | } else { |
| 1828 | encoder_config->min_transmit_bitrate_bps = kMinTransmitBitrateBps; |
| 1829 | encoder_config->content_type = VideoEncoderConfig::ContentType::kScreen; |
| 1830 | } |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1831 | send_stream_config_ = send_config->Copy(); |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 1832 | encoder_config_ = encoder_config->Copy(); |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1833 | } |
| 1834 | |
| 1835 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
| 1836 | call_ = sender_call; |
| 1837 | } |
| 1838 | |
| 1839 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 1840 | rtc::CritScope lock(&crit_); |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1841 | if (running_without_padding_) |
| 1842 | EXPECT_EQ(0, call_->GetStats().max_padding_bitrate_bps); |
| 1843 | |
| 1844 | // Wait until at least kMinPacketsToSend frames have been encoded, so that |
| 1845 | // we have reliable data. |
| 1846 | if (++packets_sent_ < kMinPacketsToSend) |
| 1847 | return SEND_PACKET; |
| 1848 | |
| 1849 | if (running_without_padding_) { |
| 1850 | // We've sent kMinPacketsToSend packets with default configuration, switch |
| 1851 | // to enabling screen content and setting min transmit bitrate. |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1852 | // Note that we need to recreate the stream if changing content type. |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1853 | packets_sent_ = 0; |
| 1854 | encoder_config_.min_transmit_bitrate_bps = kMinTransmitBitrateBps; |
| 1855 | encoder_config_.content_type = VideoEncoderConfig::ContentType::kScreen; |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1856 | running_without_padding_ = false; |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1857 | content_switch_event_.Set(); |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1858 | return SEND_PACKET; |
| 1859 | } |
| 1860 | |
| 1861 | // Make sure the pacer has been configured with a min transmit bitrate. |
| 1862 | if (call_->GetStats().max_padding_bitrate_bps > 0) |
| 1863 | observation_complete_.Set(); |
| 1864 | |
| 1865 | return SEND_PACKET; |
| 1866 | } |
| 1867 | |
| 1868 | void PerformTest() override { |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1869 | if (RunningWithoutPadding()) { |
| 1870 | ASSERT_TRUE( |
| 1871 | content_switch_event_.Wait(test::CallTest::kDefaultTimeoutMs)); |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1872 | (*stream_resetter_)(send_stream_config_, encoder_config_); |
| 1873 | } |
| 1874 | |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1875 | ASSERT_TRUE(Wait()) << "Timed out waiting for a valid padding bitrate."; |
| 1876 | } |
| 1877 | |
| 1878 | private: |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1879 | bool RunningWithoutPadding() const { |
| 1880 | rtc::CritScope lock(&crit_); |
| 1881 | return running_without_padding_; |
| 1882 | } |
| 1883 | |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1884 | rtc::CriticalSection crit_; |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1885 | rtc::Event content_switch_event_; |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1886 | Call* call_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 1887 | VideoSendStream* send_stream_ RTC_GUARDED_BY(crit_); |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1888 | VideoSendStream::Config send_stream_config_; |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1889 | VideoEncoderConfig encoder_config_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 1890 | uint32_t packets_sent_ RTC_GUARDED_BY(crit_); |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1891 | bool running_without_padding_; |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1892 | T* const stream_resetter_; |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1893 | }; |
| 1894 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1895 | TEST_P(VideoSendStreamTest, RespectsMinTransmitBitrate) { |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1896 | auto reset_fun = [](const VideoSendStream::Config& send_stream_config, |
| 1897 | const VideoEncoderConfig& encoder_config) {}; |
| 1898 | MaxPaddingSetTest<decltype(reset_fun)> test(false, &reset_fun); |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1899 | RunBaseTest(&test); |
| 1900 | } |
| 1901 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1902 | TEST_P(VideoSendStreamTest, RespectsMinTransmitBitrateAfterContentSwitch) { |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1903 | // Function for removing and recreating the send stream with a new config. |
| 1904 | auto reset_fun = [this](const VideoSendStream::Config& send_stream_config, |
| 1905 | const VideoEncoderConfig& encoder_config) { |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1906 | task_queue_.SendTask([this, &send_stream_config, &encoder_config]() { |
| 1907 | Stop(); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 1908 | DestroyVideoSendStreams(); |
| 1909 | SetVideoSendConfig(send_stream_config); |
| 1910 | SetVideoEncoderConfig(encoder_config); |
| 1911 | CreateVideoSendStreams(); |
| 1912 | SetVideoDegradation(DegradationPreference::MAINTAIN_RESOLUTION); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1913 | Start(); |
| 1914 | }); |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 1915 | }; |
| 1916 | MaxPaddingSetTest<decltype(reset_fun)> test(true, &reset_fun); |
sprang | 9c0b551 | 2016-07-06 07:54:28 | [diff] [blame] | 1917 | RunBaseTest(&test); |
| 1918 | } |
| 1919 | |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1920 | // This test verifies that new frame sizes reconfigures encoders even though not |
| 1921 | // (yet) sending. The purpose of this is to permit encoding as quickly as |
| 1922 | // possible once we start sending. Likely the frames being input are from the |
| 1923 | // same source that will be sent later, which just means that we're ready |
| 1924 | // earlier. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 1925 | TEST_P(VideoSendStreamTest, |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1926 | EncoderReconfigureOnResolutionChangeWhenNotSending) { |
| 1927 | class EncoderObserver : public test::FakeEncoder { |
| 1928 | public: |
| 1929 | EncoderObserver() |
| 1930 | : FakeEncoder(Clock::GetRealTimeClock()), |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1931 | number_of_initializations_(0), |
| 1932 | last_initialized_frame_width_(0), |
| 1933 | last_initialized_frame_height_(0) {} |
| 1934 | |
| 1935 | void WaitForResolution(int width, int height) { |
| 1936 | { |
| 1937 | rtc::CritScope lock(&crit_); |
| 1938 | if (last_initialized_frame_width_ == width && |
| 1939 | last_initialized_frame_height_ == height) { |
| 1940 | return; |
| 1941 | } |
| 1942 | } |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 1943 | EXPECT_TRUE( |
| 1944 | init_encode_called_.Wait(VideoSendStreamTest::kDefaultTimeoutMs)); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1945 | { |
| 1946 | rtc::CritScope lock(&crit_); |
| 1947 | EXPECT_EQ(width, last_initialized_frame_width_); |
| 1948 | EXPECT_EQ(height, last_initialized_frame_height_); |
| 1949 | } |
| 1950 | } |
| 1951 | |
| 1952 | private: |
| 1953 | int32_t InitEncode(const VideoCodec* config, |
| 1954 | int32_t number_of_cores, |
| 1955 | size_t max_payload_size) override { |
| 1956 | rtc::CritScope lock(&crit_); |
| 1957 | last_initialized_frame_width_ = config->width; |
| 1958 | last_initialized_frame_height_ = config->height; |
| 1959 | ++number_of_initializations_; |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 1960 | init_encode_called_.Set(); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1961 | return FakeEncoder::InitEncode(config, number_of_cores, max_payload_size); |
| 1962 | } |
| 1963 | |
| 1964 | int32_t Encode(const VideoFrame& input_image, |
| 1965 | const CodecSpecificInfo* codec_specific_info, |
| 1966 | const std::vector<FrameType>* frame_types) override { |
| 1967 | ADD_FAILURE() |
| 1968 | << "Unexpected Encode call since the send stream is not started"; |
| 1969 | return 0; |
| 1970 | } |
| 1971 | |
| 1972 | rtc::CriticalSection crit_; |
| 1973 | rtc::Event init_encode_called_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 1974 | size_t number_of_initializations_ RTC_GUARDED_BY(&crit_); |
| 1975 | int last_initialized_frame_width_ RTC_GUARDED_BY(&crit_); |
| 1976 | int last_initialized_frame_height_ RTC_GUARDED_BY(&crit_); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1977 | }; |
| 1978 | |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1979 | test::NullTransport transport; |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1980 | EncoderObserver encoder; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 1981 | test::VideoEncoderProxyFactory encoder_factory(&encoder); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1982 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 1983 | task_queue_.SendTask([this, &transport, &encoder_factory]() { |
Sebastian Jansson | 8e6602f | 2018-07-13 08:43:20 | [diff] [blame] | 1984 | CreateSenderCall(); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1985 | CreateSendConfig(1, 0, 0, &transport); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 1986 | GetVideoSendConfig()->encoder_settings.encoder_factory = &encoder_factory; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1987 | CreateVideoStreams(); |
| 1988 | CreateFrameGeneratorCapturer(kDefaultFramerate, kDefaultWidth, |
| 1989 | kDefaultHeight); |
| 1990 | frame_generator_capturer_->Start(); |
| 1991 | }); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 1992 | |
| 1993 | encoder.WaitForResolution(kDefaultWidth, kDefaultHeight); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 1994 | |
| 1995 | task_queue_.SendTask([this]() { |
| 1996 | frame_generator_capturer_->ChangeResolution(kDefaultWidth * 2, |
| 1997 | kDefaultHeight * 2); |
| 1998 | }); |
| 1999 | |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2000 | encoder.WaitForResolution(kDefaultWidth * 2, kDefaultHeight * 2); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2001 | |
| 2002 | task_queue_.SendTask([this]() { |
| 2003 | DestroyStreams(); |
| 2004 | DestroyCalls(); |
| 2005 | }); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2006 | } |
| 2007 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2008 | TEST_P(VideoSendStreamTest, CanReconfigureToUseStartBitrateAbovePreviousMax) { |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2009 | class StartBitrateObserver : public test::FakeEncoder { |
| 2010 | public: |
| 2011 | StartBitrateObserver() |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2012 | : FakeEncoder(Clock::GetRealTimeClock()), |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2013 | start_bitrate_kbps_(0) {} |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2014 | int32_t InitEncode(const VideoCodec* config, |
| 2015 | int32_t number_of_cores, |
| 2016 | size_t max_payload_size) override { |
| 2017 | rtc::CritScope lock(&crit_); |
| 2018 | start_bitrate_kbps_ = config->startBitrate; |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2019 | start_bitrate_changed_.Set(); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2020 | return FakeEncoder::InitEncode(config, number_of_cores, max_payload_size); |
| 2021 | } |
| 2022 | |
| 2023 | int32_t SetRates(uint32_t new_target_bitrate, uint32_t framerate) override { |
| 2024 | rtc::CritScope lock(&crit_); |
| 2025 | start_bitrate_kbps_ = new_target_bitrate; |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2026 | start_bitrate_changed_.Set(); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2027 | return FakeEncoder::SetRates(new_target_bitrate, framerate); |
| 2028 | } |
| 2029 | |
| 2030 | int GetStartBitrateKbps() const { |
| 2031 | rtc::CritScope lock(&crit_); |
| 2032 | return start_bitrate_kbps_; |
| 2033 | } |
| 2034 | |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2035 | bool WaitForStartBitrate() { |
| 2036 | return start_bitrate_changed_.Wait( |
| 2037 | VideoSendStreamTest::kDefaultTimeoutMs); |
| 2038 | } |
| 2039 | |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2040 | private: |
pbos | 5ad935c | 2016-01-25 11:52:44 | [diff] [blame] | 2041 | rtc::CriticalSection crit_; |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2042 | rtc::Event start_bitrate_changed_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 2043 | int start_bitrate_kbps_ RTC_GUARDED_BY(crit_); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2044 | }; |
| 2045 | |
Sebastian Jansson | 8e6602f | 2018-07-13 08:43:20 | [diff] [blame] | 2046 | CreateSenderCall(); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2047 | |
solenberg | 4fbae2b | 2015-08-28 11:07:10 | [diff] [blame] | 2048 | test::NullTransport transport; |
brandtr | 841de6a | 2016-11-15 15:10:52 | [diff] [blame] | 2049 | CreateSendConfig(1, 0, 0, &transport); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2050 | |
Sebastian Jansson | fc8d26b | 2018-02-21 08:52:06 | [diff] [blame] | 2051 | BitrateConstraints bitrate_config; |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2052 | bitrate_config.start_bitrate_bps = |
| 2053 | 2 * GetVideoEncoderConfig()->max_bitrate_bps; |
Sebastian Jansson | 8f83b42 | 2018-02-21 12:07:13 | [diff] [blame] | 2054 | sender_call_->GetTransportControllerSend()->SetSdpBitrateParameters( |
| 2055 | bitrate_config); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2056 | |
| 2057 | StartBitrateObserver encoder; |
Mirta Dvornicic | 1ec2a16 | 2018-12-10 09:47:34 | [diff] [blame] | 2058 | test::VideoEncoderProxyFactory encoder_factory(&encoder); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2059 | // Since this test does not use a capturer, set |internal_source| = true. |
| 2060 | // Encoder configuration is otherwise updated on the next video frame. |
Mirta Dvornicic | 1ec2a16 | 2018-12-10 09:47:34 | [diff] [blame] | 2061 | encoder_factory.SetHasInternalSource(true); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2062 | GetVideoSendConfig()->encoder_settings.encoder_factory = &encoder_factory; |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2063 | |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 2064 | CreateVideoStreams(); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2065 | |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2066 | EXPECT_TRUE(encoder.WaitForStartBitrate()); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2067 | EXPECT_EQ(GetVideoEncoderConfig()->max_bitrate_bps / 1000, |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2068 | encoder.GetStartBitrateKbps()); |
| 2069 | |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2070 | GetVideoEncoderConfig()->max_bitrate_bps = |
| 2071 | 2 * bitrate_config.start_bitrate_bps; |
| 2072 | GetVideoSendStream()->ReconfigureVideoEncoder( |
| 2073 | GetVideoEncoderConfig()->Copy()); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2074 | |
| 2075 | // New bitrate should be reconfigured above the previous max. As there's no |
| 2076 | // network connection this shouldn't be flaky, as no bitrate should've been |
| 2077 | // reported in between. |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2078 | EXPECT_TRUE(encoder.WaitForStartBitrate()); |
pbos@webrtc.org | 143451d | 2015-03-18 14:40:03 | [diff] [blame] | 2079 | EXPECT_EQ(bitrate_config.start_bitrate_bps / 1000, |
| 2080 | encoder.GetStartBitrateKbps()); |
| 2081 | |
| 2082 | DestroyStreams(); |
| 2083 | } |
| 2084 | |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2085 | class StartStopBitrateObserver : public test::FakeEncoder { |
| 2086 | public: |
Niels Möller | c572ff3 | 2018-11-07 07:43:50 | [diff] [blame] | 2087 | StartStopBitrateObserver() : FakeEncoder(Clock::GetRealTimeClock()) {} |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2088 | int32_t InitEncode(const VideoCodec* config, |
| 2089 | int32_t number_of_cores, |
| 2090 | size_t max_payload_size) override { |
| 2091 | rtc::CritScope lock(&crit_); |
| 2092 | encoder_init_.Set(); |
| 2093 | return FakeEncoder::InitEncode(config, number_of_cores, max_payload_size); |
| 2094 | } |
| 2095 | |
Erik Språng | 566124a | 2018-04-23 10:32:22 | [diff] [blame] | 2096 | int32_t SetRateAllocation(const VideoBitrateAllocation& bitrate, |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2097 | uint32_t framerate) override { |
| 2098 | rtc::CritScope lock(&crit_); |
| 2099 | bitrate_kbps_ = bitrate.get_sum_kbps(); |
| 2100 | bitrate_changed_.Set(); |
| 2101 | return FakeEncoder::SetRateAllocation(bitrate, framerate); |
| 2102 | } |
| 2103 | |
| 2104 | bool WaitForEncoderInit() { |
| 2105 | return encoder_init_.Wait(VideoSendStreamTest::kDefaultTimeoutMs); |
| 2106 | } |
| 2107 | |
| 2108 | bool WaitBitrateChanged(bool non_zero) { |
| 2109 | do { |
Danil Chapovalov | b9b146c | 2018-06-15 10:28:07 | [diff] [blame] | 2110 | absl::optional<int> bitrate_kbps; |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2111 | { |
| 2112 | rtc::CritScope lock(&crit_); |
| 2113 | bitrate_kbps = bitrate_kbps_; |
| 2114 | } |
| 2115 | if (!bitrate_kbps) |
| 2116 | continue; |
| 2117 | |
| 2118 | if ((non_zero && *bitrate_kbps > 0) || |
| 2119 | (!non_zero && *bitrate_kbps == 0)) { |
| 2120 | return true; |
| 2121 | } |
| 2122 | } while (bitrate_changed_.Wait(VideoSendStreamTest::kDefaultTimeoutMs)); |
| 2123 | return false; |
| 2124 | } |
| 2125 | |
| 2126 | private: |
| 2127 | rtc::CriticalSection crit_; |
| 2128 | rtc::Event encoder_init_; |
| 2129 | rtc::Event bitrate_changed_; |
Danil Chapovalov | b9b146c | 2018-06-15 10:28:07 | [diff] [blame] | 2130 | absl::optional<int> bitrate_kbps_ RTC_GUARDED_BY(crit_); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2131 | }; |
| 2132 | |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 2133 | // This test that if the encoder use an internal source, VideoEncoder::SetRates |
| 2134 | // will be called with zero bitrate during initialization and that |
| 2135 | // VideoSendStream::Stop also triggers VideoEncoder::SetRates Start to be called |
| 2136 | // with zero bitrate. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2137 | TEST_P(VideoSendStreamTest, VideoSendStreamStopSetEncoderRateToZero) { |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 2138 | test::NullTransport transport; |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 2139 | StartStopBitrateObserver encoder; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 2140 | test::VideoEncoderProxyFactory encoder_factory(&encoder); |
Mirta Dvornicic | 1ec2a16 | 2018-12-10 09:47:34 | [diff] [blame] | 2141 | encoder_factory.SetHasInternalSource(true); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2142 | test::FrameForwarder forwarder; |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 2143 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2144 | task_queue_.SendTask([this, &transport, &encoder_factory, &forwarder]() { |
Sebastian Jansson | 8e6602f | 2018-07-13 08:43:20 | [diff] [blame] | 2145 | CreateSenderCall(); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2146 | CreateSendConfig(1, 0, 0, &transport); |
| 2147 | |
| 2148 | sender_call_->SignalChannelNetworkState(MediaType::VIDEO, kNetworkUp); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2149 | GetVideoSendConfig()->encoder_settings.encoder_factory = &encoder_factory; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2150 | |
| 2151 | CreateVideoStreams(); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2152 | // Inject a frame, to force encoder creation. |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2153 | GetVideoSendStream()->Start(); |
| 2154 | GetVideoSendStream()->SetSource(&forwarder, |
| 2155 | DegradationPreference::DISABLED); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2156 | forwarder.IncomingCapturedFrame(CreateVideoFrame(640, 480, 4)); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2157 | }); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 2158 | |
| 2159 | EXPECT_TRUE(encoder.WaitForEncoderInit()); |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 2160 | |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2161 | task_queue_.SendTask([this]() { GetVideoSendStream()->Start(); }); |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 2162 | EXPECT_TRUE(encoder.WaitBitrateChanged(true)); |
| 2163 | |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2164 | task_queue_.SendTask([this]() { GetVideoSendStream()->Stop(); }); |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 2165 | EXPECT_TRUE(encoder.WaitBitrateChanged(false)); |
| 2166 | |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2167 | task_queue_.SendTask([this]() { GetVideoSendStream()->Start(); }); |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 2168 | EXPECT_TRUE(encoder.WaitBitrateChanged(true)); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 2169 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2170 | task_queue_.SendTask([this]() { |
| 2171 | DestroyStreams(); |
| 2172 | DestroyCalls(); |
| 2173 | }); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 2174 | } |
| 2175 | |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2176 | // Tests that when the encoder uses an internal source, the VideoEncoder will |
| 2177 | // be updated with a new bitrate when turning the VideoSendStream on/off with |
| 2178 | // VideoSendStream::UpdateActiveSimulcastLayers, and when the VideoStreamEncoder |
| 2179 | // is reconfigured with new active layers. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2180 | TEST_P(VideoSendStreamTest, VideoSendStreamUpdateActiveSimulcastLayers) { |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2181 | test::NullTransport transport; |
| 2182 | StartStopBitrateObserver encoder; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 2183 | test::VideoEncoderProxyFactory encoder_factory(&encoder); |
Mirta Dvornicic | 1ec2a16 | 2018-12-10 09:47:34 | [diff] [blame] | 2184 | encoder_factory.SetHasInternalSource(true); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2185 | test::FrameForwarder forwarder; |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2186 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2187 | task_queue_.SendTask([this, &transport, &encoder_factory, &forwarder]() { |
Sebastian Jansson | 8e6602f | 2018-07-13 08:43:20 | [diff] [blame] | 2188 | CreateSenderCall(); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2189 | // Create two simulcast streams. |
| 2190 | CreateSendConfig(2, 0, 0, &transport); |
| 2191 | |
| 2192 | sender_call_->SignalChannelNetworkState(MediaType::VIDEO, kNetworkUp); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2193 | GetVideoSendConfig()->encoder_settings.encoder_factory = &encoder_factory; |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2194 | |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2195 | CreateVideoStreams(); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2196 | |
| 2197 | // Inject a frame, to force encoder creation. |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2198 | GetVideoSendStream()->Start(); |
| 2199 | GetVideoSendStream()->SetSource(&forwarder, |
| 2200 | DegradationPreference::DISABLED); |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2201 | forwarder.IncomingCapturedFrame(CreateVideoFrame(640, 480, 4)); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2202 | }); |
| 2203 | |
| 2204 | EXPECT_TRUE(encoder.WaitForEncoderInit()); |
| 2205 | |
| 2206 | // When we turn on the simulcast layers it will update the BitrateAllocator, |
| 2207 | // which in turn updates the VideoEncoder's bitrate. |
| 2208 | task_queue_.SendTask([this]() { |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2209 | GetVideoSendStream()->UpdateActiveSimulcastLayers({true, true}); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2210 | }); |
| 2211 | EXPECT_TRUE(encoder.WaitBitrateChanged(true)); |
| 2212 | |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2213 | GetVideoEncoderConfig()->simulcast_layers[0].active = true; |
| 2214 | GetVideoEncoderConfig()->simulcast_layers[1].active = false; |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2215 | task_queue_.SendTask([this]() { |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2216 | GetVideoSendStream()->ReconfigureVideoEncoder( |
| 2217 | GetVideoEncoderConfig()->Copy()); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2218 | }); |
| 2219 | // TODO(bugs.webrtc.org/8807): Currently we require a hard reconfiguration to |
| 2220 | // update the VideoBitrateAllocator and BitrateAllocator of which layers are |
| 2221 | // active. Once the change is made for a "soft" reconfiguration we can remove |
| 2222 | // the expecation for an encoder init. We can also test that bitrate changes |
| 2223 | // when just updating individual active layers, which should change the |
| 2224 | // bitrate set to the video encoder. |
| 2225 | EXPECT_TRUE(encoder.WaitForEncoderInit()); |
| 2226 | EXPECT_TRUE(encoder.WaitBitrateChanged(true)); |
| 2227 | |
| 2228 | // Turning off both simulcast layers should trigger a bitrate change of 0. |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2229 | GetVideoEncoderConfig()->simulcast_layers[0].active = false; |
| 2230 | GetVideoEncoderConfig()->simulcast_layers[1].active = false; |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2231 | task_queue_.SendTask([this]() { |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 2232 | GetVideoSendStream()->UpdateActiveSimulcastLayers({false, false}); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 2233 | }); |
| 2234 | EXPECT_TRUE(encoder.WaitBitrateChanged(false)); |
| 2235 | |
| 2236 | task_queue_.SendTask([this]() { |
| 2237 | DestroyStreams(); |
| 2238 | DestroyCalls(); |
| 2239 | }); |
| 2240 | } |
wuchengli@chromium.org | f425b55 | 2014-06-20 12:04:05 | [diff] [blame] | 2241 | |
Miguel Casas-Sanchez | 4765070 | 2015-05-30 00:21:40 | [diff] [blame] | 2242 | VideoFrame CreateVideoFrame(int width, int height, uint8_t data) { |
wuchengli@chromium.org | f425b55 | 2014-06-20 12:04:05 | [diff] [blame] | 2243 | const int kSizeY = width * height * 2; |
kwiberg | 27f982b | 2016-03-01 19:52:33 | [diff] [blame] | 2244 | std::unique_ptr<uint8_t[]> buffer(new uint8_t[kSizeY]); |
wuchengli@chromium.org | f425b55 | 2014-06-20 12:04:05 | [diff] [blame] | 2245 | memset(buffer.get(), data, kSizeY); |
Artem Titov | 1ebfb6a | 2019-01-03 22:49:37 | [diff] [blame] | 2246 | VideoFrame frame = |
| 2247 | webrtc::VideoFrame::Builder() |
| 2248 | .set_video_frame_buffer(I420Buffer::Create(width, height)) |
| 2249 | .set_rotation(webrtc::kVideoRotation_0) |
| 2250 | .set_timestamp_us(data) |
| 2251 | .build(); |
magjed@webrtc.org | 2d2a30c | 2015-03-24 12:37:36 | [diff] [blame] | 2252 | frame.set_timestamp(data); |
nisse | 1c0dea8 | 2017-01-30 10:43:18 | [diff] [blame] | 2253 | // Use data as a ms timestamp. |
| 2254 | frame.set_timestamp_us(data * rtc::kNumMicrosecsPerMillisec); |
wuchengli@chromium.org | f425b55 | 2014-06-20 12:04:05 | [diff] [blame] | 2255 | return frame; |
| 2256 | } |
| 2257 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2258 | TEST_P(VideoSendStreamTest, EncoderIsProperlyInitializedAndDestroyed) { |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2259 | class EncoderStateObserver : public test::SendTest, public VideoEncoder { |
| 2260 | public: |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2261 | explicit EncoderStateObserver( |
| 2262 | test::SingleThreadedTaskQueueForTesting* task_queue) |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2263 | : SendTest(kDefaultTimeoutMs), |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2264 | task_queue_(task_queue), |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 2265 | stream_(nullptr), |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2266 | initialized_(false), |
| 2267 | callback_registered_(false), |
| 2268 | num_releases_(0), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2269 | released_(false), |
| 2270 | encoder_factory_(this) {} |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2271 | |
| 2272 | bool IsReleased() { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 2273 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2274 | return released_; |
| 2275 | } |
| 2276 | |
| 2277 | bool IsReadyForEncode() { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 2278 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2279 | return initialized_ && callback_registered_; |
| 2280 | } |
| 2281 | |
| 2282 | size_t num_releases() { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 2283 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2284 | return num_releases_; |
| 2285 | } |
| 2286 | |
| 2287 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2288 | int32_t InitEncode(const VideoCodec* codecSettings, |
| 2289 | int32_t numberOfCores, |
| 2290 | size_t maxPayloadSize) override { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 2291 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2292 | EXPECT_FALSE(initialized_); |
| 2293 | initialized_ = true; |
| 2294 | released_ = false; |
| 2295 | return 0; |
| 2296 | } |
| 2297 | |
Miguel Casas-Sanchez | 4765070 | 2015-05-30 00:21:40 | [diff] [blame] | 2298 | int32_t Encode(const VideoFrame& inputImage, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2299 | const CodecSpecificInfo* codecSpecificInfo, |
pbos | 22993e1 | 2015-10-19 09:39:06 | [diff] [blame] | 2300 | const std::vector<FrameType>* frame_types) override { |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2301 | EXPECT_TRUE(IsReadyForEncode()); |
| 2302 | |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 2303 | observation_complete_.Set(); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2304 | return 0; |
| 2305 | } |
| 2306 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2307 | int32_t RegisterEncodeCompleteCallback( |
| 2308 | EncodedImageCallback* callback) override { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 2309 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2310 | EXPECT_TRUE(initialized_); |
| 2311 | callback_registered_ = true; |
| 2312 | return 0; |
| 2313 | } |
| 2314 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2315 | int32_t Release() override { |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 2316 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2317 | EXPECT_TRUE(IsReadyForEncode()); |
| 2318 | EXPECT_FALSE(released_); |
| 2319 | initialized_ = false; |
| 2320 | callback_registered_ = false; |
| 2321 | released_ = true; |
| 2322 | ++num_releases_; |
| 2323 | return 0; |
| 2324 | } |
| 2325 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2326 | int32_t SetRates(uint32_t newBitRate, uint32_t frameRate) override { |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2327 | EXPECT_TRUE(IsReadyForEncode()); |
| 2328 | return 0; |
| 2329 | } |
| 2330 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2331 | void OnVideoStreamsCreated( |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2332 | VideoSendStream* send_stream, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2333 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2334 | stream_ = send_stream; |
| 2335 | } |
| 2336 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2337 | void ModifyVideoConfigs( |
| 2338 | VideoSendStream::Config* send_config, |
| 2339 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 2340 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2341 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2342 | encoder_config_ = encoder_config->Copy(); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2343 | } |
| 2344 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2345 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 2346 | EXPECT_TRUE(Wait()) << "Timed out while waiting for Encode."; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2347 | |
| 2348 | task_queue_->SendTask([this]() { |
| 2349 | EXPECT_EQ(0u, num_releases()); |
| 2350 | stream_->ReconfigureVideoEncoder(std::move(encoder_config_)); |
| 2351 | EXPECT_EQ(0u, num_releases()); |
| 2352 | stream_->Stop(); |
| 2353 | // Encoder should not be released before destroying the VideoSendStream. |
| 2354 | EXPECT_FALSE(IsReleased()); |
| 2355 | EXPECT_TRUE(IsReadyForEncode()); |
| 2356 | stream_->Start(); |
| 2357 | }); |
| 2358 | |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2359 | // Sanity check, make sure we still encode frames with this encoder. |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 2360 | EXPECT_TRUE(Wait()) << "Timed out while waiting for Encode."; |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2361 | } |
| 2362 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2363 | test::SingleThreadedTaskQueueForTesting* const task_queue_; |
Peter Boström | f2f8283 | 2015-05-01 11:00:41 | [diff] [blame] | 2364 | rtc::CriticalSection crit_; |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2365 | VideoSendStream* stream_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 2366 | bool initialized_ RTC_GUARDED_BY(crit_); |
| 2367 | bool callback_registered_ RTC_GUARDED_BY(crit_); |
| 2368 | size_t num_releases_ RTC_GUARDED_BY(crit_); |
| 2369 | bool released_ RTC_GUARDED_BY(crit_); |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 2370 | test::VideoEncoderProxyFactory encoder_factory_; |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2371 | VideoEncoderConfig encoder_config_; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2372 | } test_encoder(&task_queue_); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2373 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 2374 | RunBaseTest(&test_encoder); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2375 | |
| 2376 | EXPECT_TRUE(test_encoder.IsReleased()); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2377 | EXPECT_EQ(1u, test_encoder.num_releases()); |
pbos@webrtc.org | 161f808 | 2014-07-07 14:22:35 | [diff] [blame] | 2378 | } |
| 2379 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2380 | TEST_P(VideoSendStreamTest, EncoderSetupPropagatesCommonEncoderConfigValues) { |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2381 | class VideoCodecConfigObserver : public test::SendTest, |
| 2382 | public test::FakeEncoder { |
| 2383 | public: |
| 2384 | VideoCodecConfigObserver() |
| 2385 | : SendTest(kDefaultTimeoutMs), |
| 2386 | FakeEncoder(Clock::GetRealTimeClock()), |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 2387 | num_initializations_(0), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2388 | stream_(nullptr), |
| 2389 | encoder_factory_(this) {} |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2390 | |
| 2391 | private: |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2392 | void ModifyVideoConfigs( |
| 2393 | VideoSendStream::Config* send_config, |
| 2394 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 2395 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2396 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 2397 | encoder_config->max_bitrate_bps = kFirstMaxBitrateBps; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2398 | encoder_config_ = encoder_config->Copy(); |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2399 | } |
| 2400 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2401 | void OnVideoStreamsCreated( |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2402 | VideoSendStream* send_stream, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2403 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2404 | stream_ = send_stream; |
| 2405 | } |
| 2406 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2407 | int32_t InitEncode(const VideoCodec* config, |
| 2408 | int32_t number_of_cores, |
| 2409 | size_t max_payload_size) override { |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2410 | if (num_initializations_ == 0) { |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2411 | // Verify default values. |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 2412 | EXPECT_EQ(kFirstMaxBitrateBps / 1000, config->maxBitrate); |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2413 | } else { |
| 2414 | // Verify that changed values are propagated. |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 2415 | EXPECT_EQ(kSecondMaxBitrateBps / 1000, config->maxBitrate); |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2416 | } |
| 2417 | ++num_initializations_; |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2418 | init_encode_event_.Set(); |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2419 | return FakeEncoder::InitEncode(config, number_of_cores, max_payload_size); |
| 2420 | } |
| 2421 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2422 | void PerformTest() override { |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2423 | EXPECT_TRUE(init_encode_event_.Wait(kDefaultTimeoutMs)); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2424 | EXPECT_EQ(1u, num_initializations_) << "VideoEncoder not initialized."; |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2425 | |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 2426 | encoder_config_.max_bitrate_bps = kSecondMaxBitrateBps; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2427 | stream_->ReconfigureVideoEncoder(std::move(encoder_config_)); |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2428 | EXPECT_TRUE(init_encode_event_.Wait(kDefaultTimeoutMs)); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2429 | EXPECT_EQ(2u, num_initializations_) |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2430 | << "ReconfigureVideoEncoder did not reinitialize the encoder with " |
| 2431 | "new encoder settings."; |
| 2432 | } |
| 2433 | |
sprang | f24a064 | 2017-02-28 21:23:26 | [diff] [blame] | 2434 | const uint32_t kFirstMaxBitrateBps = 1000000; |
| 2435 | const uint32_t kSecondMaxBitrateBps = 2000000; |
| 2436 | |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2437 | rtc::Event init_encode_event_; |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2438 | size_t num_initializations_; |
| 2439 | VideoSendStream* stream_; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 2440 | test::VideoEncoderProxyFactory encoder_factory_; |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2441 | VideoEncoderConfig encoder_config_; |
| 2442 | } test; |
| 2443 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 2444 | RunBaseTest(&test); |
pbos@webrtc.org | bbe0a85 | 2014-09-19 12:30:25 | [diff] [blame] | 2445 | } |
| 2446 | |
Sergey Silkin | 571e6c9 | 2018-04-03 08:03:31 | [diff] [blame] | 2447 | static const size_t kVideoCodecConfigObserverNumberOfTemporalLayers = 3; |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2448 | template <typename T> |
| 2449 | class VideoCodecConfigObserver : public test::SendTest, |
| 2450 | public test::FakeEncoder { |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2451 | public: |
| 2452 | VideoCodecConfigObserver(VideoCodecType video_codec_type, |
| 2453 | const char* codec_name) |
| 2454 | : SendTest(VideoSendStreamTest::kDefaultTimeoutMs), |
| 2455 | FakeEncoder(Clock::GetRealTimeClock()), |
| 2456 | video_codec_type_(video_codec_type), |
| 2457 | codec_name_(codec_name), |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 2458 | num_initializations_(0), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2459 | stream_(nullptr), |
| 2460 | encoder_factory_(this) { |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 2461 | InitCodecSpecifics(); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2462 | } |
| 2463 | |
| 2464 | private: |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2465 | void ModifyVideoConfigs( |
| 2466 | VideoSendStream::Config* send_config, |
| 2467 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 2468 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2469 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 2470 | send_config->rtp.payload_name = codec_name_; |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2471 | |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 2472 | encoder_config->codec_type = video_codec_type_; |
kthelgason | 29a44e3 | 2016-09-27 10:52:02 | [diff] [blame] | 2473 | encoder_config->encoder_specific_settings = GetEncoderSpecificSettings(); |
Åsa Persson | d34597c | 2018-10-22 15:34:02 | [diff] [blame] | 2474 | EXPECT_EQ(1u, encoder_config->simulcast_layers.size()); |
| 2475 | encoder_config->simulcast_layers[0].num_temporal_layers = |
| 2476 | kVideoCodecConfigObserverNumberOfTemporalLayers; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2477 | encoder_config_ = encoder_config->Copy(); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2478 | } |
| 2479 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2480 | void OnVideoStreamsCreated( |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2481 | VideoSendStream* send_stream, |
| 2482 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
| 2483 | stream_ = send_stream; |
| 2484 | } |
| 2485 | |
| 2486 | int32_t InitEncode(const VideoCodec* config, |
| 2487 | int32_t number_of_cores, |
| 2488 | size_t max_payload_size) override { |
| 2489 | EXPECT_EQ(video_codec_type_, config->codecType); |
| 2490 | VerifyCodecSpecifics(*config); |
| 2491 | ++num_initializations_; |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2492 | init_encode_event_.Set(); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2493 | return FakeEncoder::InitEncode(config, number_of_cores, max_payload_size); |
| 2494 | } |
| 2495 | |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 2496 | void InitCodecSpecifics(); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2497 | void VerifyCodecSpecifics(const VideoCodec& config) const; |
kthelgason | 29a44e3 | 2016-09-27 10:52:02 | [diff] [blame] | 2498 | rtc::scoped_refptr<VideoEncoderConfig::EncoderSpecificSettings> |
| 2499 | GetEncoderSpecificSettings() const; |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2500 | |
| 2501 | void PerformTest() override { |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2502 | EXPECT_TRUE( |
| 2503 | init_encode_event_.Wait(VideoSendStreamTest::kDefaultTimeoutMs)); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2504 | ASSERT_EQ(1u, num_initializations_) << "VideoEncoder not initialized."; |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2505 | |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 2506 | // Change encoder settings to actually trigger reconfiguration. |
| 2507 | encoder_settings_.frameDroppingOn = !encoder_settings_.frameDroppingOn; |
kthelgason | 29a44e3 | 2016-09-27 10:52:02 | [diff] [blame] | 2508 | encoder_config_.encoder_specific_settings = GetEncoderSpecificSettings(); |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2509 | stream_->ReconfigureVideoEncoder(std::move(encoder_config_)); |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2510 | ASSERT_TRUE( |
| 2511 | init_encode_event_.Wait(VideoSendStreamTest::kDefaultTimeoutMs)); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2512 | EXPECT_EQ(2u, num_initializations_) |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2513 | << "ReconfigureVideoEncoder did not reinitialize the encoder with " |
| 2514 | "new encoder settings."; |
| 2515 | } |
| 2516 | |
Miguel Casas-Sanchez | 4765070 | 2015-05-30 00:21:40 | [diff] [blame] | 2517 | int32_t Encode(const VideoFrame& input_image, |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2518 | const CodecSpecificInfo* codec_specific_info, |
pbos | 22993e1 | 2015-10-19 09:39:06 | [diff] [blame] | 2519 | const std::vector<FrameType>* frame_types) override { |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2520 | // Silently skip the encode, FakeEncoder::Encode doesn't produce VP8. |
| 2521 | return 0; |
| 2522 | } |
| 2523 | |
| 2524 | T encoder_settings_; |
| 2525 | const VideoCodecType video_codec_type_; |
| 2526 | const char* const codec_name_; |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2527 | rtc::Event init_encode_event_; |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2528 | size_t num_initializations_; |
| 2529 | VideoSendStream* stream_; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 2530 | test::VideoEncoderProxyFactory encoder_factory_; |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2531 | VideoEncoderConfig encoder_config_; |
| 2532 | }; |
| 2533 | |
| 2534 | template <> |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 2535 | void VideoCodecConfigObserver<VideoCodecH264>::InitCodecSpecifics() { |
| 2536 | encoder_settings_ = VideoEncoder::GetDefaultH264Settings(); |
| 2537 | } |
| 2538 | |
| 2539 | template <> |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2540 | void VideoCodecConfigObserver<VideoCodecH264>::VerifyCodecSpecifics( |
| 2541 | const VideoCodec& config) const { |
hta | 257dc39 | 2016-10-25 16:05:06 | [diff] [blame] | 2542 | EXPECT_EQ( |
| 2543 | 0, memcmp(&config.H264(), &encoder_settings_, sizeof(encoder_settings_))); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2544 | } |
kthelgason | 29a44e3 | 2016-09-27 10:52:02 | [diff] [blame] | 2545 | |
| 2546 | template <> |
| 2547 | rtc::scoped_refptr<VideoEncoderConfig::EncoderSpecificSettings> |
| 2548 | VideoCodecConfigObserver<VideoCodecH264>::GetEncoderSpecificSettings() const { |
| 2549 | return new rtc::RefCountedObject< |
| 2550 | VideoEncoderConfig::H264EncoderSpecificSettings>(encoder_settings_); |
| 2551 | } |
| 2552 | |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2553 | template <> |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 2554 | void VideoCodecConfigObserver<VideoCodecVP8>::InitCodecSpecifics() { |
| 2555 | encoder_settings_ = VideoEncoder::GetDefaultVp8Settings(); |
| 2556 | } |
| 2557 | |
| 2558 | template <> |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2559 | void VideoCodecConfigObserver<VideoCodecVP8>::VerifyCodecSpecifics( |
| 2560 | const VideoCodec& config) const { |
| 2561 | // Check that the number of temporal layers has propagated properly to |
| 2562 | // VideoCodec. |
| 2563 | EXPECT_EQ(kVideoCodecConfigObserverNumberOfTemporalLayers, |
hta | 257dc39 | 2016-10-25 16:05:06 | [diff] [blame] | 2564 | config.VP8().numberOfTemporalLayers); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2565 | |
| 2566 | for (unsigned char i = 0; i < config.numberOfSimulcastStreams; ++i) { |
| 2567 | EXPECT_EQ(kVideoCodecConfigObserverNumberOfTemporalLayers, |
| 2568 | config.simulcastStream[i].numberOfTemporalLayers); |
| 2569 | } |
| 2570 | |
| 2571 | // Set expected temporal layers as they should have been set when |
Erik Språng | 82fad3d | 2018-03-21 08:57:23 | [diff] [blame] | 2572 | // reconfiguring the encoder and not match the set config. |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2573 | VideoCodecVP8 encoder_settings = encoder_settings_; |
| 2574 | encoder_settings.numberOfTemporalLayers = |
| 2575 | kVideoCodecConfigObserverNumberOfTemporalLayers; |
hta | 257dc39 | 2016-10-25 16:05:06 | [diff] [blame] | 2576 | EXPECT_EQ( |
| 2577 | 0, memcmp(&config.VP8(), &encoder_settings, sizeof(encoder_settings_))); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2578 | } |
kthelgason | 29a44e3 | 2016-09-27 10:52:02 | [diff] [blame] | 2579 | |
| 2580 | template <> |
| 2581 | rtc::scoped_refptr<VideoEncoderConfig::EncoderSpecificSettings> |
| 2582 | VideoCodecConfigObserver<VideoCodecVP8>::GetEncoderSpecificSettings() const { |
| 2583 | return new rtc::RefCountedObject< |
| 2584 | VideoEncoderConfig::Vp8EncoderSpecificSettings>(encoder_settings_); |
| 2585 | } |
| 2586 | |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2587 | template <> |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 2588 | void VideoCodecConfigObserver<VideoCodecVP9>::InitCodecSpecifics() { |
| 2589 | encoder_settings_ = VideoEncoder::GetDefaultVp9Settings(); |
| 2590 | } |
| 2591 | |
| 2592 | template <> |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2593 | void VideoCodecConfigObserver<VideoCodecVP9>::VerifyCodecSpecifics( |
| 2594 | const VideoCodec& config) const { |
| 2595 | // Check that the number of temporal layers has propagated properly to |
| 2596 | // VideoCodec. |
| 2597 | EXPECT_EQ(kVideoCodecConfigObserverNumberOfTemporalLayers, |
hta | 257dc39 | 2016-10-25 16:05:06 | [diff] [blame] | 2598 | config.VP9().numberOfTemporalLayers); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2599 | |
| 2600 | for (unsigned char i = 0; i < config.numberOfSimulcastStreams; ++i) { |
| 2601 | EXPECT_EQ(kVideoCodecConfigObserverNumberOfTemporalLayers, |
| 2602 | config.simulcastStream[i].numberOfTemporalLayers); |
| 2603 | } |
| 2604 | |
| 2605 | // Set expected temporal layers as they should have been set when |
| 2606 | // reconfiguring the encoder and not match the set config. |
| 2607 | VideoCodecVP9 encoder_settings = encoder_settings_; |
| 2608 | encoder_settings.numberOfTemporalLayers = |
| 2609 | kVideoCodecConfigObserverNumberOfTemporalLayers; |
hta | 257dc39 | 2016-10-25 16:05:06 | [diff] [blame] | 2610 | EXPECT_EQ( |
| 2611 | 0, memcmp(&(config.VP9()), &encoder_settings, sizeof(encoder_settings_))); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2612 | } |
| 2613 | |
kthelgason | 29a44e3 | 2016-09-27 10:52:02 | [diff] [blame] | 2614 | template <> |
| 2615 | rtc::scoped_refptr<VideoEncoderConfig::EncoderSpecificSettings> |
| 2616 | VideoCodecConfigObserver<VideoCodecVP9>::GetEncoderSpecificSettings() const { |
| 2617 | return new rtc::RefCountedObject< |
| 2618 | VideoEncoderConfig::Vp9EncoderSpecificSettings>(encoder_settings_); |
| 2619 | } |
| 2620 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2621 | TEST_P(VideoSendStreamTest, EncoderSetupPropagatesVp8Config) { |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2622 | VideoCodecConfigObserver<VideoCodecVP8> test(kVideoCodecVP8, "VP8"); |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 2623 | RunBaseTest(&test); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2624 | } |
pbos@webrtc.org | 91f1752 | 2014-07-10 10:13:37 | [diff] [blame] | 2625 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2626 | TEST_P(VideoSendStreamTest, EncoderSetupPropagatesVp9Config) { |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2627 | VideoCodecConfigObserver<VideoCodecVP9> test(kVideoCodecVP9, "VP9"); |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 2628 | RunBaseTest(&test); |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2629 | } |
pbos@webrtc.org | 91f1752 | 2014-07-10 10:13:37 | [diff] [blame] | 2630 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2631 | TEST_P(VideoSendStreamTest, EncoderSetupPropagatesH264Config) { |
Peter Boström | 53eda3d | 2015-03-27 14:53:18 | [diff] [blame] | 2632 | VideoCodecConfigObserver<VideoCodecH264> test(kVideoCodecH264, "H264"); |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 2633 | RunBaseTest(&test); |
pbos@webrtc.org | 91f1752 | 2014-07-10 10:13:37 | [diff] [blame] | 2634 | } |
| 2635 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2636 | TEST_P(VideoSendStreamTest, RtcpSenderReportContainsMediaBytesSent) { |
asapersson@webrtc.org | 1467421 | 2015-02-23 08:14:07 | [diff] [blame] | 2637 | class RtcpSenderReportTest : public test::SendTest { |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2638 | public: |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 2639 | RtcpSenderReportTest() |
| 2640 | : SendTest(kDefaultTimeoutMs), |
| 2641 | rtp_packets_sent_(0), |
| 2642 | media_bytes_sent_(0) {} |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2643 | |
| 2644 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2645 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
stefan | 4b56904 | 2015-11-11 14:39:57 | [diff] [blame] | 2646 | rtc::CritScope lock(&crit_); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2647 | RTPHeader header; |
| 2648 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
asapersson@webrtc.org | 1467421 | 2015-02-23 08:14:07 | [diff] [blame] | 2649 | ++rtp_packets_sent_; |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2650 | media_bytes_sent_ += length - header.headerLength - header.paddingLength; |
| 2651 | return SEND_PACKET; |
| 2652 | } |
| 2653 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2654 | Action OnSendRtcp(const uint8_t* packet, size_t length) override { |
stefan | 4b56904 | 2015-11-11 14:39:57 | [diff] [blame] | 2655 | rtc::CritScope lock(&crit_); |
danilchap | 3dc929e | 2016-11-02 15:21:59 | [diff] [blame] | 2656 | test::RtcpPacketParser parser; |
| 2657 | EXPECT_TRUE(parser.Parse(packet, length)); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2658 | |
danilchap | 3dc929e | 2016-11-02 15:21:59 | [diff] [blame] | 2659 | if (parser.sender_report()->num_packets() > 0) { |
| 2660 | // Only compare sent media bytes if SenderPacketCount matches the |
| 2661 | // number of sent rtp packets (a new rtp packet could be sent before |
| 2662 | // the rtcp packet). |
| 2663 | if (parser.sender_report()->sender_octet_count() > 0 && |
| 2664 | parser.sender_report()->sender_packet_count() == |
| 2665 | rtp_packets_sent_) { |
| 2666 | EXPECT_EQ(media_bytes_sent_, |
| 2667 | parser.sender_report()->sender_octet_count()); |
| 2668 | observation_complete_.Set(); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2669 | } |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2670 | } |
| 2671 | |
| 2672 | return SEND_PACKET; |
| 2673 | } |
| 2674 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2675 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 2676 | EXPECT_TRUE(Wait()) << "Timed out while waiting for RTCP sender report."; |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2677 | } |
| 2678 | |
stefan | 4b56904 | 2015-11-11 14:39:57 | [diff] [blame] | 2679 | rtc::CriticalSection crit_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 2680 | size_t rtp_packets_sent_ RTC_GUARDED_BY(&crit_); |
| 2681 | size_t media_bytes_sent_ RTC_GUARDED_BY(&crit_); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2682 | } test; |
| 2683 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 2684 | RunBaseTest(&test); |
pbos@webrtc.org | 2f4b14e | 2014-07-15 15:25:39 | [diff] [blame] | 2685 | } |
| 2686 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2687 | TEST_P(VideoSendStreamTest, TranslatesTwoLayerScreencastToTargetBitrate) { |
Sergey Silkin | a796a7e | 2018-03-01 14:11:29 | [diff] [blame] | 2688 | static const int kScreencastMaxTargetBitrateDeltaKbps = 1; |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2689 | |
| 2690 | class VideoStreamFactory |
| 2691 | : public VideoEncoderConfig::VideoStreamFactoryInterface { |
| 2692 | public: |
| 2693 | VideoStreamFactory() {} |
| 2694 | |
| 2695 | private: |
| 2696 | std::vector<VideoStream> CreateEncoderStreams( |
| 2697 | int width, |
| 2698 | int height, |
| 2699 | const VideoEncoderConfig& encoder_config) override { |
| 2700 | std::vector<VideoStream> streams = |
| 2701 | test::CreateVideoStreams(width, height, encoder_config); |
Sergey Silkin | a796a7e | 2018-03-01 14:11:29 | [diff] [blame] | 2702 | RTC_CHECK_GT(streams[0].max_bitrate_bps, |
| 2703 | kScreencastMaxTargetBitrateDeltaKbps); |
| 2704 | streams[0].target_bitrate_bps = |
| 2705 | streams[0].max_bitrate_bps - |
| 2706 | kScreencastMaxTargetBitrateDeltaKbps * 1000; |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2707 | return streams; |
| 2708 | } |
| 2709 | }; |
| 2710 | |
pbos@webrtc.org | b7ed779 | 2014-10-31 13:08:10 | [diff] [blame] | 2711 | class ScreencastTargetBitrateTest : public test::SendTest, |
| 2712 | public test::FakeEncoder { |
| 2713 | public: |
| 2714 | ScreencastTargetBitrateTest() |
| 2715 | : SendTest(kDefaultTimeoutMs), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2716 | test::FakeEncoder(Clock::GetRealTimeClock()), |
| 2717 | encoder_factory_(this) {} |
pbos@webrtc.org | b7ed779 | 2014-10-31 13:08:10 | [diff] [blame] | 2718 | |
| 2719 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2720 | int32_t InitEncode(const VideoCodec* config, |
| 2721 | int32_t number_of_cores, |
| 2722 | size_t max_payload_size) override { |
Erik Språng | 5e898d6 | 2018-07-06 14:32:20 | [diff] [blame] | 2723 | EXPECT_EQ(config->numberOfSimulcastStreams, 1); |
Sergey Silkin | a796a7e | 2018-03-01 14:11:29 | [diff] [blame] | 2724 | EXPECT_EQ(static_cast<unsigned int>(kScreencastMaxTargetBitrateDeltaKbps), |
Erik Språng | 5e898d6 | 2018-07-06 14:32:20 | [diff] [blame] | 2725 | config->simulcastStream[0].maxBitrate - |
| 2726 | config->simulcastStream[0].targetBitrate); |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 2727 | observation_complete_.Set(); |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 2728 | return test::FakeEncoder::InitEncode(config, number_of_cores, |
| 2729 | max_payload_size); |
pbos@webrtc.org | b7ed779 | 2014-10-31 13:08:10 | [diff] [blame] | 2730 | } |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2731 | void ModifyVideoConfigs( |
| 2732 | VideoSendStream::Config* send_config, |
| 2733 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 2734 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2735 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2736 | EXPECT_EQ(1u, encoder_config->number_of_streams); |
| 2737 | encoder_config->video_stream_factory = |
| 2738 | new rtc::RefCountedObject<VideoStreamFactory>(); |
Åsa Persson | d34597c | 2018-10-22 15:34:02 | [diff] [blame] | 2739 | EXPECT_EQ(1u, encoder_config->simulcast_layers.size()); |
| 2740 | encoder_config->simulcast_layers[0].num_temporal_layers = 2; |
Erik Språng | 143cec1 | 2015-04-28 08:01:41 | [diff] [blame] | 2741 | encoder_config->content_type = VideoEncoderConfig::ContentType::kScreen; |
pbos@webrtc.org | b7ed779 | 2014-10-31 13:08:10 | [diff] [blame] | 2742 | } |
| 2743 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2744 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 2745 | EXPECT_TRUE(Wait()) |
pbos@webrtc.org | b7ed779 | 2014-10-31 13:08:10 | [diff] [blame] | 2746 | << "Timed out while waiting for the encoder to be initialized."; |
| 2747 | } |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 2748 | test::VideoEncoderProxyFactory encoder_factory_; |
pbos@webrtc.org | b7ed779 | 2014-10-31 13:08:10 | [diff] [blame] | 2749 | } test; |
| 2750 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 2751 | RunBaseTest(&test); |
pbos@webrtc.org | b7ed779 | 2014-10-31 13:08:10 | [diff] [blame] | 2752 | } |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2753 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2754 | TEST_P(VideoSendStreamTest, ReconfigureBitratesSetsEncoderBitratesCorrectly) { |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2755 | // These are chosen to be "kind of odd" to not be accidentally checked against |
| 2756 | // default values. |
| 2757 | static const int kMinBitrateKbps = 137; |
| 2758 | static const int kStartBitrateKbps = 345; |
| 2759 | static const int kLowerMaxBitrateKbps = 312; |
| 2760 | static const int kMaxBitrateKbps = 413; |
| 2761 | static const int kIncreasedStartBitrateKbps = 451; |
| 2762 | static const int kIncreasedMaxBitrateKbps = 597; |
Niels Möller | 6613f8e | 2019-01-10 09:30:21 | [diff] [blame] | 2763 | // If this field trial is on, we get lower bitrates than expected by this |
| 2764 | // test, due to the packetization overhead. |
| 2765 | webrtc::test::ScopedFieldTrials field_trials( |
| 2766 | std::string(field_trial::GetFieldTrialString()) + |
| 2767 | "WebRTC-SubtractPacketizationOverhead/Disabled/"); |
| 2768 | |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2769 | class EncoderBitrateThresholdObserver : public test::SendTest, |
| 2770 | public test::FakeEncoder { |
| 2771 | public: |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2772 | explicit EncoderBitrateThresholdObserver( |
| 2773 | test::SingleThreadedTaskQueueForTesting* task_queue) |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2774 | : SendTest(kDefaultTimeoutMs), |
| 2775 | FakeEncoder(Clock::GetRealTimeClock()), |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2776 | task_queue_(task_queue), |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2777 | target_bitrate_(0), |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 2778 | num_initializations_(0), |
| 2779 | call_(nullptr), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2780 | send_stream_(nullptr), |
| 2781 | encoder_factory_(this) {} |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2782 | |
| 2783 | private: |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2784 | int32_t InitEncode(const VideoCodec* codecSettings, |
| 2785 | int32_t numberOfCores, |
| 2786 | size_t maxPayloadSize) override { |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2787 | EXPECT_GE(codecSettings->startBitrate, codecSettings->minBitrate); |
| 2788 | EXPECT_LE(codecSettings->startBitrate, codecSettings->maxBitrate); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2789 | if (num_initializations_ == 0) { |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2790 | EXPECT_EQ(static_cast<unsigned int>(kMinBitrateKbps), |
| 2791 | codecSettings->minBitrate); |
| 2792 | EXPECT_EQ(static_cast<unsigned int>(kStartBitrateKbps), |
| 2793 | codecSettings->startBitrate); |
| 2794 | EXPECT_EQ(static_cast<unsigned int>(kMaxBitrateKbps), |
| 2795 | codecSettings->maxBitrate); |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 2796 | observation_complete_.Set(); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2797 | } else if (num_initializations_ == 1) { |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2798 | EXPECT_EQ(static_cast<unsigned int>(kLowerMaxBitrateKbps), |
| 2799 | codecSettings->maxBitrate); |
| 2800 | // The start bitrate should be kept (-1) and capped to the max bitrate. |
| 2801 | // Since this is not an end-to-end call no receiver should have been |
| 2802 | // returning a REMB that could lower this estimate. |
| 2803 | EXPECT_EQ(codecSettings->startBitrate, codecSettings->maxBitrate); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2804 | } else if (num_initializations_ == 2) { |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2805 | EXPECT_EQ(static_cast<unsigned int>(kIncreasedMaxBitrateKbps), |
| 2806 | codecSettings->maxBitrate); |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2807 | // The start bitrate will be whatever the rate BitRateController |
| 2808 | // has currently configured but in the span of the set max and min |
| 2809 | // bitrate. |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2810 | } |
| 2811 | ++num_initializations_; |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2812 | init_encode_event_.Set(); |
| 2813 | |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2814 | return FakeEncoder::InitEncode(codecSettings, numberOfCores, |
| 2815 | maxPayloadSize); |
| 2816 | } |
| 2817 | |
Erik Språng | 566124a | 2018-04-23 10:32:22 | [diff] [blame] | 2818 | int32_t SetRateAllocation(const VideoBitrateAllocation& bitrate, |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 2819 | uint32_t frameRate) override { |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2820 | { |
| 2821 | rtc::CritScope lock(&crit_); |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 2822 | if (target_bitrate_ == bitrate.get_sum_kbps()) { |
| 2823 | return FakeEncoder::SetRateAllocation(bitrate, frameRate); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2824 | } |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 2825 | target_bitrate_ = bitrate.get_sum_kbps(); |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2826 | } |
| 2827 | bitrate_changed_event_.Set(); |
Erik Språng | 08127a9 | 2016-11-16 15:41:30 | [diff] [blame] | 2828 | return FakeEncoder::SetRateAllocation(bitrate, frameRate); |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2829 | } |
| 2830 | |
| 2831 | void WaitForSetRates(uint32_t expected_bitrate) { |
Niels Möller | 6bb5ab9 | 2019-01-11 10:11:10 | [diff] [blame^] | 2832 | // Wait for the expected rate to be set. In some cases there can be |
| 2833 | // more than one update pending, in which case we keep waiting |
| 2834 | // until the correct value has been observed. |
| 2835 | const int64_t start_time = rtc::TimeMillis(); |
| 2836 | do { |
| 2837 | rtc::CritScope lock(&crit_); |
| 2838 | if (target_bitrate_ == expected_bitrate) { |
| 2839 | return; |
| 2840 | } |
| 2841 | } while (bitrate_changed_event_.Wait( |
| 2842 | std::max(int64_t{1}, VideoSendStreamTest::kDefaultTimeoutMs - |
| 2843 | (rtc::TimeMillis() - start_time)))); |
Niels Möller | 6613f8e | 2019-01-10 09:30:21 | [diff] [blame] | 2844 | rtc::CritScope lock(&crit_); |
Niels Möller | 6bb5ab9 | 2019-01-11 10:11:10 | [diff] [blame^] | 2845 | EXPECT_EQ(target_bitrate_, expected_bitrate) |
| 2846 | << "Timed out while waiting encoder rate to be set."; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2847 | } |
| 2848 | |
Niels Möller | de8e6e6 | 2018-11-13 14:10:33 | [diff] [blame] | 2849 | void ModifySenderBitrateConfig( |
| 2850 | BitrateConstraints* bitrate_config) override { |
| 2851 | bitrate_config->min_bitrate_bps = kMinBitrateKbps * 1000; |
| 2852 | bitrate_config->start_bitrate_bps = kStartBitrateKbps * 1000; |
| 2853 | bitrate_config->max_bitrate_bps = kMaxBitrateKbps * 1000; |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2854 | } |
| 2855 | |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2856 | class VideoStreamFactory |
| 2857 | : public VideoEncoderConfig::VideoStreamFactoryInterface { |
| 2858 | public: |
| 2859 | explicit VideoStreamFactory(int min_bitrate_bps) |
| 2860 | : min_bitrate_bps_(min_bitrate_bps) {} |
| 2861 | |
| 2862 | private: |
| 2863 | std::vector<VideoStream> CreateEncoderStreams( |
| 2864 | int width, |
| 2865 | int height, |
| 2866 | const VideoEncoderConfig& encoder_config) override { |
| 2867 | std::vector<VideoStream> streams = |
| 2868 | test::CreateVideoStreams(width, height, encoder_config); |
| 2869 | streams[0].min_bitrate_bps = min_bitrate_bps_; |
| 2870 | return streams; |
| 2871 | } |
| 2872 | |
| 2873 | const int min_bitrate_bps_; |
| 2874 | }; |
| 2875 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2876 | void ModifyVideoConfigs( |
| 2877 | VideoSendStream::Config* send_config, |
| 2878 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 2879 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2880 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2881 | // Set bitrates lower/higher than min/max to make sure they are properly |
| 2882 | // capped. |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2883 | encoder_config->max_bitrate_bps = kMaxBitrateKbps * 1000; |
| 2884 | // Create a new StreamFactory to be able to set |
| 2885 | // |VideoStream.min_bitrate_bps|. |
| 2886 | encoder_config->video_stream_factory = |
| 2887 | new rtc::RefCountedObject<VideoStreamFactory>(kMinBitrateKbps * 1000); |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2888 | encoder_config_ = encoder_config->Copy(); |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2889 | } |
| 2890 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2891 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2892 | call_ = sender_call; |
| 2893 | } |
| 2894 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2895 | void OnVideoStreamsCreated( |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 2896 | VideoSendStream* send_stream, |
| 2897 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
| 2898 | send_stream_ = send_stream; |
| 2899 | } |
| 2900 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2901 | void PerformTest() override { |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2902 | ASSERT_TRUE( |
| 2903 | init_encode_event_.Wait(VideoSendStreamTest::kDefaultTimeoutMs)) |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2904 | << "Timed out while waiting for encoder to be configured."; |
| 2905 | WaitForSetRates(kStartBitrateKbps); |
Sebastian Jansson | fc8d26b | 2018-02-21 08:52:06 | [diff] [blame] | 2906 | BitrateConstraints bitrate_config; |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2907 | bitrate_config.start_bitrate_bps = kIncreasedStartBitrateKbps * 1000; |
| 2908 | bitrate_config.max_bitrate_bps = kIncreasedMaxBitrateKbps * 1000; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2909 | task_queue_->SendTask([this, &bitrate_config]() { |
Sebastian Jansson | 8f83b42 | 2018-02-21 12:07:13 | [diff] [blame] | 2910 | call_->GetTransportControllerSend()->SetSdpBitrateParameters( |
| 2911 | bitrate_config); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2912 | }); |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2913 | // Encoder rate is capped by EncoderConfig max_bitrate_bps. |
| 2914 | WaitForSetRates(kMaxBitrateKbps); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2915 | encoder_config_.max_bitrate_bps = kLowerMaxBitrateKbps * 1000; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2916 | send_stream_->ReconfigureVideoEncoder(encoder_config_.Copy()); |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2917 | ASSERT_TRUE( |
| 2918 | init_encode_event_.Wait(VideoSendStreamTest::kDefaultTimeoutMs)); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2919 | EXPECT_EQ(2, num_initializations_) |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2920 | << "Encoder should have been reconfigured with the new value."; |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2921 | WaitForSetRates(kLowerMaxBitrateKbps); |
| 2922 | |
| 2923 | encoder_config_.max_bitrate_bps = kIncreasedMaxBitrateKbps * 1000; |
| 2924 | send_stream_->ReconfigureVideoEncoder(encoder_config_.Copy()); |
| 2925 | ASSERT_TRUE( |
| 2926 | init_encode_event_.Wait(VideoSendStreamTest::kDefaultTimeoutMs)); |
Per | 21d45d2 | 2016-10-30 20:37:57 | [diff] [blame] | 2927 | EXPECT_EQ(3, num_initializations_) |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2928 | << "Encoder should have been reconfigured with the new value."; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2929 | // Expected target bitrate is the start bitrate set in the call to |
Sebastian Jansson | 8f83b42 | 2018-02-21 12:07:13 | [diff] [blame] | 2930 | // call_->GetTransportControllerSend()->SetSdpBitrateParameters. |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2931 | WaitForSetRates(kIncreasedStartBitrateKbps); |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2932 | } |
| 2933 | |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2934 | test::SingleThreadedTaskQueueForTesting* const task_queue_; |
pbos | 14fe708 | 2016-04-20 13:35:56 | [diff] [blame] | 2935 | rtc::Event init_encode_event_; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 2936 | rtc::Event bitrate_changed_event_; |
| 2937 | rtc::CriticalSection crit_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 2938 | uint32_t target_bitrate_ RTC_GUARDED_BY(&crit_); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 2939 | |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2940 | int num_initializations_; |
| 2941 | webrtc::Call* call_; |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 2942 | webrtc::VideoSendStream* send_stream_; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 2943 | test::VideoEncoderProxyFactory encoder_factory_; |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 2944 | webrtc::VideoEncoderConfig encoder_config_; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 2945 | } test(&task_queue_); |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2946 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 2947 | RunBaseTest(&test); |
pbos@webrtc.org | 0087318 | 2014-11-25 14:03:34 | [diff] [blame] | 2948 | } |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2949 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 2950 | TEST_P(VideoSendStreamTest, ReportsSentResolution) { |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2951 | static const size_t kNumStreams = 3; |
| 2952 | // Unusual resolutions to make sure that they are the ones being reported. |
| 2953 | static const struct { |
| 2954 | int width; |
| 2955 | int height; |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 2956 | } kEncodedResolution[kNumStreams] = {{241, 181}, {300, 121}, {121, 221}}; |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2957 | class ScreencastTargetBitrateTest : public test::SendTest, |
| 2958 | public test::FakeEncoder { |
| 2959 | public: |
| 2960 | ScreencastTargetBitrateTest() |
| 2961 | : SendTest(kDefaultTimeoutMs), |
Erik Språng | 737336d | 2016-07-29 10:59:36 | [diff] [blame] | 2962 | test::FakeEncoder(Clock::GetRealTimeClock()), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 2963 | send_stream_(nullptr), |
| 2964 | encoder_factory_(this) {} |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2965 | |
| 2966 | private: |
Miguel Casas-Sanchez | 4765070 | 2015-05-30 00:21:40 | [diff] [blame] | 2967 | int32_t Encode(const VideoFrame& input_image, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 2968 | const CodecSpecificInfo* codecSpecificInfo, |
pbos | 22993e1 | 2015-10-19 09:39:06 | [diff] [blame] | 2969 | const std::vector<FrameType>* frame_types) override { |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2970 | CodecSpecificInfo specifics; |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2971 | specifics.codecType = kVideoCodecGeneric; |
| 2972 | |
| 2973 | uint8_t buffer[16] = {0}; |
| 2974 | EncodedImage encoded(buffer, sizeof(buffer), sizeof(buffer)); |
Niels Möller | 2377588 | 2018-08-16 08:24:12 | [diff] [blame] | 2975 | encoded.SetTimestamp(input_image.timestamp()); |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2976 | encoded.capture_time_ms_ = input_image.render_time_ms(); |
| 2977 | |
| 2978 | for (size_t i = 0; i < kNumStreams; ++i) { |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2979 | encoded._frameType = (*frame_types)[i]; |
| 2980 | encoded._encodedWidth = kEncodedResolution[i].width; |
| 2981 | encoded._encodedHeight = kEncodedResolution[i].height; |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 2982 | encoded.SetSpatialIndex(i); |
brandtr | e78d266 | 2017-01-16 13:57:16 | [diff] [blame] | 2983 | EncodedImageCallback* callback; |
| 2984 | { |
| 2985 | rtc::CritScope cs(&crit_sect_); |
| 2986 | callback = callback_; |
| 2987 | } |
| 2988 | RTC_DCHECK(callback); |
| 2989 | if (callback->OnEncodedImage(encoded, &specifics, nullptr).error != |
sergeyu | 2cb155a | 2016-11-04 18:39:29 | [diff] [blame] | 2990 | EncodedImageCallback::Result::OK) { |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2991 | return -1; |
sergeyu | 2cb155a | 2016-11-04 18:39:29 | [diff] [blame] | 2992 | } |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2993 | } |
| 2994 | |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 2995 | observation_complete_.Set(); |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 2996 | return 0; |
| 2997 | } |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 2998 | void ModifyVideoConfigs( |
| 2999 | VideoSendStream::Config* send_config, |
| 3000 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3001 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 3002 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 3003 | EXPECT_EQ(kNumStreams, encoder_config->number_of_streams); |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3004 | } |
| 3005 | |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 3006 | size_t GetNumVideoStreams() const override { return kNumStreams; } |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3007 | |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 3008 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 3009 | EXPECT_TRUE(Wait()) |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3010 | << "Timed out while waiting for the encoder to send one frame."; |
| 3011 | VideoSendStream::Stats stats = send_stream_->GetStats(); |
| 3012 | |
| 3013 | for (size_t i = 0; i < kNumStreams; ++i) { |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 3014 | ASSERT_TRUE(stats.substreams.find(kVideoSendSsrcs[i]) != |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3015 | stats.substreams.end()) |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 3016 | << "No stats for SSRC: " << kVideoSendSsrcs[i] |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3017 | << ", stats should exist as soon as frames have been encoded."; |
pbos@webrtc.org | 09c77b9 | 2015-02-25 10:42:16 | [diff] [blame] | 3018 | VideoSendStream::StreamStats ssrc_stats = |
Stefan Holmer | 9fea80f | 2016-01-07 16:43:18 | [diff] [blame] | 3019 | stats.substreams[kVideoSendSsrcs[i]]; |
pbos@webrtc.org | 09c77b9 | 2015-02-25 10:42:16 | [diff] [blame] | 3020 | EXPECT_EQ(kEncodedResolution[i].width, ssrc_stats.width); |
| 3021 | EXPECT_EQ(kEncodedResolution[i].height, ssrc_stats.height); |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3022 | } |
| 3023 | } |
| 3024 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 3025 | void OnVideoStreamsCreated( |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3026 | VideoSendStream* send_stream, |
kjellander@webrtc.org | 14665ff | 2015-03-04 12:58:35 | [diff] [blame] | 3027 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3028 | send_stream_ = send_stream; |
| 3029 | } |
| 3030 | |
| 3031 | VideoSendStream* send_stream_; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 3032 | test::VideoEncoderProxyFactory encoder_factory_; |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3033 | } test; |
| 3034 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 3035 | RunBaseTest(&test); |
pbos@webrtc.org | 273a414 | 2014-12-01 15:23:21 | [diff] [blame] | 3036 | } |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3037 | |
Mirko Bonadei | 8ef5793 | 2018-11-16 13:38:03 | [diff] [blame] | 3038 | #if defined(RTC_ENABLE_VP9) |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3039 | class Vp9HeaderObserver : public test::SendTest { |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3040 | public: |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3041 | Vp9HeaderObserver() |
| 3042 | : SendTest(VideoSendStreamTest::kLongTimeoutMs), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 3043 | encoder_factory_([]() { return VP9Encoder::Create(); }), |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3044 | vp9_settings_(VideoEncoder::GetDefaultVp9Settings()), |
| 3045 | packets_sent_(0), |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 3046 | frames_sent_(0), |
| 3047 | expected_width_(0), |
| 3048 | expected_height_(0) {} |
philipel | 7fabd46 | 2015-09-03 11:42:32 | [diff] [blame] | 3049 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 3050 | virtual void ModifyVideoConfigsHook( |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3051 | VideoSendStream::Config* send_config, |
| 3052 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3053 | VideoEncoderConfig* encoder_config) {} |
| 3054 | |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3055 | virtual void InspectHeader(const RTPVideoHeaderVP9& vp9) = 0; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3056 | |
| 3057 | private: |
minyue | 20c84cc | 2017-04-10 23:57:57 | [diff] [blame] | 3058 | const int kVp9PayloadType = test::CallTest::kVideoSendPayloadType; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3059 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 3060 | void ModifyVideoConfigs( |
| 3061 | VideoSendStream::Config* send_config, |
| 3062 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3063 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 3064 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 3065 | send_config->rtp.payload_name = "VP9"; |
| 3066 | send_config->rtp.payload_type = kVp9PayloadType; |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 3067 | ModifyVideoConfigsHook(send_config, receive_configs, encoder_config); |
kthelgason | 29a44e3 | 2016-09-27 10:52:02 | [diff] [blame] | 3068 | encoder_config->encoder_specific_settings = new rtc::RefCountedObject< |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 3069 | VideoEncoderConfig::Vp9EncoderSpecificSettings>(vp9_settings_); |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 3070 | EXPECT_EQ(1u, encoder_config->number_of_streams); |
Åsa Persson | d34597c | 2018-10-22 15:34:02 | [diff] [blame] | 3071 | EXPECT_EQ(1u, encoder_config->simulcast_layers.size()); |
| 3072 | encoder_config->simulcast_layers[0].num_temporal_layers = |
| 3073 | vp9_settings_.numberOfTemporalLayers; |
perkj | 26091b1 | 2016-09-01 08:17:40 | [diff] [blame] | 3074 | encoder_config_ = encoder_config->Copy(); |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3075 | } |
| 3076 | |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 3077 | void ModifyVideoCaptureStartResolution(int* width, |
| 3078 | int* height, |
| 3079 | int* frame_rate) override { |
| 3080 | expected_width_ = *width; |
| 3081 | expected_height_ = *height; |
| 3082 | } |
| 3083 | |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3084 | void PerformTest() override { |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 3085 | EXPECT_TRUE(Wait()) << "Test timed out waiting for VP9 packet, num frames " |
| 3086 | << frames_sent_; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3087 | } |
| 3088 | |
| 3089 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 3090 | RTPHeader header; |
| 3091 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
| 3092 | |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3093 | EXPECT_EQ(kVp9PayloadType, header.payloadType); |
| 3094 | const uint8_t* payload = packet + header.headerLength; |
| 3095 | size_t payload_length = length - header.headerLength - header.paddingLength; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3096 | |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3097 | bool new_packet = packets_sent_ == 0 || |
| 3098 | IsNewerSequenceNumber(header.sequenceNumber, |
| 3099 | last_header_.sequenceNumber); |
| 3100 | if (payload_length > 0 && new_packet) { |
| 3101 | RtpDepacketizer::ParsedPayload parsed; |
| 3102 | RtpDepacketizerVp9 depacketizer; |
| 3103 | EXPECT_TRUE(depacketizer.Parse(&parsed, payload, payload_length)); |
philipel | cb96ad8 | 2018-07-02 12:41:58 | [diff] [blame] | 3104 | EXPECT_EQ(VideoCodecType::kVideoCodecVP9, parsed.video_header().codec); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3105 | // Verify common fields for all configurations. |
philipel | 29d8846 | 2018-08-08 12:26:00 | [diff] [blame] | 3106 | const auto& vp9_header = |
| 3107 | absl::get<RTPVideoHeaderVP9>(parsed.video_header().video_type_header); |
| 3108 | VerifyCommonHeader(vp9_header); |
philipel | cb96ad8 | 2018-07-02 12:41:58 | [diff] [blame] | 3109 | CompareConsecutiveFrames(header, parsed.video_header()); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3110 | // Verify configuration specific settings. |
philipel | 29d8846 | 2018-08-08 12:26:00 | [diff] [blame] | 3111 | InspectHeader(vp9_header); |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3112 | |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3113 | ++packets_sent_; |
| 3114 | if (header.markerBit) { |
| 3115 | ++frames_sent_; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3116 | } |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3117 | last_header_ = header; |
philipel | 29d8846 | 2018-08-08 12:26:00 | [diff] [blame] | 3118 | last_vp9_ = vp9_header; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3119 | } |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3120 | return SEND_PACKET; |
| 3121 | } |
| 3122 | |
philipel | 7fabd46 | 2015-09-03 11:42:32 | [diff] [blame] | 3123 | protected: |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3124 | bool ContinuousPictureId(const RTPVideoHeaderVP9& vp9) const { |
| 3125 | if (last_vp9_.picture_id > vp9.picture_id) { |
| 3126 | return vp9.picture_id == 0; // Wrap. |
| 3127 | } else { |
| 3128 | return vp9.picture_id == last_vp9_.picture_id + 1; |
| 3129 | } |
| 3130 | } |
| 3131 | |
| 3132 | void VerifySpatialIdxWithinFrame(const RTPVideoHeaderVP9& vp9) const { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3133 | bool new_layer = vp9.spatial_idx != last_vp9_.spatial_idx; |
| 3134 | EXPECT_EQ(new_layer, vp9.beginning_of_frame); |
| 3135 | EXPECT_EQ(new_layer, last_vp9_.end_of_frame); |
| 3136 | EXPECT_EQ(new_layer ? last_vp9_.spatial_idx + 1 : last_vp9_.spatial_idx, |
| 3137 | vp9.spatial_idx); |
| 3138 | } |
| 3139 | |
| 3140 | void VerifyFixedTemporalLayerStructure(const RTPVideoHeaderVP9& vp9, |
| 3141 | uint8_t num_layers) const { |
| 3142 | switch (num_layers) { |
| 3143 | case 0: |
| 3144 | VerifyTemporalLayerStructure0(vp9); |
| 3145 | break; |
| 3146 | case 1: |
| 3147 | VerifyTemporalLayerStructure1(vp9); |
| 3148 | break; |
| 3149 | case 2: |
| 3150 | VerifyTemporalLayerStructure2(vp9); |
| 3151 | break; |
| 3152 | case 3: |
| 3153 | VerifyTemporalLayerStructure3(vp9); |
| 3154 | break; |
| 3155 | default: |
| 3156 | RTC_NOTREACHED(); |
| 3157 | } |
| 3158 | } |
| 3159 | |
| 3160 | void VerifyTemporalLayerStructure0(const RTPVideoHeaderVP9& vp9) const { |
| 3161 | EXPECT_EQ(kNoTl0PicIdx, vp9.tl0_pic_idx); |
| 3162 | EXPECT_EQ(kNoTemporalIdx, vp9.temporal_idx); // no tid |
| 3163 | EXPECT_FALSE(vp9.temporal_up_switch); |
| 3164 | } |
| 3165 | |
| 3166 | void VerifyTemporalLayerStructure1(const RTPVideoHeaderVP9& vp9) const { |
| 3167 | EXPECT_NE(kNoTl0PicIdx, vp9.tl0_pic_idx); |
| 3168 | EXPECT_EQ(0, vp9.temporal_idx); // 0,0,0,... |
| 3169 | EXPECT_FALSE(vp9.temporal_up_switch); |
| 3170 | } |
| 3171 | |
| 3172 | void VerifyTemporalLayerStructure2(const RTPVideoHeaderVP9& vp9) const { |
| 3173 | EXPECT_NE(kNoTl0PicIdx, vp9.tl0_pic_idx); |
| 3174 | EXPECT_GE(vp9.temporal_idx, 0); // 0,1,0,1,... (tid reset on I-frames). |
| 3175 | EXPECT_LE(vp9.temporal_idx, 1); |
| 3176 | EXPECT_EQ(vp9.temporal_idx > 0, vp9.temporal_up_switch); |
| 3177 | if (IsNewPictureId(vp9)) { |
| 3178 | uint8_t expected_tid = |
| 3179 | (!vp9.inter_pic_predicted || last_vp9_.temporal_idx == 1) ? 0 : 1; |
| 3180 | EXPECT_EQ(expected_tid, vp9.temporal_idx); |
| 3181 | } |
| 3182 | } |
| 3183 | |
| 3184 | void VerifyTemporalLayerStructure3(const RTPVideoHeaderVP9& vp9) const { |
| 3185 | EXPECT_NE(kNoTl0PicIdx, vp9.tl0_pic_idx); |
| 3186 | EXPECT_GE(vp9.temporal_idx, 0); // 0,2,1,2,... (tid reset on I-frames). |
| 3187 | EXPECT_LE(vp9.temporal_idx, 2); |
| 3188 | if (IsNewPictureId(vp9) && vp9.inter_pic_predicted) { |
| 3189 | EXPECT_NE(vp9.temporal_idx, last_vp9_.temporal_idx); |
| 3190 | switch (vp9.temporal_idx) { |
| 3191 | case 0: |
| 3192 | EXPECT_EQ(2, last_vp9_.temporal_idx); |
| 3193 | EXPECT_FALSE(vp9.temporal_up_switch); |
| 3194 | break; |
| 3195 | case 1: |
| 3196 | EXPECT_EQ(2, last_vp9_.temporal_idx); |
| 3197 | EXPECT_TRUE(vp9.temporal_up_switch); |
| 3198 | break; |
| 3199 | case 2: |
Sergey Silkin | 377ef24 | 2018-05-07 07:17:12 | [diff] [blame] | 3200 | EXPECT_LT(last_vp9_.temporal_idx, 2); |
| 3201 | EXPECT_TRUE(vp9.temporal_up_switch); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3202 | break; |
| 3203 | } |
| 3204 | } |
| 3205 | } |
| 3206 | |
| 3207 | void VerifyTl0Idx(const RTPVideoHeaderVP9& vp9) const { |
| 3208 | if (vp9.tl0_pic_idx == kNoTl0PicIdx) |
| 3209 | return; |
| 3210 | |
| 3211 | uint8_t expected_tl0_idx = last_vp9_.tl0_pic_idx; |
| 3212 | if (vp9.temporal_idx == 0) |
| 3213 | ++expected_tl0_idx; |
| 3214 | EXPECT_EQ(expected_tl0_idx, vp9.tl0_pic_idx); |
| 3215 | } |
| 3216 | |
| 3217 | bool IsNewPictureId(const RTPVideoHeaderVP9& vp9) const { |
| 3218 | return frames_sent_ > 0 && (vp9.picture_id != last_vp9_.picture_id); |
| 3219 | } |
| 3220 | |
| 3221 | // Flexible mode (F=1): Non-flexible mode (F=0): |
| 3222 | // |
| 3223 | // +-+-+-+-+-+-+-+-+ +-+-+-+-+-+-+-+-+ |
| 3224 | // |I|P|L|F|B|E|V|-| |I|P|L|F|B|E|V|-| |
| 3225 | // +-+-+-+-+-+-+-+-+ +-+-+-+-+-+-+-+-+ |
| 3226 | // I: |M| PICTURE ID | I: |M| PICTURE ID | |
| 3227 | // +-+-+-+-+-+-+-+-+ +-+-+-+-+-+-+-+-+ |
| 3228 | // M: | EXTENDED PID | M: | EXTENDED PID | |
| 3229 | // +-+-+-+-+-+-+-+-+ +-+-+-+-+-+-+-+-+ |
| 3230 | // L: | T |U| S |D| L: | T |U| S |D| |
| 3231 | // +-+-+-+-+-+-+-+-+ +-+-+-+-+-+-+-+-+ |
| 3232 | // P,F: | P_DIFF |X|N| | TL0PICIDX | |
| 3233 | // +-+-+-+-+-+-+-+-+ +-+-+-+-+-+-+-+-+ |
| 3234 | // X: |EXTENDED P_DIFF| V: | SS .. | |
| 3235 | // +-+-+-+-+-+-+-+-+ +-+-+-+-+-+-+-+-+ |
| 3236 | // V: | SS .. | |
| 3237 | // +-+-+-+-+-+-+-+-+ |
| 3238 | void VerifyCommonHeader(const RTPVideoHeaderVP9& vp9) const { |
| 3239 | EXPECT_EQ(kMaxTwoBytePictureId, vp9.max_picture_id); // M:1 |
| 3240 | EXPECT_NE(kNoPictureId, vp9.picture_id); // I:1 |
| 3241 | EXPECT_EQ(vp9_settings_.flexibleMode, vp9.flexible_mode); // F |
Sergey Silkin | 3f2634e | 2017-11-06 10:49:19 | [diff] [blame] | 3242 | |
| 3243 | if (vp9_settings_.numberOfSpatialLayers > 1) { |
| 3244 | EXPECT_LT(vp9.spatial_idx, vp9_settings_.numberOfSpatialLayers); |
| 3245 | } else if (vp9_settings_.numberOfTemporalLayers > 1) { |
| 3246 | EXPECT_EQ(vp9.spatial_idx, 0); |
| 3247 | } else { |
| 3248 | EXPECT_EQ(vp9.spatial_idx, kNoSpatialIdx); |
| 3249 | } |
| 3250 | |
| 3251 | if (vp9_settings_.numberOfTemporalLayers > 1) { |
| 3252 | EXPECT_LT(vp9.temporal_idx, vp9_settings_.numberOfTemporalLayers); |
| 3253 | } else if (vp9_settings_.numberOfSpatialLayers > 1) { |
| 3254 | EXPECT_EQ(vp9.temporal_idx, 0); |
| 3255 | } else { |
| 3256 | EXPECT_EQ(vp9.temporal_idx, kNoTemporalIdx); |
| 3257 | } |
| 3258 | |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3259 | if (vp9.ss_data_available) // V |
| 3260 | VerifySsData(vp9); |
| 3261 | |
| 3262 | if (frames_sent_ == 0) |
| 3263 | EXPECT_FALSE(vp9.inter_pic_predicted); // P |
| 3264 | |
| 3265 | if (!vp9.inter_pic_predicted) { |
| 3266 | EXPECT_TRUE(vp9.temporal_idx == 0 || vp9.temporal_idx == kNoTemporalIdx); |
| 3267 | EXPECT_FALSE(vp9.temporal_up_switch); |
| 3268 | } |
| 3269 | } |
| 3270 | |
| 3271 | // Scalability structure (SS). |
| 3272 | // |
| 3273 | // +-+-+-+-+-+-+-+-+ |
| 3274 | // V: | N_S |Y|G|-|-|-| |
| 3275 | // +-+-+-+-+-+-+-+-+ |
| 3276 | // Y: | WIDTH | N_S + 1 times |
| 3277 | // +-+-+-+-+-+-+-+-+ |
| 3278 | // | HEIGHT | |
| 3279 | // +-+-+-+-+-+-+-+-+ |
| 3280 | // G: | N_G | |
| 3281 | // +-+-+-+-+-+-+-+-+ |
| 3282 | // N_G: | T |U| R |-|-| N_G times |
| 3283 | // +-+-+-+-+-+-+-+-+ |
| 3284 | // | P_DIFF | R times |
| 3285 | // +-+-+-+-+-+-+-+-+ |
| 3286 | void VerifySsData(const RTPVideoHeaderVP9& vp9) const { |
| 3287 | EXPECT_TRUE(vp9.ss_data_available); // V |
| 3288 | EXPECT_EQ(vp9_settings_.numberOfSpatialLayers, // N_S + 1 |
| 3289 | vp9.num_spatial_layers); |
| 3290 | EXPECT_TRUE(vp9.spatial_layer_resolution_present); // Y:1 |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 3291 | int expected_width = expected_width_; |
| 3292 | int expected_height = expected_height_; |
Peter Boström | 0208322 | 2016-06-14 10:52:54 | [diff] [blame] | 3293 | for (int i = static_cast<int>(vp9.num_spatial_layers) - 1; i >= 0; --i) { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3294 | EXPECT_EQ(expected_width, vp9.width[i]); // WIDTH |
| 3295 | EXPECT_EQ(expected_height, vp9.height[i]); // HEIGHT |
| 3296 | expected_width /= 2; |
| 3297 | expected_height /= 2; |
| 3298 | } |
| 3299 | } |
| 3300 | |
| 3301 | void CompareConsecutiveFrames(const RTPHeader& header, |
| 3302 | const RTPVideoHeader& video) const { |
philipel | 29d8846 | 2018-08-08 12:26:00 | [diff] [blame] | 3303 | const auto& vp9_header = |
| 3304 | absl::get<RTPVideoHeaderVP9>(video.video_type_header); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3305 | |
| 3306 | bool new_frame = packets_sent_ == 0 || |
| 3307 | IsNewerTimestamp(header.timestamp, last_header_.timestamp); |
johan | 0d1b2b6 | 2017-01-10 12:21:35 | [diff] [blame] | 3308 | EXPECT_EQ(new_frame, video.is_first_packet_in_frame); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3309 | if (!new_frame) { |
| 3310 | EXPECT_FALSE(last_header_.markerBit); |
| 3311 | EXPECT_EQ(last_header_.timestamp, header.timestamp); |
philipel | 29d8846 | 2018-08-08 12:26:00 | [diff] [blame] | 3312 | EXPECT_EQ(last_vp9_.picture_id, vp9_header.picture_id); |
| 3313 | EXPECT_EQ(last_vp9_.temporal_idx, vp9_header.temporal_idx); |
| 3314 | EXPECT_EQ(last_vp9_.tl0_pic_idx, vp9_header.tl0_pic_idx); |
| 3315 | VerifySpatialIdxWithinFrame(vp9_header); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3316 | return; |
| 3317 | } |
| 3318 | // New frame. |
philipel | 29d8846 | 2018-08-08 12:26:00 | [diff] [blame] | 3319 | EXPECT_TRUE(vp9_header.beginning_of_frame); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3320 | |
| 3321 | // Compare with last packet in previous frame. |
| 3322 | if (frames_sent_ == 0) |
| 3323 | return; |
| 3324 | EXPECT_TRUE(last_vp9_.end_of_frame); |
| 3325 | EXPECT_TRUE(last_header_.markerBit); |
philipel | 29d8846 | 2018-08-08 12:26:00 | [diff] [blame] | 3326 | EXPECT_TRUE(ContinuousPictureId(vp9_header)); |
| 3327 | VerifyTl0Idx(vp9_header); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3328 | } |
| 3329 | |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 3330 | test::FunctionVideoEncoderFactory encoder_factory_; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3331 | VideoCodecVP9 vp9_settings_; |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3332 | webrtc::VideoEncoderConfig encoder_config_; |
| 3333 | RTPHeader last_header_; |
| 3334 | RTPVideoHeaderVP9 last_vp9_; |
| 3335 | size_t packets_sent_; |
| 3336 | size_t frames_sent_; |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 3337 | int expected_width_; |
| 3338 | int expected_height_; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3339 | }; |
| 3340 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3341 | TEST_P(VideoSendStreamTest, Vp9NonFlexMode_1Tl1SLayers) { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3342 | const uint8_t kNumTemporalLayers = 1; |
| 3343 | const uint8_t kNumSpatialLayers = 1; |
| 3344 | TestVp9NonFlexMode(kNumTemporalLayers, kNumSpatialLayers); |
| 3345 | } |
| 3346 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3347 | TEST_P(VideoSendStreamTest, Vp9NonFlexMode_2Tl1SLayers) { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3348 | const uint8_t kNumTemporalLayers = 2; |
| 3349 | const uint8_t kNumSpatialLayers = 1; |
| 3350 | TestVp9NonFlexMode(kNumTemporalLayers, kNumSpatialLayers); |
| 3351 | } |
| 3352 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3353 | TEST_P(VideoSendStreamTest, Vp9NonFlexMode_3Tl1SLayers) { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3354 | const uint8_t kNumTemporalLayers = 3; |
| 3355 | const uint8_t kNumSpatialLayers = 1; |
| 3356 | TestVp9NonFlexMode(kNumTemporalLayers, kNumSpatialLayers); |
| 3357 | } |
| 3358 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3359 | TEST_P(VideoSendStreamTest, Vp9NonFlexMode_1Tl2SLayers) { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3360 | const uint8_t kNumTemporalLayers = 1; |
| 3361 | const uint8_t kNumSpatialLayers = 2; |
| 3362 | TestVp9NonFlexMode(kNumTemporalLayers, kNumSpatialLayers); |
| 3363 | } |
| 3364 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3365 | TEST_P(VideoSendStreamTest, Vp9NonFlexMode_2Tl2SLayers) { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3366 | const uint8_t kNumTemporalLayers = 2; |
| 3367 | const uint8_t kNumSpatialLayers = 2; |
| 3368 | TestVp9NonFlexMode(kNumTemporalLayers, kNumSpatialLayers); |
| 3369 | } |
| 3370 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3371 | TEST_P(VideoSendStreamTest, Vp9NonFlexMode_3Tl2SLayers) { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3372 | const uint8_t kNumTemporalLayers = 3; |
| 3373 | const uint8_t kNumSpatialLayers = 2; |
| 3374 | TestVp9NonFlexMode(kNumTemporalLayers, kNumSpatialLayers); |
| 3375 | } |
| 3376 | |
| 3377 | void VideoSendStreamTest::TestVp9NonFlexMode(uint8_t num_temporal_layers, |
| 3378 | uint8_t num_spatial_layers) { |
| 3379 | static const size_t kNumFramesToSend = 100; |
| 3380 | // Set to < kNumFramesToSend and coprime to length of temporal layer |
| 3381 | // structures to verify temporal id reset on key frame. |
| 3382 | static const int kKeyFrameInterval = 31; |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 3383 | |
| 3384 | static const int kWidth = kMinVp9SpatialLayerWidth; |
| 3385 | static const int kHeight = kMinVp9SpatialLayerHeight; |
| 3386 | static const float kGoodBitsPerPixel = 0.1f; |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3387 | class NonFlexibleMode : public Vp9HeaderObserver { |
| 3388 | public: |
| 3389 | NonFlexibleMode(uint8_t num_temporal_layers, uint8_t num_spatial_layers) |
| 3390 | : num_temporal_layers_(num_temporal_layers), |
| 3391 | num_spatial_layers_(num_spatial_layers), |
| 3392 | l_field_(num_temporal_layers > 1 || num_spatial_layers > 1) {} |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 3393 | |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 3394 | void ModifyVideoConfigsHook( |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3395 | VideoSendStream::Config* send_config, |
| 3396 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3397 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 04dd176 | 2018-03-23 15:05:22 | [diff] [blame] | 3398 | encoder_config->codec_type = kVideoCodecVP9; |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 3399 | int bitrate_bps = 0; |
| 3400 | for (int sl_idx = 0; sl_idx < num_spatial_layers_; ++sl_idx) { |
| 3401 | const int width = kWidth << sl_idx; |
| 3402 | const int height = kHeight << sl_idx; |
| 3403 | const float bpp = kGoodBitsPerPixel / (1 << sl_idx); |
| 3404 | bitrate_bps += static_cast<int>(width * height * bpp * 30); |
| 3405 | } |
| 3406 | encoder_config->max_bitrate_bps = bitrate_bps * 2; |
| 3407 | |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3408 | vp9_settings_.flexibleMode = false; |
| 3409 | vp9_settings_.frameDroppingOn = false; |
| 3410 | vp9_settings_.keyFrameInterval = kKeyFrameInterval; |
| 3411 | vp9_settings_.numberOfTemporalLayers = num_temporal_layers_; |
| 3412 | vp9_settings_.numberOfSpatialLayers = num_spatial_layers_; |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3413 | } |
| 3414 | |
Sergey Silkin | 8668496 | 2018-03-28 17:32:37 | [diff] [blame] | 3415 | void ModifyVideoCaptureStartResolution(int* width, |
| 3416 | int* height, |
| 3417 | int* frame_rate) override { |
| 3418 | expected_width_ = kWidth << (num_spatial_layers_ - 1); |
| 3419 | expected_height_ = kHeight << (num_spatial_layers_ - 1); |
| 3420 | *width = expected_width_; |
| 3421 | *height = expected_height_; |
| 3422 | } |
| 3423 | |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3424 | void InspectHeader(const RTPVideoHeaderVP9& vp9) override { |
Sergey Silkin | 3f2634e | 2017-11-06 10:49:19 | [diff] [blame] | 3425 | bool ss_data_expected = |
| 3426 | !vp9.inter_pic_predicted && vp9.beginning_of_frame && |
| 3427 | (vp9.spatial_idx == 0 || vp9.spatial_idx == kNoSpatialIdx); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3428 | EXPECT_EQ(ss_data_expected, vp9.ss_data_available); |
Sergey Silkin | 3f2634e | 2017-11-06 10:49:19 | [diff] [blame] | 3429 | if (num_spatial_layers_ > 1) { |
| 3430 | EXPECT_EQ(vp9.spatial_idx > 0, vp9.inter_layer_predicted); |
| 3431 | } else { |
| 3432 | EXPECT_FALSE(vp9.inter_layer_predicted); |
| 3433 | } |
| 3434 | |
asapersson | 38bb8ad | 2015-12-14 09:41:19 | [diff] [blame] | 3435 | EXPECT_EQ(!vp9.inter_pic_predicted, |
| 3436 | frames_sent_ % kKeyFrameInterval == 0); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3437 | |
| 3438 | if (IsNewPictureId(vp9)) { |
Sergey Silkin | 3f2634e | 2017-11-06 10:49:19 | [diff] [blame] | 3439 | if (num_temporal_layers_ == 1 && num_spatial_layers_ == 1) { |
| 3440 | EXPECT_EQ(kNoSpatialIdx, vp9.spatial_idx); |
| 3441 | } else { |
| 3442 | EXPECT_EQ(0, vp9.spatial_idx); |
| 3443 | } |
| 3444 | if (num_spatial_layers_ > 1) |
| 3445 | EXPECT_EQ(num_spatial_layers_ - 1, last_vp9_.spatial_idx); |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3446 | } |
| 3447 | |
| 3448 | VerifyFixedTemporalLayerStructure(vp9, |
| 3449 | l_field_ ? num_temporal_layers_ : 0); |
| 3450 | |
| 3451 | if (frames_sent_ > kNumFramesToSend) |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 3452 | observation_complete_.Set(); |
philipel | 0f9af01 | 2015-09-01 14:01:51 | [diff] [blame] | 3453 | } |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3454 | const uint8_t num_temporal_layers_; |
| 3455 | const uint8_t num_spatial_layers_; |
| 3456 | const bool l_field_; |
| 3457 | } test(num_temporal_layers, num_spatial_layers); |
philipel | cfc319b | 2015-11-10 15:17:23 | [diff] [blame] | 3458 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 3459 | RunBaseTest(&test); |
philipel | cfc319b | 2015-11-10 15:17:23 | [diff] [blame] | 3460 | } |
| 3461 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3462 | TEST_P(VideoSendStreamTest, Vp9NonFlexModeSmallResolution) { |
asapersson | d9f641e | 2016-01-21 09:11:35 | [diff] [blame] | 3463 | static const size_t kNumFramesToSend = 50; |
| 3464 | static const int kWidth = 4; |
| 3465 | static const int kHeight = 4; |
| 3466 | class NonFlexibleModeResolution : public Vp9HeaderObserver { |
| 3467 | void ModifyVideoConfigsHook( |
| 3468 | VideoSendStream::Config* send_config, |
| 3469 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3470 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 3471 | encoder_config->codec_type = kVideoCodecVP9; |
asapersson | d9f641e | 2016-01-21 09:11:35 | [diff] [blame] | 3472 | vp9_settings_.flexibleMode = false; |
| 3473 | vp9_settings_.numberOfTemporalLayers = 1; |
| 3474 | vp9_settings_.numberOfSpatialLayers = 1; |
| 3475 | |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 3476 | EXPECT_EQ(1u, encoder_config->number_of_streams); |
asapersson | d9f641e | 2016-01-21 09:11:35 | [diff] [blame] | 3477 | } |
| 3478 | |
| 3479 | void InspectHeader(const RTPVideoHeaderVP9& vp9_header) override { |
| 3480 | if (frames_sent_ > kNumFramesToSend) |
| 3481 | observation_complete_.Set(); |
| 3482 | } |
perkj | fa10b55 | 2016-10-03 06:45:26 | [diff] [blame] | 3483 | |
| 3484 | void ModifyVideoCaptureStartResolution(int* width, |
| 3485 | int* height, |
| 3486 | int* frame_rate) override { |
| 3487 | expected_width_ = kWidth; |
| 3488 | expected_height_ = kHeight; |
| 3489 | *width = kWidth; |
| 3490 | *height = kHeight; |
| 3491 | } |
asapersson | d9f641e | 2016-01-21 09:11:35 | [diff] [blame] | 3492 | } test; |
| 3493 | |
| 3494 | RunBaseTest(&test); |
| 3495 | } |
| 3496 | |
kjellander | f9e2a36 | 2017-03-24 19:17:33 | [diff] [blame] | 3497 | #if defined(WEBRTC_ANDROID) |
| 3498 | // Crashes on Android; bugs.webrtc.org/7401 |
| 3499 | #define MAYBE_Vp9FlexModeRefCount DISABLED_Vp9FlexModeRefCount |
| 3500 | #else |
Sergey Silkin | be71a1e | 2018-05-17 14:46:43 | [diff] [blame] | 3501 | // TODO(webrtc:9270): Support of flexible mode is temporarily disabled. Enable |
| 3502 | // the test after webrtc:9270 is implemented. |
| 3503 | #define MAYBE_Vp9FlexModeRefCount DISABLED_Vp9FlexModeRefCount |
| 3504 | // #define MAYBE_Vp9FlexModeRefCount Vp9FlexModeRefCount |
kjellander | f9e2a36 | 2017-03-24 19:17:33 | [diff] [blame] | 3505 | #endif |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3506 | TEST_P(VideoSendStreamTest, MAYBE_Vp9FlexModeRefCount) { |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3507 | class FlexibleMode : public Vp9HeaderObserver { |
stefan | ff48361 | 2015-12-21 11:14:00 | [diff] [blame] | 3508 | void ModifyVideoConfigsHook( |
philipel | cfc319b | 2015-11-10 15:17:23 | [diff] [blame] | 3509 | VideoSendStream::Config* send_config, |
| 3510 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3511 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 259a497 | 2018-04-05 13:36:51 | [diff] [blame] | 3512 | encoder_config->codec_type = kVideoCodecVP9; |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3513 | encoder_config->content_type = VideoEncoderConfig::ContentType::kScreen; |
philipel | cfc319b | 2015-11-10 15:17:23 | [diff] [blame] | 3514 | vp9_settings_.flexibleMode = true; |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3515 | vp9_settings_.numberOfTemporalLayers = 1; |
| 3516 | vp9_settings_.numberOfSpatialLayers = 2; |
philipel | cfc319b | 2015-11-10 15:17:23 | [diff] [blame] | 3517 | } |
| 3518 | |
Åsa Persson | ff24c04 | 2015-12-04 09:58:08 | [diff] [blame] | 3519 | void InspectHeader(const RTPVideoHeaderVP9& vp9_header) override { |
| 3520 | EXPECT_TRUE(vp9_header.flexible_mode); |
| 3521 | EXPECT_EQ(kNoTl0PicIdx, vp9_header.tl0_pic_idx); |
| 3522 | if (vp9_header.inter_pic_predicted) { |
| 3523 | EXPECT_GT(vp9_header.num_ref_pics, 0u); |
Peter Boström | 5811a39 | 2015-12-10 12:02:50 | [diff] [blame] | 3524 | observation_complete_.Set(); |
philipel | cfc319b | 2015-11-10 15:17:23 | [diff] [blame] | 3525 | } |
| 3526 | } |
| 3527 | } test; |
| 3528 | |
stefan | e74eef1 | 2016-01-08 14:47:13 | [diff] [blame] | 3529 | RunBaseTest(&test); |
philipel | cfc319b | 2015-11-10 15:17:23 | [diff] [blame] | 3530 | } |
Mirko Bonadei | 8ef5793 | 2018-11-16 13:38:03 | [diff] [blame] | 3531 | #endif // defined(RTC_ENABLE_VP9) |
philipel | cfc319b | 2015-11-10 15:17:23 | [diff] [blame] | 3532 | |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 3533 | void VideoSendStreamTest::TestRequestSourceRotateVideo( |
| 3534 | bool support_orientation_ext) { |
Sebastian Jansson | 8e6602f | 2018-07-13 08:43:20 | [diff] [blame] | 3535 | CreateSenderCall(); |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 3536 | |
| 3537 | test::NullTransport transport; |
brandtr | 841de6a | 2016-11-15 15:10:52 | [diff] [blame] | 3538 | CreateSendConfig(1, 0, 0, &transport); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 3539 | GetVideoSendConfig()->rtp.extensions.clear(); |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 3540 | if (support_orientation_ext) { |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 3541 | GetVideoSendConfig()->rtp.extensions.push_back( |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 3542 | RtpExtension(RtpExtension::kVideoRotationUri, 1)); |
| 3543 | } |
| 3544 | |
| 3545 | CreateVideoStreams(); |
| 3546 | test::FrameForwarder forwarder; |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 3547 | GetVideoSendStream()->SetSource(&forwarder, |
| 3548 | DegradationPreference::MAINTAIN_FRAMERATE); |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 3549 | |
| 3550 | EXPECT_TRUE(forwarder.sink_wants().rotation_applied != |
| 3551 | support_orientation_ext); |
| 3552 | |
| 3553 | DestroyStreams(); |
| 3554 | } |
| 3555 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3556 | TEST_P(VideoSendStreamTest, |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 3557 | RequestSourceRotateIfVideoOrientationExtensionNotSupported) { |
| 3558 | TestRequestSourceRotateVideo(false); |
| 3559 | } |
| 3560 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3561 | TEST_P(VideoSendStreamTest, |
perkj | 803d97f | 2016-11-01 18:45:46 | [diff] [blame] | 3562 | DoNotRequestsRotationIfVideoOrientationExtensionSupported) { |
| 3563 | TestRequestSourceRotateVideo(true); |
| 3564 | } |
| 3565 | |
Åsa Persson | f06bacc | 2018-10-12 09:07:20 | [diff] [blame] | 3566 | TEST_P(VideoSendStreamTest, EncoderConfigMaxFramerateReportedToSource) { |
| 3567 | static const int kMaxFps = 22; |
| 3568 | class FpsObserver : public test::SendTest, |
| 3569 | public test::FrameGeneratorCapturer::SinkWantsObserver { |
| 3570 | public: |
| 3571 | FpsObserver() : SendTest(kDefaultTimeoutMs) {} |
| 3572 | |
| 3573 | void OnFrameGeneratorCapturerCreated( |
| 3574 | test::FrameGeneratorCapturer* frame_generator_capturer) override { |
| 3575 | frame_generator_capturer->SetSinkWantsObserver(this); |
| 3576 | } |
| 3577 | |
| 3578 | void OnSinkWantsChanged(rtc::VideoSinkInterface<VideoFrame>* sink, |
| 3579 | const rtc::VideoSinkWants& wants) override { |
| 3580 | if (wants.max_framerate_fps == kMaxFps) |
| 3581 | observation_complete_.Set(); |
| 3582 | } |
| 3583 | |
| 3584 | void ModifyVideoConfigs( |
| 3585 | VideoSendStream::Config* send_config, |
| 3586 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3587 | VideoEncoderConfig* encoder_config) override { |
| 3588 | encoder_config->simulcast_layers[0].max_framerate = kMaxFps; |
| 3589 | } |
| 3590 | |
| 3591 | void PerformTest() override { |
| 3592 | EXPECT_TRUE(Wait()) << "Timed out while waiting for fps to be reported."; |
| 3593 | } |
| 3594 | } test; |
| 3595 | |
| 3596 | RunBaseTest(&test); |
| 3597 | } |
| 3598 | |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3599 | // This test verifies that overhead is removed from the bandwidth estimate by |
| 3600 | // testing that the maximum possible target payload rate is smaller than the |
| 3601 | // maximum bandwidth estimate by the overhead rate. |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3602 | TEST_P(VideoSendStreamTest, RemoveOverheadFromBandwidth) { |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3603 | test::ScopedFieldTrials override_field_trials( |
| 3604 | "WebRTC-SendSideBwe-WithOverhead/Enabled/"); |
| 3605 | class RemoveOverheadFromBandwidthTest : public test::EndToEndTest, |
| 3606 | public test::FakeEncoder { |
| 3607 | public: |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 3608 | explicit RemoveOverheadFromBandwidthTest( |
| 3609 | test::SingleThreadedTaskQueueForTesting* task_queue) |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3610 | : EndToEndTest(test::CallTest::kDefaultTimeoutMs), |
| 3611 | FakeEncoder(Clock::GetRealTimeClock()), |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 3612 | task_queue_(task_queue), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 3613 | encoder_factory_(this), |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3614 | call_(nullptr), |
michaelt | 192132e | 2017-01-26 17:05:27 | [diff] [blame] | 3615 | max_bitrate_bps_(0), |
Niels Möller | c572ff3 | 2018-11-07 07:43:50 | [diff] [blame] | 3616 | first_packet_sent_(false) {} |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3617 | |
Erik Språng | 566124a | 2018-04-23 10:32:22 | [diff] [blame] | 3618 | int32_t SetRateAllocation(const VideoBitrateAllocation& bitrate, |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3619 | uint32_t frameRate) override { |
| 3620 | rtc::CritScope lock(&crit_); |
michaelt | 192132e | 2017-01-26 17:05:27 | [diff] [blame] | 3621 | // Wait for the first sent packet so that videosendstream knows |
| 3622 | // rtp_overhead. |
| 3623 | if (first_packet_sent_) { |
| 3624 | max_bitrate_bps_ = bitrate.get_sum_bps(); |
| 3625 | bitrate_changed_event_.Set(); |
| 3626 | } |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3627 | return FakeEncoder::SetRateAllocation(bitrate, frameRate); |
| 3628 | } |
| 3629 | |
| 3630 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
| 3631 | call_ = sender_call; |
| 3632 | } |
| 3633 | |
| 3634 | void ModifyVideoConfigs( |
| 3635 | VideoSendStream::Config* send_config, |
| 3636 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3637 | VideoEncoderConfig* encoder_config) override { |
| 3638 | send_config->rtp.max_packet_size = 1200; |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 3639 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3640 | EXPECT_FALSE(send_config->rtp.extensions.empty()); |
| 3641 | } |
| 3642 | |
michaelt | 192132e | 2017-01-26 17:05:27 | [diff] [blame] | 3643 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 3644 | rtc::CritScope lock(&crit_); |
| 3645 | first_packet_sent_ = true; |
| 3646 | return SEND_PACKET; |
| 3647 | } |
| 3648 | |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3649 | void PerformTest() override { |
Sebastian Jansson | fc8d26b | 2018-02-21 08:52:06 | [diff] [blame] | 3650 | BitrateConstraints bitrate_config; |
michaelt | 192132e | 2017-01-26 17:05:27 | [diff] [blame] | 3651 | constexpr int kStartBitrateBps = 60000; |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3652 | constexpr int kMaxBitrateBps = 60000; |
michaelt | 192132e | 2017-01-26 17:05:27 | [diff] [blame] | 3653 | constexpr int kMinBitrateBps = 10000; |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3654 | bitrate_config.start_bitrate_bps = kStartBitrateBps; |
| 3655 | bitrate_config.max_bitrate_bps = kMaxBitrateBps; |
michaelt | 192132e | 2017-01-26 17:05:27 | [diff] [blame] | 3656 | bitrate_config.min_bitrate_bps = kMinBitrateBps; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 3657 | task_queue_->SendTask([this, &bitrate_config]() { |
Sebastian Jansson | 8f83b42 | 2018-02-21 12:07:13 | [diff] [blame] | 3658 | call_->GetTransportControllerSend()->SetSdpBitrateParameters( |
| 3659 | bitrate_config); |
Stefan Holmer | 64be7fa | 2018-10-04 13:21:55 | [diff] [blame] | 3660 | call_->GetTransportControllerSend()->OnTransportOverheadChanged(40); |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 3661 | }); |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3662 | |
| 3663 | // At a bitrate of 60kbps with a packet size of 1200B video and an |
michaelt | 192132e | 2017-01-26 17:05:27 | [diff] [blame] | 3664 | // overhead of 40B per packet video produces 2240bps overhead. |
| 3665 | // So the encoder BW should be set to 57760bps. |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 3666 | EXPECT_TRUE( |
| 3667 | bitrate_changed_event_.Wait(VideoSendStreamTest::kDefaultTimeoutMs)); |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3668 | { |
| 3669 | rtc::CritScope lock(&crit_); |
michaelt | 273f31b | 2017-02-08 16:21:52 | [diff] [blame] | 3670 | EXPECT_LE(max_bitrate_bps_, 57760u); |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3671 | } |
| 3672 | } |
| 3673 | |
| 3674 | private: |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 3675 | test::SingleThreadedTaskQueueForTesting* const task_queue_; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 3676 | test::VideoEncoderProxyFactory encoder_factory_; |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3677 | Call* call_; |
| 3678 | rtc::CriticalSection crit_; |
danilchap | a37de39 | 2017-09-09 11:17:22 | [diff] [blame] | 3679 | uint32_t max_bitrate_bps_ RTC_GUARDED_BY(&crit_); |
| 3680 | bool first_packet_sent_ RTC_GUARDED_BY(&crit_); |
michaelt | 192132e | 2017-01-26 17:05:27 | [diff] [blame] | 3681 | rtc::Event bitrate_changed_event_; |
eladalon | 413ee9a | 2017-08-22 11:02:52 | [diff] [blame] | 3682 | } test(&task_queue_); |
michaelt | a332877 | 2016-11-29 17:25:03 | [diff] [blame] | 3683 | RunBaseTest(&test); |
| 3684 | } |
| 3685 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3686 | TEST_P(VideoSendStreamTest, SendsKeepAlive) { |
sprang | 168794c | 2017-07-06 11:38:06 | [diff] [blame] | 3687 | const int kTimeoutMs = 50; // Really short timeout for testing. |
sprang | 168794c | 2017-07-06 11:38:06 | [diff] [blame] | 3688 | |
| 3689 | class KeepaliveObserver : public test::SendTest { |
| 3690 | public: |
| 3691 | KeepaliveObserver() : SendTest(kDefaultTimeoutMs) {} |
| 3692 | |
sprang | db2a9fc | 2017-08-09 13:42:32 | [diff] [blame] | 3693 | void OnRtpTransportControllerSendCreated( |
| 3694 | RtpTransportControllerSend* controller) override { |
| 3695 | RtpKeepAliveConfig config; |
| 3696 | config.timeout_interval_ms = kTimeoutMs; |
| 3697 | config.payload_type = CallTest::kDefaultKeepalivePayloadType; |
| 3698 | controller->SetKeepAliveConfig(config); |
sprang | e5c4a81 | 2017-07-11 10:44:17 | [diff] [blame] | 3699 | } |
| 3700 | |
sprang | 168794c | 2017-07-06 11:38:06 | [diff] [blame] | 3701 | private: |
| 3702 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 3703 | RTPHeader header; |
| 3704 | EXPECT_TRUE(parser_->Parse(packet, length, &header)); |
| 3705 | |
sprang | d2702ef | 2017-07-10 15:41:10 | [diff] [blame] | 3706 | if (header.payloadType != CallTest::kDefaultKeepalivePayloadType) { |
sprang | 168794c | 2017-07-06 11:38:06 | [diff] [blame] | 3707 | // The video stream has started. Stop it now. |
| 3708 | if (capturer_) |
| 3709 | capturer_->Stop(); |
| 3710 | } else { |
| 3711 | observation_complete_.Set(); |
| 3712 | } |
| 3713 | |
| 3714 | return SEND_PACKET; |
| 3715 | } |
| 3716 | |
sprang | 168794c | 2017-07-06 11:38:06 | [diff] [blame] | 3717 | void PerformTest() override { |
| 3718 | EXPECT_TRUE(Wait()) << "Timed out while waiting for keep-alive packet."; |
| 3719 | } |
| 3720 | |
| 3721 | void OnFrameGeneratorCapturerCreated( |
| 3722 | test::FrameGeneratorCapturer* frame_generator_capturer) override { |
| 3723 | capturer_ = frame_generator_capturer; |
| 3724 | } |
| 3725 | |
| 3726 | test::FrameGeneratorCapturer* capturer_ = nullptr; |
| 3727 | } test; |
| 3728 | |
| 3729 | RunBaseTest(&test); |
| 3730 | } |
| 3731 | |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3732 | class PacingFactorObserver : public test::SendTest { |
| 3733 | public: |
| 3734 | PacingFactorObserver(bool configure_send_side, |
Danil Chapovalov | b9b146c | 2018-06-15 10:28:07 | [diff] [blame] | 3735 | absl::optional<float> expected_pacing_factor) |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3736 | : test::SendTest(VideoSendStreamTest::kDefaultTimeoutMs), |
| 3737 | configure_send_side_(configure_send_side), |
| 3738 | expected_pacing_factor_(expected_pacing_factor) {} |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3739 | |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3740 | void ModifyVideoConfigs( |
| 3741 | VideoSendStream::Config* send_config, |
| 3742 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3743 | VideoEncoderConfig* encoder_config) override { |
| 3744 | // Check if send-side bwe extension is already present, and remove it if |
| 3745 | // it is not desired. |
| 3746 | bool has_send_side = false; |
| 3747 | for (auto it = send_config->rtp.extensions.begin(); |
| 3748 | it != send_config->rtp.extensions.end(); ++it) { |
| 3749 | if (it->uri == RtpExtension::kTransportSequenceNumberUri) { |
| 3750 | if (configure_send_side_) { |
| 3751 | has_send_side = true; |
| 3752 | } else { |
| 3753 | send_config->rtp.extensions.erase(it); |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3754 | } |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3755 | break; |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3756 | } |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3757 | } |
| 3758 | |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3759 | if (configure_send_side_ && !has_send_side) { |
| 3760 | // Want send side, not present by default, so add it. |
| 3761 | send_config->rtp.extensions.emplace_back( |
| 3762 | RtpExtension::kTransportSequenceNumberUri, |
| 3763 | RtpExtension::kTransportSequenceNumberDefaultId); |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3764 | } |
| 3765 | |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3766 | // ALR only enabled for screenshare. |
| 3767 | encoder_config->content_type = VideoEncoderConfig::ContentType::kScreen; |
| 3768 | } |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3769 | |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3770 | void OnVideoStreamsCreated( |
| 3771 | VideoSendStream* send_stream, |
| 3772 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
| 3773 | auto internal_send_peer = test::VideoSendStreamPeer(send_stream); |
| 3774 | // Video streams created, check that pacing factor is correctly configured. |
| 3775 | EXPECT_EQ(expected_pacing_factor_, |
| 3776 | internal_send_peer.GetPacingFactorOverride()); |
| 3777 | observation_complete_.Set(); |
| 3778 | } |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3779 | |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3780 | void PerformTest() override { |
| 3781 | EXPECT_TRUE(Wait()) << "Timed out while waiting for stream creation."; |
| 3782 | } |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3783 | |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3784 | private: |
| 3785 | const bool configure_send_side_; |
Danil Chapovalov | b9b146c | 2018-06-15 10:28:07 | [diff] [blame] | 3786 | const absl::optional<float> expected_pacing_factor_; |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3787 | }; |
| 3788 | |
| 3789 | std::string GetAlrProbingExperimentString() { |
| 3790 | return std::string( |
| 3791 | AlrExperimentSettings::kScreenshareProbingBweExperimentName) + |
| 3792 | "/1.0,2875,80,40,-60,3/"; |
| 3793 | } |
| 3794 | const float kAlrProbingExperimentPaceMultiplier = 1.0f; |
| 3795 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3796 | TEST_P(VideoSendStreamTest, AlrConfiguredWhenSendSideOn) { |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3797 | test::ScopedFieldTrials alr_experiment(GetAlrProbingExperimentString()); |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3798 | // Send-side bwe on, use pacing factor from |kAlrProbingExperiment| above. |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3799 | PacingFactorObserver test_with_send_side(true, |
| 3800 | kAlrProbingExperimentPaceMultiplier); |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3801 | RunBaseTest(&test_with_send_side); |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3802 | } |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3803 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3804 | TEST_P(VideoSendStreamTest, AlrNotConfiguredWhenSendSideOff) { |
Sebastian Jansson | a45c8da | 2018-01-16 09:55:29 | [diff] [blame] | 3805 | test::ScopedFieldTrials alr_experiment(GetAlrProbingExperimentString()); |
| 3806 | // Send-side bwe off, use configuration should not be overridden. |
Danil Chapovalov | b9b146c | 2018-06-15 10:28:07 | [diff] [blame] | 3807 | PacingFactorObserver test_without_send_side(false, absl::nullopt); |
Erik Språng | 7c8cca3 | 2017-10-24 15:05:18 | [diff] [blame] | 3808 | RunBaseTest(&test_without_send_side); |
| 3809 | } |
| 3810 | |
Ilya Nikolaevskiy | 4425b05 | 2018-03-15 10:42:00 | [diff] [blame] | 3811 | // Test class takes as argument a function pointer to reset the send |
| 3812 | // stream and call OnVideoStreamsCreated. This is necessary since you cannot |
| 3813 | // change the content type of a VideoSendStream, you need to recreate it. |
| 3814 | // Stopping and recreating the stream can only be done on the main thread and in |
| 3815 | // the context of VideoSendStreamTest (not BaseTest). The test switches from |
| 3816 | // realtime to screenshare and back. |
| 3817 | template <typename T> |
| 3818 | class ContentSwitchTest : public test::SendTest { |
| 3819 | public: |
| 3820 | enum class StreamState { |
| 3821 | kBeforeSwitch = 0, |
| 3822 | kInScreenshare = 1, |
| 3823 | kAfterSwitchBack = 2, |
| 3824 | }; |
| 3825 | static const uint32_t kMinPacketsToSend = 50; |
| 3826 | |
| 3827 | explicit ContentSwitchTest(T* stream_reset_fun) |
| 3828 | : SendTest(test::CallTest::kDefaultTimeoutMs), |
Ilya Nikolaevskiy | 4425b05 | 2018-03-15 10:42:00 | [diff] [blame] | 3829 | call_(nullptr), |
| 3830 | state_(StreamState::kBeforeSwitch), |
| 3831 | send_stream_(nullptr), |
| 3832 | send_stream_config_(nullptr), |
| 3833 | packets_sent_(0), |
| 3834 | stream_resetter_(stream_reset_fun) { |
| 3835 | RTC_DCHECK(stream_resetter_); |
| 3836 | } |
| 3837 | |
| 3838 | void OnVideoStreamsCreated( |
| 3839 | VideoSendStream* send_stream, |
| 3840 | const std::vector<VideoReceiveStream*>& receive_streams) override { |
| 3841 | rtc::CritScope lock(&crit_); |
| 3842 | send_stream_ = send_stream; |
| 3843 | } |
| 3844 | |
| 3845 | void ModifyVideoConfigs( |
| 3846 | VideoSendStream::Config* send_config, |
| 3847 | std::vector<VideoReceiveStream::Config>* receive_configs, |
| 3848 | VideoEncoderConfig* encoder_config) override { |
| 3849 | RTC_DCHECK_EQ(1, encoder_config->number_of_streams); |
| 3850 | encoder_config->min_transmit_bitrate_bps = 0; |
| 3851 | encoder_config->content_type = |
| 3852 | VideoEncoderConfig::ContentType::kRealtimeVideo; |
| 3853 | send_stream_config_ = send_config->Copy(); |
| 3854 | encoder_config_ = encoder_config->Copy(); |
| 3855 | } |
| 3856 | |
| 3857 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
| 3858 | call_ = sender_call; |
| 3859 | } |
| 3860 | |
| 3861 | Action OnSendRtp(const uint8_t* packet, size_t length) override { |
| 3862 | rtc::CritScope lock(&crit_); |
| 3863 | |
| 3864 | auto internal_send_peer = test::VideoSendStreamPeer(send_stream_); |
| 3865 | float pacing_factor = |
| 3866 | internal_send_peer.GetPacingFactorOverride().value_or(0.0f); |
| 3867 | float expected_pacing_factor = PacedSender::kDefaultPaceMultiplier; |
| 3868 | if (send_stream_->GetStats().content_type == |
| 3869 | webrtc::VideoContentType::SCREENSHARE) { |
| 3870 | expected_pacing_factor = 1.0f; // Currently used pacing factor in ALR. |
| 3871 | } |
| 3872 | |
| 3873 | EXPECT_NEAR(expected_pacing_factor, pacing_factor, 1e-6); |
| 3874 | |
| 3875 | // Wait until at least kMinPacketsToSend packets to be sent, so that |
| 3876 | // some frames would be encoded. |
| 3877 | if (++packets_sent_ < kMinPacketsToSend) |
| 3878 | return SEND_PACKET; |
| 3879 | |
| 3880 | if (state_ != StreamState::kAfterSwitchBack) { |
| 3881 | // We've sent kMinPacketsToSend packets, switch the content type and move |
| 3882 | // move to the next state. |
| 3883 | // Note that we need to recreate the stream if changing content type. |
| 3884 | packets_sent_ = 0; |
| 3885 | if (encoder_config_.content_type == |
| 3886 | VideoEncoderConfig::ContentType::kRealtimeVideo) { |
| 3887 | encoder_config_.content_type = VideoEncoderConfig::ContentType::kScreen; |
| 3888 | } else { |
| 3889 | encoder_config_.content_type = |
| 3890 | VideoEncoderConfig::ContentType::kRealtimeVideo; |
| 3891 | } |
| 3892 | switch (state_) { |
| 3893 | case StreamState::kBeforeSwitch: |
| 3894 | state_ = StreamState::kInScreenshare; |
| 3895 | break; |
| 3896 | case StreamState::kInScreenshare: |
| 3897 | state_ = StreamState::kAfterSwitchBack; |
| 3898 | break; |
| 3899 | case StreamState::kAfterSwitchBack: |
| 3900 | RTC_NOTREACHED(); |
| 3901 | break; |
| 3902 | } |
| 3903 | content_switch_event_.Set(); |
| 3904 | return SEND_PACKET; |
| 3905 | } |
| 3906 | |
| 3907 | observation_complete_.Set(); |
| 3908 | return SEND_PACKET; |
| 3909 | } |
| 3910 | |
| 3911 | void PerformTest() override { |
| 3912 | while (GetStreamState() != StreamState::kAfterSwitchBack) { |
| 3913 | ASSERT_TRUE( |
| 3914 | content_switch_event_.Wait(test::CallTest::kDefaultTimeoutMs)); |
| 3915 | (*stream_resetter_)(send_stream_config_, encoder_config_, this); |
| 3916 | } |
| 3917 | |
| 3918 | ASSERT_TRUE(Wait()) |
| 3919 | << "Timed out waiting for a frame sent after switch back"; |
| 3920 | } |
| 3921 | |
| 3922 | private: |
| 3923 | StreamState GetStreamState() { |
| 3924 | rtc::CritScope lock(&crit_); |
| 3925 | return state_; |
| 3926 | } |
| 3927 | |
| 3928 | rtc::CriticalSection crit_; |
| 3929 | rtc::Event content_switch_event_; |
| 3930 | Call* call_; |
| 3931 | StreamState state_ RTC_GUARDED_BY(crit_); |
| 3932 | VideoSendStream* send_stream_ RTC_GUARDED_BY(crit_); |
| 3933 | VideoSendStream::Config send_stream_config_; |
| 3934 | VideoEncoderConfig encoder_config_; |
| 3935 | uint32_t packets_sent_ RTC_GUARDED_BY(crit_); |
| 3936 | T* stream_resetter_; |
| 3937 | }; |
| 3938 | |
Sebastian Jansson | c714b6e | 2018-08-30 13:45:41 | [diff] [blame] | 3939 | TEST_P(VideoSendStreamTest, SwitchesToScreenshareAndBack) { |
Ilya Nikolaevskiy | 4425b05 | 2018-03-15 10:42:00 | [diff] [blame] | 3940 | auto reset_fun = [this](const VideoSendStream::Config& send_stream_config, |
| 3941 | const VideoEncoderConfig& encoder_config, |
| 3942 | test::BaseTest* test) { |
| 3943 | task_queue_.SendTask([this, &send_stream_config, &encoder_config, &test]() { |
| 3944 | Stop(); |
Sebastian Jansson | f33905d | 2018-07-13 07:49:00 | [diff] [blame] | 3945 | DestroyVideoSendStreams(); |
| 3946 | SetVideoSendConfig(send_stream_config); |
| 3947 | SetVideoEncoderConfig(encoder_config); |
| 3948 | CreateVideoSendStreams(); |
| 3949 | SetVideoDegradation(DegradationPreference::MAINTAIN_RESOLUTION); |
| 3950 | test->OnVideoStreamsCreated(GetVideoSendStream(), video_receive_streams_); |
Ilya Nikolaevskiy | 4425b05 | 2018-03-15 10:42:00 | [diff] [blame] | 3951 | Start(); |
| 3952 | }); |
| 3953 | }; |
| 3954 | ContentSwitchTest<decltype(reset_fun)> test(&reset_fun); |
| 3955 | RunBaseTest(&test); |
| 3956 | } |
| 3957 | |
pbos@webrtc.org | 119a1cc | 2013-08-20 13:14:07 | [diff] [blame] | 3958 | } // namespace webrtc |